GNU bug report logs - #4930
23.1.50; C-mouse-1 undefined?

Previous Next

Full log

Message #34 received at 4930-done <at> debbugs.gnu.org (full text, mbox):

From: Peter Dyballa <Peter_Dyballa <at> Freenet.DE>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Bernhard Herzog <bh <at> intevation.de>,
	Clathrate Boink <clathrate.boink <at> gmail.com>, 4930-done <at> debbugs.gnu.org
Subject: Re: Fix for timestamp related popup-menu problem with some X servers
Date: Thu, 1 Apr 2010 00:31:05 +0200

Am 31.03.2010 um 01:28 schrieb Chong Yidong:

>> Anyway, to cut the story short, below is a patch to fix this problem.
>> It uses last_event_timestamp from keyboard.c instead of the timestamp
>> From the button event.  AFAICT, last_event_timestamp is the timestamp
>> From the button event, most of the time anyway, because usually the
>> button event that will lead to the popup-menu being displayed is the
>> last one that was processed.
>
> Thanks.  I've checked your patch into the emacs-23 branch.


Hello!

I updated GNU Emacs 23.1.90 via CVS approximately ten hours after you  
sent the message. I compiled on my Mac the default GTK and the Xaw3d X  
clients, using the libraries either provided by by Fink or by  
MacPorts. The results are clear and unchanged:

 • the Xaw3d based Emacsen know C-mouse-1,
 • the GTK based Emacsen do *not* know C-mouse-1 and complain and  
dump a core when killed with xkill.


Grep finds last_event_timestamp here:

	./src/keyboard.c:369:unsigned long last_event_timestamp;
	./src/keyboard.c:3866:	  last_event_timestamp = event->timestamp;
	./src/keyboard.c:4152:      last_event_timestamp = event->timestamp;
	./src/keyboard.c:4440:      last_event_timestamp = event->timestamp;
	./src/xselect.c:139:extern unsigned long last_event_timestamp;
	./src/xselect.c:391:  Time time = last_event_timestamp;
	./src/xselect.c:1388:  Time requestor_time = last_event_timestamp;
	./src/xselect.c:2227:    timestamp = last_event_timestamp;

Are these the updated sources?

--
Greetings

  Pete

                  Sorry my terrible English, my native language Lisp

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.