GNU bug report logs - #49288
[PATCH] gnu: services: Export provenance-entry and sexp->channel

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andrew Tropin <andrew <at> trop.in>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49288: closed ([PATCH] gnu: services: Export provenance-entry
 and sexp->channel)
Date: Thu, 01 Jul 2021 14:37:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 01 Jul 2021 17:36:45 +0300
with message-id <87lf6q3xtu.fsf <at> trop.in>
and subject line Re: bug#49288: [PATCH] gnu: services: Export provenance-entry and sexp->channel
has caused the debbugs.gnu.org bug report #49288,
regarding [PATCH] gnu: services: Export provenance-entry and sexp->channel
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49288: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49288
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andrew Tropin <andrew <at> trop.in>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: services: Export provenance-entry and sexp->channel
Date: Wed, 30 Jun 2021 12:45:32 +0300

These functions are need for Guix Home.
---
 For now functions are copy pasted, but it seems better to reuse
 existing functions.
 https://git.sr.ht/~abcdw/rde/tree/057888b2604b05d555fd1b67f3d356644f9a134d/gnu/home-services.scm#L418
 
 gnu/services.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/services.scm b/gnu/services.scm
index 8d413e198e..53b358c63b 100644
--- a/gnu/services.scm
+++ b/gnu/services.scm
@@ -91,6 +91,9 @@
             ambiguous-target-service-error-service
             ambiguous-target-service-error-target-type
 
+            provenance-entry
+            sexp->channel
+
             system-service-type
             provenance-service-type
             sexp->system-provenance
-- 
2.32.0


<#secure method=pgpmime mode=sign>

[Message part 3 (message/rfc822, inline)]

From: Andrew Tropin <andrew <at> trop.in>
To: Ludovic Courtès <ludo <at> gnu.org>, 49288-done <at> debbugs.gnu.org
Cc: 49288 <at> debbugs.gnu.org
Subject: Re: bug#49288: [PATCH] gnu: services: Export provenance-entry and
 sexp->channel
Date: Thu, 01 Jul 2021 17:36:45 +0300

[Message part 4 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi!
>
> Andrew Tropin <andrew <at> trop.in> skribis:
>
>> These functions are need for Guix Home.
>> ---
>>  For now functions are copy pasted, but it seems better to reuse
>>  existing functions.
>>  https://git.sr.ht/~abcdw/rde/tree/057888b2604b05d555fd1b67f3d356644f9a134d/gnu/home-services.scm#L418
>>  
>>  gnu/services.scm | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/services.scm b/gnu/services.scm
>> index 8d413e198e..53b358c63b 100644
>> --- a/gnu/services.scm
>> +++ b/gnu/services.scm
>> @@ -91,6 +91,9 @@
>>              ambiguous-target-service-error-service
>>              ambiguous-target-service-error-target-type
>>  
>> +            provenance-entry
>> +            sexp->channel
>
> This ‘sexp->channel’ exists “for historical reasons”.  Could you use
> (@ (guix channels) sexp->channel) instead, together with
> ‘channel-instance->sexp’?

Sure!)

> Actually, could you define it like so:
>
> --8<---------------cut here---------------start------------->8---
> (define home-provenance-service-type
>   (service-type
>    (inherit provenance-service-type)
>    (extensions
>     (list (service-extension
> 	   home-service-type
>            (service-extension-compute
> 	    (first (service-extensions provenance-service-type))))))
>    (default-value #f)))
> --8<---------------cut here---------------end--------------->8---

Looks good to me.

> More generally, perhaps you could have a procedure that takes a service
> type and “rewires” it so that it extends ‘home-service-type’ instead of
> ‘etc-service-type’, say.  Does that make sense?

Thank you for the idea, it can be useful, I'll consider it.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.