GNU bug report logs - #49283
[PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows

Previous Next

Full log

Message #35 received at 49283 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 49283 <at> debbugs.gnu.org, larsi <at> gnus.org, michael.albinus <at> gmx.de
Subject: Re: bug#49283: [PATCH] 27.2; `(call-process "program" null-device
 ...)' fails over TRAMP from local MS Windows
Date: Sat, 03 Jul 2021 10:02:32 +0300

> From: Jim Porter <jporterbugs <at> gmail.com>
> Date: Fri, 2 Jul 2021 11:47:12 -0700
> Cc: Michael Albinus <michael.albinus <at> gmx.de>, Lars Ingebrigtsen <larsi <at> gnus.org>, 49283 <at> debbugs.gnu.org
> 
> > expand-file-name is not a problem, it can deal with encoded file
> > names.  The problem is the calls to remove_slash_colon and
> > report_file_error: they should receive file names in their internal
> > representation.
> 
> Right, I was just worried that if I relied on
> `encode_current_directory' returning an encoded path,
> `expand-file-name' might sometimes return an encoded path (e.g. if
> INFILE is a simple relative path like "foo") and sometimes an
> unencoded path (e.g. if INFILE is an absolute path). I might be wrong
> though, since I didn't look closely at the implementation...
> 
> > How about adding a 'bool' argument to encode_current_directory, so
> > that the caller could control whether or not it encodes the directory
> > file name?  Then you could in this case tell encode_current_directory
> > not to encode the directory file name.
> 
> Ok, I did that (and renamed it to `get_current_directory' since it
> doesn't always encode anymore). How does the attached patch look?

LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.