From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 05:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 49283@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16250300756107 (code B ref -1); Wed, 30 Jun 2021 05:15:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jun 2021 05:14:35 +0000 Received: from localhost ([127.0.0.1]:56255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lySYU-0001aR-MJ for submit@debbugs.gnu.org; Wed, 30 Jun 2021 01:14:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:43814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lySYT-0001aK-Cx for submit@debbugs.gnu.org; Wed, 30 Jun 2021 01:14:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49582) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lySYT-0002ga-4h for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 01:14:33 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:39436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lySYR-0002XW-FX for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 01:14:32 -0400 Received: by mail-pf1-x42e.google.com with SMTP id b12so229450pfv.6 for ; Tue, 29 Jun 2021 22:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=fTG3RurQTXGyK0ee5BBPjJXE5+S/naHDcSH4AKGeU80=; b=mz1IvLvfXAYrSpQ1v7yj+TUJWSn8Wt7AwBWINe5JUmuTCYDKEPYrI1DHk9hvN7cPzY pykbfxUN5nHPKjYMF/aPA5YxD1HjArp3pkPQhcvwRZHgpcfc2tSwLTQIxfGF8dk6k4pL Gy90DRw6pA+uQ4Ipa9YHaFJoRLLlYE+iimcsswFtRzAV/e86CUzBFxLrozjphBWvNX76 5ZnVAu4wnGjci0rHHfDlbmQaM1DYq8nOysfaPasUnfrYltx9w7yvzJk6sEMWpUFE8epr LxjjhM5VpREZdy3VUNT82qYNrt4wz8W51YHnDK+wA3lmdgWxW8UByAbVvo+5juOhYVyN pm2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=fTG3RurQTXGyK0ee5BBPjJXE5+S/naHDcSH4AKGeU80=; b=Jkklq43VwUQtQyGbnRoqT4VZgiESQstU+jyZIxxZy4ZjxMo/yDhdt2RyXCS91B4hut 1W9kZYl5xgsXIXIvGnUtZTLiQnvuIYcvsbnbu+iaw3UHvaUAJ3/jlT/JuY9UDrF5zkAc eRfmCscOvKAUfIIJcErS069i9yq8wE8SOLQ/GqlGg5ORf0h935G5zUwMSQDufpLm6dx8 UjpcsDMbNloXR53JUAYJckiXVM4PaMHn9h140U31kXFxRXcAxnIo4eKBe7iAhaFwD+XZ oQGYyRJSVBcVnD+ncDnyL81l128xkpCO/DnuzcCN7NaYhI8Qbewsl5BnL6c78i25rOxZ IdJw== X-Gm-Message-State: AOAM530iUxePsz4KGea2v8OBt2JuUOdG+QbFbLd66lHN+FmVgDNHk6wP m4jGOLb8xP3hkSmnO9CrwgN1nfwyLPmG6HfsI7909xtWpg0= X-Google-Smtp-Source: ABdhPJx4m7JVik9n/o/Gyh9mNSrEwucwL1ieClPJ0FyLvm0iuEbJh8+SIVXLQSgjfN6ynZJlxJEzl29mAK5slf1HEi4= X-Received: by 2002:a63:b912:: with SMTP id z18mr24552985pge.185.1625030069326; Tue, 29 Jun 2021 22:14:29 -0700 (PDT) MIME-Version: 1.0 From: Jim Porter Date: Tue, 29 Jun 2021 22:14:19 -0700 Message-ID: Content-Type: multipart/mixed; boundary="000000000000082fa905c5f4ccca" Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=jporterbugs@gmail.com; helo=mail-pf1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000082fa905c5f4ccca Content-Type: text/plain; charset="UTF-8" I noticed an issue when trying to use flyspell (or ispell) using hunspell from a local MS Windows system on a TRAMP file. It results in an error that it can't find the file "/sshx:server:/path/to/NUL". I narrowed this down to the fact that `ispell-find-hunspell-dictionaries' calls `call-process' with `infile' set to `null-device'. To see this in action: emacs -Q C-x C-f /sshx:server:~/path/to/file.txt M-: (setq ispell-program-name "hunspell") RET M-x flyspell-mode ;; or... M-: (call-process "something" null-device) RET This results in the following error: ---------------------------------------- Debugger entered--Lisp error: (file-missing "Opening process input file" #("No such file or directory" 0 25 (charset windows-1252)) "/sshx:server:/path/to/NUL") call-process("something" "NUL") eval((call-process "something" null-device) t) eval-expression((call-process "something" null-device) nil nil 127) funcall-interactively(eval-expression (call-process "something" null-device) nil nil 127) call-interactively(eval-expression nil nil) command-execute(eval-expression) ---------------------------------------- It seems this is a result of the fact that `null-device' on MS Windows is "NUL", and `(expand-file-name "NUL")' is "/NUL". When `default-directory' is a local MS Windows path, this is ok, but when it's a TRAMP path, it looks for a real file named NUL on the remote (GNU/Linux) machine. However, since `call-process' executes from the (local) home directory if `default-directory' is a TRAMP path, I think it makes more sense for `infile' to be interpreted relative to the homedir too. I've attached a speculative patch that I think fixes this. (Note: I don't have an MS Windows build environment set up at the moment, so I only tested that this works like I'd expect from GNU/Linux. It'd probably be good to make sure it works on MS Windows too.) While I'm hesitant to touch something as low-level as `call-process', I think fixing this in general would be the best long-term solution, assuming it doesn't break something I'm unaware of. Another, less-invasive fix would be to fix `ispell-find-hunspell-dictionaries' to pass `nil' as the `infile' when invoking hunspell. --000000000000082fa905c5f4ccca Content-Type: application/octet-stream; name="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Disposition: attachment; filename="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqj0oykl0 RnJvbSBlNzM3ZjQwMGY3ZTU3ZmM5OTIyMmI1YzM1MWU0ODUzNzM1YzJjNmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFR1ZSwgMjkgSnVuIDIwMjEgMjI6MDE6NTMgLTA3MDAKU3ViamVjdDogW1BBVENIXSBFbnN1 cmUgJ2NhbGwtcHJvY2VzcycgaW50ZXJwcmV0cyAnaW5maWxlJyBhcyBhIGxvY2FsIHBhdGgKCiog c3JjL2NhbGxwcm9jLmMgKEZjYWxsX3Byb2Nlc3MpOiBJbnRlcnByZXQgJ2luZmlsZScgcmVsYXRp dmUgdG8gdGhlCmRpcmVjdG9yeSBmcm9tIHdoaWNoICdwcm9ncmFtJyBpcyBjYWxsZWQsIG5vdCAn ZGVmYXVsdC1kaXJlY3RvcnknLgotLS0KIHNyYy9jYWxscHJvYy5jIHwgMiArLQogMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Nh bGxwcm9jLmMgYi9zcmMvY2FsbHByb2MuYwppbmRleCBhYWJjMzkzMTNiLi41N2NmNzgxZDI4IDEw MDY0NAotLS0gYS9zcmMvY2FsbHByb2MuYworKysgYi9zcmMvY2FsbHByb2MuYwpAQCAtMjcwLDcg KzI3MCw3IEBAIERFRlVOICgiY2FsbC1wcm9jZXNzIiwgRmNhbGxfcHJvY2VzcywgU2NhbGxfcHJv Y2VzcywgMSwgTUFOWSwgMCwKIAogICBpZiAobmFyZ3MgPj0gMiAmJiAhIE5JTFAgKGFyZ3NbMV0p KQogICAgIHsKLSAgICAgIGluZmlsZSA9IEZleHBhbmRfZmlsZV9uYW1lIChhcmdzWzFdLCBCVkFS IChjdXJyZW50X2J1ZmZlciwgZGlyZWN0b3J5KSk7CisgICAgICBpbmZpbGUgPSBGZXhwYW5kX2Zp bGVfbmFtZSAoYXJnc1sxXSwgZW5jb2RlX2N1cnJlbnRfZGlyZWN0b3J5ICgpKTsKICAgICAgIENI RUNLX1NUUklORyAoaW5maWxlKTsKICAgICB9CiAgIGVsc2UKLS0gCjIuMjUuMQoK --000000000000082fa905c5f4ccca-- From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 07:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 49283@debbugs.gnu.org Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162503789718401 (code B ref 49283); Wed, 30 Jun 2021 07:25:01 +0000 Received: (at 49283) by debbugs.gnu.org; 30 Jun 2021 07:24:57 +0000 Received: from localhost ([127.0.0.1]:56328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyUae-0004mj-Tm for submit@debbugs.gnu.org; Wed, 30 Jun 2021 03:24:57 -0400 Received: from mout.gmx.net ([212.227.15.19]:42069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyUad-0004mW-2y for 49283@debbugs.gnu.org; Wed, 30 Jun 2021 03:24:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1625037888; bh=bV5exH8fH4NrRiTyKJNPnsGrlIOhDlWsk/O8TUaUrRY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=XUtiDk8TNDb0+uiQiBqztCxeQNmxQSkSymC1+28QDC3L4zbjAxsj26eA0B6W53/Pc 8VSkcfnRdwvYC37LUpMH+Sq8jEpfEbN0vq8h5Sa/u1aT+RLTbyersnvKO8Wcx/vsRp wLWxf/WvBPI5ZZl68FyHgq25zzssdwAueTeBafYY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.147.177]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3bSj-1lHZ3L1nwR-010cxA; Wed, 30 Jun 2021 09:24:48 +0200 From: Michael Albinus References: Date: Wed, 30 Jun 2021 09:24:47 +0200 In-Reply-To: (Jim Porter's message of "Tue, 29 Jun 2021 22:14:19 -0700") Message-ID: <87a6n7zuf4.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:JqnbDiJ+85wKvqAWJbWHCsco+MtMoH5QOlxi9IiOSwswnUrTDNH 9G2trvOQ2IuDTzb7mz/Ql8cPu1/mQ8b5+pmqlaxX4omHr8kZ8+1Bra9eMEVkrVqtRivfVq7 j7b8vXtWyBpt3MGEubjn1MX9mZwGz2GYNfK+wMuYLqEGX+WsCN1MscGxLMD0p2yAT8Ywvks Sovf7cZw/T3EbBBmQt1YQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:C4KBmUvySGw=:hgm+DF4fjuyGYJ/hL+KRN3 DjsjADRau2JxCMbdanz2tTqjeTHx8a4NYvyZDOImF1maVHueO1rKYY+vXZdkRK8BONMIXTchi ijrmaSi7knz57TAqGASBEj05TJJwA7slZdT/KutxzovO/WQucjBOhdeoqhARmxi46S18YR1RU /ohbbEArGsmcKg/HcPD7qOXVm5xwa0OuUL+tiuX4omaYweDJa1u7gx7MwwtZg7bIzGLHo0Ikh 5o1RV6rvpMeimFSX1J5r0dTZ0tQ4PfZgY39SCQlbj21dQjnhxDNlhTGsddWSawnjFv0QlOXl6 X9eOwbxE3w6sZfvB8QnPmZQTsle2QRbL4Wceazg0LtYdpED6bRnbHjj+KShjQCgjujp92l1ex OL78HzF8wZMCdrza2eMlSa8r896ArB6PBuHJKMm02KTWInmAxuTBsniARawjPNvqcBbEm5ALT uXHBsJqeoghMFeOalJaH6xIY9Ir2vzu9zUTNYZUt/6SluXlU9at9ACg6IDoJZSpVdj1cYcaHs iksgk5TS49Yd6sq8+JeEqI8mn7YYPLz8oPRmKvycMJQi8cxQfDiXJ9IzejVyi7BMgf0HDWQEj 6Z26YsgI31eCEOYwzCdqcyTivJkOcM5xudizNuf8iXyqwkCytlw7gNeAWkM//HUGLkgmEewQ6 JjqlkAT3aM/FqPcvydk2U//D534sURO3ZPtwZxnBN8ock9lT+Maz+fDggAsvqw+cGUIUGIzut YOl8dVsDpcQwDByTPJ1/BAbbpa1tPw7Fzfhz+doejFyn4PXfKpe7rVqAVz85yITJWXjQ4DPG4 uh8qJ9yNFWsUsOlx2M+f8rcEs/UfS8Eq619isGtos421IOXqwn7Dm5nsKu55BDz8QtVzq9gCb DAhzgkBU3rcS3jtoq9+SfH+4HG46lipMUyJA3rpzkfwGV+5SrtClBkqi7t3NUCl475IYdJQD9 zyYFFKmtHi89nGQ9LA7RYWpc5CJBgeil3puimpBbrTcG+JLYKTLxIs1PaVX7Ww18wZUIU/hhO w22s4eGPOew5Jq0W048s4FY0tVTvZ6pibg0GqTm3Udq1NyUo8k0O9Gp0c7iC8J3ktjPnSapma vuHJdA3FHQio4n/z4uVFBeq8kl7/LsxYAlJYR32s5hlpB/May2EwFXJ5A== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jim Porter writes: Hi Jim, > I noticed an issue when trying to use flyspell (or ispell) using > hunspell from a local MS Windows system on a TRAMP file. It results in > an error that it can't find the file "/sshx:server:/path/to/NUL". I > narrowed this down to the fact that > `ispell-find-hunspell-dictionaries' calls `call-process' with `infile' > set to `null-device'. `call-process' doesn't know of remote files. You must use `process-file' instead. > To see this in action: > > emacs -Q > C-x C-f /sshx:server:~/path/to/file.txt > M-: (setq ispell-program-name "hunspell") RET > M-x flyspell-mode > ;; or... > M-: (call-process "something" null-device) RET It is not a good idea to use `null-device' as INFILE, just use nil. At least in the `process-file' case, Tramp shall know which value to take for `null-device'. After all, it seems to be rather a flyspell/ispell feature request to support remote files. Best regards, Michael. From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: 49283@debbugs.gnu.org Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162507340631493 (code B ref 49283); Wed, 30 Jun 2021 17:17:02 +0000 Received: (at 49283) by debbugs.gnu.org; 30 Jun 2021 17:16:46 +0000 Received: from localhost ([127.0.0.1]:58651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lydpO-0008Bt-5P for submit@debbugs.gnu.org; Wed, 30 Jun 2021 13:16:46 -0400 Received: from mail-pl1-f181.google.com ([209.85.214.181]:38789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lydpM-0008Bf-2y for 49283@debbugs.gnu.org; Wed, 30 Jun 2021 13:16:45 -0400 Received: by mail-pl1-f181.google.com with SMTP id b1so1859172pls.5 for <49283@debbugs.gnu.org>; Wed, 30 Jun 2021 10:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qczHVslvBN+Qo3WLWDGvCD/IBhDOUxa9f3nKycUtoLg=; b=sxXE6rQLGPoBJzue2S8YxjZDrE+qVS9JXGz3GJnJ+hVs+D6pA5zFLvhNW6yHqaPGTw 67wUcKGkvDdgjCdcFGHc3yIBhfA8S4N1RByD1RbvIcbSIkIgvW46swJrX/L9UAJDQmS3 C2kWTLfvkdyW04MqCO4NgMWBWetxaxRI7oOWkQBjO75XC39wbjqTgx3z7vhq+au9jLKh tiAjfuAribHO5XJeCDTagTXs5sNZr5nFXCEpRy5fv+0763AwcOoLu9Ek434dIVZLMOQi DRCvy/tjeIp+F2WkUg7o9odAcQ6+aHvsMU/9cxoiYNDVy31JhnIJyNbF/fSZaT/vyVJC k9Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qczHVslvBN+Qo3WLWDGvCD/IBhDOUxa9f3nKycUtoLg=; b=r15V+9iuPX496JUUpwhtr+NSuld671hN3a+/yGw3V9Ics4EsMuR4xJz3AI+pihKE8Z aLwRMWVeTwu5Cv5YEfATnm6WPQhMecw9iA0D1f4oil/PtEpIL0FUvJQdmJfhWbmIwTvX gugSFe1BBJVF7t5eHl5E95b+OobDe5WTf7GlVz4IUkxcqowr9aGwECmux8U//eGuEYDc Ssf8RDpeg6TLHrY97Tmlz/B8nPiT0ciTgywkawJKMVgEf5IphToA1Bm7nUTo/azsNfhS t+Y5bEv7N73ptsybcVtxJnzNjJC/pvZye9gt2FhfigmuR6N3cNtOiP+sx2lbOGsPZFxA 201A== X-Gm-Message-State: AOAM533iUekIhJBO+E2aF6qdKYGcq3vF4g6+ORqwvGSUoYlLGrNcb6gG COPu6DoIbjEaALHrtu338PKQ12C0FbgTOtO1HQA= X-Google-Smtp-Source: ABdhPJxXmOmHbXkH2/NFO5c+oH2tIkq4loxurpMRQ3IF27pqDBzZ8VhirVtFZsXcMerIRPOAK0fIqvN2JWCJg47VH7A= X-Received: by 2002:a17:90a:5202:: with SMTP id v2mr34175160pjh.169.1625073398145; Wed, 30 Jun 2021 10:16:38 -0700 (PDT) MIME-Version: 1.0 References: <87a6n7zuf4.fsf@gmx.de> In-Reply-To: <87a6n7zuf4.fsf@gmx.de> From: Jim Porter Date: Wed, 30 Jun 2021 10:16:28 -0700 Message-ID: Content-Type: multipart/mixed; boundary="000000000000a17afb05c5fee2c9" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000a17afb05c5fee2c9 Content-Type: text/plain; charset="UTF-8" On Wed, Jun 30, 2021 at 12:24 AM Michael Albinus wrote: > > Jim Porter writes: > > > I noticed an issue when trying to use flyspell (or ispell) using > > hunspell from a local MS Windows system on a TRAMP file. It results in > > an error that it can't find the file "/sshx:server:/path/to/NUL". I > > narrowed this down to the fact that > > `ispell-find-hunspell-dictionaries' calls `call-process' with `infile' > > set to `null-device'. > > `call-process' doesn't know of remote files. You must use `process-file' instead. That's not a problem; it's actually the right thing to do in this case, I think. flyspell/ispell is trying to use my local version of hunspell on the contents of a remote buffer. Since flyspell/ispell just look at the buffer contents and not the actual file, it can use `call-process'. > It is not a good idea to use `null-device' as INFILE, just use nil. At > least in the `process-file' case, Tramp shall know which value to take > for `null-device'. That fix would also work (see the attached patch). However, when I read the `call-process' documentation, it says that when `default-directory' is remote, it runs the program from "~". That's fine overall, and means it's a good way to be sure you're always running a process locally. It's just that when you do this, INFILE's path is expanded relative to the remote directory. I don't think that can ever work, since `call-process' doesn't know how to open a TRAMP file. Because of that, it makes more sense to me that you'd expand INFILE's path relative to wherever PROGRAM will be run from. That means that when `default-directory' is remote, both PROGRAM and INFILE are expanded relative to "~". That's more consistent, and my first patch would hopefully prevent similar errors anytime `call-process' is used from a remote buffer. --000000000000a17afb05c5fee2c9 Content-Type: application/octet-stream; name="0001-Don-t-pass-null-device-to-call-process-in-ispell.patch" Content-Disposition: attachment; filename="0001-Don-t-pass-null-device-to-call-process-in-ispell.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqjqkskd0 RnJvbSAyZWVlOWI0ZTcwZmU0ODllYjQ2ZmI5NGFiMDAwYzZkMGI3MjYyZTI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFdlZCwgMzAgSnVuIDIwMjEgMTA6MDE6MzIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBEb24n dCBwYXNzICdudWxsLWRldmljZScgdG8gJ2NhbGwtcHJvY2VzcycgaW4gaXNwZWxsCgoqIGxpc3Av dGV4dG1vZGVzL2lzcGVsbC5lbCAoaXNwZWxsLWZpbmQtaHVuc3BlbGwtZGljdGlvbmFyaWVzKToK UmVwbGFjZSAnbnVsbC1kZXZpY2UnIHdpdGggbmlsLgotLS0KIGxpc3AvdGV4dG1vZGVzL2lzcGVs bC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbCBiL2xpc3AvdGV4dG1vZGVz L2lzcGVsbC5lbAppbmRleCBjZTVhNTcyMDg1Li4wYTgyYmY1YTJkIDEwMDY0NAotLS0gYS9saXNw L3RleHRtb2Rlcy9pc3BlbGwuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCkBAIC0x MDc2LDcgKzEwNzYsNyBAQCBpc3BlbGwtZmluZC1odW5zcGVsbC1kaWN0aW9uYXJpZXMKICAgICAg ICAgICAoc3BsaXQtc3RyaW5nCiAgICAgICAgICAgICh3aXRoLXRlbXAtYnVmZmVyCiAgICAgICAg ICAgICAgKGlzcGVsbC1jYWxsLXByb2Nlc3MgaXNwZWxsLXByb2dyYW0tbmFtZQotICAgICAgICAg ICAgICAgICAgICAgICAgICAgIG51bGwtZGV2aWNlCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbmlsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdAogICAgICAgICAgICAgICAgICAg ICAgICAgICAgIG5pbAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICItRCIKLS0gCjIuMjUu MQoK --000000000000a17afb05c5fee2c9-- From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 11:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 49283@debbugs.gnu.org, Michael Albinus Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162513768622823 (code B ref 49283); Thu, 01 Jul 2021 11:09:01 +0000 Received: (at 49283) by debbugs.gnu.org; 1 Jul 2021 11:08:06 +0000 Received: from localhost ([127.0.0.1]:59676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyuY9-0005w3-Ro for submit@debbugs.gnu.org; Thu, 01 Jul 2021 07:08:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:39106) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyuY7-0005vN-L3 for 49283@debbugs.gnu.org; Thu, 01 Jul 2021 07:08:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qjtMgz6QSRp7eyQH97mtHHkqcFbTASIbdDX+zcMvQ4k=; b=BFJYjyE74hT7gCqDQSLJ/jDZeM ajQtXmnQtTBfE0ElZd5pNwB/uLo62YXnx3brUuddNPs/T/2WojsYJf763FRwbvYKjvCfg4D3/KO/7 luz2qTmK0ucdp1D7UXpxyeEnK8ms/CZXkGeENnMGQVsD5u6x7I0jkFsrHj9TZyoff5nw=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyuXy-0003w0-Ja; Thu, 01 Jul 2021 13:07:57 +0200 From: Lars Ingebrigtsen References: <87a6n7zuf4.fsf@gmx.de> X-Now-Playing: Jane Siberry's _Bound By The Beauty_: "Are We Dancing Now? (Map III)" Date: Thu, 01 Jul 2021 13:07:54 +0200 In-Reply-To: (Jim Porter's message of "Wed, 30 Jun 2021 10:16:28 -0700") Message-ID: <877dia2sxh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: >> It is not a good idea to use `null-device' as INFILE, just use nil. At >> least in the `process-file' case, Tramp shall know which value to take >> for `null-device'. > > That fix would also work ( [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: >> It is not a good idea to use `null-device' as INFILE, just use nil. At >> least in the `process-file' case, Tramp shall know which value to take >> for `null-device'. > > That fix would also work (see the attached patch). Applied to Emacs 28 now. > However, when I read the `call-process' documentation, it says that > when `default-directory' is remote, it runs the program from "~". > That's fine overall, and means it's a good way to be sure you're > always running a process locally. It's just that when you do this, > INFILE's path is expanded relative to the remote directory. I don't > think that can ever work, since `call-process' doesn't know how to > open a TRAMP file. Because of that, it makes more sense to me that > you'd expand INFILE's path relative to wherever PROGRAM will be run > from. That means that when `default-directory' is remote, both PROGRAM > and INFILE are expanded relative to "~". That's more consistent, and > my first patch would hopefully prevent similar errors anytime > `call-process' is used from a remote buffer. But is that what your first patch does? * src/callproc.c (Fcall_process): Interpret 'infile' relative to the directory from which 'program' is called, not 'default-directory'. --- src/callproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/callproc.c b/src/callproc.c index aabc39313b..57cf781d28 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -270,7 +270,7 @@ DEFUN ("call-process", Fcall_process, Scall_process, 1, MANY, 0, if (nargs >= 2 && ! NILP (args[1])) { - infile = Fexpand_file_name (args[1], BVAR (current_buffer, directory)); + infile = Fexpand_file_name (args[1], encode_current_directory ()); CHECK_STRING (infile); -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 12:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Jim Porter , 49283@debbugs.gnu.org Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162514237923663 (code B ref 49283); Thu, 01 Jul 2021 12:27:02 +0000 Received: (at 49283) by debbugs.gnu.org; 1 Jul 2021 12:26:19 +0000 Received: from localhost ([127.0.0.1]:59845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyvlq-00069b-PR for submit@debbugs.gnu.org; Thu, 01 Jul 2021 08:26:19 -0400 Received: from mout.gmx.net ([212.227.17.22]:60829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyvlo-00069N-F7 for 49283@debbugs.gnu.org; Thu, 01 Jul 2021 08:26:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1625142369; bh=k93Ae2F9tbm856uctktbQaY8KvFL6snOOiZrBftSyGo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=PUU6gPIvsBCLKWwV6CR+UyTK2C9eCA19COISEWyvE+O8eBi9q/Fxmm/1ROzd7pRbZ vkQm3UYGaSrolahEGG2hHVaGMSJJjePVZljRrja4Lz4Dk4PIxgf23E3KrEWQJneTiY u0uhhKAGZp4J0vtw81LK8Tm/trpnNFP81IaeIZn8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.159.163]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N7iCg-1lCxwh2lLm-014mpb; Thu, 01 Jul 2021 14:26:09 +0200 From: Michael Albinus References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> Date: Thu, 01 Jul 2021 14:26:08 +0200 In-Reply-To: <877dia2sxh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 01 Jul 2021 13:07:54 +0200") Message-ID: <87h7hexlsv.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:2bNLi+pHv5RvuClWCvlr9Vd/qXo79HrefGDPnCeSGrWHc8g44bR JiMIaYhWmBBEyyJcpmYBKqHWrsnTtSWs9HN8Ji5ljR0mjfJ4cxfAt07mIZ5X1bt3rgf/tp4 kkTMS7PTqfhsrmuEW5flTHRq+Pv8d7Z6mMSuOKhfuSIOTlpsP1SP+tzpuZ8nrFe3Pbnupw9 XfDrr2HQ8DzpjEdjEhCvg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:KPmq2cHxOxE=:UHSv372xQPvKGsKN6J6nH3 UL0KcrmtwFkOKOCAopolkO9oQcX6ZWj6dAF+1ZN4+zbqQ2l1kyB4nA/Yoh+OGIWPa6mEsQnE2 6gPRyOrvJVBrPZ/o5p6qLIG1swKPxq6U8alSXzRQEmV5z8ChgewHePmSDoYlW3kz24Hk1zq3l ZG7TgNbtxkWDp+T+W0gsbJgX0nTCPWPGMRHZyhT2Zqt0O77IhHW1YVO3Z9FqGivScIcfr/hqA ue0zzZMrITHYdW6P1RqIzrUFUFsiGlEj7SZgK9mZLL0uCnTbCSBiu0bOvD+L2MpIkFRUvhtcW ZWd+TxJbLxaQLJl5z8OE7LKJLx2Ydb/byLZWToNqAmRZQNVYGfiBFe/6gOuy8NDjdLj5oMccu nCRjqC728cm5AAch2X14s6/n1X8s81xxgrtgNwIDp+MhCHDy2IzUYR0DfUTFQ2D2U3BWlePYM K2ZJYeK0CDIN8suEm1skQzirRyLsUqcxCNKD5JIS1SVGtM7VFYqPsajwO3Fw6brQQsM03wjuX a/WTzmwud6EqcXf/8YGgkLOYIQ6bKHBcw32JhM9KwgnfkZTrhh1RhCjpVMU5g+TMdR2ZNV/HD vhMIq2av/dnUK34BzsjWG4RYftekids/IUbp2H+MbEV55EJEt9QVqRT0x0iAawMmJC+OlW+EF qINxIJ41xFyGKCb82QiWe/LfTauxGdXkrqAtr1Ki896cw44qp+La74pnIHpA5CdQTGpp0twgk 8xMF7wl4/LnLHXtsNSzI62RkqK7e5CR75IXh/sKHA5sp0/vymtKZIH9vjkbWWc5AS7x5S1WSn KHWpdZ5H8aLJeWh70sV9FW0zpbm6zkgi6AkrCf0XKCeq5iAf5BbuSrv75KNQYAkIrD7VL5bo/ GL+bcMxqriyCsT2tlIdzEsWKxl8zglAWJpWW5omV+qAnhzSO3DhzixilTCdziT6G+y57NGlz2 wxGIm1SDnXzcfsJroRuBsJ7oQTvuGAZ3VTLRBaVZr7erdVZsvu3Kc8zeDEBraDi6N21xwxdzG TcQuPtOkIX+cc9dzIVTO5JUhGlPIKK2gKxqJ4rK6d1+pfJ/YMRiTG9bwERpmudbRY1VWjSv17 ixsYkBimjmbkoSfoEggUMZDlEf4mMuIKLywKj4ze8UqibQ4kClDnIqDOA== Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: Hi, >> However, when I read the `call-process' documentation, it says that >> when `default-directory' is remote, it runs the program from "~". >> That's fine overall, and means it's a good way to be sure you're >> always running a process locally. It's just that when you do this, >> INFILE's path is expanded relative to the remote directory. I don't >> think that can ever work, since `call-process' doesn't know how to >> open a TRAMP file. Because of that, it makes more sense to me that >> you'd expand INFILE's path relative to wherever PROGRAM will be run >> from. That means that when `default-directory' is remote, both PROGRAM >> and INFILE are expanded relative to "~". That's more consistent, and >> my first patch would hopefully prevent similar errors anytime >> `call-process' is used from a remote buffer. > > But is that what your first patch does? > > * src/callproc.c (Fcall_process): Interpret 'infile' relative to the > directory from which 'program' is called, not 'default-directory'. > --- > src/callproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/callproc.c b/src/callproc.c > index aabc39313b..57cf781d28 100644 > --- a/src/callproc.c > +++ b/src/callproc.c > @@ -270,7 +270,7 @@ DEFUN ("call-process", Fcall_process, Scall_process,= 1, MANY, 0, > > if (nargs >=3D 2 && ! NILP (args[1])) > { > - infile =3D Fexpand_file_name (args[1], BVAR (current_buffer, dire= ctory)); > + infile =3D Fexpand_file_name (args[1], encode_current_directory (= )); > CHECK_STRING (infile); Yes, this seems TRT. encode_current_directory returns either default-directory if this is a local dir, or "~" otherwise. Expanding INFILE to that directory is OK, I believe. So we shall apply Jim's patch. Maybe the docstring could be enhanced a little bit at the end, saying that INFILE, if it is a relative file name, is expanded to the directory the process uses as cwd. From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: Jim Porter , 49283@debbugs.gnu.org Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162514290224527 (code B ref 49283); Thu, 01 Jul 2021 12:35:02 +0000 Received: (at 49283) by debbugs.gnu.org; 1 Jul 2021 12:35:02 +0000 Received: from localhost ([127.0.0.1]:59854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyvu2-0006N7-T4 for submit@debbugs.gnu.org; Thu, 01 Jul 2021 08:35:01 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyvu0-0006Ms-Qi for 49283@debbugs.gnu.org; Thu, 01 Jul 2021 08:34:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iadtcHFg/CqlLhVnspRKMtRkUtz0I3vF2IOtYYixAYM=; b=MKdo9HJD7mvtwCoSqVPofHSIS9 RfWjiX/oWdrjxYRXX8BCAaRRWQ9BJS3suoS1Z9wBXwPNOuP0OMG1zF19Krr499M3zB6FoiekITEWe 9b8uM6FcVRgqhOgjyMqZK3Vlcf9R9CH5dBWq5b0zCpZpX1b5D3DCXL3WY3yWnYeYcj48=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyvtr-0004no-Qn; Thu, 01 Jul 2021 14:34:38 +0200 From: Lars Ingebrigtsen References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEWcaFGtjWDNconp zLxmSDcGBAf///9OYyusAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+UHAQwfJpaM6eMAAAG4SURBVDjL hZQ9j+QgDIZNQno77PZ86PqAdX3mjumvSP7/X1nDhMCstDoXkcYPr53XJgNwxaqYIxDA86zR8qDz XyHfgEL5rbOpZACSQMgZdmPYYQeKNaA+c0aYRdPBHMvx8zweKFr+vIFJ6HOJnSZi/t3AJKcwY15y TiqaDiSflgwZjnMn6iCwT7QcCCvmB6kUGuAUUC3/9C5KIFw7EFP6eRR3/KEA/K8GItGHPh9cAII2 Ao4KkAj3KhD/oOemEIGENdIrCsh/Gqh5isyOI0qp/R1wDSyzXK4eNY9zAxqWUYF7BVSW8AYISz6K DZjuUi8kbwVOobf+8wII3lXAPsqo/O08WQYlIBR/in1Y7iEmnIACUwRw0qj1kG34aZIMb3Vn1IFU 96E8qT7vUmWDFVwxAubAZgD5OYAWpUfuColLQu3CrUP5N0A2xBGUu1t7OPBviu15+Uhgw3dwzQrm no7zrTB+GhTR2Bs4wtQB21bKOIQu2ZJrYCYZ4S3ZVtVKTRDApzKTIO9t61f72vlOYFPiyrztn/MG bpejxaWwAchCB+8W7h7lkoUBPH4CuZVSr7+GNlv9fwA/gC9BA9ZbJyfMCwAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMS0wNy0wMVQxMjozMTozOCswMDowMMnxCG4AAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjEtMDctMDFUMTI6MzE6MzgrMDA6MDC4rLDSAAAAAElFTkSuQmCC X-Now-Playing: Jane Siberry's _Maria_: "Caravan" Date: Thu, 01 Jul 2021 14:34:35 +0200 In-Reply-To: <87h7hexlsv.fsf@gmx.de> (Michael Albinus's message of "Thu, 01 Jul 2021 14:26:08 +0200") Message-ID: <8735syyzz8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: >> * src/callproc.c (Fcall_process): Interpret 'infile' relative to the >> directory from which 'program' is called, not 'default-directory'. [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: >> * src/callproc.c (Fcall_process): Interpret 'infile' relative to the >> directory from which 'program' is called, not 'default-directory'. [...] > Yes, this seems TRT. encode_current_directory returns either > default-directory if this is a local dir, or "~" otherwise. Expanding > INFILE to that directory is OK, I believe. > > So we shall apply Jim's patch. Maybe the docstring could be enhanced a > little bit at the end, saying that INFILE, if it is a relative file > name, is expanded to the directory the process uses as cwd. Oh, I interpreted the commit message as "the directory where 'program' is" and the patch didn't seem to do that. But I still don't understand "the directory from which 'program' is called", because that's `default-directory'. (Except, as you say, when it's a remote dir.) The patch looks good to me, too, but the commit message is confusing. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 13:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Albinus Cc: jporterbugs@gmail.com, larsi@gnus.org, 49283@debbugs.gnu.org Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162514516028100 (code B ref 49283); Thu, 01 Jul 2021 13:13:02 +0000 Received: (at 49283) by debbugs.gnu.org; 1 Jul 2021 13:12:40 +0000 Received: from localhost ([127.0.0.1]:59931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lywUi-0007J8-0S for submit@debbugs.gnu.org; Thu, 01 Jul 2021 09:12:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lywUf-0007Iu-1g for 49283@debbugs.gnu.org; Thu, 01 Jul 2021 09:12:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50400) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lywUZ-0004pZ-Ky; Thu, 01 Jul 2021 09:12:31 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3918 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lywUZ-0002gT-2G; Thu, 01 Jul 2021 09:12:31 -0400 Date: Thu, 01 Jul 2021 16:12:25 +0300 Message-Id: <83lf6qkwjq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h7hexlsv.fsf@gmx.de> (message from Michael Albinus on Thu, 01 Jul 2021 14:26:08 +0200) References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Date: Thu, 01 Jul 2021 14:26:08 +0200 > Cc: Jim Porter , 49283@debbugs.gnu.org > > Lars Ingebrigtsen writes: > > > - infile = Fexpand_file_name (args[1], BVAR (current_buffer, directory)); > > + infile = Fexpand_file_name (args[1], encode_current_directory ()); > > CHECK_STRING (infile); > > Yes, this seems TRT. encode_current_directory returns either > default-directory if this is a local dir, or "~" otherwise. Expanding > INFILE to that directory is OK, I believe. > > So we shall apply Jim's patch. Maybe the docstring could be enhanced a > little bit at the end, saying that INFILE, if it is a relative file > name, is expanded to the directory the process uses as cwd. encode_current_directory returns an encoded file name. So if we make this change, we should avoid calling ENCODE_FILE on it (doing so is a no-op, but it's still unclean). From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jul 2021 19:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 49283@debbugs.gnu.org, Lars Ingebrigtsen , Michael Albinus Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162516876114890 (code B ref 49283); Thu, 01 Jul 2021 19:46:02 +0000 Received: (at 49283) by debbugs.gnu.org; 1 Jul 2021 19:46:01 +0000 Received: from localhost ([127.0.0.1]:33732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz2dN-0003s4-7H for submit@debbugs.gnu.org; Thu, 01 Jul 2021 15:46:01 -0400 Received: from mail-pg1-f173.google.com ([209.85.215.173]:34450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz2dL-0003rs-Bu for 49283@debbugs.gnu.org; Thu, 01 Jul 2021 15:45:59 -0400 Received: by mail-pg1-f173.google.com with SMTP id a7so7154658pga.1 for <49283@debbugs.gnu.org>; Thu, 01 Jul 2021 12:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uffpiXg9jXMwvxC5NdfGkkZs2MUtILZh53C5H8rENtk=; b=bK8qNfBZRpM0RGoZ+ImdSyhrIgmR8xy4o0Z6g3WeD1ispaEqoy+P3i7vOPjL1YIEdH 4cDQigQZLfKYp7FGFPBZ31r0fy4CCHyHccLQtOuiiI5sJGP6HoThJDKbLzR+90DhpJ4A PDM3m6OZQcJtAOxwaz1JMQPo4LfK0Pq7vIi7JnVto1cQFTKRrVBkuET2fNmX6Ex5P4Qj lCdJSCcImyk4H2JCBvU9GEiuQlyxAancxCCCDkkWUSR7UNE4SD2gt+PnKh/CytDZzadD MOtHEz0eY9VK2P0TXcJddfSCsr1i6K9syqHXog60OGZHNy2uQEstltWdhXYR1K37kUOo kZ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uffpiXg9jXMwvxC5NdfGkkZs2MUtILZh53C5H8rENtk=; b=khG/fNWqRDm9ROrQjIRQtjeSF6vEU38Z+LGQUAmIDDJwnF8+xNBsDbp1GSgUQgz1uA yvotDKRIuQ2cux4NJTzt5/sf5luHtdP4ElFwqEu+S8cVnhoGTWD6YVeKe+PicpBIFXW+ 8IC7jGpZMEOFqFBJaNnsA30vIXJUZ/+v3MFk/SsVcpZWn4AB56P1Z+sThYvBO8OoGz6w o5hmg54L46PKKNMR7RidT+vHH1WKkbMxRC1aiiaEoTu2M9wCn5ILKcGITJgo+EedfVi5 kssfHVLvrx0sPlxp6R7OAAq+p2uI9tlRmm59kM/ob9J7BmIXEMX9NJ3SenmcXK0TEQZQ 8C5A== X-Gm-Message-State: AOAM533TJZ4uCEldytquBW6xIYY/e6APdOLCX2sA2g8enHTrPVsl8PYj HLMhKhXfSQpUWbovwaa5IxLI6DN8JJqF5GnLWrM= X-Google-Smtp-Source: ABdhPJwPTq30G6tDTUw8L6AQi0n/po0Y5+jKH+lGa9Ln7VwtPKdKW6Wg56FQGPGng7wTRW5dCr3cGvGSpavk/etz2R8= X-Received: by 2002:aa7:9464:0:b029:306:3984:b22a with SMTP id t4-20020aa794640000b02903063984b22amr1274605pfq.81.1625168753316; Thu, 01 Jul 2021 12:45:53 -0700 (PDT) MIME-Version: 1.0 References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> <83lf6qkwjq.fsf@gnu.org> In-Reply-To: <83lf6qkwjq.fsf@gnu.org> From: Jim Porter Date: Thu, 1 Jul 2021 12:45:42 -0700 Message-ID: Content-Type: multipart/mixed; boundary="0000000000003df81805c61516c7" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003df81805c61516c7 Content-Type: text/plain; charset="UTF-8" On Thu, Jul 1, 2021 at 6:12 AM Eli Zaretskii wrote: > > > From: Michael Albinus > > Date: Thu, 01 Jul 2021 14:26:08 +0200 > > Cc: Jim Porter , 49283@debbugs.gnu.org > > > > So we shall apply Jim's patch. Maybe the docstring could be enhanced a > > little bit at the end, saying that INFILE, if it is a relative file > > name, is expanded to the directory the process uses as cwd. > > encode_current_directory returns an encoded file name. So if we make > this change, we should avoid calling ENCODE_FILE on it (doing so is a > no-op, but it's still unclean). I'd considered that when writing my initial patch to `call-process', but I wasn't sure what the most-correct way to avoid that would be. It seems we want an encoded path before returning from `encode_current_directory' in order to check that our result is actually accessible. But then that encoded dir gets passed in to `expand-file-name'. If INFILE is an un-encoded absolute path, wouldn't `expand-file-name' be un-encoded as well? Maybe a better way would be to get the cwd *without* encoding it (see the attached patch). However, maybe there's a simpler answer to all of this that I just don't know about since I'm not very familiar with how Emacs encodes file names. --0000000000003df81805c61516c7 Content-Type: application/octet-stream; name="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Disposition: attachment; filename="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqlbhmyy0 RnJvbSBlODVkMWU4ZGI4MTY0ZmU3MmZhYWQ0ZDVlZjUxZDg0ZjlkODQ0YWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IFRodSwgMSBKdWwgMjAyMSAxMjo0MTo0OSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEVuc3Vy ZSAnY2FsbC1wcm9jZXNzJyBpbnRlcnByZXRzICdpbmZpbGUnIGFzIGEgbG9jYWwgcGF0aAoKKiBz cmMvY2FsbHByb2MuYyAoRmNhbGxfcHJvY2Vzcyk6IEludGVycHJldCAnaW5maWxlJyByZWxhdGl2 ZSB0byB0aGUKd29ya2luZyBkaXJlY3RvcnkgZnJvbSB3aGljaCAncHJvZ3JhbScgaXMgcnVuLCBu b3QgJ2RlZmF1bHQtZGlyZWN0b3J5Jy4KLS0tCiBzcmMvY2FsbHByb2MuYyB8IDE5ICsrKysrKysr KysrKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxscHJvYy5jIGIvc3JjL2NhbGxwcm9jLmMKaW5kZXgg YWFiYzM5MzEzYi4uMTQyZmI0Y2IyMyAxMDA2NDQKLS0tIGEvc3JjL2NhbGxwcm9jLmMKKysrIGIv c3JjL2NhbGxwcm9jLmMKQEAgLTIyNSw4ICsyMjUsOSBAQCBERUZVTiAoImNhbGwtcHJvY2VzcyIs IEZjYWxsX3Byb2Nlc3MsIFNjYWxsX3Byb2Nlc3MsIDEsIE1BTlksIDAsCiBUaGUgcmVtYWluaW5n IGFyZ3VtZW50cyBhcmUgb3B0aW9uYWwuCiAKIFRoZSBwcm9ncmFtJ3MgaW5wdXQgY29tZXMgZnJv bSBmaWxlIElORklMRSAobmlsIG1lYW5zIGBudWxsLWRldmljZScpLgotSWYgeW91IHdhbnQgdG8g bWFrZSB0aGUgaW5wdXQgY29tZSBmcm9tIGFuIEVtYWNzIGJ1ZmZlciwgdXNlCi1gY2FsbC1wcm9j ZXNzLXJlZ2lvbicgaW5zdGVhZC4KK0lmIElORklMRSBpcyBhIHJlbGF0aXZlIHBhdGgsIGl0IHdp bGwgYmUgbG9va2VkIGZvciByZWxhdGl2ZSB0byB0aGUKK2RpcmVjdG9yeSB3aGVyZSB0aGUgcHJv Y2VzcyBpcyBydW4gKHNlZSBiZWxvdykuICBJZiB5b3Ugd2FudCB0byBtYWtlIHRoZQoraW5wdXQg Y29tZSBmcm9tIGFuIEVtYWNzIGJ1ZmZlciwgdXNlIGBjYWxsLXByb2Nlc3MtcmVnaW9uJyBpbnN0 ZWFkLgogCiBUaGlyZCBhcmd1bWVudCBERVNUSU5BVElPTiBzcGVjaWZpZXMgaG93IHRvIGhhbmRs ZSBwcm9ncmFtJ3Mgb3V0cHV0LgogSWYgREVTVElOQVRJT04gaXMgYSBidWZmZXIsIG9yIHQgdGhh dCBzdGFuZHMgZm9yIHRoZSBjdXJyZW50IGJ1ZmZlciwKQEAgLTI3MCw3ICsyNzEsMTkgQEAgREVG VU4gKCJjYWxsLXByb2Nlc3MiLCBGY2FsbF9wcm9jZXNzLCBTY2FsbF9wcm9jZXNzLCAxLCBNQU5Z LCAwLAogCiAgIGlmIChuYXJncyA+PSAyICYmICEgTklMUCAoYXJnc1sxXSkpCiAgICAgewotICAg ICAgaW5maWxlID0gRmV4cGFuZF9maWxlX25hbWUgKGFyZ3NbMV0sIEJWQVIgKGN1cnJlbnRfYnVm ZmVyLCBkaXJlY3RvcnkpKTsKKyAgICAgIC8qIEV4cGFuZCBpbmZpbGUgcmVsYXRpdmUgdG8gdGhl IGN1cnJlbnQgYnVmZmVyJ3MgY3VycmVudAorCSBkaXJlY3RvcnksIG9yIGl0cyB1bmhhbmRsZWQg ZXF1aXZhbGVudCAoIn4iKS4gICovCisgICAgICBMaXNwX09iamVjdCBjdXJkaXIgPSBCVkFSIChj dXJyZW50X2J1ZmZlciwgZGlyZWN0b3J5KTsKKyAgICAgIGN1cmRpciA9IEZ1bmhhbmRsZWRfZmls ZV9uYW1lX2RpcmVjdG9yeSAoY3VyZGlyKTsKKworICAgICAgLyogSWYgdGhlIGZpbGUgbmFtZSBo YW5kbGVyIHNheXMgdGhhdCBkaXIgaXMgdW5yZWFjaGFibGUsIHVzZQorCSBhIHNlbnNpYmxlIGRl ZmF1bHQuICovCisgICAgICBpZiAoTklMUCAoY3VyZGlyKSkKKwljdXJkaXIgPSBidWlsZF9zdHJp bmcgKCJ+Iik7CisKKyAgICAgIGN1cmRpciA9IGV4cGFuZF9hbmRfZGlyX3RvX2ZpbGUgKGN1cmRp cik7CisKKyAgICAgIGluZmlsZSA9IEZleHBhbmRfZmlsZV9uYW1lIChhcmdzWzFdLCBjdXJkaXIp OwogICAgICAgQ0hFQ0tfU1RSSU5HIChpbmZpbGUpOwogICAgIH0KICAgZWxzZQotLSAKMi4yNS4x Cgo= --0000000000003df81805c61516c7-- From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jul 2021 06:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 49283@debbugs.gnu.org, larsi@gnus.org, michael.albinus@gmx.de Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162520787910468 (code B ref 49283); Fri, 02 Jul 2021 06:38:01 +0000 Received: (at 49283) by debbugs.gnu.org; 2 Jul 2021 06:37:59 +0000 Received: from localhost ([127.0.0.1]:34056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzCoJ-0002im-Cg for submit@debbugs.gnu.org; Fri, 02 Jul 2021 02:37:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzCoH-0002iZ-J4 for 49283@debbugs.gnu.org; Fri, 02 Jul 2021 02:37:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52630) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzCoC-00015Q-6G; Fri, 02 Jul 2021 02:37:52 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4535 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzCo9-0006J8-QA; Fri, 02 Jul 2021 02:37:51 -0400 Date: Fri, 02 Jul 2021 09:37:49 +0300 Message-Id: <83k0m9jk5e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Thu, 1 Jul 2021 12:45:42 -0700) References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> <83lf6qkwjq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Date: Thu, 1 Jul 2021 12:45:42 -0700 > Cc: Michael Albinus , Lars Ingebrigtsen , 49283@debbugs.gnu.org > > > encode_current_directory returns an encoded file name. So if we make > > this change, we should avoid calling ENCODE_FILE on it (doing so is a > > no-op, but it's still unclean). > > I'd considered that when writing my initial patch to `call-process', > but I wasn't sure what the most-correct way to avoid that would be. It > seems we want an encoded path before returning from > `encode_current_directory' in order to check that our result is > actually accessible. But then that encoded dir gets passed in to > `expand-file-name'. If INFILE is an un-encoded absolute path, wouldn't > `expand-file-name' be un-encoded as well? expand-file-name is not a problem, it can deal with encoded file names. The problem is the calls to remove_slash_colon and report_file_error: they should receive file names in their internal representation. > Maybe a better way would be to get the cwd *without* encoding it (see > the attached patch). However, maybe there's a simpler answer to all of > this that I just don't know about since I'm not very familiar with how > Emacs encodes file names. How about adding a 'bool' argument to encode_current_directory, so that the caller could control whether or not it encodes the directory file name? Then you could in this case tell encode_current_directory not to encode the directory file name. From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jul 2021 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 49283@debbugs.gnu.org, Lars Ingebrigtsen , Michael Albinus Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162525165426134 (code B ref 49283); Fri, 02 Jul 2021 18:48:02 +0000 Received: (at 49283) by debbugs.gnu.org; 2 Jul 2021 18:47:34 +0000 Received: from localhost ([127.0.0.1]:37134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzOCM-0006nR-0M for submit@debbugs.gnu.org; Fri, 02 Jul 2021 14:47:34 -0400 Received: from mail-pf1-f177.google.com ([209.85.210.177]:34417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzOCH-0006n9-04 for 49283@debbugs.gnu.org; Fri, 02 Jul 2021 14:47:32 -0400 Received: by mail-pf1-f177.google.com with SMTP id f20so1863374pfa.1 for <49283@debbugs.gnu.org>; Fri, 02 Jul 2021 11:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cb9xBNPOoM1UXKCMFzSezExiRk8QZKzsei184+7GD3g=; b=ljRC4c4TxIPiApCqoOVas/4DZFXtZi+tVn8g5wJwEgUGRaCFOSPrhVZ37z8mi7IXWY N/+nyhCUaG3ZVGbcRKkHHBmkP+3xHDmB3i+elPmEFC9gAPSWSgq93wUHGiYv/7FJeVAA gHlskQc/tDDs8U4rB1hVroHGdyaK4HOY6fzGjiSob2kvSj4sqDRMJG+vmSgWlUYna8Kg cCEAEegx8tSaiUbGJj4qa3R4gmLM9jhqJRB0fGqSHjZkZwmhXwoYadR9/ZtqwQ/n++Fb gQ5ElwR+fawcOb4YUywiLZErLgEovOlvhmlyRhA4lKPDd6/dZy4W+16Bjyh6sVhDgZ8f ANRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cb9xBNPOoM1UXKCMFzSezExiRk8QZKzsei184+7GD3g=; b=tNPtxJQ3YdmBjPRRhxlpMaOs5f0WeFS4nQb1DYP6LT9MJOYOH4PCHR2jbvvtSOz+49 YD3cOhF0jKkWqu9IKPepC7hEvMAfSsYrT6RPI8YfSRpIdPxhSv2cz1NJik16vHERvWPK HoOlCPMkbGvGw4m1Xpzdsb3le/rVbwuvdzhMNkuF5bRGkRJMWv7mnmpfb2rhBLDtpeTA Cfe6uOAQ6H0RAYCyc7lSzS5G7opiK9lFGHlt3gxLDn/4eWaYuEQbi51TK8c9K2bWWUWy qhNg0Xk2PRgyrAx7apy6xJrbVFK0A2kk+8gY/i2BxvAaX3JMTgG0gkzQSvWEVLaa+Cpo IhOQ== X-Gm-Message-State: AOAM533gjw5rWGEjxXrZ0T/qd8EmKtzMi3HV5k1FaS5kfIko06Om7PRu TS3NXq2UVpNs4F18wktBSCQbr1qewlxWHjBiSAg= X-Google-Smtp-Source: ABdhPJwCB7ZsDnDobBAECVY8MIX8Ykq8Gkj/xI2J+DdZu/w8/VD5toab0mNzeS024a/ArUDlIzpPlCnVgXX629wdnh0= X-Received: by 2002:a63:b912:: with SMTP id z18mr1319041pge.185.1625251643070; Fri, 02 Jul 2021 11:47:23 -0700 (PDT) MIME-Version: 1.0 References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> <83lf6qkwjq.fsf@gnu.org> <83k0m9jk5e.fsf@gnu.org> In-Reply-To: <83k0m9jk5e.fsf@gnu.org> From: Jim Porter Date: Fri, 2 Jul 2021 11:47:12 -0700 Message-ID: Content-Type: multipart/mixed; boundary="000000000000db3bc405c62862be" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000db3bc405c62862be Content-Type: text/plain; charset="UTF-8" On Thu, Jul 1, 2021 at 11:37 PM Eli Zaretskii wrote: > > > From: Jim Porter > > Date: Thu, 1 Jul 2021 12:45:42 -0700 > > Cc: Michael Albinus , Lars Ingebrigtsen , 49283@debbugs.gnu.org > > > > I'd considered that when writing my initial patch to `call-process', > > but I wasn't sure what the most-correct way to avoid that would be. It > > seems we want an encoded path before returning from > > `encode_current_directory' in order to check that our result is > > actually accessible. But then that encoded dir gets passed in to > > `expand-file-name'. If INFILE is an un-encoded absolute path, wouldn't > > `expand-file-name' be un-encoded as well? > > expand-file-name is not a problem, it can deal with encoded file > names. The problem is the calls to remove_slash_colon and > report_file_error: they should receive file names in their internal > representation. Right, I was just worried that if I relied on `encode_current_directory' returning an encoded path, `expand-file-name' might sometimes return an encoded path (e.g. if INFILE is a simple relative path like "foo") and sometimes an unencoded path (e.g. if INFILE is an absolute path). I might be wrong though, since I didn't look closely at the implementation... > How about adding a 'bool' argument to encode_current_directory, so > that the caller could control whether or not it encodes the directory > file name? Then you could in this case tell encode_current_directory > not to encode the directory file name. Ok, I did that (and renamed it to `get_current_directory' since it doesn't always encode anymore). How does the attached patch look? --000000000000db3bc405c62862be Content-Type: application/octet-stream; name="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Disposition: attachment; filename="0001-Ensure-call-process-interprets-infile-as-a-local-pat.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqmotlp60 RnJvbSBhYjZlNDc5NTI5NDRlOTQwNjNhNGRiNjQ0MmVlMzU0OWRjNDZiZmI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IEZyaSwgMiBKdWwgMjAyMSAxMTo0MTo0MSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEVuc3Vy ZSAnY2FsbC1wcm9jZXNzJyBpbnRlcnByZXRzIElORklMRSBhcyBhIGxvY2FsIHBhdGgKCiogc3Jj L2NhbGxwcm9jLmMgKGdldF9jdXJyZW50X2RpcmVjdG9yeSk6IFJlbmFtZSBmcm9tCidlbmNvZGVf Y3VycmVudF9kaXJlY3RvcnknIGFuZCBhZGQgYm9vbGVhbiBFTkNPREUgZmxhZy4KKEZjYWxsX3By b2Nlc3MpOiBJbnRlcnByZXQgSU5GSUxFIHJlbGF0aXZlIHRvIHRoZSB3b3JraW5nIGRpcmVjdG9y eQpmcm9tIHdoaWNoIFBST0dSQU0gaXMgcnVuLCBub3QgJ2RlZmF1bHQtZGlyZWN0b3J5Jy4KKGNh bGxfcHJvY2Vzcyk6IFVzZSAnZ2V0X2N1cnJlbnRfZGlyZWN0b3J5Jy4KKiBzcmMvcHJvY2Vzcy5j IChGbWFrZV9wcm9jZXNzKTogVXNlICdnZXRfY3VycmVudF9kaXJlY3RvcnknLgoqIHNyYy9wcm9j ZXNzLmggKGdldF9jdXJyZW50X2RpcmVjdG9yeSk6IFJlbmFtZSBkZWNsIGZyb20KJ2VuY29kZV9j dXJyZW50X2RpcmVjdG9yeScuCiogc3JjL3N5c2RlcC5jIChzeXNfc3Vic2hlbGwpOiBVc2UgJ2dl dF9jdXJyZW50X2RpcmVjdG9yeScuCi0tLQogc3JjL2NhbGxwcm9jLmMgfCAyNSArKysrKysrKysr KysrKystLS0tLS0tLS0tCiBzcmMvcHJvY2Vzcy5jICB8ICAyICstCiBzcmMvcHJvY2Vzcy5oICB8 ICAyICstCiBzcmMvc3lzZGVwLmMgICB8ICAyICstCiA0IGZpbGVzIGNoYW5nZWQsIDE4IGluc2Vy dGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9jYWxscHJvYy5jIGIv c3JjL2NhbGxwcm9jLmMKaW5kZXggYWFiYzM5MzEzYi4uNjc1Yjc4ZGFmMyAxMDA2NDQKLS0tIGEv c3JjL2NhbGxwcm9jLmMKKysrIGIvc3JjL2NhbGxwcm9jLmMKQEAgLTExNiwxMSArMTE2LDEzIEBA ICNkZWZpbmUgX1BfTk9XQUlUIDEJLyogZnJvbSBwcm9jZXNzLmggKi8KIAkJCQkgICAgIGNvbnN0 IGNoYXIgKik7CiAMCiAvKiBSZXR1cm4gdGhlIGN1cnJlbnQgYnVmZmVyJ3Mgd29ya2luZyBkaXJl Y3RvcnksIG9yIHRoZSBob21lCi0gICBkaXJlY3RvcnkgaWYgaXQncyB1bnJlYWNoYWJsZSwgYXMg YSBzdHJpbmcgc3VpdGFibGUgZm9yIGEgc3lzdGVtIGNhbGwuCi0gICBTaWduYWwgYW4gZXJyb3Ig aWYgdGhlIHJlc3VsdCB3b3VsZCBub3QgYmUgYW4gYWNjZXNzaWJsZSBkaXJlY3RvcnkuICAqLwor ICAgZGlyZWN0b3J5IGlmIGl0J3MgdW5yZWFjaGFibGUuICBJZiBFTkNPREUgaXMgdHJ1ZSwgcmV0 dXJuIGFzIGEgc3RyaW5nCisgICBzdWl0YWJsZSBmb3IgYSBzeXN0ZW0gY2FsbDsgb3RoZXJ3aXNl LCByZXR1cm4gYSBzdHJpbmcgaW4gaXRzCisgICBpbnRlcm5hbCByZXByZXNlbnRhdGlvbi4gIFNp Z25hbCBhbiBlcnJvciBpZiB0aGUgcmVzdWx0IHdvdWxkIG5vdCBiZQorICAgYW4gYWNjZXNzaWJs ZSBkaXJlY3RvcnkuICAqLwogCiBMaXNwX09iamVjdAotZW5jb2RlX2N1cnJlbnRfZGlyZWN0b3J5 ICh2b2lkKQorZ2V0X2N1cnJlbnRfZGlyZWN0b3J5IChib29sIGVuY29kZSkKIHsKICAgTGlzcF9P YmplY3QgY3VyZGlyID0gQlZBUiAoY3VycmVudF9idWZmZXIsIGRpcmVjdG9yeSk7CiAgIExpc3Bf T2JqZWN0IGRpciA9IEZ1bmhhbmRsZWRfZmlsZV9uYW1lX2RpcmVjdG9yeSAoY3VyZGlyKTsKQEAg LTEzMSwxMiArMTMzLDEyIEBAIGVuY29kZV9jdXJyZW50X2RpcmVjdG9yeSAodm9pZCkKICAgICBk aXIgPSBidWlsZF9zdHJpbmcgKCJ+Iik7CiAKICAgZGlyID0gZXhwYW5kX2FuZF9kaXJfdG9fZmls ZSAoZGlyKTsKLSAgZGlyID0gRU5DT0RFX0ZJTEUgKHJlbW92ZV9zbGFzaF9jb2xvbiAoZGlyKSk7 CisgIExpc3BfT2JqZWN0IGVuY29kZWRfZGlyID0gRU5DT0RFX0ZJTEUgKHJlbW92ZV9zbGFzaF9j b2xvbiAoZGlyKSk7CiAKLSAgaWYgKCEgZmlsZV9hY2Nlc3NpYmxlX2RpcmVjdG9yeV9wIChkaXIp KQorICBpZiAoISBmaWxlX2FjY2Vzc2libGVfZGlyZWN0b3J5X3AgKGVuY29kZWRfZGlyKSkKICAg ICByZXBvcnRfZmlsZV9lcnJvciAoIlNldHRpbmcgY3VycmVudCBkaXJlY3RvcnkiLCBjdXJkaXIp OwogCi0gIHJldHVybiBkaXI7CisgIHJldHVybiBlbmNvZGUgPyBlbmNvZGVkX2RpciA6IGRpcjsK IH0KIAogLyogSWYgUCBpcyByZWFwYWJsZSwgcmVjb3JkIGl0IGFzIGEgZGVsZXRlZCBwcm9jZXNz IGFuZCBraWxsIGl0LgpAQCAtMjI1LDggKzIyNyw5IEBAIERFRlVOICgiY2FsbC1wcm9jZXNzIiwg RmNhbGxfcHJvY2VzcywgU2NhbGxfcHJvY2VzcywgMSwgTUFOWSwgMCwKIFRoZSByZW1haW5pbmcg YXJndW1lbnRzIGFyZSBvcHRpb25hbC4KIAogVGhlIHByb2dyYW0ncyBpbnB1dCBjb21lcyBmcm9t IGZpbGUgSU5GSUxFIChuaWwgbWVhbnMgYG51bGwtZGV2aWNlJykuCi1JZiB5b3Ugd2FudCB0byBt YWtlIHRoZSBpbnB1dCBjb21lIGZyb20gYW4gRW1hY3MgYnVmZmVyLCB1c2UKLWBjYWxsLXByb2Nl c3MtcmVnaW9uJyBpbnN0ZWFkLgorSWYgSU5GSUxFIGlzIGEgcmVsYXRpdmUgcGF0aCwgaXQgd2ls bCBiZSBsb29rZWQgZm9yIHJlbGF0aXZlIHRvIHRoZQorZGlyZWN0b3J5IHdoZXJlIHRoZSBwcm9j ZXNzIGlzIHJ1biAoc2VlIGJlbG93KS4gIElmIHlvdSB3YW50IHRvIG1ha2UgdGhlCitpbnB1dCBj b21lIGZyb20gYW4gRW1hY3MgYnVmZmVyLCB1c2UgYGNhbGwtcHJvY2Vzcy1yZWdpb24nIGluc3Rl YWQuCiAKIFRoaXJkIGFyZ3VtZW50IERFU1RJTkFUSU9OIHNwZWNpZmllcyBob3cgdG8gaGFuZGxl IHByb2dyYW0ncyBvdXRwdXQuCiBJZiBERVNUSU5BVElPTiBpcyBhIGJ1ZmZlciwgb3IgdCB0aGF0 IHN0YW5kcyBmb3IgdGhlIGN1cnJlbnQgYnVmZmVyLApAQCAtMjcwLDcgKzI3Myw5IEBAIERFRlVO ICgiY2FsbC1wcm9jZXNzIiwgRmNhbGxfcHJvY2VzcywgU2NhbGxfcHJvY2VzcywgMSwgTUFOWSwg MCwKIAogICBpZiAobmFyZ3MgPj0gMiAmJiAhIE5JTFAgKGFyZ3NbMV0pKQogICAgIHsKLSAgICAg IGluZmlsZSA9IEZleHBhbmRfZmlsZV9uYW1lIChhcmdzWzFdLCBCVkFSIChjdXJyZW50X2J1ZmZl ciwgZGlyZWN0b3J5KSk7CisgICAgICAvKiBFeHBhbmQgaW5maWxlIHJlbGF0aXZlIHRvIHRoZSBj dXJyZW50IGJ1ZmZlcidzIGN1cnJlbnQKKwkgZGlyZWN0b3J5LCBvciBpdHMgdW5oYW5kbGVkIGVx dWl2YWxlbnQgKCJ+IikuICAqLworICAgICAgaW5maWxlID0gRmV4cGFuZF9maWxlX25hbWUgKGFy Z3NbMV0sIGdldF9jdXJyZW50X2RpcmVjdG9yeSAoZmFsc2UpKTsKICAgICAgIENIRUNLX1NUUklO RyAoaW5maWxlKTsKICAgICB9CiAgIGVsc2UKQEAgLTQzOSw3ICs0NDQsNyBAQCBjYWxsX3Byb2Nl c3MgKHB0cmRpZmZfdCBuYXJncywgTGlzcF9PYmplY3QgKmFyZ3MsIGludCBmaWxlZmQsCiAgICAg IGJ1ZmZlcidzIGN1cnJlbnQgZGlyZWN0b3J5LCBvciBpdHMgdW5oYW5kbGVkIGVxdWl2YWxlbnQu ICBXZQogICAgICBjYW4ndCBqdXN0IGhhdmUgdGhlIGNoaWxkIGNoZWNrIGZvciBhbiBlcnJvciB3 aGVuIGl0IGRvZXMgdGhlCiAgICAgIGNoZGlyLCBzaW5jZSBpdCdzIGluIGEgdmZvcmsuICAqLwot ICBjdXJyZW50X2RpciA9IGVuY29kZV9jdXJyZW50X2RpcmVjdG9yeSAoKTsKKyAgY3VycmVudF9k aXIgPSBnZXRfY3VycmVudF9kaXJlY3RvcnkgKHRydWUpOwogCiAgIGlmIChTVFJJTkdQIChlcnJv cl9maWxlKSkKICAgICB7CmRpZmYgLS1naXQgYS9zcmMvcHJvY2Vzcy5jIGIvc3JjL3Byb2Nlc3Mu YwppbmRleCBjMzU0ZjNhOTBkLi5iOGMzZTRlY2ZiIDEwMDY0NAotLS0gYS9zcmMvcHJvY2Vzcy5j CisrKyBiL3NyYy9wcm9jZXNzLmMKQEAgLTE3NTUsNyArMTc1NSw3IEBAIERFRlVOICgibWFrZS1w cm9jZXNzIiwgRm1ha2VfcHJvY2VzcywgU21ha2VfcHJvY2VzcywgMCwgTUFOWSwgMCwKICAgICAg YnVmZmVyJ3MgY3VycmVudCBkaXJlY3RvcnksIG9yIGl0cyB1bmhhbmRsZWQgZXF1aXZhbGVudC4g IFdlCiAgICAgIGNhbid0IGp1c3QgaGF2ZSB0aGUgY2hpbGQgY2hlY2sgZm9yIGFuIGVycm9yIHdo ZW4gaXQgZG9lcyB0aGUKICAgICAgY2hkaXIsIHNpbmNlIGl0J3MgaW4gYSB2Zm9yay4gICovCi0g IGN1cnJlbnRfZGlyID0gZW5jb2RlX2N1cnJlbnRfZGlyZWN0b3J5ICgpOworICBjdXJyZW50X2Rp ciA9IGdldF9jdXJyZW50X2RpcmVjdG9yeSAodHJ1ZSk7CiAKICAgbmFtZSA9IEZwbGlzdF9nZXQg KGNvbnRhY3QsIFFDbmFtZSk7CiAgIENIRUNLX1NUUklORyAobmFtZSk7CmRpZmYgLS1naXQgYS9z cmMvcHJvY2Vzcy5oIGIvc3JjL3Byb2Nlc3MuaAppbmRleCAwODkwZjI1M2E0Li40YTI1ZDEzZDI2 IDEwMDY0NAotLS0gYS9zcmMvcHJvY2Vzcy5oCisrKyBiL3NyYy9wcm9jZXNzLmgKQEAgLTI2NCw3 ICsyNjQsNyBAQCBwc2V0X2dudXRsc19jcmVkX3R5cGUgKHN0cnVjdCBMaXNwX1Byb2Nlc3MgKnAs IExpc3BfT2JqZWN0IHZhbCkKIAogLyogRGVmaW5lZCBpbiBjYWxscHJvYy5jLiAgKi8KIAotZXh0 ZXJuIExpc3BfT2JqZWN0IGVuY29kZV9jdXJyZW50X2RpcmVjdG9yeSAodm9pZCk7CitleHRlcm4g TGlzcF9PYmplY3QgZ2V0X2N1cnJlbnRfZGlyZWN0b3J5IChib29sKTsKIGV4dGVybiB2b2lkIHJl Y29yZF9raWxsX3Byb2Nlc3MgKHN0cnVjdCBMaXNwX1Byb2Nlc3MgKiwgTGlzcF9PYmplY3QpOwog CiAvKiBEZWZpbmVkIGluIHN5c2RlcC5jLiAgKi8KZGlmZiAtLWdpdCBhL3NyYy9zeXNkZXAuYyBi L3NyYy9zeXNkZXAuYwppbmRleCA1MWQ4YjVlZWVkLi5iOGVjMjJkOWRkIDEwMDY0NAotLS0gYS9z cmMvc3lzZGVwLmMKKysrIGIvc3JjL3N5c2RlcC5jCkBAIC02NTcsNyArNjU3LDcgQEAgc3lzX3N1 YnNoZWxsICh2b2lkKQogI2VuZGlmCiAgIHBpZF90IHBpZDsKICAgc3RydWN0IHNhdmVfc2lnbmFs IHNhdmVkX2hhbmRsZXJzWzVdOwotICBjaGFyICpzdHIgPSBTU0RBVEEgKGVuY29kZV9jdXJyZW50 X2RpcmVjdG9yeSAoKSk7CisgIGNoYXIgKnN0ciA9IFNTREFUQSAoZ2V0X2N1cnJlbnRfZGlyZWN0 b3J5ICh0cnVlKSk7CiAKICNpZmRlZiBET1NfTlQKICAgcGlkID0gMDsKLS0gCjIuMjUuMQoK --000000000000db3bc405c62862be-- From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Jul 2021 07:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 49283@debbugs.gnu.org, larsi@gnus.org, michael.albinus@gmx.de Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.16252957636065 (code B ref 49283); Sat, 03 Jul 2021 07:03:02 +0000 Received: (at 49283) by debbugs.gnu.org; 3 Jul 2021 07:02:43 +0000 Received: from localhost ([127.0.0.1]:37856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzZfm-0001Zl-RJ for submit@debbugs.gnu.org; Sat, 03 Jul 2021 03:02:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzZfj-0001ZW-Sx for 49283@debbugs.gnu.org; Sat, 03 Jul 2021 03:02:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35768) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzZfe-0001fl-3X; Sat, 03 Jul 2021 03:02:34 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3324 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzZfd-0000V1-Mk; Sat, 03 Jul 2021 03:02:34 -0400 Date: Sat, 03 Jul 2021 10:02:32 +0300 Message-Id: <83o8bjj2wn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jim Porter on Fri, 2 Jul 2021 11:47:12 -0700) References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> <83lf6qkwjq.fsf@gnu.org> <83k0m9jk5e.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Date: Fri, 2 Jul 2021 11:47:12 -0700 > Cc: Michael Albinus , Lars Ingebrigtsen , 49283@debbugs.gnu.org > > > expand-file-name is not a problem, it can deal with encoded file > > names. The problem is the calls to remove_slash_colon and > > report_file_error: they should receive file names in their internal > > representation. > > Right, I was just worried that if I relied on > `encode_current_directory' returning an encoded path, > `expand-file-name' might sometimes return an encoded path (e.g. if > INFILE is a simple relative path like "foo") and sometimes an > unencoded path (e.g. if INFILE is an absolute path). I might be wrong > though, since I didn't look closely at the implementation... > > > How about adding a 'bool' argument to encode_current_directory, so > > that the caller could control whether or not it encodes the directory > > file name? Then you could in this case tell encode_current_directory > > not to encode the directory file name. > > Ok, I did that (and renamed it to `get_current_directory' since it > doesn't always encode anymore). How does the attached patch look? LGTM, thanks. From unknown Sun Jun 22 07:58:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49283: [PATCH] 27.2; `(call-process "program" null-device ...)' fails over TRAMP from local MS Windows Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jul 2021 13:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49283 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 49283@debbugs.gnu.org, Eli Zaretskii , Michael Albinus Received: via spool by 49283-submit@debbugs.gnu.org id=B49283.162540556913635 (code B ref 49283); Sun, 04 Jul 2021 13:33:02 +0000 Received: (at 49283) by debbugs.gnu.org; 4 Jul 2021 13:32:49 +0000 Received: from localhost ([127.0.0.1]:40565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m02Er-0003Xr-Gk for submit@debbugs.gnu.org; Sun, 04 Jul 2021 09:32:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m02En-0003XT-Qt for 49283@debbugs.gnu.org; Sun, 04 Jul 2021 09:32:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mx1ohuBLjXZynDg0qALq09sr9z24S4yV1SbL+z6Acto=; b=d2UeM9salYTEellZM3ANTfIxjc 7bUK1d6s/tL/p6iWZpvlI9duUgJNimV0hzCxykX3LX9wP7xyfYAktsLTa0fTrZl7m68KPtKgTC+3X yV6q2V8nTav3sBqeAc1stV0oEuvisvz9qxepXt139sIIRF8QF8ETFfp5OID0fCGbDgPc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m02Ee-0000kQ-8v; Sun, 04 Jul 2021 15:32:38 +0200 From: Lars Ingebrigtsen References: <87a6n7zuf4.fsf@gmx.de> <877dia2sxh.fsf@gnus.org> <87h7hexlsv.fsf@gmx.de> <83lf6qkwjq.fsf@gnu.org> <83k0m9jk5e.fsf@gnu.org> X-Now-Playing: New Order's _Power, Corruption & Lies_: "Leave Me Alone" Date: Sun, 04 Jul 2021 15:32:35 +0200 In-Reply-To: (Jim Porter's message of "Fri, 2 Jul 2021 11:47:12 -0700") Message-ID: <87wnq6432k.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Ok, I did that (and renamed it to `get_current_directory' since it > doesn't always encode anymore). How does the attached patch look? Looks good; so I've now pushed it to Emacs 28, and with that I'm closing this bug report. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Ok, I did that (and renamed it to `get_current_directory' since it > doesn't always encode anymore). How does the attached patch look? Looks good; so I've now pushed it to Emacs 28, and with that I'm closing this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 04 09:32:57 2021 Received: (at control) by debbugs.gnu.org; 4 Jul 2021 13:32:58 +0000 Received: from localhost ([127.0.0.1]:40568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m02Ez-0003YK-Mz for submit@debbugs.gnu.org; Sun, 04 Jul 2021 09:32:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m02Ex-0003Y0-On for control@debbugs.gnu.org; Sun, 04 Jul 2021 09:32:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Mq+/4j24f2/qeUsemitUIFz3yBu9nu1I0HerkoIeS28=; b=PUmhMrFcYWx79MCQqg73McPtvM SUwf29pzqNnNi6kevClcYtZpPg8DQS76KXZc7moxWMRTp7p40UGBxU9uiEK2luRUL0h7CtXn02CXF rmkIYvU9pf8d2e0jfJNyWUVhWfMV5Sd2OLp488laqo02ZclmAfK6v0RumRJ1MlB4fmio=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m02Ep-0000kc-W5 for control@debbugs.gnu.org; Sun, 04 Jul 2021 15:32:49 +0200 Date: Sun, 04 Jul 2021 15:32:47 +0200 Message-Id: <87v95q4328.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49283 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49283 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49283 28.1 quit