From unknown Fri Sep 05 08:21:37 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4928: 23.1; lm-keywords more flexibility Reply-To: Kevin Ryde , 4928@debbugs.gnu.org Resent-From: Kevin Ryde Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 15 Nov 2009 00:35:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4928 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125824503124424 (code B ref -1); Sun, 15 Nov 2009 00:35:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Nov 2009 00:30:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.8 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAF0UTYn024420 for ; Sat, 14 Nov 2009 16:30:31 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9T0e-0006cv-JI for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9T0a-0006cT-JB for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:28 -0500 Received: from [199.232.76.173] (port=52233 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9T0a-0006cQ-EU for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:24 -0500 Received: from mailout1-1.pacific.net.au ([61.8.2.208]:34440 helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N9T0Z-0006Or-KD for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:24 -0500 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 6E0A3503B7A for ; Sun, 15 Nov 2009 11:30:19 +1100 (EST) Received: from blah.blah (ppp20E0.dyn.pacific.net.au [61.8.32.224]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id CEBB92740F for ; Sun, 15 Nov 2009 11:30:17 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1N9T0Q-0003Bd-EI for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 11:30:14 +1100 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Date: Sun, 15 Nov 2009 11:30:13 +1100 Message-ID: <87skcgy6i2.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= This is a idea to relax/extend lm-keywords to cope with multi-line keywords, like say Drew's icicles.el, ;; Keywords: internal, extensions, help, abbrev, local, minibuffer, ;; keys, apropos, completion, matching, regexp, command And comma-only separators like say zenirc-color.el, ;; Keywords: zenirc,extensions And trailing-space as in say vm-summary-faces.el, which had been ok in Emacs 21. ;; Keywords: VM 2009-11-13 Kevin Ryde * emacs-lisp/lisp-mnt.el (lm-keywords): Allow multi-line keywords. (lm-keywords-list): Allow comma-only separator like "foo,bar". Ignore trailing spaces by omit-nulls to split-string (fixing regression from Emacs 21 due to the incompatible split-string change.) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=lisp-mnt.el.keywords.diff --- lisp-mnt.el.~1.63.~ 2009-10-08 11:00:31.000000000 +1100 +++ lisp-mnt.el 2009-11-15 11:27:05.000000000 +1100 @@ -445,16 +445,20 @@ (match-string-no-properties 1))))))) (defun lm-keywords (&optional file) - "Return the keywords given in file FILE, or current buffer if FILE is nil." + "Return the keywords given in file FILE, or current buffer if FILE is nil. +The return value is a `downcase'-ed string, or nil if no keywords +header. Multi-line keywords are joined up with a space between +each line." (lm-with-file file - (let ((keywords (lm-header "keywords"))) - (and keywords (downcase keywords))))) + (let ((keywords (lm-header-multiline "keywords"))) + (and keywords + (mapconcat 'downcase keywords " "))))) (defun lm-keywords-list (&optional file) "Return list of keywords given in file FILE." (let ((keywords (lm-keywords file))) (if keywords - (split-string keywords ",?[ \t]")))) + (split-string keywords "[, \t\n]+" t)))) (defvar finder-known-keywords) (defun lm-keywords-finder-p (&optional file) --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' --=-=-=-- From unknown Fri Sep 05 08:21:37 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4928: 23.1; lm-keywords more flexibility Reply-To: Stefan Monnier , 4928@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 15 Nov 2009 01:55:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4928 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4928-submit@emacsbugs.donarmstrong.com id=B4928.12582492421614 (code B ref 4928); Sun, 15 Nov 2009 01:55:05 +0000 Received: (at 4928) by emacsbugs.donarmstrong.com; 15 Nov 2009 01:40:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.6 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.pppoe.ca (ironport2-out.teksavvy.com [206.248.154.181]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAF1eeSB001608 for <4928@emacsbugs.donarmstrong.com>; Sat, 14 Nov 2009 17:40:41 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArcEAAXr/kpMCqHJ/2dsb2JhbACBTNB3hDwEiT4 X-IronPort-AV: E=Sophos;i="4.44,744,1249272000"; d="scan'208";a="49431732" Received: from 76-10-161-201.dsl.teksavvy.com (HELO pastel.home) ([76.10.161.201]) by ironport2-out.pppoe.ca with ESMTP; 14 Nov 2009 20:40:19 -0500 Received: by pastel.home (Postfix, from userid 20848) id BA367F2149; Sat, 14 Nov 2009 20:40:18 -0500 (EST) From: Stefan Monnier To: Kevin Ryde Cc: 4928@debbugs.gnu.org Message-ID: References: <87skcgy6i2.fsf@blah.blah> Date: Sat, 14 Nov 2009 20:40:18 -0500 In-Reply-To: <87skcgy6i2.fsf@blah.blah> (Kevin Ryde's message of "Sun, 15 Nov 2009 11:30:13 +1100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > This is a idea to relax/extend lm-keywords to cope with multi-line > keywords, like say Drew's icicles.el, Feel free to install it, Stefan From rgm@gnu.org Mon Nov 16 11:39:41 2009 Received: (at control) by emacsbugs.donarmstrong.com; 16 Nov 2009 19:39:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGI2FuN002916 for ; Mon, 16 Nov 2009 10:02:16 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NA5u1-0004AG-LB; Mon, 16 Nov 2009 13:02:13 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19201.37797.524753.543418@fencepost.gnu.org> Date: Mon, 16 Nov 2009 13:02:13 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: k^eR=<\"G;m%*rkJ3R8gB\=1A!RK|h Subject: bug#4928 closed by Kevin Ryde (Re: bug#4928: 23.1; lm-keywords more flexibility) Message-ID: References: <87skce2e7f.fsf@blah.blah> <87skcgy6i2.fsf@blah.blah> X-Emacs-PR-Message: they-closed 4928 X-Emacs-PR-Package: emacs Reply-To: 4928@debbugs.gnu.org Date: Tue, 17 Nov 2009 00:30:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1258417806-25194-1" This is a multi-part message in MIME format... ------------=_1258417806-25194-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4928: 23.1; lm-keywords more flexibility It has been closed by Kevin Ryde . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Kevin Ryde by replying to this email. --=20 4928: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4928 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1258417806-25194-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4928-done) by emacsbugs.donarmstrong.com; 17 Nov 2009 00:21:51 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mailout2.pacific.net.au (mailout2-5.pacific.net.au [61.8.2.228]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAH0LnAP024700 for <4928-done@emacsbugs.donarmstrong.com>; Mon, 16 Nov 2009 16:21:51 -0800 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id 050F518D5A7 for <4928-done@emacsbugs.donarmstrong.com>; Tue, 17 Nov 2009 11:21:48 +1100 (EST) Received: from blah.blah (ppp23E4.dyn.pacific.net.au [61.8.35.228]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 923312742A for <4928-done@emacsbugs.donarmstrong.com>; Tue, 17 Nov 2009 11:21:47 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1NABpF-0000wn-Ne for 4928-done@emacsbugs.donarmstrong.com; Tue, 17 Nov 2009 11:21:41 +1100 From: Kevin Ryde To: 4928-done@debbugs.gnu.org Subject: Re: bug#4928: 23.1; lm-keywords more flexibility References: <87skcgy6i2.fsf@blah.blah> Date: Tue, 17 Nov 2009 11:21:40 +1100 In-Reply-To: (Stefan Monnier's message of "Sat, 14 Nov 2009 20:40:18 -0500") Message-ID: <87skce2e7f.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier writes: > > Feel free to install it, Done. ------------=_1258417806-25194-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 15 Nov 2009 00:30:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.8 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAF0UTYn024420 for ; Sat, 14 Nov 2009 16:30:31 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9T0e-0006cv-JI for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9T0a-0006cT-JB for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:28 -0500 Received: from [199.232.76.173] (port=52233 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9T0a-0006cQ-EU for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:24 -0500 Received: from mailout1-1.pacific.net.au ([61.8.2.208]:34440 helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N9T0Z-0006Or-KD for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 19:30:24 -0500 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id 6E0A3503B7A for ; Sun, 15 Nov 2009 11:30:19 +1100 (EST) Received: from blah.blah (ppp20E0.dyn.pacific.net.au [61.8.32.224]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id CEBB92740F for ; Sun, 15 Nov 2009 11:30:17 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1N9T0Q-0003Bd-EI for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 11:30:14 +1100 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.1; lm-keywords more flexibility Date: Sun, 15 Nov 2009 11:30:13 +1100 Message-ID: <87skcgy6i2.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= This is a idea to relax/extend lm-keywords to cope with multi-line keywords, like say Drew's icicles.el, ;; Keywords: internal, extensions, help, abbrev, local, minibuffer, ;; keys, apropos, completion, matching, regexp, command And comma-only separators like say zenirc-color.el, ;; Keywords: zenirc,extensions And trailing-space as in say vm-summary-faces.el, which had been ok in Emacs 21. ;; Keywords: VM 2009-11-13 Kevin Ryde * emacs-lisp/lisp-mnt.el (lm-keywords): Allow multi-line keywords. (lm-keywords-list): Allow comma-only separator like "foo,bar". Ignore trailing spaces by omit-nulls to split-string (fixing regression from Emacs 21 due to the incompatible split-string change.) --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=lisp-mnt.el.keywords.diff --- lisp-mnt.el.~1.63.~ 2009-10-08 11:00:31.000000000 +1100 +++ lisp-mnt.el 2009-11-15 11:27:05.000000000 +1100 @@ -445,16 +445,20 @@ (match-string-no-properties 1))))))) (defun lm-keywords (&optional file) - "Return the keywords given in file FILE, or current buffer if FILE is nil." + "Return the keywords given in file FILE, or current buffer if FILE is nil. +The return value is a `downcase'-ed string, or nil if no keywords +header. Multi-line keywords are joined up with a space between +each line." (lm-with-file file - (let ((keywords (lm-header "keywords"))) - (and keywords (downcase keywords))))) + (let ((keywords (lm-header-multiline "keywords"))) + (and keywords + (mapconcat 'downcase keywords " "))))) (defun lm-keywords-list (&optional file) "Return list of keywords given in file FILE." (let ((keywords (lm-keywords file))) (if keywords - (split-string keywords ",?[ \t]")))) + (split-string keywords "[, \t\n]+" t)))) (defvar finder-known-keywords) (defun lm-keywords-finder-p (&optional file) --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' --=-=-=-- ------------=_1258417806-25194-1--