From unknown Sun Jun 15 13:03:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49275: 28.0.50; [PATCH] improve-switch-to-prev-buffer-skip Resent-From: Trust me I am a Doctor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Jun 2021 16:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 49275@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16249836195313 (code B ref -1); Tue, 29 Jun 2021 16:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jun 2021 16:20:19 +0000 Received: from localhost ([127.0.0.1]:55172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyGTC-0001Nc-NV for submit@debbugs.gnu.org; Tue, 29 Jun 2021 12:20:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:48536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyGTA-0001NU-SO for submit@debbugs.gnu.org; Tue, 29 Jun 2021 12:20:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyGTA-0000YD-Lv for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 12:20:16 -0400 Received: from mx1.riseup.net ([198.252.153.129]:33032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyGT4-0006uM-Vi for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 12:20:16 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4GDqSm1VHrzDqr0 for ; Tue, 29 Jun 2021 09:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1624983608; bh=4o8arc121vx/G4xfrNAZAa3SYvLft+447CPIcQmq7k0=; h=From:To:Subject:Date:From; b=MFzr2LXm4FzLVFQArb7mGp9r5dOSY+Aav6qj/i1jupK5PGDiyRA3z14vtjY/HDxJe SjvqXPwkbjUZTk7DTDzBHU1ileVXANrbtK+3e5GJbLSkgnO6rdWTOV9JgEThyHkygi Bak0x2SivNNChXKQf/9bTBZOk3eFzx4hiQ6yM6Fs= X-Riseup-User-ID: F0A74C3DC130224F6856F8F0F3A757E1B3FB4E0DFE5DE686B035017A27605224 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4GDqSk3BWVz5vbQ for ; Tue, 29 Jun 2021 09:20:05 -0700 (PDT) From: Trust me I am a Doctor Date: Tue, 29 Jun 2021 17:56:18 +0200 Message-ID: <87lf6sy76c.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=198.252.153.129; envelope-from=pillule@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain $ emacs -Q ;; Considering the next commands : (defun pils/cycle-buffer-of-major-mode (&optional arg) "Switch to previous buffer of this major mode. With ARG as \\[universal-argument], switch to the next instead." (interactive "P") (let ((switch-to-prev-buffer-skip (lambda (window buffer _bury-or-kill) (not (eq (buffer-local-value 'major-mode (window-buffer window)) (buffer-local-value 'major-mode buffer)))))) (if arg (switch-to-next-buffer) (switch-to-prev-buffer nil 'append))) (when (eq (current-buffer) (window-old-buffer)) (user-error "No other %s buffer available." major-mode))) (defun pils/next-buffer-of-major-mode () "Switch to the next buffer of this major mode." (interactive) (pils/cycle-buffer-of-major-mode t)) ;; That we could temporary bind to : (global-set-key (kbd "M-p") #'pils/cycle-buffer-of-major-mode) (global-set-key (kbd "M-n") #'pils/next-buffer-of-major-mode) Now gently but firmly, play theses emacs chords. What happened ? The first command will put you in another mode. That is unexpected ... Worse the second one will quickly jam. The current implementation 'switch-to-prev-buffer-skip' fallback to the first skipped buffer if no one have satisfied its anti-predicate. That's why you could end up in another mode despite setting 'switch-to-prev-buffer-skip' to not select others modes. Conservatively I fix that by checking if 'switch-to-prev-buffer-skip' is a function. The second issue is a bug in the implementation of 'switch-to-next-buffer'. This command should never return the same buffer, it is wrote in its docstring, and it escaped me in commit d0c7d8bc22. So here a little patch to fix both. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Improve-switch-to-prev-buffer-skip.patch Content-Description: Improve-switch-to-prev-buffer-skip >From 687725fa0ab9c5cae9a6c5efb7e24c14ce2c2a1f Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Sun, 27 Jun 2021 02:24:27 +0200 Subject: [PATCH] Improve switch-to-prev-buffer-skip * lisp/window.el (switch-to-prev-buffer): It was fall-backing to the first skipped buffer, what I know is it is most probably undesirable when 'switch-to-prev-buffer-skip' is a function. So we only do it when it is not a function. (switch-to-next-buffer): Tiddo, and also fix a bug where this function was returning the same buffer, as it never should do. --- lisp/window.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/window.el b/lisp/window.el index c0511bec4c..668bcf0d04 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4721,8 +4721,8 @@ switch-to-prev-buffer window new-buffer (nth 1 entry) (nth 2 entry)) (throw 'found t))))) - (when skipped - ;; Show first skipped buffer. + (when (and skipped (not functionp switch-to-prev-buffer-skip-p)) + ;; Show first skipped buffer, unless skip was a function. (setq new-buffer skipped) (set-window-buffer-start-and-point window new-buffer))) @@ -4831,6 +4831,7 @@ switch-to-next-buffer ;; nreverse here!) (dolist (entry (reverse (window-prev-buffers window))) (when (and (not (eq new-buffer (car entry))) + (not (eq old-buffer (car entry))) (setq new-buffer (car entry)) (or (buffer-live-p new-buffer) (not (setq killed-buffers @@ -4842,8 +4843,8 @@ switch-to-next-buffer window new-buffer (nth 1 entry) (nth 2 entry)) (throw 'found t)))) - (when skipped - ;; Show first skipped buffer. + (when (and skipped (not functionp switch-to-prev-buffer-skip-p)) + ;; Show first skipped buffer, unless skip was a function. (setq new-buffer skipped) (set-window-buffer-start-and-point window new-buffer))) -- 2.20.1 --=-=-=-- From unknown Sun Jun 15 13:03:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49275: 28.0.50; [PATCH] improve-switch-to-prev-buffer-skip Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Trust me I am a Doctor , 49275@debbugs.gnu.org Received: via spool by 49275-submit@debbugs.gnu.org id=B49275.162503863319715 (code B ref 49275); Wed, 30 Jun 2021 07:38:02 +0000 Received: (at 49275) by debbugs.gnu.org; 30 Jun 2021 07:37:13 +0000 Received: from localhost ([127.0.0.1]:56359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyUmX-00057u-Ap for submit@debbugs.gnu.org; Wed, 30 Jun 2021 03:37:13 -0400 Received: from mout.gmx.net ([212.227.17.20]:37601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyUmV-00057h-Oz for 49275@debbugs.gnu.org; Wed, 30 Jun 2021 03:37:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1625038621; bh=YG9tL6Bdma2v4dq1UrDlSrANch8XOPU6uotUhJ+Q0sc=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=ikg/ZHR7tf6F4OIyLDI7FRv9NMnlx0nxZe9bUcQngOyn0C7l3eFJKX8Bn8+qTBexk mX6nmkmIARZR/acS03aiTCz2XE7yqyoM3YHRcM+pRMFxwyMZtq3qm/DiVJsGLmlqhN +wAIN3uzVuzq5K5qVH4u6SHSkS6XwjvkvFfvgw68= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([46.125.249.76]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MYvY8-1llNmP3GDY-00UqWr; Wed, 30 Jun 2021 09:37:01 +0200 References: <87lf6sy76c.fsf@riseup.net> From: martin rudalics Message-ID: <14ae1372-39c7-c4b0-be94-6944df2724d4@gmx.at> Date: Wed, 30 Jun 2021 09:37:00 +0200 MIME-Version: 1.0 In-Reply-To: <87lf6sy76c.fsf@riseup.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:h3CLJDO9/d/b+rQ1jutUgtlGNbRxcRrdUkQTMGuFdUA7O47Dx1g dz/a+Ci+YSI2crgbjhF3Tmwf80hJdvoQbQ1nW0h0IqdrPwZs9wm7MS+fNfYlZcU95LZfZJ+ GdSQILofFBlwjKGfqYCI/KCvMgbAM3BuEYCInlvAIanS83TgA3vIWVdym+c4uhDsnVmXE6q 4fzWe/gTYEqKeKdNC2ahA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:JsMSN447p2E=:2Dj5f9sxt21GIGM0T5RAEa TKvlLzhgfF/KUhC589lDdHpc0s7JEM+BkaVW1ITOgD0vAHeizAn7BOXGoLHg52tbxMz67W7qn CDxzyHwgATOiNYVgX62o58U1r8I6QF/aXOD4zKGLz8Njj5OyxO5yFJJXWaMCzm1yYCwx9C0Se JzG+DAkGg1f09oiBgHwAZNI+tqAub4wJrcAJSkCDGKpgC4CiqS3ytmSJaWiyzzq3QQoKexsJr kGPl9vi8rDEMivoF6Z+JIV/GDni7GkvteatfrQURw2ZvFfAnOeWazi89ZS84kyxh9FA7+SZ8A m6hVzfHKyxlmlGU79bZksOnZz2s08Fkl7Kjj+QMfyqG9uqDjT99+WImCJUIJSsw+aYwzIXKG4 /mKKLqmut8xYkb8IaURQ6i+iy4WBRbCo61mmc0D2z900Ft9weZ44gMNsfdZjgO5SjDHRstNeH f08Gqr5iFOG3iwwmFdzwmpz9pVbporzx4rH0NTiRI+ObkLDdCkmSBXL9Vp76gKEBsFnOrthkP 82Jpgskr9AJH8TJb//S5kEILJT+mqyucWojsNZSlmrNuQXZjxXM1sSR+4W2FPclX3kL2VwKPu mq//rXCRusIImUQ2qa4z4wfcXpIiy/HPRg1202XSu2/2xyNCLJ7nwZAFPuPQNY3ATSSstwOE1 2QwM/18lzEveF8LfseD4lb4ToZjDEWmIle+3Gvg1t9Zt7amTgd3ANCqGeED6JA7ltw7Fx3W6k fzb/PqcmEIv5KUk1mCkf83X3EYTJwX/djK6eBsgDPAfprMraaEyUwf0nNfVbBpdaD8TYt0xPZ xt5xWTAlnJflp6seLW/3kbocYVLwvF59ag4fgehrn4GvyqGH5+RyU4F6mJeKXrmcpI8JgihAX zro6Kzn+u2KuM+YZPIyaOqiB3sfcijIJRONEPFOQNkCyn37NIycbiMd3OLw2HI3v2g2scKeW8 JFfBUphGnJPb652ktVIZAzAppKnVwBMlI2mrWCf9hr4uqWHyfPZVjA8iyyYPVf0l7GLQz9kh/ qj8xShbt8Qof+inx/k3pvZgHNL5MsYqGY9SopNwd6edX6Kt222D1LQqAuaY3ho3dLAD5X6dEN RppABhKGbuQneai7wKpa0J/u4krXBMQUbCU X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Conservatively I fix that by checking if 'switch-to-prev-buffer-skip' > is a function. What is the intended meaning of + (when (and skipped (not functionp switch-to-prev-buffer-skip-p)) Did you mean + (when (and skipped (not (functionp switch-to-prev-buffer-skip))) here? martin From unknown Sun Jun 15 13:03:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49275: 28.0.50; [PATCH] improve-switch-to-prev-buffer-skip Resent-From: Trust me I am a Doctor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Jul 2021 12:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics Cc: 49275@debbugs.gnu.org Received: via spool by 49275-submit@debbugs.gnu.org id=B49275.162574837026572 (code B ref 49275); Thu, 08 Jul 2021 12:47:01 +0000 Received: (at 49275) by debbugs.gnu.org; 8 Jul 2021 12:46:10 +0000 Received: from localhost ([127.0.0.1]:54605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1TPt-0006uA-Kd for submit@debbugs.gnu.org; Thu, 08 Jul 2021 08:46:10 -0400 Received: from mx1.riseup.net ([198.252.153.129]:51214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1TPq-0006m7-Pu for 49275@debbugs.gnu.org; Thu, 08 Jul 2021 08:46:08 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4GLGHX6JfmzDqqQ; Thu, 8 Jul 2021 05:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1625748360; bh=olauWunNs8++EV2HgWpiwkI7z2E1nmHpTwPAVzyb6as=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=mJGlm48g3ph3PkL87TUKAi+EOP3q4q0AfFFiTNSIYnGN9AN4q6wrBdqBGS63OHwCe YLAWHcw6icj+whiMP4Zx5IlIk9mVgQOuPg+5JireHk0nMDfPHWKDpxpUo2TIvzZJwj Z6vIpQQBs97Hh7x51V67XhiNITrphh3cCnBKhhcM= X-Riseup-User-ID: A36A2B1A76E73A4578F31C80F3F370BF6CB7912C546E1F431CFB6FE82F22FB17 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4GLGHW67crz5vND; Thu, 8 Jul 2021 05:45:59 -0700 (PDT) References: <87lf6sy76c.fsf@riseup.net> <14ae1372-39c7-c4b0-be94-6944df2724d4@gmx.at> From: Trust me I am a Doctor Date: Thu, 08 Jul 2021 14:43:46 +0200 In-reply-to: <14ae1372-39c7-c4b0-be94-6944df2724d4@gmx.at> Message-ID: <87sg0p55z1.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain martin rudalics writes: >> Conservatively I fix that by checking if 'switch-to-prev-buffer-skip' >> is a function. > > What is the intended meaning of > > + (when (and skipped (not functionp switch-to-prev-buffer-skip-p)) > > Did you mean > > + (when (and skipped (not (functionp switch-to-prev-buffer-skip))) > > here? Duh. Indeed. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Improve-switch-to-prev-buffer-skip.patch Content-Description: improve switch to prev buffer skip with fixed parens >From 687725fa0ab9c5cae9a6c5efb7e24c14ce2c2a1f Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Sun, 27 Jun 2021 02:24:27 +0200 Subject: [PATCH] Improve switch-to-prev-buffer-skip * lisp/window.el (switch-to-prev-buffer): It was fall-backing to the first skipped buffer, what I know is it is most probably undesirable when 'switch-to-prev-buffer-skip' is a function. So we only do it when it is not a function. (switch-to-next-buffer): Tiddo, and also fix a bug where this function was returning the same buffer, as it never should do. --- lisp/window.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/window.el b/lisp/window.el index c0511bec4c..668bcf0d04 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4721,8 +4721,8 @@ switch-to-prev-buffer window new-buffer (nth 1 entry) (nth 2 entry)) (throw 'found t))))) - (when skipped - ;; Show first skipped buffer. + (when (and skipped (not functionp switch-to-prev-buffer-skip-p)) + ;; Show first skipped buffer, unless skip was a function. (setq new-buffer skipped) (set-window-buffer-start-and-point window new-buffer))) @@ -4831,6 +4831,7 @@ switch-to-next-buffer ;; nreverse here!) (dolist (entry (reverse (window-prev-buffers window))) (when (and (not (eq new-buffer (car entry))) + (not (eq old-buffer (car entry))) (setq new-buffer (car entry)) (or (buffer-live-p new-buffer) (not (setq killed-buffers @@ -4842,8 +4843,8 @@ switch-to-next-buffer window new-buffer (nth 1 entry) (nth 2 entry)) (throw 'found t)))) - (when skipped - ;; Show first skipped buffer. + (when (and skipped (not functionp switch-to-prev-buffer-skip-p)) + ;; Show first skipped buffer, unless skip was a function. (setq new-buffer skipped) (set-window-buffer-start-and-point window new-buffer))) -- 2.20.1 --=-=-= Content-Type: text/plain -- --=-=-=-- From unknown Sun Jun 15 13:03:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49275: 28.0.50; [PATCH] improve-switch-to-prev-buffer-skip Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Jul 2021 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Trust me I am a Doctor Cc: 49275@debbugs.gnu.org Received: via spool by 49275-submit@debbugs.gnu.org id=B49275.16265968784333 (code B ref 49275); Sun, 18 Jul 2021 08:28:02 +0000 Received: (at 49275) by debbugs.gnu.org; 18 Jul 2021 08:27:58 +0000 Received: from localhost ([127.0.0.1]:55180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m529W-00017o-MA for submit@debbugs.gnu.org; Sun, 18 Jul 2021 04:27:58 -0400 Received: from mout.gmx.net ([212.227.17.21]:60911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m529T-00017c-Bk for 49275@debbugs.gnu.org; Sun, 18 Jul 2021 04:27:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1626596865; bh=Et+JUDwMNrWHFtQrSlM6TnUGG1U5uAYhnA7+4bpaCmw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=AlAPi35FizYWcOVUtcihNkR3oG/aFyT15FZ+9mljyaoOQzTkFFKwW7NPHsBroE9CS Q75oVS9S5TX+m92C85DVmKZ7gyBWZDsqcTDo8yIW6CfCkgmb7C6fd7Bo2o1fwM3lF8 S7pJY9Rj34cMghoe152qb/pckV9Dm42DdScmFbwc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([213.142.97.181]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mi2Jt-1lR2hd3mWf-00e0f4; Sun, 18 Jul 2021 10:27:44 +0200 References: <87lf6sy76c.fsf@riseup.net> <14ae1372-39c7-c4b0-be94-6944df2724d4@gmx.at> <87sg0p55z1.fsf@riseup.net> From: martin rudalics Message-ID: Date: Sun, 18 Jul 2021 10:27:43 +0200 MIME-Version: 1.0 In-Reply-To: <87sg0p55z1.fsf@riseup.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:AmLeTZyLiUyJCRT05oLuzxXRRBdHTiVj2bvMTdJ2TZCLJ8BWBtC MgOkux/XeUGZc1MBYKQaL8iMX6+vPj+pMMruKnjcwXquiC185iGkiABlqW7Yvvfns7cssXA hqhn2YNpwPDH9uX/xbYn4z0F5dasXIUY8c6AUHSiGMS6HnmR2nNGMJHX5y803HUP9Scvhzr V/hu2UtiSb7/CQlIYRSYg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:EfyXXbwtU/A=:1KJfYYbd7XPf0W4l6vJkuv GIq4CwkOoYC37jef5VUJVYroNwnkld8maRivhToJeFaWPsiQebUY4ila82doRsu0cmNoVouGE g8cMV5SzGP8si/jA+BgFoFDOngat8+RG4EQA3xQJkT0vIND6o/r6a3q8zSxWpU0UlylYWxnKH eRbrb+ESYTqA2gOZshET1KPNxb9ZXmoHpM8w9BbyAwcTGxNzFsDGdSYj6cFEN2BMzV2VyZEul ZGYTYJPk6aRQeVo7m0uc2o0tLrM0UrV8KK7AaAJRPAnHhydAabzFh4pcxgh7KdbzuVLW6klj4 ACjBCW5T8QlxFFMjtRkwi7dLZNJSgkZkFlCt49gu84R8e78dk3Ftju3WaoyLO2wuF6J1+4gN4 r4/EVl0q+ir3Q9QMzlEcLsxNhDPROcnTSaHUXKIuTkqyB74/w653fsqg5h+lroIp0z2NUt3H3 zFRU30AL+8UQxu6ImULNVhYGdW2Ns3yRI9j05TTNebUClznmZIdE7D6Uw7GsdAO0lg0nKxUtz E27/e1f47Ss67MnLfUG9Fzg3Qf7mnI/Zj/kslLOLBWqnYQPqJBxvkxCJaNpcKL6kqUNfqpp3/ hig77AQLU1UE52L1gyDzbDWXUiAd2DVUeT12xFTfhi3ZgsKmUFjNPjWme3/lK8OgH/wptwqPp zUGXItViz3UswPhTNuJbkZsqtt/b1uVPr6P1cASIu5MsdoIZvXGo740HPL//vzf1RBJFLM5Zl 1cakIXJbND7KRNFu3DQfaYSWuXqi+DvygrPB9vkiriPLSoQ5W8YtmB0B5fpZqioI9oY9C7mV5 Bt+PMfi+vTYv2BtaJbS1KJpkGfaaOG0WstxYtNdR3cG9OYSeKSXSlr1Wvm2hTIh9NOLZiFOS3 o83chdFD1EU6djT0wFvAWfu9Lb+0OLpk4pcv4khTaw6aDdy4P/3RakLo+FtPI+lg5/yg5wFbu tB/vyr2DeBFpdPnv1rvlVsQxPxQ0n30qSUcTZFfJO/RX70sFwpqA4dduzSzK1jYd349JNhLAv 0tA4BcbEyG/TiRh/WgxvlCpBYTbqDbHgpRLe0+T1CktjNfXYtd0RWfHjHdi6qG7HU4FqjPNkd 3vv5LfBaVsSk4lH31m3i/AFbNsaxed4INeV X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry but this is still not right. It now gets me In switch-to-prev-buffer: =2E./../lisp/window.el:4724:27: Warning: =E2=80=98not=E2=80=99 called wit= h 2 args, but requires 1 =2E./../lisp/window.el:4724:27: Warning: reference to free variable =E2=80= =98functionp=E2=80=99 =2E./../lisp/window.el:4724:27: Warning: reference to free variable =E2=80=98switch-to-prev-buffer-skip-p=E2=80=99 In switch-to-next-buffer: =2E./../lisp/window.el:4846:27: Warning: =E2=80=98not=E2=80=99 called wit= h 2 args, but requires 1 =2E./../lisp/window.el:4846:27: Warning: reference to free variable =E2=80= =98functionp=E2=80=99 =2E./../lisp/window.el:4846:27: Warning: reference to free variable =E2=80=98switch-to-prev-buffer-skip-p=E2=80=99 martin From unknown Sun Jun 15 13:03:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49275: 28.0.50; [PATCH] improve-switch-to-prev-buffer-skip Resent-From: Trust me I am a Doctor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jul 2021 10:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics Cc: 49275@debbugs.gnu.org Received: via spool by 49275-submit@debbugs.gnu.org id=B49275.16268616913099 (code B ref 49275); Wed, 21 Jul 2021 10:02:01 +0000 Received: (at 49275) by debbugs.gnu.org; 21 Jul 2021 10:01:31 +0000 Received: from localhost ([127.0.0.1]:36160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m692h-0000nu-6G for submit@debbugs.gnu.org; Wed, 21 Jul 2021 06:01:31 -0400 Received: from mx1.riseup.net ([198.252.153.129]:42392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m692e-0000ni-MP for 49275@debbugs.gnu.org; Wed, 21 Jul 2021 06:01:30 -0400 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4GVB1Z6B9XzF4XL; Wed, 21 Jul 2021 03:01:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1626861682; bh=fjp15eZkUfSxT57dw7rDLdKvJBu9lzl/KaSl7u62FSs=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=s9egC/WOrIqCKbZzqycP784eCoV+UybizjdH02HR3DtIj5QvvCj0XWvR16F0p/8ST ocAFaJqG1E7iFqQ0HbJlI3a3Q7y/nyszmkZMMNdY8uMUq+KXgPaz5aHXJnczlbBr8F QFDB7nq5gum+mVk06MSaYS4Nmg7hz2YvrMeZBk9Y= X-Riseup-User-ID: F3F7933A717249BFC1D3D9524BD819F3D0A6C0638A14E0341FA930E6CA965FF2 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4GVB1Y75bkz1ySb; Wed, 21 Jul 2021 03:01:21 -0700 (PDT) References: <87lf6sy76c.fsf@riseup.net> <14ae1372-39c7-c4b0-be94-6944df2724d4@gmx.at> <87sg0p55z1.fsf@riseup.net> From: Trust me I am a Doctor Date: Wed, 21 Jul 2021 11:59:52 +0200 In-reply-to: Message-ID: <87bl6wdlzn.fsf@riseup.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable martin rudalics writes: > Sorry but this is still not right. It now gets me > > In switch-to-prev-buffer: > ../../lisp/window.el:4724:27: Warning: =E2=80=98not=E2=80=99 called with = 2 args, but requires > 1 > ../../lisp/window.el:4724:27: Warning: reference to free variable =E2=80= =98functionp=E2=80=99 > ../../lisp/window.el:4724:27: Warning: reference to free variable > =E2=80=98switch-to-prev-buffer-skip-p=E2=80=99 > > In switch-to-next-buffer: > ../../lisp/window.el:4846:27: Warning: =E2=80=98not=E2=80=99 called with = 2 args, but requires > 1 > ../../lisp/window.el:4846:27: Warning: reference to free variable =E2=80= =98functionp=E2=80=99 > ../../lisp/window.el:4846:27: Warning: reference to free variable > =E2=80=98switch-to-prev-buffer-skip-p=E2=80=99 > > martin Sorry that was the same buggy one. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Make-switch-to-prev-buffer-skip-more-reliable.patch Content-Description: this one is corrected >From b1375219d247d87ac72a41fb4f1887a9a40039fc Mon Sep 17 00:00:00 2001 From: Trust me I am a doctor Date: Sun, 27 Jun 2021 02:27:48 +0200 Subject: [PATCH] Make switch-to-prev-buffer-skip more reliable * lisp/window.el (switch-to-prev-buffer): It was fall-backing to the first skipped buffer, what I know is it is most probably undesirable when 'switch-to-prev-buffer-skip' is a function. So we only do it when it is not a function. (switch-to-next-buffer): Tiddo, and also fix a bug where this function was returning the same buffer, as it never should do. --- lisp/window.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/window.el b/lisp/window.el index c0511bec4c..9315107f1f 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -4721,8 +4721,8 @@ switch-to-prev-buffer window new-buffer (nth 1 entry) (nth 2 entry)) (throw 'found t))))) - (when skipped - ;; Show first skipped buffer. + (when (and skipped (not (functionp switch-to-prev-buffer-skip))) + ;; Show first skipped buffer, unless skip was a function. (setq new-buffer skipped) (set-window-buffer-start-and-point window new-buffer))) @@ -4831,6 +4831,7 @@ switch-to-next-buffer ;; nreverse here!) (dolist (entry (reverse (window-prev-buffers window))) (when (and (not (eq new-buffer (car entry))) + (not (eq old-buffer (car entry))) (setq new-buffer (car entry)) (or (buffer-live-p new-buffer) (not (setq killed-buffers @@ -4842,8 +4843,8 @@ switch-to-next-buffer window new-buffer (nth 1 entry) (nth 2 entry)) (throw 'found t)))) - (when skipped - ;; Show first skipped buffer. + (when (and skipped (not (functionp switch-to-prev-buffer-skip))) + ;; Show first skipped buffer, unless skip was a function. (setq new-buffer skipped) (set-window-buffer-start-and-point window new-buffer))) -- 2.20.1 --=-=-= Content-Type: text/plain -- --=-=-=-- From unknown Sun Jun 15 13:03:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49275: 28.0.50; [PATCH] improve-switch-to-prev-buffer-skip Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Aug 2021 08:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Trust me I am a Doctor Cc: 49275@debbugs.gnu.org Received: via spool by 49275-submit@debbugs.gnu.org id=B49275.162927372316283 (code B ref 49275); Wed, 18 Aug 2021 08:03:02 +0000 Received: (at 49275) by debbugs.gnu.org; 18 Aug 2021 08:02:03 +0000 Received: from localhost ([127.0.0.1]:54751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGGWR-0004EZ-Gx for submit@debbugs.gnu.org; Wed, 18 Aug 2021 04:02:03 -0400 Received: from mout.gmx.net ([212.227.15.19]:42311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGGWP-0004E0-Fb for 49275@debbugs.gnu.org; Wed, 18 Aug 2021 04:02:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1629273713; bh=DPKRnh5LcVEa/qrcKMVtx9SwrKTs+LSUN/xYKKc72Lo=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=erivOM9/8ShWd/Z/Z0obUOVwiWkJpsOMOoVDnrxCGhyAU+ub6n3MqZuQMtnX+7WRN EP5R5G87gMxOVHOwVKATrQr5uF6AiYKFv0/ebxlEF+ZJVGN7D/w2ePHtoGIyUy50vn cRkFb/ng3ZtO78Of2bLzpccQI0JuoZ8H3gVQ1q0Q= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.120]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1ML9yS-1mYTrO05oI-00IG4V; Wed, 18 Aug 2021 10:01:52 +0200 References: <87lf6sy76c.fsf@riseup.net> <14ae1372-39c7-c4b0-be94-6944df2724d4@gmx.at> <87sg0p55z1.fsf@riseup.net> <87bl6wdlzn.fsf@riseup.net> From: martin rudalics Message-ID: <0255e5e5-9e36-dc8d-3c61-cbe5a13f8a17@gmx.at> Date: Wed, 18 Aug 2021 10:01:48 +0200 MIME-Version: 1.0 In-Reply-To: <87bl6wdlzn.fsf@riseup.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:CbYyJ0bsWDxAwJQOzbgu3LVwQC5zfJoOQfjIsxGA+77LVwh4D7o FnWX+qTexIdrsYKAgdB/OwiF6SenHTyBTwEiqdcQ3F2dX5qIe9cdcjsiqu5SF9a7A3hPKNM 4BJZB+Oai9zdCyVFzliQUjDVHaZmhUnF3bRJo/Rss5YKLcooZIEFV/FBy5WoXlqlglRJ0pY lPURXFHnm9jC+PE8+9SJQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:nYtQbYGZYFY=:bPuw4MOedIfc2ORoIJ8YoT THz+eaWAdj2hy28288SjRJjGD7sETiYtql2no3EE5zlPkTdLjF1NizSuqQwg/QjM2NZeXde4W jCG6PPdzjpXy1sx/BDvMfYUeVbr8SuNdNzfyV9GZqKJsgoHbX0Wd48OEgCA5Nxp6UzOL5fTrk U/gs1hYbrxMPrxT8kVRde6c/dPTmyLO7oNSxeamoeTdQxYjFJP5wkMlIV8z6V8bsuDhbnsYLM e82Tsu/tIvvg5IiIqGao4K8LE8EhvSxyp57Iy2kC8wI67cAaDWopj9yTAFo2taGGtuJOJJvT4 XQDaqn/lZ2z+PUtR5wdfpbqLvb73Xm7V4PLXCAj0PbqchkiEAmYuCbuYICqo0Lpwyh/xKxNDO IW2DT27HXNBkef4SQNaJHhWXK2+RdwWzT1+daYyb7STWBQvE+SPm7JI4l1MpJfx9wP/EHldm3 x/A/J16em0pSOuiII2Md7NipZWp2Upfkm+hu/mnBuHiPtfb8MPjBxfxo/Npkl+mgzXK7LkWFM 0nxjN0ltFoEg0qksedWUUDnXidN7vbTVsBh4E0sPG0k/i/83bBr0eVpadglyU2+vPDul1kGKl ciuym6avIggo9ir4pbm0RmRWNx0gR/tdfWo/HR4w3Yr2+TfewPVsLLuUt+CrTtsIip4lHPbvH u5/n3VoIKkImWmoK8Gah8bXJ2SHk2J/q0m6fx/DQSyeKkYE/E9sXXZl6GfFGTGqVEKJxyoM29 wYfgeIQVcTj5oDmVw4E6wYi4Dvj7IXinUa2nSq4E7pmWS9RqSACb7qMvYOy+110hh21VoHrkT ZF2qUzZ3Kb8pa5d8E4PKep4K1iLzmmTfjDePWgyjC1FakfTnk8d7EqfBQdr8d/6L6ukT21YiO 04Y3E5jDwRqp/qbE1W6R5pXEKKTUvQ4QiWSXkfRhwExdym18iqLpXPfIs1Lw45jUrxgctSx5N Dom5e0g/zjcdq7iJGAhHfHkAyFpyR1F2/VtFPRyz5YLFU0x4Tsm1861PAeV08/oztOvBwP8l3 2p1eyAGMsRD/NYBL1MemW0Izf2aTAkNbqCjLrVcUxNHefb/Ha+8VPENdrPHSb9KBE+ji4hGai h8gZB4Se1bHO5d1FjrGPtxuNDnVrb2ky/NJZcerdb+TYI2GuDt2Z+WIwA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Sorry that was the same buggy one. Installed, finally. Sorry for the delay. Thanks, martin From unknown Sun Jun 15 13:03:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49275: 28.0.50; [PATCH] improve-switch-to-prev-buffer-skip Resent-From: Trust me I am a Doctor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Aug 2021 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: control@debbugs.gnu.org Cc: 49275@debbugs.gnu.org Received: via spool by 49275-submit@debbugs.gnu.org id=B49275.162931129818653 (code B ref 49275); Wed, 18 Aug 2021 18:29:01 +0000 Received: (at 49275) by debbugs.gnu.org; 18 Aug 2021 18:28:18 +0000 Received: from localhost ([127.0.0.1]:57611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGQIQ-0004qi-Hp for submit@debbugs.gnu.org; Wed, 18 Aug 2021 14:28:18 -0400 Received: from mx1.riseup.net ([198.252.153.129]:51190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGQIL-0004qP-0i; Wed, 18 Aug 2021 14:28:13 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4GqbxH50HmzDv41; Wed, 18 Aug 2021 11:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1629311283; bh=LYotG0BSY3Lpt16ooFW86Gdcw2u7FXeFWqDPOo3mgqk=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=VrcAIS52CYeu5L0wcjkdPM5Z/e+KxNWpDKRipUU47KJ738JDDkxMgTFh15bgzovIO xi7jmbpTeQ8gVhCnpvBPU6sIrDk4rkaLyeq0BVQ33gwCrD3bjb2Poh6hB/jL1kEpS8 ot2eKuo+2M45iVHqABMot9AmrVdiKiSIf0MOGm5A= X-Riseup-User-ID: E3A47FD976B85C90E9D4E974BD5F922BA1086F15DDAA16853036ECCA5DC84B98 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4GqbxG4c01z5vh4; Wed, 18 Aug 2021 11:28:02 -0700 (PDT) References: <87lf6sy76c.fsf@riseup.net> <14ae1372-39c7-c4b0-be94-6944df2724d4@gmx.at> <87sg0p55z1.fsf@riseup.net> <87bl6wdlzn.fsf@riseup.net> <0255e5e5-9e36-dc8d-3c61-cbe5a13f8a17@gmx.at> From: Trust me I am a Doctor Date: Wed, 18 Aug 2021 20:27:15 +0200 In-reply-to: <0255e5e5-9e36-dc8d-3c61-cbe5a13f8a17@gmx.at> Message-ID: <87czqad2vp.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 49275 thanks --