GNU bug report logs - #49274
[PATCH] lisp/cus-theme: retain documentation string when customizing theme

Previous Next

Full log

Message #20 received at 49274 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Christopher League <league <at> contrapunctus.net>
Cc: 49274 <at> debbugs.gnu.org
Subject: Re: bug#49274: [PATCH] lisp/cus-theme: retain documentation string
 when customizing theme
Date: Wed, 30 Jun 2021 11:09:29 -0300

Christopher League <league <at> contrapunctus.net> writes:

> On 2021-06-29 20:03, Mauro Aranda wrote:
>> That's because there was a change to the :format property of the text
>> widget, but this call wasn't updated.  Try overriding it like this:
>> (widget-create 'text :format "%v" ...)
>> 
>> The above should make it work.  Please try it, thank you.
>
> Yes, that works. I'm including an updated patch below. Thanks. CL
>

[...]

> +    (widget-insert "Description: ")
> +    (setq custom-theme-description
> +	  (widget-create 'editable-field
> +		         :value (or (get theme 'theme-documentation)
> +				    (format-time-string "Created %Y-%m-%d."))))

Did you send the old one by mistake?

Also, please format the commit message according to the Emacs
conventions: see the file CONTRIBUTE and the "Commit messages" section
in particular.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.