From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 29 07:52:11 2021 Received: (at submit) by debbugs.gnu.org; 29 Jun 2021 11:52:11 +0000 Received: from localhost ([127.0.0.1]:53765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyCHj-0002xn-0x for submit@debbugs.gnu.org; Tue, 29 Jun 2021 07:52:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:33012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyCHg-0002xc-NX for submit@debbugs.gnu.org; Tue, 29 Jun 2021 07:52:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyCHg-0003bW-4d for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 07:52:08 -0400 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]:46867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyCHc-0006av-0d for bug-gnu-emacs@gnu.org; Tue, 29 Jun 2021 07:52:07 -0400 Received: by mail-oi1-x22e.google.com with SMTP id a133so23729433oib.13 for ; Tue, 29 Jun 2021 04:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jimeh.me; s=google; h=mime-version:from:date:message-id:subject:to; bh=2rCQZFun2d8CHc14wGLQ4X0gQGKgbbkDz9W9+iOcXcs=; b=OTt9vmtYN3pmJBBeSh6EN6KII5bZ5gmBR5StCZKxhVx+Ta8N3WbExLW4k2vlh2Z1jW FoEyxI60gprr9Zmrur6bbjzpz9YDmDS2DXVByLQnq9meaAZUbpGeubS5E4/oYf2gxzpw iob++r1POoVN+tvdBBe6yR0ejvrwJFVTfHHniq7iU8yUz30uFQ5zRU4MOktE55pZSICA 4e6wVp0LcCCgqte0bguguwVbzqYDWOOfsmNhPrYRAol1V/aNT82XKFSo3bC+Y1GMpsGR ws6XXy/uoFdOBjLSlum4bBjGFUwB1QQKF83sXPLUKoq9rtNKDh4AX1nPx3cVjX+oiryN d3Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2rCQZFun2d8CHc14wGLQ4X0gQGKgbbkDz9W9+iOcXcs=; b=FNFd9uWCUopCMytg14fuQKRXn9TRS/WgNMkOjciPXOh6qg+hZf4HWir5AIovW+DAVh IKdJt39LyLER+KG/qVz7TkMaQaSCwtldBnA4fCBtXqEoXYcSXl8tHZaGDUuAeSsPOfy9 Gs/bA3h7yrQWUwmimhTZus3Fx7RVxHiKixxrAZbO57TfMpY8L4J39ZyMtik43Xa6MA+N q1Lt/N4pPJSAxInqUUbey5Hy5vTbbw/D3VM+jWpHnWJ213vxyGH2QVPeQeT+myP8xtQY GtsM8LrKUvqACv2BHGMR2pxhEP0Y7yQZ+GARyHYEIg1iKvmwQIXXoViK7co5y+LHm/NB ZX3w== X-Gm-Message-State: AOAM532TXShRF5Lm7pBYwtYUW1K5Nklo89jV/fnM7/hjYt+tXecvOxrp yC5jkn/z4un5ntajROkZaU3ZPIl8dCvl8iu3yFo1L0RoXvwnub/h/I8= X-Google-Smtp-Source: ABdhPJxc2dF0UlqbM5Sv94A4D572P3YfQ+zrP2Jhm75C8JK6V6dvHS7FnPwwjm7RRC8Z9sB4jw1NSpGN0mKfYIoCOsg= X-Received: by 2002:aca:5743:: with SMTP id l64mr7221529oib.100.1624967519063; Tue, 29 Jun 2021 04:51:59 -0700 (PDT) MIME-Version: 1.0 From: Jim Myhrberg Date: Tue, 29 Jun 2021 12:51:48 +0100 Message-ID: Subject: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::22e; envelope-from=contact@jimeh.me; helo=mail-oi1-x22e.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_05=-0.5, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When performing a self-contained Emacs.app build, *.eln files for Emacs' built-in lisp files stored within the Emacs.app bundle are not used. I believe commit 5dd2d50 which moved *.eln files and various paths around a bit for macOS builds, has re-introduced an old bug from last year. Basically the checksums that makes up part of the *.eln file names uses the absolute path of the .el file in question, but for self contained .app builds it needs to just use the relative path to the app itself. In short, any *.el files which contain ".app/Contents/" within their absolute file path, need to have anything before ".app/Contents/" removed before the *.eln filename checksum is calculated. Potentially some extra logic might be needed for build-time native-comp, as the checksums in the *.eln files bundled into the app right now are not based on the final location of lisp files within the .app bundle. In my testing, of the two checksums which are part of all *.eln filenames, the first checksum is different in the newly async generated *.eln files compared to those within the application bundle. The second checksum is identical. Also moving Emacs.app to different locations on the file system will cause it to re-compile *.eln files again, with the first checksum changing again. For the sake of any doubt, this issue occurs both with and without NATIVE_FULL_AOT=1. I've seen this behavior with all builds from the master branch that I've done since the 27th of June. Hopefully I've provided enough information here, please don't hesitate to ask if anything more is needed. P.S. I'm pretty new to emacs bug reporting, so apologies if I'm doing something wrong, and please let me know if so, and what I should be doing instead :) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 29 08:25:48 2021 Received: (at 49270) by debbugs.gnu.org; 29 Jun 2021 12:25:48 +0000 Received: from localhost ([127.0.0.1]:53812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyCoG-0003ou-CF for submit@debbugs.gnu.org; Tue, 29 Jun 2021 08:25:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyCoE-0003oi-NU for 49270@debbugs.gnu.org; Tue, 29 Jun 2021 08:25:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52406) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyCo7-0006bK-IU; Tue, 29 Jun 2021 08:25:41 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2634 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyCo7-0007QP-5h; Tue, 29 Jun 2021 08:25:39 -0400 Date: Tue, 29 Jun 2021 15:25:41 +0300 Message-Id: <83im1woo1m.fsf@gnu.org> From: Eli Zaretskii To: Jim Myhrberg In-Reply-To: (message from Jim Myhrberg on Tue, 29 Jun 2021 12:51:48 +0100) Subject: Re: bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49270 Cc: 49270@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Myhrberg > Date: Tue, 29 Jun 2021 12:51:48 +0100 > > When performing a self-contained Emacs.app build, *.eln files for > Emacs' built-in lisp files stored within the Emacs.app bundle are not > used. Thanks, but how do you see that? From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 29 09:07:28 2021 Received: (at 49270) by debbugs.gnu.org; 29 Jun 2021 13:07:29 +0000 Received: from localhost ([127.0.0.1]:53833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyDSa-0004nc-Kd for submit@debbugs.gnu.org; Tue, 29 Jun 2021 09:07:28 -0400 Received: from mail-oi1-f177.google.com ([209.85.167.177]:41877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyDSX-0004nM-OQ for 49270@debbugs.gnu.org; Tue, 29 Jun 2021 09:07:27 -0400 Received: by mail-oi1-f177.google.com with SMTP id t80so4712169oie.8 for <49270@debbugs.gnu.org>; Tue, 29 Jun 2021 06:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jimeh.me; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UA322MYndzruPHUDPHqDVb625jRIPEgd0kYqYwEGjsc=; b=PVqHFLJozVkuY+LI406ZIkKob2JfNwGQDnCW4x6TdvVcJtZzeBL1lQMTUivM8rHIAh 6lMtfwlskLHDp5hgSLvnE3FnhpnRCenoBHnpUWDpmqxKKbboGPtxyX39SK+M8sijdRi5 QHwo8TlguYb7yUxiUHmM3f4xcIMfVvFZK5HMWLfgXYg2dCdcG644hZCZTM5SjQlfn9AC fc1SGBB4P+UgiOBpmn8Ybsv8l8zbh3ip6jJzG3i6Nuc6Qf9Bsi80aNaALpgo4YguKTd4 y6SHIeq2XSkorBVI9DZo4f84y/LDG+izrkjLGWxxcoefCh04hZKokACFPU75RHFSIyjJ y0Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UA322MYndzruPHUDPHqDVb625jRIPEgd0kYqYwEGjsc=; b=nlyuXH5BP1UZZGbD2gqfChk0sluPgUjmpmnI4QumtM53seU8rUtfvQVtRe0i6ork+M hs8bkF0jmURVQn+Q+kom8Fy0GY29QiVu7grduxWCi1JW+Ttf5Qpf//aLyH4yi/zllXUa A9/24AIqgEcn6fnpMrYAxF7hOE4zIbD/RMkSKeIgLbIWgjizU5+3YsVK8js7Jx1uBbaL +OI953PdsyXYSIzNxK9DcElOC7uuMxDInqrWbVSnTRbTdLSWWTPLDIZQPUOA+hjixoeH VcEYPwKpJ/eXKHiHs14MRaA/PFeR7ND0w4TONXBVbVtP8AHWtre4PEVFqARU7X1JmCc8 QyHQ== X-Gm-Message-State: AOAM530HfAf6/0ip1s5Q17DO9y5fhtH4ijPW4C0QNd4ATLsyfmat4MAy uQx2P5NCZ/rESrAzmr/oAmbt6U0OuNA9ptBiE7nvUg== X-Google-Smtp-Source: ABdhPJxhehFXIFCjzjQ1OrEKu8Vorn0efZsC+G2N13VZqNCWH3lnBNqMiOXgxeMFlEyhWKJbVgKG0em+naXtdxMm9do= X-Received: by 2002:aca:4d05:: with SMTP id a5mr14278188oib.163.1624972040087; Tue, 29 Jun 2021 06:07:20 -0700 (PDT) MIME-Version: 1.0 References: <83im1woo1m.fsf@gnu.org> In-Reply-To: <83im1woo1m.fsf@gnu.org> From: Jim Myhrberg Date: Tue, 29 Jun 2021 14:07:08 +0100 Message-ID: Subject: Re: bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49270 Cc: 49270@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jun 29, 2021 at 1:25 PM Eli Zaretskii wrote: > > > From: Jim Myhrberg > > Date: Tue, 29 Jun 2021 12:51:48 +0100 > > > > When performing a self-contained Emacs.app build, *.eln files for > > Emacs' built-in lisp files stored within the Emacs.app bundle are not > > used. > > Thanks, but how do you see that? For better or worse, in a rather unsophisticated way; by launching Emacs.app and seeing the async native-comp kick off for all of Emacs' built-in lisp files. And by doing some additional experiments with *.eln files just now. The Emacs.app bundle I built earlier today includes "bytecomp-12882072-3f2b96ca.eln" in "Emacs.app/Contents/MacOS/lib/emacs/28.0.50/native-lisp", but when launching Emacs.app it performs async native-comp on bytecomp.el, and produced "bytecomp-a3d51747-3f2b96ca.eln" in my user eln cache folder. If I just relaunch Emacs again it does not re-compile bytecomp.el. If I move the newly created "bytecomp-a3d51747-3f2b96ca.eln" from my user eln cache folder into the Emacs.app bundle next to the original bytecomp-*.eln, and launch Emacs.app, it also does not re-compile bytecomp.el. However, if I then move Emacs.app itself (from /Users/jimeh/Downloads to /Users/jimeh/Desktop in this case), it will re-compile bytecomp.el again on launch, producing "bytecomp-30860bee-3f2b96ca.eln" in my user eln cache folder. At the end I have three separate bytecomp-*.eln files: - "bytecomp-12882072-3f2b96ca.eln" - produced at Emacs build time and bundled into the app - "bytecomp-a3d51747-3f2b96ca.eln" - produced via async native-comp at launch of Emacs.app while it was located in "/Users/jimeh/Downloads/", with absolute path to bytecomp.el.gz being "/Users/jimeh/Downloads/Emacs.app/Contents/Resources/lisp/emacs-lisp/bytecomp.el.gz" - "bytecomp-30860bee-3f2b96ca.eln" - produced via async native-comp at launch of Emacs.app while it was located in "/Users/jimeh/Desktop/", with absolute path to bytecomp.el.gz being "/Users/jimeh/Desktop/Emacs.app/Contents/Resources/lisp/emacs-lisp/bytecomp.el.gz" And this is why I believe the first checksum within *.eln file names is based on the absolute path even when the source .el/.el.gz files are located within a .app bundle. Also, I forgot mention earlier, but the previous bug for this issue from last year is bug#43532, potentially that might give some additional context. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 29 14:12:06 2021 Received: (at 49270) by debbugs.gnu.org; 29 Jun 2021 18:12:06 +0000 Received: from localhost ([127.0.0.1]:55278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyIDO-00045b-EQ for submit@debbugs.gnu.org; Tue, 29 Jun 2021 14:12:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyIDN-000456-7Y for 49270@debbugs.gnu.org; Tue, 29 Jun 2021 14:12:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37552) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyIDH-0007IB-Nc; Tue, 29 Jun 2021 14:11:59 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4155 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyIDH-0008SG-80; Tue, 29 Jun 2021 14:11:59 -0400 Date: Tue, 29 Jun 2021 21:11:58 +0300 Message-Id: <837dico80h.fsf@gnu.org> From: Eli Zaretskii To: Jim Myhrberg In-Reply-To: (message from Jim Myhrberg on Tue, 29 Jun 2021 12:51:48 +0100) Subject: Re: bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49270 Cc: 49270@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Myhrberg > Date: Tue, 29 Jun 2021 12:51:48 +0100 > > When performing a self-contained Emacs.app build, *.eln files for > Emacs' built-in lisp files stored within the Emacs.app bundle are not > used. > > I believe commit 5dd2d50 which moved *.eln files and various paths > around a bit for macOS builds, has re-introduced an old bug from last > year. Basically the checksums that makes up part of the *.eln file > names uses the absolute path of the .el file in question, but for self > contained .app builds it needs to just use the relative path to the > app itself. That's not (exactly) how this stuff is supposed to work, AFAIR, not after the recent changes. Please look at the code and the comments in comp.c:comp-el-to-eln-rel-filename, and tell if you understand why this isn't working for you. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 29 17:06:59 2021 Received: (at 49270) by debbugs.gnu.org; 29 Jun 2021 21:07:00 +0000 Received: from localhost ([127.0.0.1]:55769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyKwd-0002HO-Kn for submit@debbugs.gnu.org; Tue, 29 Jun 2021 17:06:59 -0400 Received: from outbound.soverin.net ([116.202.126.228]:38677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyKwY-0002H5-VF for 49270@debbugs.gnu.org; Tue, 29 Jun 2021 17:06:59 -0400 Received: from smtp.soverin.net (unknown [10.10.3.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 87D21940; Tue, 29 Jun 2021 21:06:48 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.138]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1625000808; bh=W4fl6QkkGSL4qDcIeYRE7GU82TSWHRErBUTorp3OGaY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kbm3AKEmGv8AQ7u/qF4UdYJQxMxKlHc+UadZjjZrj496Br4h3bht1JP3A8Aq2XzwU 8TF7mZ4uwhyspiazPy0ZBrEWvs6cbp7WGbUN1zKwPRDOTD5+AqqRWng1GwvU57zGx4 1iRgJd3Es6AI6z3y1Y7epyIX8QXCapQpJK92HGTf9CDDdEU9qo6jpKixyvvkdpyooi Qui5WN3UnPbRhpD8wSIHAC7BLg7t1dpwhr+WtcIOZXc6PE5gIpaI0MGc2POrEN+7Mm MyRy1du5cERRKf43/XuhQtMUF0iR9WDsh+G7yiMUXxGLdiDcIH9YW7SX5Ts9BhrNpC B08aXrag82BCA== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id F24F7202CCEEA1; Tue, 29 Jun 2021 22:06:43 +0100 (BST) Date: Tue, 29 Jun 2021 22:06:43 +0100 From: Alan Third To: Jim Myhrberg Subject: Re: bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files Message-ID: Mail-Followup-To: Alan Third , Jim Myhrberg , 49270@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="V3I3HI0zC00u6XFs" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49270 Cc: 49270@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --V3I3HI0zC00u6XFs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 29, 2021 at 12:51:48PM +0100, Jim Myhrberg wrote: > When performing a self-contained Emacs.app build, *.eln files for > Emacs' built-in lisp files stored within the Emacs.app bundle are not > used. > > I believe commit 5dd2d50 which moved *.eln files and various paths > around a bit for macOS builds, has re-introduced an old bug from last > year. Basically the checksums that makes up part of the *.eln file > names uses the absolute path of the .el file in question, but for self > contained .app builds it needs to just use the relative path to the > app itself. I don't think this is the same bug (although I guess it has the same symptoms). Please try the attached patch, it fixes it here. -- Alan Third --V3I3HI0zC00u6XFs Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Fix-NS-native-comp-search-path-bug-49270.patch" >From 0517874eb4bce2cbbcdf58516c43d50b0174c0ec Mon Sep 17 00:00:00 2001 From: Alan Third Date: Tue, 29 Jun 2021 22:02:43 +0100 Subject: [PATCH] Fix NS native comp search path (bug#49270) * configure.ac (NS_SELF_CONTAINED): We need to make lispdirrel the same as lispdir when building a self contained app bundle as they're both relative paths. --- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index c8920d877e..6e2cda947a 100644 --- a/configure.ac +++ b/configure.ac @@ -2025,6 +2025,7 @@ AC_DEFUN infodir="\${ns_appresdir}/info" mandir="\${ns_appresdir}/man" lispdir="\${ns_appresdir}/lisp" + lispdirrel="\${ns_appresdir}/lisp" test "$locallisppathset" = no && locallisppath="\${ns_appresdir}/site-lisp" INSTALL_ARCH_INDEP_EXTRA= fi -- 2.29.2 --V3I3HI0zC00u6XFs-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 30 05:32:28 2021 Received: (at 49270) by debbugs.gnu.org; 30 Jun 2021 09:32:28 +0000 Received: from localhost ([127.0.0.1]:56446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyWa4-000838-1B for submit@debbugs.gnu.org; Wed, 30 Jun 2021 05:32:28 -0400 Received: from mail-oi1-f180.google.com ([209.85.167.180]:43945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyWa2-00082u-De for 49270@debbugs.gnu.org; Wed, 30 Jun 2021 05:32:26 -0400 Received: by mail-oi1-f180.google.com with SMTP id 22so2301941oix.10 for <49270@debbugs.gnu.org>; Wed, 30 Jun 2021 02:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jimeh.me; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Uk2MRmNO6JY8/Xpk5DygKHKMAFDep9W/Mlp9yTTGwyU=; b=UpGLEp50hShI2giMBPbz7CgrxE9BofmoO6I+32JPd6B22Svs43XB4h/DgcXwIevT7Y sV32ndHAN96H5VfnN7FYSsebDxBLzpKw3TkItGZs1gMLPPK91xnYjDMACCvSG4ayI4Hi xDyDgC2CjDCaJCdwQe7/LmkY0+kobvpTlQky8ro8NdyBs2Z015uHrvML12DOmKBt3XO0 M7q8kQozq/JBCevpZTxuxRbmuVLSg348Du/hVMaI8zJLqEQJ41a0EUmelV4YKm0YN1+8 Sp1K8At+4ISOqcjFf2tkXzc1vk5T+d+5mZcfWUqNc9nZsE7BY5XZOlhC1FiYa/6iU/ua Ux1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Uk2MRmNO6JY8/Xpk5DygKHKMAFDep9W/Mlp9yTTGwyU=; b=GNatG/1/0ls9WyIOCm2b81qP7iQ/mwsrzGj1E8tRgq7hmIl/CF6RGqzFH3oNz/Lsfm vXuzRVc6xXs1kmZVNAosLg2K1jGvjTJA3/Ki8n0oRxRc1fwDb+vYK8hDZwT/SbKzx6HJ CGBJIB46oCnru9rzxum1Ubu0kOoDfTWBOBkz8Vcp4OgvtMMZANYgxFIvz+0NM9o71yxr 5LBYjPvmKlkvVFr9o8PA2KTWZo+UbRe+4qUMWy8EaZKjkJxx0FelT6kvVcr+SiIm9HMk SJBbkJZn+pMTf7Dy2ps/Oo2aOLB9fJJ93xWZ68UiE5SQqYFA4SK4CrNzsZmkPh1o18iF bBIw== X-Gm-Message-State: AOAM531y6ecu+SKOwnlTBuG5m61MAekmOoSjxfVx+D3csM6TXaC2+Zmh sdr3NgUktusWOWhtbO/RNqBOV17ikgK5FB68yZRfs7nOT8+8Eavl X-Google-Smtp-Source: ABdhPJyItdvfBkzxV1+2GovzUq4dzJNLBx6B4GdX4ng3IEcY8XwSUtdXgnro0474q46a2+D36H/E3qB6/+p5P5vSKI8= X-Received: by 2002:aca:1809:: with SMTP id h9mr2393759oih.4.1625045540534; Wed, 30 Jun 2021 02:32:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jim Myhrberg Date: Wed, 30 Jun 2021 10:32:09 +0100 Message-ID: Subject: Re: bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files To: Alan Third , Jim Myhrberg , 49270@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49270 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, Jun 29, 2021 at 10:06 PM Alan Third wrote: > Please try the attached patch, it fixes it here. Awesome, thanks. I've just tested the patch and can confirm it fixes the issue on my end too. All *.eln files in the .app bundle are now located correctly, even when moving the app around the filesystem :) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 01 17:17:06 2021 Received: (at 49270-done) by debbugs.gnu.org; 1 Jul 2021 21:17:06 +0000 Received: from localhost ([127.0.0.1]:33779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz43W-00062Z-0d for submit@debbugs.gnu.org; Thu, 01 Jul 2021 17:17:06 -0400 Received: from outbound.soverin.net ([116.202.126.228]:57777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz43U-00061a-AL for 49270-done@debbugs.gnu.org; Thu, 01 Jul 2021 17:17:04 -0400 Received: from smtp.soverin.net (unknown [10.10.3.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by outbound.soverin.net (Postfix) with ESMTPS id 0020C8D5; Thu, 1 Jul 2021 21:16:59 +0000 (UTC) Received: from smtp.soverin.net (smtp.soverin.net [159.69.232.142]) by soverin.net DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=idiocy.org; s=soverin; t=1625174218; bh=hO+/JlEeI9+EqCmGk/+7u23NUwmtETcITrPB9sRetio=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gYv3HZbc9QLgSr2T5iyQn7PinAc/9mBybJsjSvu6AImfKs3EpIt1LigcPlMphsrXm /+tPhpWvA9vAVnm9dCusrDneI4PZusoAIyJC2/Vmx7N3yqX+fHLEPV4hX8gAPLwuok Taq2oPxyJynKmomGoCMjalPFsb7R0HH2/HrdJYNgZiqyV+KGJTstFtFhNBvP0AmvoE u+0RxLGrXoPNe/5D6pbeo5hbTtXH+zFJV+NFJa5oSVB7yWznf73nLgM3gtM1qlm89z gxP83o4/wLE1IsTJ2zoQ9RFM3aVbrvQvaaIlKZk7qZ2Z0Fle0RtOkOp2pzdGJNkjAm 8Uwuv+sck18hg== Received: by breton.holly.idiocy.org (Postfix, from userid 501) id A5441202CE03A6; Thu, 1 Jul 2021 22:16:56 +0100 (BST) Date: Thu, 1 Jul 2021 22:16:56 +0100 From: Alan Third To: Jim Myhrberg Subject: Re: bug#49270: 28.0.50: native-comp: macOS self-contained .app does not use bundled *.eln files Message-ID: Mail-Followup-To: Alan Third , Jim Myhrberg , 49270-done@debbugs.gnu.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49270-done Cc: 49270-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Jun 30, 2021 at 10:32:09AM +0100, Jim Myhrberg wrote: > On Tue, Jun 29, 2021 at 10:06 PM Alan Third wrote: > > Please try the attached patch, it fixes it here. > > Awesome, thanks. I've just tested the patch and can confirm it fixes > the issue on my end too. All *.eln files in the .app bundle are now > located correctly, even when moving the app around the filesystem :) Pushed to master. -- Alan Third From unknown Sun Jun 22 07:42:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 30 Jul 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator