From gg@zip.com.au Sat Nov 14 13:44:49 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Nov 2009 21:44:49 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.8 required=4.0 tests=AWL,FOURLA,FVGT_m_MULTI_ODD autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAELilsl008191 for ; Sat, 14 Nov 2009 13:44:49 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N9QQJ-0006p5-7p for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N9QQC-0006j4-Rd for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:45 -0500 Received: from [199.232.76.173] (port=48358 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N9QQC-0006ii-LY for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:40 -0500 Received: from mailout2-5.pacific.net.au ([61.8.2.228]:40389 helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N9QQB-00022M-OM for bug-gnu-emacs@gnu.org; Sat, 14 Nov 2009 16:44:40 -0500 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout2.pacific.net.au (Postfix) with ESMTP id 8EB3B1937B9 for ; Sun, 15 Nov 2009 08:44:30 +1100 (EST) Received: from blah.blah (ppp20E0.dyn.pacific.net.au [61.8.32.224]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id CDE242740A for ; Sun, 15 Nov 2009 08:44:29 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1N9QQ0-0001Ee-QL for bug-gnu-emacs@gnu.org; Sun, 15 Nov 2009 08:44:28 +1100 From: Kevin Ryde To: bug-gnu-emacs@gnu.org Subject: 23.1; checkdoc-proper-noun-regexp with regexp-opt Date: Sun, 15 Nov 2009 08:44:28 +1100 Message-ID: <87lji8zsqr.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= This is the simplification I mentioned before for the way checkdoc-proper-noun-regexp is built. You'd be tempted to build the regexp within checkdoc-proper-noun-region-engine (maybe just with mapconcat) for easier customizing of checkdoc-proper-noun-list, but I suppose nobody changes it. 2009-11-13 Kevin Ryde * emacs-lisp/checkdoc.el (checkdoc-proper-noun-regexp): Build value with regexp-opt instead of explicit joining loop. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=checkdoc.el.regexp-opt.diff --- checkdoc.el.~1.80.~ 2009-11-09 08:46:10.000000000 +1100 +++ checkdoc.el 2009-11-09 09:33:33.000000000 +1100 @@ -334,12 +334,9 @@ ;; "[.!?]" is for noun at end of a sentence, since those chars ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>. ;; The \" allows it to be the last sentence in a docstring too. - (let ((expr "\\_<\\(") - (l checkdoc-proper-noun-list)) - (while l - (setq expr (concat expr (car l) (if (cdr l) "\\|" "")) - l (cdr l))) - (concat expr "\\)\\(\\_>\\|[.!?][ \t\n\"]\\)")) + (concat "\\_<" + (regexp-opt checkdoc-proper-noun-list t) + "\\(\\_>\\|[.!?][ \t\n\"]\\)") "Regular expression derived from `checkdoc-proper-noun-regexp'.") (defvar checkdoc-common-verbs-regexp nil --=-=-= In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5) of 2009-09-14 on raven, modified by Debian configured using `configure '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_AU value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default-enable-multibyte-characters: t --=-=-=-- From rgm@gnu.org Mon Nov 16 11:39:41 2009 Received: (at control) by emacsbugs.donarmstrong.com; 16 Nov 2009 19:39:41 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.3 required=4.0 tests=AWL,ONEWORD,VALID_BTS_CONTROL, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAGI2FuN002916 for ; Mon, 16 Nov 2009 10:02:16 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NA5u1-0004AG-LB; Mon, 16 Nov 2009 13:02:13 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19201.37797.524753.543418@fencepost.gnu.org> Date: Mon, 16 Nov 2009 13:02:13 -0500 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: black X-Ran: k^eR=<\"G;m%*rkJ3R8gB\=1A!RK|h; Mon, 16 Nov 2009 20:42:12 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1NAFtJ-0006Zc-B0; Mon, 16 Nov 2009 23:42:09 -0500 From: Glenn Morris To: Kevin Ryde Cc: 4927@debbugs.gnu.org Subject: Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regexp-opt References: <87lji8zsqr.fsf@blah.blah> X-Spook: ARPA analyzer ammunition Becker Zachawi 22nd SAS X-Ran: Ym~qoxwu|5%)#:d>{%9v!t(Aj;t5+\Z/(Q*I9#*Fxc&fG!>XBdRUM-{L5e*JnRZR5HFSWJ X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 16 Nov 2009 23:42:09 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Kevin Ryde wrote: > This is the simplification I mentioned before for the way > checkdoc-proper-noun-regexp is built. I think you should feel free to just install this kind of thing, without needing to create a bug report. From gg@zip.com.au Tue Nov 24 15:13:57 2009 Received: (at 4927-done) by emacsbugs.donarmstrong.com; 24 Nov 2009 23:13:58 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mailout1.pacific.net.au (mailout1-1.pacific.net.au [61.8.2.208]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nAONDujL002443 for <4927-done@emacsbugs.donarmstrong.com>; Tue, 24 Nov 2009 15:13:57 -0800 Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.2.163]) by mailout1.pacific.net.au (Postfix) with ESMTP id B29D1510DF2 for <4927-done@emacsbugs.donarmstrong.com>; Wed, 25 Nov 2009 10:13:55 +1100 (EST) Received: from blah.blah (ppp291C.dyn.pacific.net.au [61.8.41.28]) by mailproxy2.pacific.net.au (Postfix) with ESMTP id 448962741D for <4927-done@emacsbugs.donarmstrong.com>; Wed, 25 Nov 2009 10:13:55 +1100 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1ND4Zr-0000vq-Ok for 4927-done@emacsbugs.donarmstrong.com; Wed, 25 Nov 2009 10:13:43 +1100 From: Kevin Ryde To: 4927-done@debbugs.gnu.org Subject: Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regexp-opt References: <87lji8zsqr.fsf@blah.blah> Date: Wed, 25 Nov 2009 10:13:43 +1100 In-Reply-To: (Glenn Morris's message of "Mon, 16 Nov 2009 23:42:09 -0500") Message-ID: <87zl6b349k.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Glenn Morris writes: > > I think you should feel free to just install this kind of thing, > without needing to create a bug report. Done. From unknown Mon Aug 18 11:05:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 23 Dec 2009 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A long time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator