From unknown Sat Aug 09 04:55:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49248 <49248@debbugs.gnu.org> To: bug#49248 <49248@debbugs.gnu.org> Subject: Status: 28.0.50; read-from-minibuffer returns a window-live-p error when its original window is deleted Reply-To: bug#49248 <49248@debbugs.gnu.org> Date: Sat, 09 Aug 2025 11:55:08 +0000 retitle 49248 28.0.50; read-from-minibuffer returns a window-live-p error w= hen its original window is deleted reassign 49248 emacs submitter 49248 Thierry Volpiatto severity 49248 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 28 02:52:29 2021 Received: (at submit) by debbugs.gnu.org; 28 Jun 2021 06:52:29 +0000 Received: from localhost ([127.0.0.1]:50774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxl88-00017r-LR for submit@debbugs.gnu.org; Mon, 28 Jun 2021 02:52:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:56416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxl86-00017i-6d for submit@debbugs.gnu.org; Mon, 28 Jun 2021 02:52:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxl85-0004dJ-Ju for bug-gnu-emacs@gnu.org; Mon, 28 Jun 2021 02:52:25 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxl81-0006DA-5y for bug-gnu-emacs@gnu.org; Mon, 28 Jun 2021 02:52:25 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 85C29240102 for ; Mon, 28 Jun 2021 08:52:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1624863135; bh=m4d30FoNLEUdqfFXMlmrSX7Uu71oMLelWHSZYWbdhyg=; h=From:To:Subject:Date:From; b=mI/6XbgdmCaKCQCiemIvtgoqw5Kf7DnWfBUUW67r9K+P+zVbAAqLMztI4pd17dPWM bPS3Y20Xulekm3yW28tnWloDckJXprJPH2Jo48SQVtIpCfBV5a0gxGE3qstdB3KaeJ O7KfzXd1n/qBfkRXDRdBc0wN72HO24VSVDBrZHsduu4u3ICLNJ/kBFdhbvMotl7FPB U2BwbyGEcerxqnFbWsuRw4LhxL8YHMqJwKEmNHdnQxhS75EKoJUPdhc4IGxml0uTJQ TcUIYHiKb8FW1hyHjonDcI7soz6rbPk2byT5QRh4PDU3DXlEhHUM7rgkd0UWCDyx5o H/HprmRdprjiQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GCyvy0Vndz9rxD for ; Mon, 28 Jun 2021 08:52:13 +0200 (CEST) From: Thierry Volpiatto To: bug-gnu-emacs@gnu.org Subject: 28.0.50; read-from-minibuffer returns a window-live-p error when its original window is deleted Date: Mon, 28 Jun 2021 06:32:27 +0000 Message-ID: <8735t2h46e.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=thievol@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello, I have a bug report https://github.com/emacs-helm/helm/issues/2424 where it seems a minibuffer not belong anymore to its window when this one is deleted. Here is what's happening: I have a function that change the place of the window where originally read-from-minibuffer was called, the window goes right, left, up and down at each call of this function, but once we press RET to exit the read-from-minibuffer an error is raised: Wrong type argument: window-live-p, # (See backtrace in the link to helm issue mentionned above) The error seems to come from read-from-minibuffer. This always worked since emacs-24 to emacs-27.2. Here is the function: https://github.com/emacs-helm/helm/blob/master/helm.el#L6596 I wonder if this is a bug or an incompatible change in emacs-28, if so what are the new directives in such case. Thanks. In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2021-06-27 built on IPadS340 Repository revision: b8f9e58ef72402e69a1f0960816184d52e5d2d29 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux Mint 19.3 Configured using: 'configure CFLAGS=-O8 --with-mailutils --with-cairo --with-native-compilation' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Elisp Minor modes in effect: bug-reference-prog-mode: t global-undo-tree-mode: t undo-tree-mode: t global-ligature-mode: t ligature-mode: t psession-mode: t psession-savehist-mode: t global-git-gutter-mode: t git-gutter-mode: t display-time-mode: t winner-mode: t show-paren-mode: t helm-epa-mode: t helm-descbinds-mode: t override-global-mode: t helm-adaptive-mode: t helm-mode: t shell-dirtrack-mode: t helm-popup-tip-mode: t async-bytecomp-package-mode: t dired-async-mode: t minibuffer-depth-indicate-mode: t straight-use-package-mode: t straight-package-neutering-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/thierry/.emacs.d/straight/build/transient/transient hides /usr/local/share/emacs/28.0.50/lisp/transient Features: (epa-mail face-remap mu4e-thread-folding addressbook-bookmark mu4e-config org-mu4e mu4e-contrib mu4e-patch mu4e mu4e-org mu4e-main mu4e-view mu4e-view-gnus gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win gnus nnheader mu4e-view-common mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions ido rfc2368 smtpmail mu4e-mark mu4e-proc mu4e-utils doc-view jka-compr image-mode exif mu4e-lists mu4e-message shr kinsoku svg dom flow-fill hl-line mu4e-vars mu4e-meta shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 mm-util mail-prsvr mail-utils helm-command image-file image-converter cl-print help-fns smerge-mode view helm-dabbrev tramp-archive tramp-gvfs tramp-cache zeroconf dbus helm-x-files helm-for-files helm-bookmark bookmark conf-mode ledger-config ledger-mode ledger-check ledger-texi ledger-test ledger-sort ledger-report ledger-reconcile ledger-occur ledger-fonts ledger-fontify ledger-state ledger-complete ledger-schedule ledger-init ledger-xact ledger-post ledger-exec ledger-navigate eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util ledger-context ledger-commodities ledger-regex bug-reference naquadah-theme solar cal-dst holidays hol-loaddefs tv-utils undo-tree diff undo-tree-autoloads ligature ligature-autoloads rainbow-mode-autoloads psession frameset wgrep-helm wgrep grep compile text-property-search wgrep-autoloads log-view pcvs-util pcmpl-git pcmpl-git-autoloads toc-org-autoloads cl-indent ffap markdown-toc-autoloads markdown-mode-autoloads autocrypt ietf-drums config-w3m w3m-autoloads git-gutter git-gutter-autoloads mule-util appt diary-lib diary-loaddefs gud anaconda-mode xref project pythonic f dash s anaconda-mode-autoloads pythonic-autoloads f-autoloads s-autoloads emamux-autoloads magit-autoloads magit-section-autoloads git-commit-autoloads with-editor-autoloads transient-autoloads dash-autoloads pcomplete-extension pcmpl-unix pcmpl-gnu iterator iedit-autoloads ledger-mode-autoloads wdired dired-extension org-config ob-gnuplot org-crypt net-utils time all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons all-the-icons-autoloads winner w3m-wget wget wget-sysdep autotest-mode autoconf-mode paren woman man ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util init-helm helm-fd epa derived epg epg-config helm-epa helm-misc helm-imenu imenu helm-elisp-package package url-handlers helm-find helm-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat advice org-macs org-loaddefs cal-menu calendar cal-loaddefs helm-external helm-net browse-url xml url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap isearch-light helm-descbinds cus-edit pp wid-edit helm-ls-git vc-git diff-mode vc vc-dispatcher helm-ipython helm-elisp helm-eval edebug backtrace find-func helm-info python tramp-sh use-package-bind-key bind-key popup helm-adaptive diminish helm-mode helm-files filenotify tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete comint ansi-color ring parse-time iso8601 time-date ls-lisp auth-source password-cache json map helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types use-package-diminish helm-extensions-autoloads helm-config helm-autoloads helm async-bytecomp helm-global-bindings helm-easymenu helm-source eieio eieio-core eieio-loaddefs helm-multi-match helm-lib dired-async dired-aux dired dired-loaddefs async emms-autoloads finder-inf use-package-core popup-autoloads diminish-autoloads mb-depth server edmacro kmacro avoid cus-load use-package-autoloads bind-key-autoloads straight-autoloads straight comp comp-cstr warnings rx cl-extra info autoload radix-tree seq easy-mmode cl-seq pcase subr-x byte-opt checkdoc lisp-mnt thingatpt help-mode cl-macs gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 576183 177686) (symbols 48 39767 34) (strings 32 151520 65945) (string-bytes 1 5536163) (vectors 16 80431) (vector-slots 8 2008218 250049) (floats 8 1375 1061) (intervals 56 3800 2423) (buffers 992 76)) <#secure method=pgpmime mode=sign> -- Thierry From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 28 03:53:31 2021 Received: (at 49248) by debbugs.gnu.org; 28 Jun 2021 07:53:31 +0000 Received: from localhost ([127.0.0.1]:50877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxm5D-0002l2-Hq for submit@debbugs.gnu.org; Mon, 28 Jun 2021 03:53:31 -0400 Received: from mout.gmx.net ([212.227.17.22]:38769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxm5B-0002kq-VS for 49248@debbugs.gnu.org; Mon, 28 Jun 2021 03:53:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1624866803; bh=b/oOP8D2oB9FiF5VvNGOHKT7Q6iuQw0lw5BIGijDWBo=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=Mj1+sOvwESJqrb5uU5Xf4JccwWg2cNJQp37wHCbZyG1NpiffI8hAa4e4XBsjZhH7t DlCoytNWqL8SE9w/SDHa83wRl30au7simJQ/1hQ6URE19vK5RpB/wdNFkIvv/ccRJx xcFsOfb1scuDrZXXNw+Hp1qYYnVNo4jAjOCr3650= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.205]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MC34X-1m59Oo0Uub-00CSGk; Mon, 28 Jun 2021 09:53:23 +0200 Subject: Re: bug#49248: 28.0.50; read-from-minibuffer returns a window-live-p error when its original window is deleted To: Thierry Volpiatto , 49248@debbugs.gnu.org References: <8735t2h46e.fsf@posteo.net> From: martin rudalics Message-ID: Date: Mon, 28 Jun 2021 09:53:22 +0200 MIME-Version: 1.0 In-Reply-To: <8735t2h46e.fsf@posteo.net> Content-Type: multipart/mixed; boundary="------------AA5D2FDAA4FD7FC80E2CC353" Content-Language: en-US X-Provags-ID: V03:K1:IoUXV7MqM+45DJapg2lhqt6MZDDxCp0sgXqXYigdPN4bAo0GE/U qw84qQbPtmnH8Mf4Du7bskFQ967bZlKTZv/Yb8u/dtcOOfebTurZl/6mXWuNLMokxXypYXC 1oLLzFDqNpO9DiwiLAtNYS6fKU/JwqUSlAR4MIDQ7ACYm29E7PDXXZxdjZYqb97TWA4KL3d QPSQYQ+rcaZm+WkRW6oyg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:y+ZeCsC5+fs=:dIuc1hOX24orQD18H3nEyO SRLbRAVAIrypU0Oi3nA3iFwDxhrZDR0E+PCoPRfDy2q04sMm6TMTUCzVUqZAUIE3yzGwkhBQW oQvo5NeFlSv2vcVAXJ45dwyx6pO6S5QQLUWXF/Pl6053gg0M4WX2fKftE4C3mVfWIlwmUZMI1 qfif19IQZzXru3SIImaswbLiKLN1GEqya1IhMWytgYnQkU8ab9rw1qVDg1S8pA+zNad4ygyLx 5KI3EETRI6ua/YiSjUcPiV9NSw2NHGaz4RxeWAICEn9FzsVfyBq03ogQZ/IaqnkBzIRX90UnV mtzFgaYxR3w7XC47VWxPjuwGVJHAoj94MjhNYrcnyCzGaohJ5bIKMu0H9ZMpIr5rr4xUjKsLU a0kIUw4QRIDlRO32/3ceemzlRr9bOB7I1a5VhoBb9yGzGAYML+RlPkyzQtMsc0TtZNwMka7qc ++uT6GCsUiw3kGE0x2Iu+KwS3N5YPTseDu0CCL+3FAq63TA/pvKd8DZF9KmLT/QkdLFNAZr/R FTBccIqi63NN88+GZd3djU4dZaFJo9cLzKCu5JAug9O24R/5l2rnJOMi+U/GVZcF5s5xo3R63 JmSQdKwOI2riU+yYVFlElswP5DC45AlYcXDkp7Sg5Q0obIR6X8mhzypKzbM5iuda4+IkTGNL3 5yo58vVlKLQ6U5C0tvKCPjT0G7s0SXQgusr5Nk8VJmKNKy5+PxdNSKyhCRxiyZ0Q4hLFAx86N +sh+yKzmHpaXeJY05JideMuOhXUy9AZiBcvL0VWYL/YJUz/lG4OM2ERojN4g9GiC3/3XpI2Ri udKMzXpOGjP+bwkmTFDH132jcNQ+UP0wbSj7mowtdTFPV3r+IZ9KqpvCkpFtPCNdcWgpHLIr3 WfOq95QRaOj3Lot9Gw+1kwKCBlr8LrhsvTN4XFiTfi6jRy4tw7qCfvyEvd6mLV2nwNHRUFeiw leQxDrJ+WdecrK/KWyEzvn5+ZEomlxmx6JktItpGxx+aZt4FOA8NRWIicDLroKIXamDxjKs6J I1229mEx46JcCcEZ7Zm7WtX+P91zv1ZRNv5d6mPFnHTeEhwMgFxErhciHhT3yuaVXw0lAz1A7 6BPFn2toW4Dq2FvUIluL5AfvAj3qdj3E3AG X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49248 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------AA5D2FDAA4FD7FC80E2CC353 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > Wrong type argument: window-live-p, # > (See backtrace in the link to helm issue mentionned above) Can you try the attached. martin --------------AA5D2FDAA4FD7FC80E2CC353 Content-Type: text/x-patch; name="minibuf.c.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="minibuf.c.diff" diff --git a/src/minibuf.c b/src/minibuf.c index 00069eabbe..1b842b7721 100644 =2D-- a/src/minibuf.c +++ b/src/minibuf.c @@ -1210,7 +1210,7 @@ read_minibuf_unwind (void) WINDOW_FRAME (XWINDOW (minibuf_window)))) Fset_frame_selected_window (selected_frame, prev, Qnil); } - else + else if (WINDOW_LIVE_P (calling_window)) Fset_frame_selected_window (calling_frame, calling_window, Qnil); } --------------AA5D2FDAA4FD7FC80E2CC353-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 28 07:47:53 2021 Received: (at 49248) by debbugs.gnu.org; 28 Jun 2021 11:47:53 +0000 Received: from localhost ([127.0.0.1]:51183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxpk1-0004bg-6B for submit@debbugs.gnu.org; Mon, 28 Jun 2021 07:47:53 -0400 Received: from mout02.posteo.de ([185.67.36.66]:48199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxpjw-0004bN-FH for 49248@debbugs.gnu.org; Mon, 28 Jun 2021 07:47:51 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 9F4FD2400FD for <49248@debbugs.gnu.org>; Mon, 28 Jun 2021 13:47:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1624880861; bh=gqtvEb/ACIM+02GjOgHaEPGqe7Bu+5IPGFiSv8Gc9zk=; h=From:To:Cc:Subject:Date:From; b=bZeaZB1YtU1D8g6ZSKK+pSFO2mChfobQb2mOFkl8A+0I4HyYPl0wtSRe2Xw5kPl19 Y2bEnuho1TXWNme0CU7O3JwSf86y/BeJIUCsl77VYXvLnJt7N7R6HTOvUhKj3jaLhS 0rKENfHaw94PwcR07x/6sT3+0YhsvxOng4dTg/+lUFurHSiom8+KHWrG3lSEC9CTow /WI/J0nMcht7zLoONmpF4MWU8l3N8lvZFmxNStXhdmJATPg77T3Qgbgnjjm4qEI1j/ 4kZigPrR+Vp0/1az9oE7fuaZtw3/Dnm3VcSY06iNnOZqeg4sfWXPfO/aHzsiE+mNA0 fxY0ROZMZpn5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GD5Sr0NNSz6tmF; Mon, 28 Jun 2021 13:47:39 +0200 (CEST) References: <8735t2h46e.fsf@posteo.net> From: Thierry Volpiatto To: martin rudalics Subject: Re: bug#49248: 28.0.50; read-from-minibuffer returns a window-live-p error when its original window is deleted Date: Mon, 28 Jun 2021 11:47:22 +0000 In-reply-to: Message-ID: <875yxy5hye.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49248 Cc: 49248@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable martin rudalics writes: >> Wrong type argument: window-live-p, # >> (See backtrace in the link to helm issue mentionned above) > > Can you try the attached. Thanks Martin for quick answer and fix, yes it is now working. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmDZttkTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkxbEC/9vV/UpVec5VFHgLpiMAxfJOz56PmiA xVbqrcveAHdEFTAqIFl0CjonVdfvwLaf9zNIHxovHDcdAHDmVxFoJYsGos4PCMtq U1XhBGf2Y0sLk0KdAoXErNFfkhbf1url9ysozsXUFPsb6EXlfQqhkAVRdXGxM+S5 mNODGnwpENZtkWpi/Egdd6n8q5tXxI+A8bHLvPCKNR1hcID7gZuS/xy205/wlf1S cYFbsTT8cM3iEjgNeResc5E7PP4MVIklrCQuuThbx7fF5n5Ewk0qrmrRdIDsT0nu ZrQzNPeRTQtNELBS5WlYt5osqQfzFkfbLudKFXdJYPT22Ph9+rD86JTRsFqblQX+ tuSBscDr0eFo5YdA5ehmRulHk3W5QTiLsP+vcGbRBfiQI3L00iNEV0gB4Gj536+R UPLguT/xm7O8Lfc9k8PYb8Wykh16BhJpTwZXMZwDPNF9YhDhqvZl5IdpYSB8ZpYu KG+GvQbdFvjtJx3Lc3l99Ou6cBixWTmIApo= =xLU5 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 29 04:03:22 2021 Received: (at 49248) by debbugs.gnu.org; 29 Jun 2021 08:03:22 +0000 Received: from localhost ([127.0.0.1]:53556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ly8iI-0000zx-6s for submit@debbugs.gnu.org; Tue, 29 Jun 2021 04:03:22 -0400 Received: from mout.gmx.net ([212.227.15.15]:37353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ly8iF-0000zj-Tz for 49248@debbugs.gnu.org; Tue, 29 Jun 2021 04:03:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1624953793; bh=3O1mM+IqSZ2DHua0Q9RoNQZApaIWmNS4XVAdUjzp4Z0=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Nk/mrZlUEG+Ph138w2S/P6edNawx5NzNgiNpL7yET4CumbMhHVoMNc152bjLPPT/q DlnQhGrFWNPewA7oRxBZvQBvVSVSyF4ZgA2Y+HnLv9XQ5ZXTXDlyfeGVLHnRh8ShAn PJqEETkydgmnzBgOK0bRDOffg1PpUIPaZZ6JML1k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.100] ([212.95.5.38]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MeU0k-1lPuM840hw-00aWiA; Tue, 29 Jun 2021 10:03:13 +0200 Subject: Re: bug#49248: 28.0.50; read-from-minibuffer returns a window-live-p error when its original window is deleted To: Thierry Volpiatto References: <8735t2h46e.fsf@posteo.net> <87a6na5ibc.fsf@posteo.net> From: martin rudalics Message-ID: Date: Tue, 29 Jun 2021 10:03:11 +0200 MIME-Version: 1.0 In-Reply-To: <87a6na5ibc.fsf@posteo.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:EUvTfIIqHWXqLwpQHRpLhT15BrYkUu0qYPlaAlfVisdxnYJaRU1 VHoWnhUbVEtpY9d3CSwmP2/JSjUjYcZB8aULTStR3wZIE2Ab50YM86cbED8iqTO4HtzGP3y xyZocYhdTHVbPwKOD0F9JuhX7c7h/WIO1qTpYhNr98W851twLBuHjQ+XpKYDNMB4kfHM08W m26hP7nMIgNkeg/TJcz3g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:QgCNVWlR4I4=:RXPzPrSvKmPUfPguVPUhhy 9Ch6exKTG91epikXN10zx5nNwdRIprlt7WRRGwvHPeypdbze9HgxzayILYTY+bvycLvha/ZUu H7vfn0plbhddXib7fxV8GlwxxyU9MlotgY9qLH8rWoQSh3mUFmpOi35BFwTZwFMH5yekJObat FrlAH4W4N+k6rHYv6NaL3/yQPoy3pnMo60uXK/L6JmaBWpFvluIl+uHbaPaajUw/uka1xRnT0 /8A0QdkwyrnTaFZA9hebJ5WiY2yw9BHsJ2qFx7KQoTGUBA+ECQfI78ro7LRxN8Kk6OMyQCieP 3KRkSiMbo6njXJrWVoqsORX2ZoXOtUuPJj6/a617Q2RfKnslNUEg/AAKu6srTF+dYaqSwfWL5 iMGQfdpGCvWgrBWgCDLu+4gP1U8gql5Wi8NH5Oo/zuTdlZgrinlazY2iVlDqHkQB9oqLAh2dv bo3oBsjhU4J3vsCfuo00lpxy/nels1R+ImlTjYgNLlQrxu7dPDh+XMKpkqlZANiN5qQ+EmdXR ydG0Dto+213vj6AI+hHnaGsQYUb/xGqEnUrJ0XmlsA30tHgwWeImu1H/luB7VDVdDnP+Adx52 t/g0p6eA6pjmtAsw8QxL6KavcjNTdNK4wkYlSgJ5HkKHzBmpagluG1wJF/b/UB4789X3L82cM 6tgokbxVsbhoW1+yvgnF3kggHsSjfVXv0PouqhepSX/hxRwa+AJ/D2JFou1RPaw5MGVqSKfLo vJ6SDnlWVczv7hw0YlqbRA6/QEIW/VHcsRNl3p6JO5xpLCI07HNzjTu3WMlDp+eJIv0/37b0A R//2trqUgig5zXFrufdjn0oAwXRNq1gJnKsDdWxtta6JB0RtegRvX6hZUA/qmFnQeIJe9p17F VfUnjF/Cll7PRLnsBrcyvkQ4hXAwYPrz7V6knmEA+Y5sKGrmuzyEtgyM2UMtxvTIwv+B5dEjo 6nOIwaDbzFcDDvbNJ+mRPo0Vb/kyrsDXWA7+M5W2mZ3D2wNzPaaOsaTnjcagU2hBhPE1HBKqT MWCE22SPzEztEu8GZdulFIqs6q4lEeYECMTwOomr46rUXIxpIWJ11tnzJGBiLL+S46xIyEY5+ gJcQpSr7bIvgXodMLRruCR68vFSlkB9ExzC X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49248 Cc: 49248@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Thanks Martin for quick answer and fix, yes it is now working. Pushed to master now. Apparently, exiting from the minibuffer may select a frame no less than four times here: #1 in read_minibuf_unwind if (!EQ (exp_MB_frame, saved_selected_frame) && !NILP (exp_MB_frame)) do_switch_frame (exp_MB_frame, 0, 0, Qt); /* This also sets minibuf_window */ #2 in read_minibuf_unwind else if (WINDOW_LIVE_P (calling_window)) Fset_frame_selected_window (calling_frame, calling_window, Qnil); #3 in read_minibuf_unwind /* Restore the selected frame. */ if (!EQ (exp_MB_frame, saved_selected_frame) && !NILP (exp_MB_frame)) do_switch_frame (saved_selected_frame, 0, 0, Qt); #4 in read_minibuf if (FRAMEP (calling_frame) && FRAME_LIVE_P (XFRAME (calling_frame)) && (!EQ (selected_frame, calling_frame) || (WINDOW_LIVE_P (XFRAME (calling_frame)->minibuffer_window) && !EQ (XWINDOW (XFRAME (calling_frame)->minibuffer_window) ->frame, calling_frame)))) call2 (Qselect_frame_set_input_focus, calling_frame, Qnil); These will confuse the hell out of any window manager (and of me). Can some knowledgeable soul tell us what all this code is supposed to do and whether it could be refactored in some sane way? Many thanks in advance, martin From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 01 05:21:08 2021 Received: (at 49248) by debbugs.gnu.org; 1 Jul 2021 09:21:08 +0000 Received: from localhost ([127.0.0.1]:59563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyssd-00033P-Nz for submit@debbugs.gnu.org; Thu, 01 Jul 2021 05:21:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyssc-00032S-EE for 49248@debbugs.gnu.org; Thu, 01 Jul 2021 05:21:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44854) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyssW-0001u5-QC; Thu, 01 Jul 2021 05:21:00 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1517 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyssW-0005Ht-2Z; Thu, 01 Jul 2021 05:21:00 -0400 Date: Thu, 01 Jul 2021 12:21:03 +0300 Message-Id: <83pmw2l79c.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: (message from martin rudalics on Tue, 29 Jun 2021 10:03:11 +0200) Subject: Re: bug#49248: 28.0.50; read-from-minibuffer returns a window-live-p error when its original window is deleted References: <8735t2h46e.fsf@posteo.net> <87a6na5ibc.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49248 Cc: thievol@posteo.net, 49248@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: martin rudalics > Date: Tue, 29 Jun 2021 10:03:11 +0200 > Cc: 49248@debbugs.gnu.org > > Apparently, exiting from the minibuffer may select a frame no less > than four times here: > > #1 in read_minibuf_unwind > if (!EQ (exp_MB_frame, saved_selected_frame) > && !NILP (exp_MB_frame)) > do_switch_frame (exp_MB_frame, 0, 0, Qt); /* This also sets > minibuf_window */ > > #2 in read_minibuf_unwind > else if (WINDOW_LIVE_P (calling_window)) > Fset_frame_selected_window (calling_frame, calling_window, Qnil); > > #3 in read_minibuf_unwind > /* Restore the selected frame. */ > if (!EQ (exp_MB_frame, saved_selected_frame) > && !NILP (exp_MB_frame)) > do_switch_frame (saved_selected_frame, 0, 0, Qt); > > #4 in read_minibuf > if (FRAMEP (calling_frame) > && FRAME_LIVE_P (XFRAME (calling_frame)) > && (!EQ (selected_frame, calling_frame) > || (WINDOW_LIVE_P (XFRAME (calling_frame)->minibuffer_window) > && !EQ (XWINDOW (XFRAME (calling_frame)->minibuffer_window) > ->frame, > calling_frame)))) > call2 (Qselect_frame_set_input_focus, calling_frame, Qnil); > > These will confuse the hell out of any window manager (and of me). Can > some knowledgeable soul tell us what all this code is supposed to do and > whether it could be refactored in some sane way? #1 and #3 are identical, so I think we could avoid #3 by testing the selected frame against saved_selected_frame. #2 is only done if "the previous minibuffer displayed in this miniwindow is dead", so I don't see a problem there. #4 is only done if read_minibuf_unwind didn't already do it, for whatever reason, so it's just the code trying to be defensive. (read_minibuf_unwind must re-select the original frame in case we QUIT or signal an error during read_minibuf.) HTH