From unknown Sun Jun 22 00:51:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49245: Enchant dictionaries list not being correctly set, and other minor fixes Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jun 2021 21:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 49245@debbugs.gnu.org X-Debbugs-Original-To: bug-emacs Received: via spool by submit@debbugs.gnu.org id=B.162482883213950 (code B ref -1); Sun, 27 Jun 2021 21:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2021 21:20:32 +0000 Received: from localhost ([127.0.0.1]:50435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxcCe-0003cw-5x for submit@debbugs.gnu.org; Sun, 27 Jun 2021 17:20:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:52236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxcCZ-0003ck-3G for submit@debbugs.gnu.org; Sun, 27 Jun 2021 17:20:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxcCY-0007Tz-NA for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44026) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxcCY-0001in-F5 for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55334) by fencepost.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxcCY-0007k7-D1 for bug-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]:36658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxcCV-0001e3-Od for bug-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: by mail-oi1-x22c.google.com with SMTP id 11so11236680oid.3 for ; Sun, 27 Jun 2021 14:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=Vn5XJOM8LP1+oxq6R4AgAvkpOaHOMKecAcrRYAoeMqk=; b=ZZd3QSvx48EcDL+0IbdwdVlsJI8PCqVbh1VO7YHEOumUHG8jzKY1vVDH7hpuafxbLx aohbOTi3fA5VLMJq1GpS6eRQ4ScMc2AcVEKEvTCFEojRxsC0cWCzRBgO4u4RQSsCFmM9 183NiHNGJxpt0Eh9g/xlOgV7TnEJxbeOiuX10= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Vn5XJOM8LP1+oxq6R4AgAvkpOaHOMKecAcrRYAoeMqk=; b=t385rbA/nDiRitoofLN2Wo3qtTn9lW76Sg7Uqf5CyjUZvTL25zZcHvp/HzU4Ck70CV 78ZL3UPCG2iTyMBMh0JGHwwNXofX/E328QQEbIFHDUbzNE/IC7CnBpjbsS/gUUMB7A32 RFae6ymxf9Ma1nDBwdLM9HBeESe6rISjxXNLWEjaU/f+uEET/Ss+GrjVCsPyuO2yDVFg 7chnL2vLzZDvYF78WMXo84hA2Vc+k9ymAFeJUPcHx2Jv3Zz1b28OgqpuVU0c9aLtMQG2 CHbqEEAEtN/RYWfyDXuf1KV2EZ/XY7eoSPaVPPXrdKWT1jJ5NMKHAQ+nH6pDLsZUGfo1 xLBw== X-Gm-Message-State: AOAM530aruNpo3kogaSU2kiWIg20hKkoR0qGOt2UyTNKUOO/CotEOpFR JG/3TA734GoZwTDph2repgM0cpKWzYGHFuGVnLT957PHGttsBw== X-Google-Smtp-Source: ABdhPJwx1ywZr8N4mzCWovgkdfP9YyVEXcygICmHqcIwxwG3HH2PkL4DMAgXnHDhDi4qahSnVCTQdWSm66EwzOcuJTM= X-Received: by 2002:aca:4d94:: with SMTP id a142mr3421163oib.179.1624828821779; Sun, 27 Jun 2021 14:20:21 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Sun, 27 Jun 2021 22:20:10 +0100 Message-ID: Content-Type: multipart/mixed; boundary="000000000000be687d05c5c5f084" Received-SPF: pass client-ip=2607:f8b0:4864:20::22c; envelope-from=rrt@sc3d.org; helo=mail-oi1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --000000000000be687d05c5c5f084 Content-Type: multipart/alternative; boundary="000000000000be687b05c5c5f082" --000000000000be687b05c5c5f082 Content-Type: text/plain; charset="UTF-8" I found a bug recently where, when using Enchant as the back-end for ispell.el, spellchecking was locking up for some languages. This turned out to be the combination of two problems. First, ispell-find-enchant-dictionaries was incorrectly merging ispell-dictionary-base-alist into its result. This caused the ispell-set-spellchecker-params to fail to add the correct "-d LANG" flag arguments to the list of dictionaries that it used to start Enchant, which in turn meant that the process was started as e.g. enchant-2 -d francais # rather than -d fr_FR and failed to start properly. I have fixed this by simply removing the incorrect code (patch 0003 attached). Secondly, ispell.el failed to notice that it had not actually started an Enchant process, and hung while trying to read from it in ispell-accept-output. I fixed this by testing that the process is live before trying to read from or write to it (patch 0002 attached). Finally, while reading the source code I found an ancient comment that is more of a commit message in spirit (it explains how the current code came to be that way, rather than explaining something about how it works), so I removed it (patch 0001 attached). As usual with my infrequent patches, I would appreciate other eyes on them before I install them, if possible. I remain an active user of ispell with Enchant, though, so I will give them plenty of manual testing. Thanks in advance! -- https://rrt.sc3d.org --000000000000be687b05c5c5f082 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I found a bug recently where, when usin= g Enchant as the back-end for ispell.el, spellchecking was locking up for s= ome languages.

This tu= rned out to be the combination of two problems.
First, ispell-find-enchant-dictionaries was incor= rectly merging ispell-dictionary-base-alist into its result. This caused th= e ispell-set-spellchecker-params to fail to add the correct "-d LANG&q= uot; flag arguments to the list of dictionaries that it used to start Encha= nt, which in turn meant that the process was started as e.g.

enchant-2 -d francais # rather than = -d fr_FR

and failed to= start properly. I have fixed this by simply removing the incorrect code (p= atch 0003 attached).

Secondly, ispell.el failed to notice that it had not actually started an= Enchant process, and hung while trying to read from it in ispell-accept-ou= tput. I fixed this by testing that the process is live before trying to rea= d from or write to it (patch 0002 attached).

Finally, while reading the source code I found an an= cient comment that is more of a commit message in spirit (it explains how t= he current code came to be that way, rather than explaining something about= how it works), so I removed it (patch 0001 attached).

As usual with my infrequent patches, I wou= ld appreciate other eyes on them before I install them, if possible. I rema= in an active user of ispell with Enchant, though, so I will give them plent= y of manual testing. Thanks in advance!

--
--000000000000be687b05c5c5f082-- --000000000000be687d05c5c5f084 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-lisp-textmodes-ispell.el-Check-process-is-live-befor.patch" Content-Disposition: attachment; filename="0002-lisp-textmodes-ispell.el-Check-process-is-live-befor.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqfp40ae1 RnJvbSBlMDgwNjVkYTVkYjlkYzFjMzBiMWI4M2FkY2M4OGQzOGIxZWQ2NzFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFN1 biwgMjcgSnVuIDIwMjEgMjI6MDc6MDYgKzAxMDAKU3ViamVjdDogW1BBVENIIDIvM10gKiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWw6IENoZWNrIHByb2Nlc3MgaXMgbGl2ZSBiZWZvcmUKIGludGVy YWN0aW5nLgoKQ2hlY2sgdGhhdCBgaXNwZWxsLXByb2Nlc3MnIGlzIGxpdmUgYmVmb3JlIHRyeWlu ZyB0byByZWFkIGZyb20gb3IKd3JpdGUgdG8gaXQuIFRoaXMgYXZvaWRzIGEgaGFuZyBpZiB0aGUg cHJvY2VzcyBoYXMgZGllZC4KLS0tCiBsaXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwgfCAxMyArKysr KysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbCBiL2xpc3AvdGV4dG1vZGVz L2lzcGVsbC5lbAppbmRleCBlM2MxZTYxNzcyLi44Yjc5OWIwOGMwIDEwMDY0NAotLS0gYS9saXNw L3RleHRtb2Rlcy9pc3BlbGwuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCkBAIC0x NzY1LDEwICsxNzY1LDEyIEBAIGlzcGVsbC1hY2NlcHQtb3V0cHV0CiBJZiBhc3luY2hyb25vdXMg c3VicHJvY2Vzc2VzIGFyZSBub3Qgc3VwcG9ydGVkLCBjYWxsIGZ1bmN0aW9uIGBpc3BlbGwtZmls dGVyJwogYW5kIHBhc3MgaXQgdGhlIG91dHB1dCBvZiB0aGUgbGFzdCBJc3BlbGwgaW52b2NhdGlv bi4iCiAgIChpZiBpc3BlbGwtYXN5bmMtcHJvY2Vzc3AKLSAgICAgIChsZXQgKCh0aW1lb3V0IChp ZiB0aW1lb3V0LW1zZWNzCi0JCQkgKCsgKG9yIHRpbWVvdXQtc2VjcyAwKSAoLyB0aW1lb3V0LW1z ZWNzIDEwMDAuMCkpCi0JCSAgICAgICB0aW1lb3V0LXNlY3MpKSkKLQkoYWNjZXB0LXByb2Nlc3Mt b3V0cHV0IGlzcGVsbC1wcm9jZXNzIHRpbWVvdXQpKQorICAgICAgKGlmIChwcm9jZXNzLWxpdmUt cCBpc3BlbGwtcHJvY2VzcykKKyAgICAgICAobGV0ICgodGltZW91dCAoaWYgdGltZW91dC1tc2Vj cworCQkJICAoKyAob3IgdGltZW91dC1zZWNzIDApICgvIHRpbWVvdXQtbXNlY3MgMTAwMC4wKSkK KwkJICAgICAgICB0aW1lb3V0LXNlY3MpKSkKKwkgKGFjY2VwdC1wcm9jZXNzLW91dHB1dCBpc3Bl bGwtcHJvY2VzcyB0aW1lb3V0KSkKKyAgICAgICAoZXJyb3IgIk5vIElzcGVsbCBwcm9jZXNzIHRv IHJlYWQgb3V0cHV0IGZyb20hIikpCiAgICAgKGlmIChudWxsIGlzcGVsbC1wcm9jZXNzKQogCShl cnJvciAiTm8gSXNwZWxsIHByb2Nlc3MgdG8gcmVhZCBvdXRwdXQgZnJvbSEiKQogICAgICAgKGxl dCAoKGJ1ZiBpc3BlbGwtb3V0cHV0LWJ1ZmZlcikKQEAgLTE3OTMsNyArMTc5NSw4IEBAIGlzcGVs bC1zZW5kLXJlcGxhY2VtZW50CiAoZGVmdW4gaXNwZWxsLXNlbmQtc3RyaW5nIChzdHJpbmcpCiAg ICJTZW5kIHRoZSBzdHJpbmcgU1RSSU5HIHRvIHRoZSBJc3BlbGwgcHJvY2Vzcy4iCiAgIChpZiBp c3BlbGwtYXN5bmMtcHJvY2Vzc3AKLSAgICAgIChwcm9jZXNzLXNlbmQtc3RyaW5nIGlzcGVsbC1w cm9jZXNzIHN0cmluZykKKyAgICAgIChpZiAocHJvY2Vzcy1saXZlLXAgaXNwZWxsLXByb2Nlc3Mp CisgICAgICAgKHByb2Nlc3Mtc2VuZC1zdHJpbmcgaXNwZWxsLXByb2Nlc3Mgc3RyaW5nKSkKICAg ICA7OyBBc3luY2hyb25vdXMgc3VicHJvY2Vzc2VzIGFyZW4ndCBzdXBwb3J0ZWQgb24gdGhpcyBs b3Npbmcgc3lzdGVtLgogICAgIDs7IFdlIGtlZXAgYWxsIHRoZSBkaXJlY3RpdmVzIHBhc3NlZCB0 byBJc3BlbGwgZHVyaW5nIHRoZSBlbnRpcmUKICAgICA7OyBzZXNzaW9uIGluIGEgYnVmZmVyLCBh bmQgcGFzcyB0aGVtIGFuZXcgZWFjaCB0aW1lIHdlIGludm9rZQotLSAKMi4yNS4xCgo= --000000000000be687d05c5c5f084 Content-Type: text/x-patch; charset="US-ASCII"; name="0003-lisp-textmodes-ispell.el-Fix-finding-dictionaries-fo.patch" Content-Disposition: attachment; filename="0003-lisp-textmodes-ispell.el-Fix-finding-dictionaries-fo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqfp40ai2 RnJvbSBlM2NkNTM2MWJlYTM2ZWNkOWMwMjZiY2E5M2ViM2UzODA5NzIxZTEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFN1 biwgMjcgSnVuIDIwMjEgMjI6MDg6NDAgKzAxMDAKU3ViamVjdDogW1BBVENIIDMvM10gKiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWw6IEZpeCBmaW5kaW5nIGRpY3Rpb25hcmllcyBmb3IKIEVuY2hh bnQuCgooaXNwZWxsLWZpbmQtZW5jaGFudC1kaWN0aW9uYXJpZXMpOgoKSSBvcmlnaW5hbGx5IGNv cGllZCB0aGlzIGNvZGUgZnJvbSB0aGUgZXF1aXZhbGVudCBjb2RlIGZvcgpBc3BlbGwuIFVuZm9y dHVuYXRlbHkgaXQgd2FzIHdyb25nIGZvciB0aGUgY2FzZSBvZiBFbmNoYW50OiBpdCBzaG91bGQK ZmluZCBvbmx5IGRpY3Rpb25hcmllcyB0aGF0IEVuY2hhbnQga25vd3MgYWJvdXQsIGFuZCBub3Qg bWVyZ2UgaW4KYGlzcGVsbC1kaWN0aW9uYXJ5LWJhc2UtYWxpc3QnIG9yIGFkZCBhIGRlZmF1bHQg ZWxlbWVudCwgYXMgdGhlc2UKYXJlIGRlYWx0IHdpdGggaW4gYGlzcGVsbC1zZXQtc3BlbGxjaGVj a2VyLXBhcmFtcycuCgpUaGlzIGNhdXNlZCBhIGJ1ZyB3aGVyZSB0aGUgY29ycmVjdCBgLWQnIGFy Z3VtZW50IHdvdWxkIG5vdCBiZSBhZGRlZAp0byB0aGUgaW52b2NhdGlvbiBvZiBlbmNoYW50LCBs ZWFkaW5nIHRvIHRoZSBwcm9jZXNzIG5vdCBiZWluZwpjb3JyZWN0bHkgc3RhcnRlZC4KLS0tCiBs aXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwgfCAxMyArLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4 dG1vZGVzL2lzcGVsbC5lbCBiL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbAppbmRleCA4Yjc5OWIw OGMwLi41NTcwODAwNzc2IDEwMDY0NAotLS0gYS9saXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwKKysr IGIvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCkBAIC0xMjExLDE4ICsxMjExLDcgQEAgaXNwZWxs LWZpbmQtZW5jaGFudC1kaWN0aW9uYXJpZXMKICAgICAgICAgICAgICAgICAgICAgYCgsbGFuZyAi W1s6YWxwaGE6XV0iICJbXls6YWxwaGE6XV0iCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LChpc3BlbGwtLWdldC1leHRyYS13b3JkLWNoYXJhY3RlcnMgbGFuZykgdCBuaWwgbmlsIHV0Zi04 KSkKICAgICAgICAgICAgICAgICAgIGRpY3Rpb25hcmllcykpKQotICAgIDs7IE1lcmdlIGludG8g Rk9VTkQgYW55IGVsZW1lbnRzIGZyb20gdGhlIHN0YW5kYXJkIGlzcGVsbC1kaWN0aW9uYXJ5LWJh c2UtYWxpc3QKLSAgICA7OyB3aGljaCBoYXZlIG5vIGVsZW1lbnQgaW4gRk9VTkQgYXQgYWxsLgot ICAgIChkb2xpc3QgKGRpY3QgaXNwZWxsLWRpY3Rpb25hcnktYmFzZS1hbGlzdCkKLSAgICAgICh1 bmxlc3MgKGFzc29jIChjYXIgZGljdCkgZm91bmQpCi0JKHNldHEgZm91bmQgKG5jb25jIGZvdW5k IChsaXN0IGRpY3QpKSkpKQotICAgIChzZXRxIGlzcGVsbC1lbmNoYW50LWRpY3Rpb25hcnktYWxp c3QgZm91bmQpCi0gICAgOzsgQWRkIGEgZGVmYXVsdCBlbnRyeQotICAgIChsZXQgKChkZWZhdWx0 LWRpY3QKLSAgICAgICAgICAgIGAobmlsICJbWzphbHBoYTpdXSIgIlteWzphbHBoYTpdXSIKLSAg ICAgICAgICAgICAgICAgICwoaXNwZWxsLS1nZXQtZXh0cmEtd29yZC1jaGFyYWN0ZXJzKQotICAg ICAgICAgICAgICAgICAgdCBuaWwgbmlsIHV0Zi04KSkpCi0gICAgICAocHVzaCBkZWZhdWx0LWRp Y3QgaXNwZWxsLWVuY2hhbnQtZGljdGlvbmFyeS1hbGlzdCkpKSkKKyAgICAoc2V0cSBpc3BlbGwt ZW5jaGFudC1kaWN0aW9uYXJ5LWFsaXN0IGZvdW5kKSkpCiAKIDs7IFNldCBwYXJhbXMgYWNjb3Jk aW5nIHRvIHRoZSBzZWxlY3RlZCBzcGVsbGNoZWNrZXIKIAotLSAKMi4yNS4xCgo= --000000000000be687d05c5c5f084 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-textmodes-ispell.el-ispell-word-Remove-a-redund.patch" Content-Disposition: attachment; filename="0001-lisp-textmodes-ispell.el-ispell-word-Remove-a-redund.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqfp40a50 RnJvbSBlMTJjOGE1MWNjZWU1Y2QyY2M4OWFlNTAzZDJjZTVhMDg1YjA1NTY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFN1 biwgMjcgSnVuIDIwMjEgMjI6MDQ6MTcgKzAxMDAKU3ViamVjdDogW1BBVENIIDEvM10gKiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWwgKGlzcGVsbC13b3JkKTogUmVtb3ZlIGEKIHJlZHVuZGFudCBj b21tZW50CgpSZW1vdmUgYSBjb21tZW50IG9mIHB1cmVseSBoaXN0b3JpY2FsIGludGVyZXN0LiAo SXQgcmVhZHMgbGlrZSBhCmNvbW1pdCBtZXNzYWdlLCBub3QgYSBjb21tZW50LikKLS0tCiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWwgfCAyIC0tCiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwgYi9saXNwL3RleHRtb2Rl cy9pc3BlbGwuZWwKaW5kZXggNGRiYzc2NDBiYy4uZTNjMWU2MTc3MiAxMDA2NDQKLS0tIGEvbGlz cC90ZXh0bW9kZXMvaXNwZWxsLmVsCisrKyBiL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbApAQCAt MTkxMSw4ICsxOTExLDYgQEAgaXNwZWxsLXdvcmQKIAkgICAgZW5kIChjYXIgKGNkciAoY2RyIHdv cmQpKSkKIAkgICAgd29yZCAoY2FyIHdvcmQpKQogCi0gICAgICA7OyBBdCB0aGlzIHBvaW50IGl0 IHVzZWQgdG8gaWdub3JlIDItbGV0dGVyIHdvcmRzLgotICAgICAgOzsgQnV0IHRoYXQgaXMgc2ls bHk7IGlmIHRoZSB1c2VyIGFza3MgZm9yIGl0LCB3ZSBzaG91bGQgZG8gaXQuIC0gcm1zLgogICAg ICAgKG9yIHF1aWV0bHkKIAkgIChtZXNzYWdlICJDaGVja2luZyBzcGVsbGluZyBvZiAlcy4uLiIK IAkJICAgKGZ1bmNhbGwgaXNwZWxsLWZvcm1hdC13b3JkLWZ1bmN0aW9uIHdvcmQpKSkKLS0gCjIu MjUuMQoK --000000000000be687d05c5c5f084-- From unknown Sun Jun 22 00:51:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49245: Enchant dictionaries list not being correctly set, and other minor fixes Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jun 2021 12:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Reuben Thomas Cc: 49245@debbugs.gnu.org Received: via spool by 49245-submit@debbugs.gnu.org id=B49245.162488244620183 (code B ref 49245); Mon, 28 Jun 2021 12:15:01 +0000 Received: (at 49245) by debbugs.gnu.org; 28 Jun 2021 12:14:06 +0000 Received: from localhost ([127.0.0.1]:51209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxq9N-0005FT-Ue for submit@debbugs.gnu.org; Mon, 28 Jun 2021 08:14:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxq9L-0005Er-Qk for 49245@debbugs.gnu.org; Mon, 28 Jun 2021 08:14:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36048) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxq9G-0005eV-3b; Mon, 28 Jun 2021 08:13:58 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4862 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxq9F-0002Cv-NX; Mon, 28 Jun 2021 08:13:58 -0400 Date: Mon, 28 Jun 2021 15:13:54 +0300 Message-Id: <83a6nap4ot.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 27 Jun 2021 22:20:10 +0100 > From: Reuben Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I found a bug recently where, when using Enchant as the back-end for ispell.el, spellchecking was locking up > for some languages. > > This turned out to be the combination of two problems. > > First, ispell-find-enchant-dictionaries was incorrectly merging ispell-dictionary-base-alist into its result. This > caused the ispell-set-spellchecker-params to fail to add the correct "-d LANG" flag arguments to the list of > dictionaries that it used to start Enchant, which in turn meant that the process was started as e.g. > > enchant-2 -d francais # rather than -d fr_FR > > and failed to start properly. I have fixed this by simply removing the incorrect code (patch 0003 attached). > > Secondly, ispell.el failed to notice that it had not actually started an Enchant process, and hung while trying to > read from it in ispell-accept-output. I fixed this by testing that the process is live before trying to read from or > write to it (patch 0002 attached). > > Finally, while reading the source code I found an ancient comment that is more of a commit message in > spirit (it explains how the current code came to be that way, rather than explaining something about how it > works), so I removed it (patch 0001 attached). > > As usual with my infrequent patches, I would appreciate other eyes on them before I install them, if possible. OK for the first 2 patches, but please don't remove that comment, it explains something important, and there's no reason to remove it (or many other similar comments we have throughout our code). Thanks. From unknown Sun Jun 22 00:51:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49245: Enchant dictionaries list not being correctly set, and other minor fixes Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jun 2021 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 49245@debbugs.gnu.org Received: via spool by 49245-submit@debbugs.gnu.org id=B49245.162488348021876 (code B ref 49245); Mon, 28 Jun 2021 12:32:01 +0000 Received: (at 49245) by debbugs.gnu.org; 28 Jun 2021 12:31:20 +0000 Received: from localhost ([127.0.0.1]:51215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxqQ4-0005gm-Fa for submit@debbugs.gnu.org; Mon, 28 Jun 2021 08:31:20 -0400 Received: from mail-ot1-f48.google.com ([209.85.210.48]:33705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxqQ2-0005gY-55 for 49245@debbugs.gnu.org; Mon, 28 Jun 2021 08:31:19 -0400 Received: by mail-ot1-f48.google.com with SMTP id o17-20020a9d76510000b02903eabfc221a9so18623242otl.0 for <49245@debbugs.gnu.org>; Mon, 28 Jun 2021 05:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MPGdA9g9iPDzuwAQYdwpNhq0pEgQ9uqxzhgD6wl6zqI=; b=anJ5tH0OeShIX0OT76Ba1R+wAUJsaV5epC5hfzoNjSCDPjGdSYIEWqKmdd+EUyqhGi VkSjZp9jAI0ZPxTSEX1ZvR1slwOPf4rKOB4f7Hc5VgLfNNn/ny6Z8/rW8a7SPUGGvFsK Ncy7LSJTkFa2AhAPtCprCWwPedV0V2n9ERd60= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MPGdA9g9iPDzuwAQYdwpNhq0pEgQ9uqxzhgD6wl6zqI=; b=Twhf8K0NUGcpUXw6DPbqVtDR4ntOkC0n3uCXHGufjrUfjSuKL2RgGEiSflSp9pLEbK UE1j1+kyew86Vel7HyipWZ6Y3uT0Ex3hVOeB8CpSDeVMdwAR9gEHccEqAJkvmrhbj8Wx THMafYfKsijeOkddvUTPMbC9kDz8emPyMsAyPI1/7cXPyg3OYGYhvUdUVS92ThQW9fR9 nXlcAoVitb28imCNdGUXRbnegAyqteEWG26vN2pPm+z5f7j6nYFOkmf3InD9LNQIkqQQ nVgJjMi1gsMsWKTSboy2vIGMvWvt7BxKl7iJsQ+yZdXPuCY5oM4zVij2K5kHd64Gbat+ ibEg== X-Gm-Message-State: AOAM533L8I/XfjWkbDeg0wShPmAH1dUdSrRLWAv2mWSF9aLJRQU8cBsO AiXUs3M5EOsYyNl1RygctIBIrU9nqyRqdKSJiQAxIQ== X-Google-Smtp-Source: ABdhPJxfCjLj+L77mK8hOnR9KB8gSCBzQikP6oyoxaPMMGwQgAEmkhKncayMlKEyhRejY5+osaLRw3C3ivrvItqvCbk= X-Received: by 2002:a05:6830:1643:: with SMTP id h3mr21567494otr.76.1624883472400; Mon, 28 Jun 2021 05:31:12 -0700 (PDT) MIME-Version: 1.0 References: <83a6nap4ot.fsf@gnu.org> In-Reply-To: <83a6nap4ot.fsf@gnu.org> From: Reuben Thomas Date: Mon, 28 Jun 2021 13:31:01 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000002c942505c5d2aae2" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002c942505c5d2aae2 Content-Type: text/plain; charset="UTF-8" On Mon, 28 Jun 2021 at 13:13, Eli Zaretskii wrote: > OK for the first 2 patches, Thanks for the review. > but please don't remove that comment, it > explains something important, and there's no reason to remove it (or > many other similar comments we have throughout our code). > In that case, please can you explain it, and I can rewrite it so that its significance is more evident. As I said, it explains why something was changed in the past (which is useful information in a commit message) rather than how or why the current code does something that may not be obvious just from reading the code (which would be suitable for a comment). Commit f0a1f8bdb5, which introduces it, has the message "Do not ignore short words". The current code does not have to *do* anything to check short words; that commit simply removed a check. I do not see anything in the current code that raises any questions that need answering by a comment. On the contrary, the comment raises a question: "is there some setting for minimum word length that I need to be aware of?". So I feel I've missed something here that a rewording of the comment could fix. -- https://rrt.sc3d.org --0000000000002c942505c5d2aae2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, 28 Jun 2021 = at 13:13, Eli Zaretskii <eliz@gnu.org> wrote:
OK for the first 2 patches,

Thanks for the review.
=C2=A0
but please don't= remove that comment, it
explains something important, and there's no reason to remove it (or many other similar comments we have throughout our code).
<= div>
In that case, please can you explain it, a= nd I can rewrite it so that its significance is more evident. As I said, it= explains why something was changed in the past (which is useful informatio= n in a commit message) rather than how or why the current code does somethi= ng that may not be obvious just from reading the code (which would be suita= ble for a comment). Commit f0a1f8bdb5, which introduces it, has the message= "Do not ignore short words". The current code does not have to *= do* anything to check short words; that commit simply removed a check. I do= not see anything in the current code that raises any questions that need a= nswering by a comment. On the contrary, the comment raises a question: &quo= t;is there some setting for minimum word length that I need to be aware of?= ". So I feel I've missed something here that a rewording of the co= mment could fix.

--
<= /div> --0000000000002c942505c5d2aae2-- From unknown Sun Jun 22 00:51:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49245: Enchant dictionaries list not being correctly set, and other minor fixes Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jun 2021 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Reuben Thomas Cc: 49245@debbugs.gnu.org Received: via spool by 49245-submit@debbugs.gnu.org id=B49245.16248910342297 (code B ref 49245); Mon, 28 Jun 2021 14:38:02 +0000 Received: (at 49245) by debbugs.gnu.org; 28 Jun 2021 14:37:14 +0000 Received: from localhost ([127.0.0.1]:52232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxsNu-0000az-11 for submit@debbugs.gnu.org; Mon, 28 Jun 2021 10:37:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxsNq-0000ak-3P for 49245@debbugs.gnu.org; Mon, 28 Jun 2021 10:37:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40456) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxsNk-0001QV-Mn; Mon, 28 Jun 2021 10:37:04 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1797 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxsNk-000398-Az; Mon, 28 Jun 2021 10:37:04 -0400 Date: Mon, 28 Jun 2021 17:37:01 +0300 Message-Id: <837dieoy2a.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Reuben Thomas on Mon, 28 Jun 2021 13:31:01 +0100) References: <83a6nap4ot.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Reuben Thomas > Date: Mon, 28 Jun 2021 13:31:01 +0100 > Cc: 49245@debbugs.gnu.org > > but please don't remove that comment, it > explains something important, and there's no reason to remove it (or > many other similar comments we have throughout our code). > > In that case, please can you explain it, and I can rewrite it so that its significance is more evident. As I said, it > explains why something was changed in the past (which is useful information in a commit message) rather > than how or why the current code does something that may not be obvious just from reading the code > (which would be suitable for a comment). Commit f0a1f8bdb5, which introduces it, has the message "Do > not ignore short words". The current code does not have to *do* anything to check short words; that commit > simply removed a check. I do not see anything in the current code that raises any questions that need > answering by a comment. On the contrary, the comment raises a question: "is there some setting for > minimum word length that I need to be aware of?". So I feel I've missed something here that a rewording of > the comment could fix. It is customary to leave a comment when we delete some code, but are not 100% sure that code was a clear mistake. Since deleting code leaves nothing behind (unlike if you add or change code), the comment serves as a kind of "trace" for what once was there, but is no more. If you want a practical case where this could be useful, imagine a bug report regarding special treatment of words shorter than 3 letters (which are normally ignored). From unknown Sun Jun 22 00:51:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49245: Enchant dictionaries list not being correctly set, and other minor fixes Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jun 2021 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49245 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 49245@debbugs.gnu.org Received: via spool by 49245-submit@debbugs.gnu.org id=B49245.162490031226677 (code B ref 49245); Mon, 28 Jun 2021 17:12:02 +0000 Received: (at 49245) by debbugs.gnu.org; 28 Jun 2021 17:11:52 +0000 Received: from localhost ([127.0.0.1]:52391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxunY-0006wC-0Y for submit@debbugs.gnu.org; Mon, 28 Jun 2021 13:11:52 -0400 Received: from mail-ot1-f47.google.com ([209.85.210.47]:41496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxunU-0006vu-LG for 49245@debbugs.gnu.org; Mon, 28 Jun 2021 13:11:50 -0400 Received: by mail-ot1-f47.google.com with SMTP id m6-20020a9d1d060000b029044e2d8e855eso17566918otm.8 for <49245@debbugs.gnu.org>; Mon, 28 Jun 2021 10:11:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uZEUeLU6Ru5Q7w9WU2qZIeKGkMt5hsKj+cHTDDQ8AmE=; b=en7FqSLEUuTi26D+1mX8BiKeiyMnjzNz6IEY06TGwFOYRJ7ZlAzAeFMeMgO93c2Ow+ boFX1PTi4d/ECC7+z1hEym7XBsq9ZvdIIKSwjLXCKqUjJGrhbK6CHdR9I218ziGtasBN xzZWKVEFLqxctfMioTfk7CO1kc1DjsirCLdPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uZEUeLU6Ru5Q7w9WU2qZIeKGkMt5hsKj+cHTDDQ8AmE=; b=Gki2s+DpecxkddOWz+w3vCXzCWx+fuNfVWoelCDIdGjwjgcR8onZZKEMldTJtaBVNQ wLBucqy1xW+rr3Vawv7JIm5U9GZSgf13QPp8KH/AmjBEa4zElyATWeJYar89HQt2sbHt U+dR0EX43PrAoQm9BQeboHhe6033i9s7BeMtd95hLxG6HoNq74r01mK4jAUHbecUY/ng rDAl4xqxDlmg1n7sRQ0u2/CBBkgqBf+mgJsrNXWm1+UoX2QT6tPnRnjoqJ9Ezncxw12v lmHTZwkXmtNIhY3BZcGwvZM3BVTbB9ZLLtcaeKkEb+3aRiXqNDMjxIGKqBDw4V5xHJKe LGZw== X-Gm-Message-State: AOAM5323hTuy+7gtsyc5zuu9zr15ICwwVwXmInFWkM9CZRlKDxk8bLJM Wr/rF6Uqokv2mFiWGq5texxiNlNlDq2fLU3FTOXbLFf49fNasw== X-Google-Smtp-Source: ABdhPJyQOyTEkNTy+luzRV7vfMRDmnaUCaEyenNNrYnjGheEPJGOBpW9YKP4qw1os0vSOrTTyL/mrGPLQMgjZgtZBVg= X-Received: by 2002:a05:6830:1643:: with SMTP id h3mr570854otr.76.1624900302966; Mon, 28 Jun 2021 10:11:42 -0700 (PDT) MIME-Version: 1.0 References: <83a6nap4ot.fsf@gnu.org> <837dieoy2a.fsf@gnu.org> In-Reply-To: <837dieoy2a.fsf@gnu.org> From: Reuben Thomas Date: Mon, 28 Jun 2021 18:11:32 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000005aa6f205c5d695dd" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005aa6f205c5d695dd Content-Type: text/plain; charset="UTF-8" On Mon, 28 Jun 2021 at 15:37, Eli Zaretskii wrote: > It is customary to leave a comment when we delete some code, but are > not 100% sure that code was a clear mistake. Since deleting code > leaves nothing behind (unlike if you add or change code), the comment > serves as a kind of "trace" for what once was there, but is no more. > Thanks for the explanation, sounds like a culture of commenting previously unfamiliar to me. I will close this bug now. -- https://rrt.sc3d.org --0000000000005aa6f205c5d695dd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, 28 Jun 2021 at 15:37, Eli Zaretskii <eliz@gnu.org> wrote:
It is customary to leave a comment when we delete s= ome code, but are
not 100% sure that code was a clear mistake.=C2=A0 Since deleting code
leaves nothing behind (unlike if you add or change code), the comment
serves as a kind of "trace" for what once was there, but is no mo= re.

Thanks for the e= xplanation, sounds like a culture of commenting previously unfamiliar to me= .

I will close this bu= g now.

--
--0000000000005aa6f205c5d695dd-- From unknown Sun Jun 22 00:51:39 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Reuben Thomas Subject: bug#49245: closed (Closing) Message-ID: References: X-Gnu-PR-Message: they-closed 49245 X-Gnu-PR-Package: emacs Reply-To: 49245@debbugs.gnu.org Date: Mon, 28 Jun 2021 17:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1624900382-26836-1" This is a multi-part message in MIME format... ------------=_1624900382-26836-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #49245: Enchant dictionaries list not being correctly set, and other minor = fixes which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 49245@debbugs.gnu.org. --=20 49245: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49245 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1624900382-26836-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 49245-done) by debbugs.gnu.org; 28 Jun 2021 17:12:42 +0000 Received: from localhost ([127.0.0.1]:52395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxuoJ-0006yF-Ak for submit@debbugs.gnu.org; Mon, 28 Jun 2021 13:12:42 -0400 Received: from mail-ot1-f50.google.com ([209.85.210.50]:41611) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxuoG-0006xv-N9 for 49245-done@debbugs.gnu.org; Mon, 28 Jun 2021 13:12:37 -0400 Received: by mail-ot1-f50.google.com with SMTP id m6-20020a9d1d060000b029044e2d8e855eso17570043otm.8 for <49245-done@debbugs.gnu.org>; Mon, 28 Jun 2021 10:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=9T1cdH9kwuj704Hfp2et6WzEH920fexYVlS87ayvn3A=; b=HQWPUHXZCpmfLRmQzZ2LVGB809J4fkDyJjo2YgRkiaaUHoQzxkMuvsZYaHP1iFiUfX A31yNGdvKWWYFoW4HYgxX6QmqhB4m2m93ib+pG/71bVsDLJjmbTaBGYcQvR/Xnv9AKpU usgQXkT1QzDs1BLZDiYFzoD4F78xxKXfak/WE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9T1cdH9kwuj704Hfp2et6WzEH920fexYVlS87ayvn3A=; b=MXrjNCPt7eM+e6x7sexEEL81fGnkNvzmzHejyI6hp8v3BRfkN/C4KbziBH6GC09q9D FxHE2h7id8XpJK24i5zrtnBSfYAmZIXHddCiTOTEPZPQ2BTfp8maF9ul9H7DxJm2rmL5 KzqxUhVjfMRKH2ULOZeFRtfUZi9PA/Z7/Xz4IJmC/gH41vqc3HftT6m6Bes68LknWXiR ZF8BQeu79ElCuQzRdS3Y1SFQLIWVjfe4yQ2UoOExgFAp1KjhLTdOFJUuu9EOE2rLu+Cd KhwpirvJIOpCT66pQaos2vq8w3KqoLPAndtHhTKKDkJelTYKXoDRBjL2JBB94GygiUR5 Vx/g== X-Gm-Message-State: AOAM532OW+mNeovpytugmgtsjXvkZHaoEmWmyQKzGYjwF8k1VMCyR5lf mKV/JmAxAbqDT/F9frPuP2T52sST2EmiwWR6eVmGMVI98mAzUvfe X-Google-Smtp-Source: ABdhPJy8Y0B27+Hh0QhdEfVwpb6vcMsEaquBwlOhd7rp6eNZ+7ogz+ZKHJ1mslW2uILo5kWgwybsGK6H7Isa9HrrZJ8= X-Received: by 2002:a9d:628:: with SMTP id 37mr547596otn.120.1624900351219; Mon, 28 Jun 2021 10:12:31 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Mon, 28 Jun 2021 18:12:20 +0100 Message-ID: Subject: Closing To: 49245-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary="0000000000003af29805c5d698dc" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49245-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000003af29805c5d698dc Content-Type: text/plain; charset="UTF-8" Fixed by 7c93009d11 and 881e75873d. -- https://rrt.sc3d.org --0000000000003af29805c5d698dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Fixed by 7c93009d11 and 881e75873d.
--
--0000000000003af29805c5d698dc-- ------------=_1624900382-26836-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Jun 2021 21:20:32 +0000 Received: from localhost ([127.0.0.1]:50435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxcCe-0003cw-5x for submit@debbugs.gnu.org; Sun, 27 Jun 2021 17:20:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:52236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxcCZ-0003ck-3G for submit@debbugs.gnu.org; Sun, 27 Jun 2021 17:20:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxcCY-0007Tz-NA for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44026) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxcCY-0001in-F5 for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55334) by fencepost.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxcCY-0007k7-D1 for bug-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]:36658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lxcCV-0001e3-Od for bug-emacs@gnu.org; Sun, 27 Jun 2021 17:20:26 -0400 Received: by mail-oi1-x22c.google.com with SMTP id 11so11236680oid.3 for ; Sun, 27 Jun 2021 14:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=Vn5XJOM8LP1+oxq6R4AgAvkpOaHOMKecAcrRYAoeMqk=; b=ZZd3QSvx48EcDL+0IbdwdVlsJI8PCqVbh1VO7YHEOumUHG8jzKY1vVDH7hpuafxbLx aohbOTi3fA5VLMJq1GpS6eRQ4ScMc2AcVEKEvTCFEojRxsC0cWCzRBgO4u4RQSsCFmM9 183NiHNGJxpt0Eh9g/xlOgV7TnEJxbeOiuX10= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Vn5XJOM8LP1+oxq6R4AgAvkpOaHOMKecAcrRYAoeMqk=; b=t385rbA/nDiRitoofLN2Wo3qtTn9lW76Sg7Uqf5CyjUZvTL25zZcHvp/HzU4Ck70CV 78ZL3UPCG2iTyMBMh0JGHwwNXofX/E328QQEbIFHDUbzNE/IC7CnBpjbsS/gUUMB7A32 RFae6ymxf9Ma1nDBwdLM9HBeESe6rISjxXNLWEjaU/f+uEET/Ss+GrjVCsPyuO2yDVFg 7chnL2vLzZDvYF78WMXo84hA2Vc+k9ymAFeJUPcHx2Jv3Zz1b28OgqpuVU0c9aLtMQG2 CHbqEEAEtN/RYWfyDXuf1KV2EZ/XY7eoSPaVPPXrdKWT1jJ5NMKHAQ+nH6pDLsZUGfo1 xLBw== X-Gm-Message-State: AOAM530aruNpo3kogaSU2kiWIg20hKkoR0qGOt2UyTNKUOO/CotEOpFR JG/3TA734GoZwTDph2repgM0cpKWzYGHFuGVnLT957PHGttsBw== X-Google-Smtp-Source: ABdhPJwx1ywZr8N4mzCWovgkdfP9YyVEXcygICmHqcIwxwG3HH2PkL4DMAgXnHDhDi4qahSnVCTQdWSm66EwzOcuJTM= X-Received: by 2002:aca:4d94:: with SMTP id a142mr3421163oib.179.1624828821779; Sun, 27 Jun 2021 14:20:21 -0700 (PDT) MIME-Version: 1.0 From: Reuben Thomas Date: Sun, 27 Jun 2021 22:20:10 +0100 Message-ID: Subject: Enchant dictionaries list not being correctly set, and other minor fixes To: bug-emacs Content-Type: multipart/mixed; boundary="000000000000be687d05c5c5f084" Received-SPF: pass client-ip=2607:f8b0:4864:20::22c; envelope-from=rrt@sc3d.org; helo=mail-oi1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --000000000000be687d05c5c5f084 Content-Type: multipart/alternative; boundary="000000000000be687b05c5c5f082" --000000000000be687b05c5c5f082 Content-Type: text/plain; charset="UTF-8" I found a bug recently where, when using Enchant as the back-end for ispell.el, spellchecking was locking up for some languages. This turned out to be the combination of two problems. First, ispell-find-enchant-dictionaries was incorrectly merging ispell-dictionary-base-alist into its result. This caused the ispell-set-spellchecker-params to fail to add the correct "-d LANG" flag arguments to the list of dictionaries that it used to start Enchant, which in turn meant that the process was started as e.g. enchant-2 -d francais # rather than -d fr_FR and failed to start properly. I have fixed this by simply removing the incorrect code (patch 0003 attached). Secondly, ispell.el failed to notice that it had not actually started an Enchant process, and hung while trying to read from it in ispell-accept-output. I fixed this by testing that the process is live before trying to read from or write to it (patch 0002 attached). Finally, while reading the source code I found an ancient comment that is more of a commit message in spirit (it explains how the current code came to be that way, rather than explaining something about how it works), so I removed it (patch 0001 attached). As usual with my infrequent patches, I would appreciate other eyes on them before I install them, if possible. I remain an active user of ispell with Enchant, though, so I will give them plenty of manual testing. Thanks in advance! -- https://rrt.sc3d.org --000000000000be687b05c5c5f082 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I found a bug recently where, when usin= g Enchant as the back-end for ispell.el, spellchecking was locking up for s= ome languages.

This tu= rned out to be the combination of two problems.
First, ispell-find-enchant-dictionaries was incor= rectly merging ispell-dictionary-base-alist into its result. This caused th= e ispell-set-spellchecker-params to fail to add the correct "-d LANG&q= uot; flag arguments to the list of dictionaries that it used to start Encha= nt, which in turn meant that the process was started as e.g.

enchant-2 -d francais # rather than = -d fr_FR

and failed to= start properly. I have fixed this by simply removing the incorrect code (p= atch 0003 attached).

Secondly, ispell.el failed to notice that it had not actually started an= Enchant process, and hung while trying to read from it in ispell-accept-ou= tput. I fixed this by testing that the process is live before trying to rea= d from or write to it (patch 0002 attached).

Finally, while reading the source code I found an an= cient comment that is more of a commit message in spirit (it explains how t= he current code came to be that way, rather than explaining something about= how it works), so I removed it (patch 0001 attached).

As usual with my infrequent patches, I wou= ld appreciate other eyes on them before I install them, if possible. I rema= in an active user of ispell with Enchant, though, so I will give them plent= y of manual testing. Thanks in advance!

--
--000000000000be687b05c5c5f082-- --000000000000be687d05c5c5f084 Content-Type: text/x-patch; charset="US-ASCII"; name="0002-lisp-textmodes-ispell.el-Check-process-is-live-befor.patch" Content-Disposition: attachment; filename="0002-lisp-textmodes-ispell.el-Check-process-is-live-befor.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqfp40ae1 RnJvbSBlMDgwNjVkYTVkYjlkYzFjMzBiMWI4M2FkY2M4OGQzOGIxZWQ2NzFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFN1 biwgMjcgSnVuIDIwMjEgMjI6MDc6MDYgKzAxMDAKU3ViamVjdDogW1BBVENIIDIvM10gKiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWw6IENoZWNrIHByb2Nlc3MgaXMgbGl2ZSBiZWZvcmUKIGludGVy YWN0aW5nLgoKQ2hlY2sgdGhhdCBgaXNwZWxsLXByb2Nlc3MnIGlzIGxpdmUgYmVmb3JlIHRyeWlu ZyB0byByZWFkIGZyb20gb3IKd3JpdGUgdG8gaXQuIFRoaXMgYXZvaWRzIGEgaGFuZyBpZiB0aGUg cHJvY2VzcyBoYXMgZGllZC4KLS0tCiBsaXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwgfCAxMyArKysr KysrKy0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbCBiL2xpc3AvdGV4dG1vZGVz L2lzcGVsbC5lbAppbmRleCBlM2MxZTYxNzcyLi44Yjc5OWIwOGMwIDEwMDY0NAotLS0gYS9saXNw L3RleHRtb2Rlcy9pc3BlbGwuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCkBAIC0x NzY1LDEwICsxNzY1LDEyIEBAIGlzcGVsbC1hY2NlcHQtb3V0cHV0CiBJZiBhc3luY2hyb25vdXMg c3VicHJvY2Vzc2VzIGFyZSBub3Qgc3VwcG9ydGVkLCBjYWxsIGZ1bmN0aW9uIGBpc3BlbGwtZmls dGVyJwogYW5kIHBhc3MgaXQgdGhlIG91dHB1dCBvZiB0aGUgbGFzdCBJc3BlbGwgaW52b2NhdGlv bi4iCiAgIChpZiBpc3BlbGwtYXN5bmMtcHJvY2Vzc3AKLSAgICAgIChsZXQgKCh0aW1lb3V0IChp ZiB0aW1lb3V0LW1zZWNzCi0JCQkgKCsgKG9yIHRpbWVvdXQtc2VjcyAwKSAoLyB0aW1lb3V0LW1z ZWNzIDEwMDAuMCkpCi0JCSAgICAgICB0aW1lb3V0LXNlY3MpKSkKLQkoYWNjZXB0LXByb2Nlc3Mt b3V0cHV0IGlzcGVsbC1wcm9jZXNzIHRpbWVvdXQpKQorICAgICAgKGlmIChwcm9jZXNzLWxpdmUt cCBpc3BlbGwtcHJvY2VzcykKKyAgICAgICAobGV0ICgodGltZW91dCAoaWYgdGltZW91dC1tc2Vj cworCQkJICAoKyAob3IgdGltZW91dC1zZWNzIDApICgvIHRpbWVvdXQtbXNlY3MgMTAwMC4wKSkK KwkJICAgICAgICB0aW1lb3V0LXNlY3MpKSkKKwkgKGFjY2VwdC1wcm9jZXNzLW91dHB1dCBpc3Bl bGwtcHJvY2VzcyB0aW1lb3V0KSkKKyAgICAgICAoZXJyb3IgIk5vIElzcGVsbCBwcm9jZXNzIHRv IHJlYWQgb3V0cHV0IGZyb20hIikpCiAgICAgKGlmIChudWxsIGlzcGVsbC1wcm9jZXNzKQogCShl cnJvciAiTm8gSXNwZWxsIHByb2Nlc3MgdG8gcmVhZCBvdXRwdXQgZnJvbSEiKQogICAgICAgKGxl dCAoKGJ1ZiBpc3BlbGwtb3V0cHV0LWJ1ZmZlcikKQEAgLTE3OTMsNyArMTc5NSw4IEBAIGlzcGVs bC1zZW5kLXJlcGxhY2VtZW50CiAoZGVmdW4gaXNwZWxsLXNlbmQtc3RyaW5nIChzdHJpbmcpCiAg ICJTZW5kIHRoZSBzdHJpbmcgU1RSSU5HIHRvIHRoZSBJc3BlbGwgcHJvY2Vzcy4iCiAgIChpZiBp c3BlbGwtYXN5bmMtcHJvY2Vzc3AKLSAgICAgIChwcm9jZXNzLXNlbmQtc3RyaW5nIGlzcGVsbC1w cm9jZXNzIHN0cmluZykKKyAgICAgIChpZiAocHJvY2Vzcy1saXZlLXAgaXNwZWxsLXByb2Nlc3Mp CisgICAgICAgKHByb2Nlc3Mtc2VuZC1zdHJpbmcgaXNwZWxsLXByb2Nlc3Mgc3RyaW5nKSkKICAg ICA7OyBBc3luY2hyb25vdXMgc3VicHJvY2Vzc2VzIGFyZW4ndCBzdXBwb3J0ZWQgb24gdGhpcyBs b3Npbmcgc3lzdGVtLgogICAgIDs7IFdlIGtlZXAgYWxsIHRoZSBkaXJlY3RpdmVzIHBhc3NlZCB0 byBJc3BlbGwgZHVyaW5nIHRoZSBlbnRpcmUKICAgICA7OyBzZXNzaW9uIGluIGEgYnVmZmVyLCBh bmQgcGFzcyB0aGVtIGFuZXcgZWFjaCB0aW1lIHdlIGludm9rZQotLSAKMi4yNS4xCgo= --000000000000be687d05c5c5f084 Content-Type: text/x-patch; charset="US-ASCII"; name="0003-lisp-textmodes-ispell.el-Fix-finding-dictionaries-fo.patch" Content-Disposition: attachment; filename="0003-lisp-textmodes-ispell.el-Fix-finding-dictionaries-fo.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqfp40ai2 RnJvbSBlM2NkNTM2MWJlYTM2ZWNkOWMwMjZiY2E5M2ViM2UzODA5NzIxZTEwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFN1 biwgMjcgSnVuIDIwMjEgMjI6MDg6NDAgKzAxMDAKU3ViamVjdDogW1BBVENIIDMvM10gKiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWw6IEZpeCBmaW5kaW5nIGRpY3Rpb25hcmllcyBmb3IKIEVuY2hh bnQuCgooaXNwZWxsLWZpbmQtZW5jaGFudC1kaWN0aW9uYXJpZXMpOgoKSSBvcmlnaW5hbGx5IGNv cGllZCB0aGlzIGNvZGUgZnJvbSB0aGUgZXF1aXZhbGVudCBjb2RlIGZvcgpBc3BlbGwuIFVuZm9y dHVuYXRlbHkgaXQgd2FzIHdyb25nIGZvciB0aGUgY2FzZSBvZiBFbmNoYW50OiBpdCBzaG91bGQK ZmluZCBvbmx5IGRpY3Rpb25hcmllcyB0aGF0IEVuY2hhbnQga25vd3MgYWJvdXQsIGFuZCBub3Qg bWVyZ2UgaW4KYGlzcGVsbC1kaWN0aW9uYXJ5LWJhc2UtYWxpc3QnIG9yIGFkZCBhIGRlZmF1bHQg ZWxlbWVudCwgYXMgdGhlc2UKYXJlIGRlYWx0IHdpdGggaW4gYGlzcGVsbC1zZXQtc3BlbGxjaGVj a2VyLXBhcmFtcycuCgpUaGlzIGNhdXNlZCBhIGJ1ZyB3aGVyZSB0aGUgY29ycmVjdCBgLWQnIGFy Z3VtZW50IHdvdWxkIG5vdCBiZSBhZGRlZAp0byB0aGUgaW52b2NhdGlvbiBvZiBlbmNoYW50LCBs ZWFkaW5nIHRvIHRoZSBwcm9jZXNzIG5vdCBiZWluZwpjb3JyZWN0bHkgc3RhcnRlZC4KLS0tCiBs aXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwgfCAxMyArLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgMSBpbnNlcnRpb24oKyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdGV4 dG1vZGVzL2lzcGVsbC5lbCBiL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbAppbmRleCA4Yjc5OWIw OGMwLi41NTcwODAwNzc2IDEwMDY0NAotLS0gYS9saXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwKKysr IGIvbGlzcC90ZXh0bW9kZXMvaXNwZWxsLmVsCkBAIC0xMjExLDE4ICsxMjExLDcgQEAgaXNwZWxs LWZpbmQtZW5jaGFudC1kaWN0aW9uYXJpZXMKICAgICAgICAgICAgICAgICAgICAgYCgsbGFuZyAi W1s6YWxwaGE6XV0iICJbXls6YWxwaGE6XV0iCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LChpc3BlbGwtLWdldC1leHRyYS13b3JkLWNoYXJhY3RlcnMgbGFuZykgdCBuaWwgbmlsIHV0Zi04 KSkKICAgICAgICAgICAgICAgICAgIGRpY3Rpb25hcmllcykpKQotICAgIDs7IE1lcmdlIGludG8g Rk9VTkQgYW55IGVsZW1lbnRzIGZyb20gdGhlIHN0YW5kYXJkIGlzcGVsbC1kaWN0aW9uYXJ5LWJh c2UtYWxpc3QKLSAgICA7OyB3aGljaCBoYXZlIG5vIGVsZW1lbnQgaW4gRk9VTkQgYXQgYWxsLgot ICAgIChkb2xpc3QgKGRpY3QgaXNwZWxsLWRpY3Rpb25hcnktYmFzZS1hbGlzdCkKLSAgICAgICh1 bmxlc3MgKGFzc29jIChjYXIgZGljdCkgZm91bmQpCi0JKHNldHEgZm91bmQgKG5jb25jIGZvdW5k IChsaXN0IGRpY3QpKSkpKQotICAgIChzZXRxIGlzcGVsbC1lbmNoYW50LWRpY3Rpb25hcnktYWxp c3QgZm91bmQpCi0gICAgOzsgQWRkIGEgZGVmYXVsdCBlbnRyeQotICAgIChsZXQgKChkZWZhdWx0 LWRpY3QKLSAgICAgICAgICAgIGAobmlsICJbWzphbHBoYTpdXSIgIlteWzphbHBoYTpdXSIKLSAg ICAgICAgICAgICAgICAgICwoaXNwZWxsLS1nZXQtZXh0cmEtd29yZC1jaGFyYWN0ZXJzKQotICAg ICAgICAgICAgICAgICAgdCBuaWwgbmlsIHV0Zi04KSkpCi0gICAgICAocHVzaCBkZWZhdWx0LWRp Y3QgaXNwZWxsLWVuY2hhbnQtZGljdGlvbmFyeS1hbGlzdCkpKSkKKyAgICAoc2V0cSBpc3BlbGwt ZW5jaGFudC1kaWN0aW9uYXJ5LWFsaXN0IGZvdW5kKSkpCiAKIDs7IFNldCBwYXJhbXMgYWNjb3Jk aW5nIHRvIHRoZSBzZWxlY3RlZCBzcGVsbGNoZWNrZXIKIAotLSAKMi4yNS4xCgo= --000000000000be687d05c5c5f084 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-lisp-textmodes-ispell.el-ispell-word-Remove-a-redund.patch" Content-Disposition: attachment; filename="0001-lisp-textmodes-ispell.el-ispell-word-Remove-a-redund.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqfp40a50 RnJvbSBlMTJjOGE1MWNjZWU1Y2QyY2M4OWFlNTAzZDJjZTVhMDg1YjA1NTY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSZXViZW4gVGhvbWFzIDxycnRAc2MzZC5vcmc+CkRhdGU6IFN1 biwgMjcgSnVuIDIwMjEgMjI6MDQ6MTcgKzAxMDAKU3ViamVjdDogW1BBVENIIDEvM10gKiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWwgKGlzcGVsbC13b3JkKTogUmVtb3ZlIGEKIHJlZHVuZGFudCBj b21tZW50CgpSZW1vdmUgYSBjb21tZW50IG9mIHB1cmVseSBoaXN0b3JpY2FsIGludGVyZXN0LiAo SXQgcmVhZHMgbGlrZSBhCmNvbW1pdCBtZXNzYWdlLCBub3QgYSBjb21tZW50LikKLS0tCiBsaXNw L3RleHRtb2Rlcy9pc3BlbGwuZWwgfCAyIC0tCiAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9saXNwL3RleHRtb2Rlcy9pc3BlbGwuZWwgYi9saXNwL3RleHRtb2Rl cy9pc3BlbGwuZWwKaW5kZXggNGRiYzc2NDBiYy4uZTNjMWU2MTc3MiAxMDA2NDQKLS0tIGEvbGlz cC90ZXh0bW9kZXMvaXNwZWxsLmVsCisrKyBiL2xpc3AvdGV4dG1vZGVzL2lzcGVsbC5lbApAQCAt MTkxMSw4ICsxOTExLDYgQEAgaXNwZWxsLXdvcmQKIAkgICAgZW5kIChjYXIgKGNkciAoY2RyIHdv cmQpKSkKIAkgICAgd29yZCAoY2FyIHdvcmQpKQogCi0gICAgICA7OyBBdCB0aGlzIHBvaW50IGl0 IHVzZWQgdG8gaWdub3JlIDItbGV0dGVyIHdvcmRzLgotICAgICAgOzsgQnV0IHRoYXQgaXMgc2ls bHk7IGlmIHRoZSB1c2VyIGFza3MgZm9yIGl0LCB3ZSBzaG91bGQgZG8gaXQuIC0gcm1zLgogICAg ICAgKG9yIHF1aWV0bHkKIAkgIChtZXNzYWdlICJDaGVja2luZyBzcGVsbGluZyBvZiAlcy4uLiIK IAkJICAgKGZ1bmNhbGwgaXNwZWxsLWZvcm1hdC13b3JkLWZ1bmN0aW9uIHdvcmQpKSkKLS0gCjIu MjUuMQoK --000000000000be687d05c5c5f084-- ------------=_1624900382-26836-1--