From unknown Sun Jun 22 00:39:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 27 Jun 2021 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49244 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49244@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162481963331933 (code B ref -1); Sun, 27 Jun 2021 18:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2021 18:47:13 +0000 Received: from localhost ([127.0.0.1]:50392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxZoH-0008Iz-G5 for submit@debbugs.gnu.org; Sun, 27 Jun 2021 14:47:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:53854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxZoF-0008Ir-DW for submit@debbugs.gnu.org; Sun, 27 Jun 2021 14:47:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxZoF-0007Qv-11 for guix-patches@gnu.org; Sun, 27 Jun 2021 14:47:11 -0400 Received: from mira.cbaines.net ([212.71.252.8]:52278) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxZoD-0005YE-Bw for guix-patches@gnu.org; Sun, 27 Jun 2021 14:47:10 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 8888727BC78 for ; Sun, 27 Jun 2021 19:47:08 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 904f5623 for ; Sun, 27 Jun 2021 18:47:08 +0000 (UTC) From: Christopher Baines Date: Sun, 27 Jun 2021 19:47:08 +0100 Message-Id: <20210627184708.17496-1-mail@cbaines.net> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Follow up to 018f95094153660e3041ec160718f0bda286a3dc, as gcc on aarch64-linux doesn't seem to support -mstack-protector-guard=global. * gnu/packages/bootloaders.scm (grub-efi)[arguments]: Only add "--enable-stack-protector" to #:configure-flags when system is x86_64-linux. --- gnu/packages/bootloaders.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index e83f21ea63..1ff0348ac7 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -303,7 +303,10 @@ menu to select one of the installed operating systems.") ((#:tests? _ #f) #f) ((#:configure-flags flags ''()) `(cons* "--with-platform=efi" - "--enable-stack-protector" ; EFI-only for now + ,@(if (string=? (%current-system) + "x86_64-linux") + '("--enable-stack-protector") ; EFI-only for now + '()) ,flags)) ((#:phases phases) `(modify-phases ,phases -- 2.32.0 From unknown Sun Jun 22 00:39:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 29 Jun 2021 15:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49244 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 49244@debbugs.gnu.org Received: via spool by 49244-submit@debbugs.gnu.org id=B49244.16249809881234 (code B ref 49244); Tue, 29 Jun 2021 15:37:01 +0000 Received: (at 49244) by debbugs.gnu.org; 29 Jun 2021 15:36:28 +0000 Received: from localhost ([127.0.0.1]:55160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyFmm-0000Jp-10 for submit@debbugs.gnu.org; Tue, 29 Jun 2021 11:36:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyFmj-0000Ja-OX for 49244@debbugs.gnu.org; Tue, 29 Jun 2021 11:36:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57562) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyFme-0002Qt-BL; Tue, 29 Jun 2021 11:36:20 -0400 Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=49040 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyFme-0008Hv-1Q; Tue, 29 Jun 2021 11:36:20 -0400 From: Mathieu Othacehe References: <20210627184708.17496-1-mail@cbaines.net> Date: Tue, 29 Jun 2021 17:36:18 +0200 In-Reply-To: <20210627184708.17496-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 27 Jun 2021 19:47:08 +0100") Message-ID: <87wnqcvg25.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Chris, > + ,@(if (string=? (%current-system) > + "x86_64-linux") > + '("--enable-stack-protector") ; EFI-only for now > + '()) Maybe we should also avoid this option when cross-compiling? Otherwise it looks OK. Thanks, Mathieu From unknown Sun Jun 22 00:39:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49244] [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Jun 2021 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49244 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe , Christopher Baines Cc: 49244@debbugs.gnu.org Received: via spool by 49244-submit@debbugs.gnu.org id=B49244.162506610119783 (code B ref 49244); Wed, 30 Jun 2021 15:16:02 +0000 Received: (at 49244) by debbugs.gnu.org; 30 Jun 2021 15:15:01 +0000 Received: from localhost ([127.0.0.1]:58484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lybvZ-00058q-E1 for submit@debbugs.gnu.org; Wed, 30 Jun 2021 11:15:01 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:37500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lybvX-00058f-AH for 49244@debbugs.gnu.org; Wed, 30 Jun 2021 11:15:00 -0400 Received: from butterfly.local ([188.189.254.236]) by michel.telenet-ops.be with bizsmtp id PTEx2500156nx8C06TEx05; Wed, 30 Jun 2021 17:14:57 +0200 Message-ID: <0f7e68a422111e01388bc862d395b7a417be9c6e.camel@telenet.be> From: Maxime Devos Date: Wed, 30 Jun 2021 17:14:56 +0200 In-Reply-To: <87wnqcvg25.fsf@gnu.org> References: <20210627184708.17496-1-mail@cbaines.net> <87wnqcvg25.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-5SdFU8rz+AUJ1UTB+q27" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1625066097; bh=OVnqmX6QqDqA86lbkHXc/ytl9yeI7xL1UylYgUFwojg=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=sZj1h0WFA8Ku8VlRjh6m2l3ydVOpzvn8K4A5coeK/FKNCgTSdkJKsNK/s0D3sfX6s 4Y1eV/qSrI30pQ4Plzjwr9HmLEmF3JkC16DcmMcZnWa1TMMaXuHIG3DpUhYgdekma2 jQra5B+D7YrD4udLcJeEjrGVwTpB5Bvp66wdvIn1tEFPOX+SKDBmiu6xPqxiqmBtBZ Jp+esaOmpb4rBl4xt3W/Hji+QlUSjMKEMx1eIuE4koMTmLuV3Mz2OQLxQwmLPec6CE 1nS2MXYcOQzbuwZImZ2dTaj7Uq4pYr2RYmYit+DczFaSQR7bVvX3y5Z4ZGUYT64B3P FxXlZQOQ1IpRA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-5SdFU8rz+AUJ1UTB+q27 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mathieu Othacehe schreef op di 29-06-2021 om 17:36 [+0200]: > Hey Chris, >=20 > > + ,@(if (string=3D? (%current-system) > > + "x86_64-linux") > > + '("--enable-stack-protector") ; EFI-only for= now > > + '()) >=20 > Maybe we should also avoid this option when cross-compiling? Otherwise > it looks OK. Or rather, (string-prefix? (or (%current-target-system) (%current-system)) "x86_64") (or was it the other way around)? Greetings, Maxime. --=-5SdFU8rz+AUJ1UTB+q27 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYNyKcBccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7u1WAP9FP7OIOyH4y5AlbQCuSVT8KpKt x8fX340VMEPQFKglnQEAqESZxUWakBikMa35nvOr7KnY7RquLZW3IWjPVlJEhQY= =uspa -----END PGP SIGNATURE----- --=-5SdFU8rz+AUJ1UTB+q27-- From unknown Sun Jun 22 00:39:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Baines Subject: bug#49244: closed (Re: bug#49244: [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux.) Message-ID: References: <87bl7l7gst.fsf@cbaines.net> <20210627184708.17496-1-mail@cbaines.net> X-Gnu-PR-Message: they-closed 49244 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 49244@debbugs.gnu.org Date: Thu, 01 Jul 2021 23:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1625182262-2812-1" This is a multi-part message in MIME format... ------------=_1625182262-2812-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #49244: [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-li= nux. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 49244@debbugs.gnu.org. --=20 49244: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49244 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1625182262-2812-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 49244-done) by debbugs.gnu.org; 1 Jul 2021 23:31:01 +0000 Received: from localhost ([127.0.0.1]:33823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz697-0000jA-4E for submit@debbugs.gnu.org; Thu, 01 Jul 2021 19:31:01 -0400 Received: from mira.cbaines.net ([212.71.252.8]:38622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lz695-0000j0-Bg for 49244-done@debbugs.gnu.org; Thu, 01 Jul 2021 19:30:59 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id EB9D527BC78; Fri, 2 Jul 2021 00:30:58 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id f64e81a8; Thu, 1 Jul 2021 23:30:58 +0000 (UTC) References: <20210627184708.17496-1-mail@cbaines.net> <87wnqcvg25.fsf@gnu.org> User-agent: mu4e 1.4.15; emacs 27.2 From: Christopher Baines To: 49244-done@debbugs.gnu.org Subject: Re: bug#49244: [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux. In-reply-to: <87wnqcvg25.fsf@gnu.org> Date: Fri, 02 Jul 2021 00:30:58 +0100 Message-ID: <87bl7l7gst.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49244-done Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Mathieu Othacehe writes: > Hey Chris, > >> + ,@(if (string=? (%current-system) >> + "x86_64-linux") >> + '("--enable-stack-protector") ; EFI-only for now >> + '()) > > Maybe we should also avoid this option when cross-compiling? Otherwise > it looks OK. Yeah, I was trying to test the cross-compiling case, but I think something else fails regardless. Anyway, I've pushed something similar to what Maxime suggested as fd549750d9ab23a0505aeb4c03e1299e860a4f16. Thanks, CHris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmDeUDJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfTvRAArvUa/oqYKDsDE7OqR0vraMEXuHuQ/f9W 6k0QSI/ltmw4Hb1YLaW2i2vzUWmIFAQOBCDETnesxf0Xgcn/cDtptY1p/s828huF WvQ2Vnd2coHLUoLquasQiAIJSUnQlqoW3cgHlE7XtvVhcJolyzPA3JGxZebVeA4I wNGfI6a5h8sYp2dTOjwOSG8Ul2g4SHPG9AKERpHDYZS1j833sBYXOd6QKWDTSEn9 RSlDrf+W61A7BPWpgVIYMnQLscW3hfhMuN2O3j+JqrUZer6/olcLKLQcprwIMA0W 7yi/6flYF7e8DiuDJHLrGcLKpNg65PkhHsKZvjoqo5gpzd4fQ75fU+a7Z8vQI9i0 R/KR8PAow1oJL4Wjstg5CcQrwCs2bjEpoi+GpY6Yyu77/TwjXp/fN8mJ3deDKbiD BncvbcDMei38DSTpw3AggVd1+5MVtHzqbvQMc61k59xHKPf3zfz5WkAS7fDGQ/UG zD7mTpGgi7DphokcMNoGPHAqa+FV93ba7lMoNc3PxR3tDFrVHFnpOOX4yX8kl9hV h6Dfhm25ojIKhMPJTPp8MsmtP+coA2xNOrDEKE+h/WorH7xytah25zfBm2UGZAPY +ozQM22U0rn1ZnKLTgZpnVXHYipXsqUaQ/Nq2aIodKYPsrBDEAScrDI8kWqsakak QBJBKEVYyZQ= =PjIa -----END PGP SIGNATURE----- --=-=-=-- ------------=_1625182262-2812-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Jun 2021 18:47:13 +0000 Received: from localhost ([127.0.0.1]:50392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxZoH-0008Iz-G5 for submit@debbugs.gnu.org; Sun, 27 Jun 2021 14:47:13 -0400 Received: from lists.gnu.org ([209.51.188.17]:53854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxZoF-0008Ir-DW for submit@debbugs.gnu.org; Sun, 27 Jun 2021 14:47:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxZoF-0007Qv-11 for guix-patches@gnu.org; Sun, 27 Jun 2021 14:47:11 -0400 Received: from mira.cbaines.net ([212.71.252.8]:52278) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxZoD-0005YE-Bw for guix-patches@gnu.org; Sun, 27 Jun 2021 14:47:10 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:8ac0:b4c7:f5c8:7caa]) by mira.cbaines.net (Postfix) with ESMTPSA id 8888727BC78 for ; Sun, 27 Jun 2021 19:47:08 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 904f5623 for ; Sun, 27 Jun 2021 18:47:08 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] gnu: grub-efi: Only enable the stack protector on x86_64-linux. Date: Sun, 27 Jun 2021 19:47:08 +0100 Message-Id: <20210627184708.17496-1-mail@cbaines.net> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Follow up to 018f95094153660e3041ec160718f0bda286a3dc, as gcc on aarch64-linux doesn't seem to support -mstack-protector-guard=global. * gnu/packages/bootloaders.scm (grub-efi)[arguments]: Only add "--enable-stack-protector" to #:configure-flags when system is x86_64-linux. --- gnu/packages/bootloaders.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index e83f21ea63..1ff0348ac7 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -303,7 +303,10 @@ menu to select one of the installed operating systems.") ((#:tests? _ #f) #f) ((#:configure-flags flags ''()) `(cons* "--with-platform=efi" - "--enable-stack-protector" ; EFI-only for now + ,@(if (string=? (%current-system) + "x86_64-linux") + '("--enable-stack-protector") ; EFI-only for now + '()) ,flags)) ((#:phases phases) `(modify-phases ,phases -- 2.32.0 ------------=_1625182262-2812-1--