From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Jun 2021 16:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 49243@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162480975015778 (code B ref -1); Sun, 27 Jun 2021 16:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2021 16:02:30 +0000 Received: from localhost ([127.0.0.1]:50328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxXEm-00046G-CR for submit@debbugs.gnu.org; Sun, 27 Jun 2021 12:02:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:47104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxXEk-000467-LD for submit@debbugs.gnu.org; Sun, 27 Jun 2021 12:02:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxXEk-00086W-9J for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 12:02:22 -0400 Received: from mail.choca.pics ([80.67.172.235]:54632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxXEd-0001Ue-AG for bug-gnu-emacs@gnu.org; Sun, 27 Jun 2021 12:02:21 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id A75EA18064A1B for ; Sun, 27 Jun 2021 18:02:03 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id dW2VTd1a1mDx for ; Sun, 27 Jun 2021 18:02:02 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 2107618197CDF for ; Sun, 27 Jun 2021 18:02:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id fYJbikBRyQiS for ; Sun, 27 Jun 2021 18:02:01 +0200 (CEST) Received: from localhost (199.138.120.78.rev.sfr.net [78.120.138.199]) by mail.choca.pics (Postfix) with ESMTPSA id C244D18064A1A for ; Sun, 27 Jun 2021 18:02:01 +0200 (CEST) From: Damien Cassou Date: Sun, 27 Jun 2021 18:02:01 +0200 Message-ID: <87h7hjjnye.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=80.67.172.235; envelope-from=damien@cassou.me; helo=mail.choca.pics X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) --=-=-= Content-Type: text/plain Hi, please find attached a few patches for auth-source-pass that were merged upstream. Damien Cassou (2): ; * lisp/auth-source-pass.el: Improve docstrings ; * lisp/auth-source-pass.el: Remove useless metadata Iku Iwasa (1): lisp/auth-source-pass.el: Support multiple hosts in search spec Tino Calancha (1): lisp/auth-source-pass.el: Keep legitimate spaces inside data lisp/auth-source-pass.el | 61 ++++++++++++++++------------- test/lisp/auth-source-pass-tests.el | 24 +++++++++++- 2 files changed, 57 insertions(+), 28 deletions(-) -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-lisp-auth-source-pass.el-Support-multiple-hosts-in-s.patch >From 622955a93036328d06daae4779299d53eb3115af Mon Sep 17 00:00:00 2001 From: Iku Iwasa Date: Sun, 27 Jun 2021 17:36:00 +0200 Subject: [PATCH 1/4] lisp/auth-source-pass.el: Support multiple hosts in search spec * lisp/auth-source-pass.el (auth-source-pass-search): Accept a list of strings for argument HOST. (auth-source-pass--build-result): Rename argument HOST to HOSTS. Also return value "host" from entry if it exists. (auth-source-pass--find-match): Rename argument HOST to HOSTS. Iterate over each host in HOSTS. * test/lisp/auth-source-pass-tests.el: Add corresponding tests --- lisp/auth-source-pass.el | 40 ++++++++++++++++++----------- test/lisp/auth-source-pass-tests.el | 18 ++++++++++++- 2 files changed, 42 insertions(+), 16 deletions(-) diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el index a7b959c47f..6e33970486 100644 --- a/lisp/auth-source-pass.el +++ b/lisp/auth-source-pass.el @@ -61,13 +61,12 @@ auth-source-pass-search &key backend type host user port &allow-other-keys) "Given a property list SPEC, return search matches from the :backend. -See `auth-source-search' for details on SPEC." +See `auth-source-search' for details on SPEC. + +HOST can be a string or a list of strings, but USER and PORT are expected +to be a string only." (cl-assert (or (null type) (eq type (oref backend type))) t "Invalid password-store search: %s %s") - (when (consp host) - (warn "auth-source-pass ignores all but first host in spec.") - ;; Take the first non-nil item of the list of hosts - (setq host (seq-find #'identity host))) (cond ((eq host t) (warn "auth-source-pass does not handle host wildcards.") nil) @@ -78,12 +77,14 @@ auth-source-pass-search (when-let ((result (auth-source-pass--build-result host port user))) (list result))))) -(defun auth-source-pass--build-result (host port user) - "Build auth-source-pass entry matching HOST, PORT and USER." - (let ((entry-data (auth-source-pass--find-match host user port))) +(defun auth-source-pass--build-result (hosts port user) + "Build auth-source-pass entry matching HOSTS, PORT and USER. + +HOSTS can be a string or a list of strings." + (let ((entry-data (auth-source-pass--find-match hosts user port))) (when entry-data (let ((retval (list - :host host + :host (auth-source-pass--get-attr "host" entry-data) :port (or (auth-source-pass--get-attr "port" entry-data) port) :user (or (auth-source-pass--get-attr "user" entry-data) user) :secret (lambda () (auth-source-pass--get-attr 'secret entry-data))))) @@ -194,12 +195,21 @@ auth-source-pass-entries (lambda (file) (file-name-sans-extension (file-relative-name file store-dir))) (directory-files-recursively store-dir "\\.gpg\\'")))) -(defun auth-source-pass--find-match (host user port) - "Return password-store entry data matching HOST, USER and PORT. - -Disambiguate between user provided inside HOST (e.g., user@server.com) and -inside USER by giving priority to USER. Same for PORT." - (apply #'auth-source-pass--find-match-unambiguous (auth-source-pass--disambiguate host user port))) +(defun auth-source-pass--find-match (hosts user port) + "Return password-store entry data matching HOSTS, USER and PORT. + +Disambiguate between user provided inside HOSTS (e.g., user@server.com) and +inside USER by giving priority to USER. Same for PORT. +HOSTS can be a string or a list of strings." + (seq-some (lambda (host) + (let ((entry (apply #'auth-source-pass--find-match-unambiguous + (auth-source-pass--disambiguate host user port)))) + (if (or (null entry) (assoc "host" entry)) + entry + (cons (cons "host" host) entry)))) + (if (listp hosts) + hosts + (list hosts)))) (defun auth-source-pass--disambiguate (host &optional user port) "Return (HOST USER PORT) after disambiguation. diff --git a/test/lisp/auth-source-pass-tests.el b/test/lisp/auth-source-pass-tests.el index bfbef53db9..a2f84f20e8 100644 --- a/test/lisp/auth-source-pass-tests.el +++ b/test/lisp/auth-source-pass-tests.el @@ -424,21 +424,37 @@ auth-source-pass-build-result-return-parameters (auth-source-pass--with-store-find-foo '(("foo" ("secret" . "foo password"))) (let ((result (auth-source-pass--build-result "foo" 512 "user"))) + (should (equal (plist-get result :host) "foo")) (should (equal (plist-get result :port) 512)) (should (equal (plist-get result :user) "user"))))) (ert-deftest auth-source-pass-build-result-return-entry-values () (auth-source-pass--with-store-find-foo '(("foo" ("port" . 512) ("user" . "anuser"))) (let ((result (auth-source-pass--build-result "foo" nil nil))) + (should (equal (plist-get result :host) "foo")) (should (equal (plist-get result :port) 512)) (should (equal (plist-get result :user) "anuser"))))) (ert-deftest auth-source-pass-build-result-entry-takes-precedence () - (auth-source-pass--with-store-find-foo '(("foo" ("port" . 512) ("user" . "anuser"))) + (auth-source-pass--with-store-find-foo '(("foo" ("host" . "bar") ("port" . 512) ("user" . "anuser"))) (let ((result (auth-source-pass--build-result "foo" 1024 "anotheruser"))) + (should (equal (plist-get result :host) "bar")) (should (equal (plist-get result :port) 512)) (should (equal (plist-get result :user) "anuser"))))) +(ert-deftest auth-source-pass-build-result-with-multiple-hosts () + (auth-source-pass--with-store-find-foo + '(("foo" ("secret" . "foo password"))) + (let ((result (auth-source-pass--build-result '("bar" "foo") 512 "user"))) + (should (equal (plist-get result :host) "foo")) + (should (equal (plist-get result :port) 512)) + (should (equal (plist-get result :user) "user"))))) + +(ert-deftest auth-source-pass-build-result-with-multiple-hosts-no-match () + (auth-source-pass--with-store-find-foo + '(("foo" ("secret" . "foo password"))) + (should-not (auth-source-pass--build-result '("bar" "baz") 512 "user")))) + (ert-deftest auth-source-pass-can-start-from-auth-source-search () (auth-source-pass--with-store '(("gitlab.com" ("user" . "someone"))) (auth-source-pass-enable) -- 2.31.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-lisp-auth-source-pass.el-Improve-docstrings.patch >From a65fe185e40fce68d7fdb7735b6e7effae31d0ee Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Sun, 27 Jun 2021 17:38:59 +0200 Subject: [PATCH 2/4] ; * lisp/auth-source-pass.el: Improve docstrings --- lisp/auth-source-pass.el | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el index 6e33970486..0f8be84dc2 100644 --- a/lisp/auth-source-pass.el +++ b/lisp/auth-source-pass.el @@ -60,11 +60,10 @@ auth-source-pass-port-separator (cl-defun auth-source-pass-search (&rest spec &key backend type host user port &allow-other-keys) - "Given a property list SPEC, return search matches from the :backend. -See `auth-source-search' for details on SPEC. + "Given some search query, return matching credentials. -HOST can be a string or a list of strings, but USER and PORT are expected -to be a string only." +See `auth-source-search' for details on the parameters SPEC, BACKEND, TYPE, +HOST, USER and PORT." (cl-assert (or (null type) (eq type (oref backend type))) t "Invalid password-store search: %s %s") (cond ((eq host t) @@ -126,7 +125,7 @@ auth-source-pass-get The key used to retrieve the password is the symbol `secret'. The convention used as the format for a password-store file is -the following (see https://www.passwordstore.org/#organization): +the following (see URL `https://www.passwordstore.org/#organization'): secret key1: value1 @@ -278,7 +277,7 @@ auth-source-pass--entries-matching-suffix (defun auth-source-pass--generate-entry-suffixes (hostname user port) "Return a list of possible entry path suffixes in the password-store. -Based on the supported pathname patterns for HOSTNAME, USER, & +Based on the supported filename patterns for HOSTNAME, USER, & PORT, return a list of possible suffixes for matching entries in the password-store. @@ -326,3 +325,5 @@ auth-source-pass--name-port-user-suffixes (provide 'auth-source-pass) ;;; auth-source-pass.el ends here + +;; LocalWords: backend hostname -- 2.31.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0003-lisp-auth-source-pass.el-Remove-useless-metadata.patch >From 228647fdd051b3874561659d02f2f31d15b3c620 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Sun, 27 Jun 2021 17:51:54 +0200 Subject: [PATCH 3/4] ; * lisp/auth-source-pass.el: Remove useless metadata --- lisp/auth-source-pass.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el index 0f8be84dc2..c512c6fe4f 100644 --- a/lisp/auth-source-pass.el +++ b/lisp/auth-source-pass.el @@ -6,8 +6,6 @@ ;; Nicolas Petton ;; Keith Amidon ;; Version: 5.0.0 -;; Package-Requires: ((emacs "25")) -;; Url: https://github.com/DamienCassou/auth-password-store ;; Created: 07 Jun 2015 ;; This file is part of GNU Emacs. -- 2.31.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0004-lisp-auth-source-pass.el-Keep-legitimate-spaces-insi.patch >From 57f564556374f892a93c7879bc2629da8f58cb23 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Sun, 27 Jun 2021 17:53:30 +0200 Subject: [PATCH 4/4] lisp/auth-source-pass.el: Keep legitimate spaces inside data Users should be able to store a field as follows: message: remember: Destroy the image and you will break the enemy and later, recover the message untouched, i.e.: "remember: Destroy the image and you will break the enemy" * lisp/auth-source-pass.el (auth-source-pass--parse-data): Preserve inner spaces at data. * test/lisp/auth-source-pass-tests.el (auth-source-pass-parse-with-colons-in-data): Add test. --- lisp/auth-source-pass.el | 12 +++++------- test/lisp/auth-source-pass-tests.el | 6 ++++++ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el index c512c6fe4f..914f8d2f1b 100644 --- a/lisp/auth-source-pass.el +++ b/lisp/auth-source-pass.el @@ -167,15 +167,13 @@ auth-source-pass--parse-secret (defun auth-source-pass--parse-data (contents) "Parse the password-store data in the string CONTENTS and return an alist. CONTENTS is the contents of a password-store formatted file." - (let ((lines (split-string contents "\n" t "[ \t]+"))) + (let ((lines (cdr (split-string contents "\n" t "[ \t]+")))) (seq-remove #'null (mapcar (lambda (line) - (let ((pair (mapcar (lambda (s) (string-trim s)) - (split-string line ":")))) - (when (> (length pair) 1) - (cons (car pair) - (mapconcat #'identity (cdr pair) ":"))))) - (cdr lines))))) + (when-let ((pos (seq-position line ?:))) + (cons (string-trim (substring line 0 pos)) + (string-trim (substring line (1+ pos)))))) + lines)))) (defun auth-source-pass--do-debug (&rest msg) "Call `auth-source-do-debug` with MSG and a prefix." diff --git a/test/lisp/auth-source-pass-tests.el b/test/lisp/auth-source-pass-tests.el index a2f84f20e8..d050ac5b69 100644 --- a/test/lisp/auth-source-pass-tests.el +++ b/test/lisp/auth-source-pass-tests.el @@ -49,6 +49,12 @@ auth-source-pass-parse-with-trailing-spaces '(("key1" . "val1") ("key2" . "val2")))))) +(ert-deftest auth-source-pass-parse-with-colons-in-data () + (let ((content "pass\n--\nkey1 :val1\nkey2: please: keep my space after colon\n\n")) + (should (equal (auth-source-pass--parse-data content) + '(("key1" . "val1") + ("key2" . "please: keep my space after colon")))))) + (defvar auth-source-pass--debug-log nil "Contains a list of all messages passed to `auth-source-do-debug`.") -- 2.31.1 --=-=-=-- From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jun 2021 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Damien Cassou Cc: 49243@debbugs.gnu.org Received: via spool by 49243-submit@debbugs.gnu.org id=B49243.162488572525509 (code B ref 49243); Mon, 28 Jun 2021 13:09:02 +0000 Received: (at 49243) by debbugs.gnu.org; 28 Jun 2021 13:08:45 +0000 Received: from localhost ([127.0.0.1]:51268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxr0H-0006dN-EV for submit@debbugs.gnu.org; Mon, 28 Jun 2021 09:08:45 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:45590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxr0E-0006d3-AK for 49243@debbugs.gnu.org; Mon, 28 Jun 2021 09:08:43 -0400 Received: by mail-wm1-f47.google.com with SMTP id u8-20020a7bcb080000b02901e44e9caa2aso11061829wmj.4 for <49243@debbugs.gnu.org>; Mon, 28 Jun 2021 06:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=/+RPYutFY/hm0/WZizcP+MKv7XhexF9Nsii8Uyhazpk=; b=atFTf4guXQ7ODsnSz6ZwlCt4ijWyzXp/Avexplo4/M9FKvqmx+GI1Dowuh/83Fa+4e tvkyPKuG2i/DErCoyEpBeztkCUzzjvQFPiqAzJNtWhV7D9uGrmFPEZ5s1uYapDrUk+yE UxgfWsZ9SQ6xLx0RQsTNqgOXzFoYZDkYutyfNbfhxTaicPQOzrSGyjZCQsR5kbIG6eYD kPwDQdII7edS40l42fZQvKl71Ef0Of6j8bpFMvIXPfVqSB141EiZlHY5Ackasifqdwda Hjxa5oxlS88emtH/8TCWFAe1edo5Zs4s6osNoPBgOmjZeKo8IAXTxftro8sv2CZrnx0/ c8NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=/+RPYutFY/hm0/WZizcP+MKv7XhexF9Nsii8Uyhazpk=; b=A0zdEu6HI0XaYvT8U5nbA/wBjCuRLLe6brhxl7/qGHeaWXN1rfNYeViiF3n9qJboEw rGRvgHvDmqXQagA/K4GB91Ku8cmANCd5uFT/puZI7mpGQIPFOzLo9MjcmHKSr3mIu+L+ qV+F1pdDFbq+Oxx45ol6tgksNKn34/5gSmH3fOncV7GNgVL4T8qyxU3N/O77lCb6mkR6 DjUeES0AUwc5QtTEIN6DJC4er+a43M5rnEpGaatKlxE0f3hm3LcDwPhq9nvh5dS9GEAn clOIuVjwJ+DqdwhrFe/AE5u848bMVpVzGLfWOm90KlRb9NSlN7ysb9Ai27Nq6ZJdCO+W XSHQ== X-Gm-Message-State: AOAM533ASmJShP56PQPD6ugewFVEmMg9zKyqmZIAn1WBq6DW81ie9Dd4 cI4UKXLy5rOqYPnlxg0YwwwEFYsZ3Bw= X-Google-Smtp-Source: ABdhPJz4U1+70QuH++GovDtRadQEWAMm3xtGjcIPGk3S+uj2uOZfVNJDW6f2dVc878Jazi1C9h5dbQ== X-Received: by 2002:a05:600c:21c4:: with SMTP id x4mr26437778wmj.30.1624885716167; Mon, 28 Jun 2021 06:08:36 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id x81sm22320774wmg.36.2021.06.28.06.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 06:08:35 -0700 (PDT) From: Robert Pluim References: <87h7hjjnye.fsf@cassou.me> Date: Mon, 28 Jun 2021 15:08:34 +0200 In-Reply-To: <87h7hjjnye.fsf@cassou.me> (Damien Cassou's message of "Sun, 27 Jun 2021 18:02:01 +0200") Message-ID: <87o8bqdtm5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sun, 27 Jun 2021 18:02:01 +0200, Damien Cassou said: Damien> Hi, Damien> please find attached a few patches for auth-source-pass that were merged Damien> upstream. Damien> Damien Cassou (2): Damien> ; * lisp/auth-source-pass.el: Improve docstrings Damien> ; * lisp/auth-source-pass.el: Remove useless metadata Damien> Iku Iwasa (1): Damien> lisp/auth-source-pass.el: Support multiple hosts in search spec Hmm, if auth-source-search supports multiple hosts, it would be good if that were documented in the info manual. Robert -- From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Damien Cassou Cc: 49243@debbugs.gnu.org Received: via spool by 49243-submit@debbugs.gnu.org id=B49243.16250585634506 (code B ref 49243); Wed, 30 Jun 2021 13:10:02 +0000 Received: (at 49243) by debbugs.gnu.org; 30 Jun 2021 13:09:23 +0000 Received: from localhost ([127.0.0.1]:56765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyZxz-0001Ac-8a for submit@debbugs.gnu.org; Wed, 30 Jun 2021 09:09:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyZxx-0001AK-8H for 49243@debbugs.gnu.org; Wed, 30 Jun 2021 09:09:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=t3iHN2bbmu4ItcDUTTxqyM9zMcsKIpf6dyK9byk/bic=; b=RMmOu0QBaAqEjXrDmFhKh7LgZ2 Ye/713B/9gdPe+5qm9cpSoalMJ7i44hO/OqwHqqyEPy/WKkr4QHQAAgb0P28H/tzYviznmfV6REw6 gA/R9rR1wjx4wb4vPX+shzhspdIS3Nc3mFyeyTbhW5QpPL+I3mELwXJjaYDpXaURn8Cw=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyZxo-0001wG-56; Wed, 30 Jun 2021 15:09:14 +0200 From: Lars Ingebrigtsen References: <87h7hjjnye.fsf@cassou.me> X-Now-Playing: Jim O'Rourke's _To Magnetize Money and Return a Roving Eye (2)_: "To Magnetize Money and Return a Roving Eye pt2" Date: Wed, 30 Jun 2021 15:09:11 +0200 In-Reply-To: <87h7hjjnye.fsf@cassou.me> (Damien Cassou's message of "Sun, 27 Jun 2021 18:02:01 +0200") Message-ID: <87eecj7b48.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Damien Cassou writes: > please find attached a few patches for auth-source-pass that were merged > upstream. Thanks; looks good to me. You can still push directly to Emacs, I think? Or do you want me to apply the patches? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Damien Cassou writes: > please find attached a few patches for auth-source-pass that were merged > upstream. Thanks; looks good to me. You can still push directly to Emacs, I think? Or do you want me to apply the patches? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 16:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 49243@debbugs.gnu.org Received: via spool by 49243-submit@debbugs.gnu.org id=B49243.162506937625178 (code B ref 49243); Wed, 30 Jun 2021 16:10:02 +0000 Received: (at 49243) by debbugs.gnu.org; 30 Jun 2021 16:09:36 +0000 Received: from localhost ([127.0.0.1]:58575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lycmO-0006Y2-E8 for submit@debbugs.gnu.org; Wed, 30 Jun 2021 12:09:36 -0400 Received: from mail.choca.pics ([80.67.172.235]:55374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lycmN-0006Xu-2T for 49243@debbugs.gnu.org; Wed, 30 Jun 2021 12:09:35 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id B95E5181A5050; Wed, 30 Jun 2021 18:09:33 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id zVDjxZBlYDbA; Wed, 30 Jun 2021 18:09:33 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 392DA18197CC5; Wed, 30 Jun 2021 18:09:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id Be9C5KdLUhzL; Wed, 30 Jun 2021 18:09:33 +0200 (CEST) Received: from localhost (199.138.120.78.rev.sfr.net [78.120.138.199]) by mail.choca.pics (Postfix) with ESMTPSA id EF24818190F49; Wed, 30 Jun 2021 18:09:32 +0200 (CEST) From: Damien Cassou In-Reply-To: <87eecj7b48.fsf@gnus.org> References: <87h7hjjnye.fsf@cassou.me> <87eecj7b48.fsf@gnus.org> Date: Wed, 30 Jun 2021 18:09:32 +0200 Message-ID: <87y2aribb7.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Thanks; looks good to me. You can still push directly to Emacs, I > think? Or do you want me to apply the patches? I would feel safer if you do it for me :-). > Hmm, if auth-source-search supports multiple hosts, it would be good > if that were documented in the info manual. not sure because supporting only one host was a bug: auth-source-pass wasn't implementing the auth-source protocol correctly. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 17:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Damien Cassou Cc: Lars Ingebrigtsen , 49243@debbugs.gnu.org Received: via spool by 49243-submit@debbugs.gnu.org id=B49243.16250757932749 (code B ref 49243); Wed, 30 Jun 2021 17:57:01 +0000 Received: (at 49243) by debbugs.gnu.org; 30 Jun 2021 17:56:33 +0000 Received: from localhost ([127.0.0.1]:58707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyeRt-0000iH-98 for submit@debbugs.gnu.org; Wed, 30 Jun 2021 13:56:33 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]:38647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyeRq-0000i3-Vr for 49243@debbugs.gnu.org; Wed, 30 Jun 2021 13:56:31 -0400 Received: by mail-wr1-f45.google.com with SMTP id u6so4705880wrs.5 for <49243@debbugs.gnu.org>; Wed, 30 Jun 2021 10:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=Z7+SkDvXu+GvbcU57FvU3DAkjGOMqlFlOLqnTPYs1Y0=; b=Pth29l6xfsixjWMG3EK5We/ms+/jmhf4qesSTB8A+sZYg0/KOTM0cneXNCR+Qng01l q5WV7vb8VpM4L3TZpsObAG6qYwmfujEYViWYz3yIZXiBUbXJUXIdzdgJXSA5KifbY9KC G5o/H/ByExWb7a0HIw8tMj9X77vVfH0XoJBvJLJGvKX3CvXqbzKN1gcnpsQWDsm6NuUV OSYAziMOCs1F+3/HHCKNcJvALuCYw/t22YPiwsboc2D/J1mkISmkUfHKYZjgj662JvaZ HbKhpYe/FjSSi5zDXec5RNa4eT88qdm+ZcPblqqZJ2dEAvWkHolZS6LZNvuIkYwR6u5r S8Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=Z7+SkDvXu+GvbcU57FvU3DAkjGOMqlFlOLqnTPYs1Y0=; b=HEiDyitUkPj6XigdHGnsgm27ryS8fxFWtDq2Q+ODnAr1mU8n8huRFK4YsRIDLPlUd3 oGCHYv9ll7kSVjAv0FFqK+lYztoGY95Xt+359dBy6FL5eePQZNcpEpKOyYtItB3zDAKR QBVHIe6Fo/O4yzQbWQ+HKXLZpiOaS0uFlr1afhHvm7KyLeQDfw/B1sx/4dCLsvgKQICt gNwrJexDhF0vj1BzOIOJeuGzGL6xYLWbuu2J1rAR9TCo0Wt4T4NK/uDiFEL5KJ9tyKnE sz3EJOXw7N0iheS4floxX5mNH1+KgU0RVg9S/HePVHQQB7z4cFU0vWNGX7fbHdavZ1RR 2cQg== X-Gm-Message-State: AOAM533kOs50TcHd+nNHsOV7P7j4CBSurJyXBnbS16Qz43hGZWBTNdl9 T5mxQIcOhS9PcCaOfBrf1mR0AnXrCj4= X-Google-Smtp-Source: ABdhPJzeMkhzsGSgg8lkJM2lxP5KImztkMyKyl4TFKJ4EAGpH7RIEXfoaZuEd8hLSmExru9LApv//g== X-Received: by 2002:a5d:4486:: with SMTP id j6mr41025387wrq.174.1625075784751; Wed, 30 Jun 2021 10:56:24 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id y3sm23056486wru.78.2021.06.30.10.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Jun 2021 10:56:24 -0700 (PDT) From: Robert Pluim References: <87h7hjjnye.fsf@cassou.me> <87eecj7b48.fsf@gnus.org> <87y2aribb7.fsf@cassou.me> Date: Wed, 30 Jun 2021 19:56:23 +0200 In-Reply-To: <87y2aribb7.fsf@cassou.me> (Damien Cassou's message of "Wed, 30 Jun 2021 18:09:32 +0200") Message-ID: <87v95vck3c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 30 Jun 2021 18:09:32 +0200, Damien Cassou = said: Damien> Lars Ingebrigtsen writes: >> Thanks; looks good to me. You can still push directly to Emacs, I >> think? Or do you want me to apply the patches? Damien> I would feel safer if you do it for me :-). >> Hmm, if auth-source-search supports multiple hosts, it would be good >> if that were documented in the info manual. Damien> not sure because supporting only one host was a bug: auth-sourc= e-pass Damien> wasn't implementing the auth-source protocol correctly. That last bit was me, not Lars. I was trying to nudge you to go look at the 'developers' section of the auth-source info manual and bring its documentation in line with the implementation, since it currently doesn=CA=BCt say anything about multiple hosts. Robert --=20 From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jul 2021 10:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Damien Cassou Cc: 49243@debbugs.gnu.org Received: via spool by 49243-submit@debbugs.gnu.org id=B49243.162522326414881 (code B ref 49243); Fri, 02 Jul 2021 10:55:02 +0000 Received: (at 49243) by debbugs.gnu.org; 2 Jul 2021 10:54:24 +0000 Received: from localhost ([127.0.0.1]:35034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzGoS-0003rx-Ic for submit@debbugs.gnu.org; Fri, 02 Jul 2021 06:54:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzGoQ-0003ri-UL for 49243@debbugs.gnu.org; Fri, 02 Jul 2021 06:54:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wmPE+7kFQymo60YgZHEttT4ScK2hT7uABU83j4H0P+A=; b=TX7H6CtC1Fj9zZi4ee8p62+b8d yeRj2O2VPNzJVaGGV2H/GOJAy2e97LcCh3tAywM7MLoU1CTAXwma4UkdeR9sgcd8ZZQ4IukG4QfJ7 ZFrCvwiJ0hnzuwi73PhZwlPW/aigHakypoakPis8p01rqonDfcAe0ZjdVUCW4lUkzn00=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzGoH-0007rd-Iq; Fri, 02 Jul 2021 12:54:16 +0200 From: Lars Ingebrigtsen References: <87h7hjjnye.fsf@cassou.me> <87eecj7b48.fsf@gnus.org> <87y2aribb7.fsf@cassou.me> X-Now-Playing: Military Genius's _The Wire Tapper 52_: "L.M.G.D." Date: Fri, 02 Jul 2021 12:54:13 +0200 In-Reply-To: <87y2aribb7.fsf@cassou.me> (Damien Cassou's message of "Wed, 30 Jun 2021 18:09:32 +0200") Message-ID: <87k0m9vve2.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Damien Cassou writes: > Lars Ingebrigtsen writes: >> Thanks; looks good to me. You can still push directly to Emacs, I >> think? Or do you want me to apply the patches? > > I would feel safer if you do it [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Damien Cassou writes: > Lars Ingebrigtsen writes: >> Thanks; looks good to me. You can still push directly to Emacs, I >> think? Or do you want me to apply the patches? > > I would feel safer if you do it for me :-). Sure; no prob. :-) Pushed now to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 02 06:54:49 2021 Received: (at control) by debbugs.gnu.org; 2 Jul 2021 10:54:49 +0000 Received: from localhost ([127.0.0.1]:35037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzGoq-0003sZ-Qr for submit@debbugs.gnu.org; Fri, 02 Jul 2021 06:54:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzGoa-0003s7-D2 for control@debbugs.gnu.org; Fri, 02 Jul 2021 06:54:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jbPnnP87685pk/gaiOHGp6D+uGlkliQcxMrLFSzS7II=; b=BSjhMQz/hMwhNCBLoLQbJQ/hzA Gu1fUvNe9zG+gPQey9DD0GpXP/ixmSNWb7IQJI6nsOrMf5yEwWf5Jym+b819c5o/bJWSqatJ+PSJc MgmffeDg8HTZHP+ckF0TDxCiRsf9ryHK20RLD5yZGt06t6hcFkw+tojbItr4/Js3JVfg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lzGoS-0007ro-OD for control@debbugs.gnu.org; Fri, 02 Jul 2021 12:54:26 +0200 Date: Fri, 02 Jul 2021 12:54:24 +0200 Message-Id: <87im1tvvdr.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49243 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49243 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49243 28.1 quit From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jul 2021 13:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: 49243@debbugs.gnu.org Received: via spool by 49243-submit@debbugs.gnu.org id=B49243.162523282731715 (code B ref 49243); Fri, 02 Jul 2021 13:34:01 +0000 Received: (at 49243) by debbugs.gnu.org; 2 Jul 2021 13:33:47 +0000 Received: from localhost ([127.0.0.1]:35321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJIg-0008FS-Po for submit@debbugs.gnu.org; Fri, 02 Jul 2021 09:33:47 -0400 Received: from mail.choca.pics ([80.67.172.235]:51550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJIZ-0008FD-MN for 49243@debbugs.gnu.org; Fri, 02 Jul 2021 09:33:45 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id D3949181A5050; Fri, 2 Jul 2021 15:33:37 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id QKtMAuYTy_1s; Fri, 2 Jul 2021 15:33:37 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 54E05181A5051; Fri, 2 Jul 2021 15:33:37 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id AZ_WWMNK7tkz; Fri, 2 Jul 2021 15:33:37 +0200 (CEST) Received: from localhost (199.138.120.78.rev.sfr.net [78.120.138.199]) by mail.choca.pics (Postfix) with ESMTPSA id 1A1FA181A5050; Fri, 2 Jul 2021 15:33:37 +0200 (CEST) From: Damien Cassou In-Reply-To: <87v95vck3c.fsf@gmail.com> References: <87h7hjjnye.fsf@cassou.me> <87eecj7b48.fsf@gnus.org> <87y2aribb7.fsf@cassou.me> <87v95vck3c.fsf@gmail.com> Date: Fri, 02 Jul 2021 15:33:36 +0200 Message-ID: <87mtr4lu1b.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > That last bit was me, not Lars. I was trying to nudge you to go look > at the 'developers' section of the auth-source info manual and bring > its documentation in line with the implementation, since it currently > doesn=CA=BCt say anything about multiple hosts. I've just checked. The info manual says: -- Function: auth-source-search &rest spec &key type max host user port secret require create delete &allow-other-keys =20=20 This function searches (or modifies) authentication backends according to SPEC. See the function=E2=80=99s doc-string for detail= s. And the docstring says: A string value is always matched literally. A symbol is matched as its string value, literally. All the SPEC values can be single values (symbol or string) or lists thereof (in which case any of the search terms matches). I think this is good enough. --=20 Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From unknown Sun Jun 22 07:52:19 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49243: 27.2; [PATCH] Merge auth-source-pass changes from upstream Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jul 2021 13:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49243 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Damien Cassou Cc: 49243@debbugs.gnu.org Received: via spool by 49243-submit@debbugs.gnu.org id=B49243.1625233704687 (code B ref 49243); Fri, 02 Jul 2021 13:49:01 +0000 Received: (at 49243) by debbugs.gnu.org; 2 Jul 2021 13:48:24 +0000 Received: from localhost ([127.0.0.1]:35352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJWq-0000B0-7e for submit@debbugs.gnu.org; Fri, 02 Jul 2021 09:48:24 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:39726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzJWm-0000Af-HO for 49243@debbugs.gnu.org; Fri, 02 Jul 2021 09:48:23 -0400 Received: by mail-wr1-f42.google.com with SMTP id f14so12184866wrs.6 for <49243@debbugs.gnu.org>; Fri, 02 Jul 2021 06:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=6zkGcsAWDAdQSvdNh5YrCVN5Bcj7ubyaNcdJlIEVUSA=; b=NnuUrUISxC3iOHokZU2wevKTaghNPqSomookeWNLZzU5cGWr7tDnecdiL3K1GD8TD/ +zWvzMZme3fPgcLQj+RBSkJBlU53Kf9DJ3ZmDWGYw9PGzmXwYJqySayjCqh7+j26SMVc 4wbQn0sqnDzoweTGp+Z4Om8O1XZ7L/ZSTQDJLDelfsxahT16vu7dGNei84pTIjhWxSc3 79GQDLv+hwKU+GuL1LKYd5GQ0bBgYemoyPuuvhNungvlH02kwEheXHQnDGViXXGQHqqj 1ELxTSL47AwBnCVgnS5PIy+yQ6ybVhsikFo3z9TPkDq/BhOZ0pdb8+4+U4uGVxB3t8Pk DLCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=6zkGcsAWDAdQSvdNh5YrCVN5Bcj7ubyaNcdJlIEVUSA=; b=Pl3AEnEGvqiJqArzudPjGUd9MChhtDRusLmCNdfsNFKiJcm7A0ofq1w2+zqsdIi6uk xeHREURaj0Ls/3uZ5MYK8UizZ9sfsoTIaKFN9sZ5jIFLPVDPes7fjLmfBMZB2pmIHNXp m/7u1dnrCPZ7Au1Gj8ANk/k18ltXAtfhOeyGgHO4ZLM0l0ZZIEeqjcblFLiy6Z3go4y/ hoc19wN7roRCXTsC9w3Y8ApU0pd9mtqjrTVgR0eazeZku2KxrlgfOPX18BYV7c8SmeD2 U5NvJS8vDBVkht6EQ4HDjQ0meSc7PeMLeHB8OSvj+oeZLwsSQl8DUxKn0udfn+O/kGPv g1fQ== X-Gm-Message-State: AOAM5335cIuF8Q8sbS6tGdm+80h3JyhvSNM4JNsjA0eMY5TeGiJdY8MQ K8XJZZVhwPrT4whPfKVSF3lvkW2itQI= X-Google-Smtp-Source: ABdhPJyoz23solrx6B8Wy3J+ezBWsVfv1X0m7eGz/uEU3B2ktlDllWdAH1Y/oTWaO7zbmxH0Pn3KJQ== X-Received: by 2002:a5d:49c9:: with SMTP id t9mr6183450wrs.364.1625233694146; Fri, 02 Jul 2021 06:48:14 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id v17sm3233086wrt.74.2021.07.02.06.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 06:48:13 -0700 (PDT) From: Robert Pluim References: <87h7hjjnye.fsf@cassou.me> <87eecj7b48.fsf@gnus.org> <87y2aribb7.fsf@cassou.me> <87v95vck3c.fsf@gmail.com> <87mtr4lu1b.fsf@cassou.me> Date: Fri, 02 Jul 2021 15:48:12 +0200 In-Reply-To: <87mtr4lu1b.fsf@cassou.me> (Damien Cassou's message of "Fri, 02 Jul 2021 15:33:36 +0200") Message-ID: <87o8bkddyb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 02 Jul 2021 15:33:36 +0200, Damien Cassou = said: Damien> Robert Pluim writes: >> That last bit was me, not Lars. I was trying to nudge you to go look >> at the 'developers' section of the auth-source info manual and bring >> its documentation in line with the implementation, since it currently >> doesn=CA=BCt say anything about multiple hosts. Damien> I've just checked. The info manual says: Damien> -- Function: auth-source-search &rest spec &key type max hos= t user port Damien> secret require create delete &allow-other-keys =20=20 Damien> This function searches (or modifies) authentication backe= nds Damien> according to SPEC. See the function=E2=80=99s doc-strin= g for details. Damien> And the docstring says: Damien> A string value is always matched literally. A symbol is matc= hed as Damien> its string value, literally. All the SPEC values can be sing= le values Damien> (symbol or string) or lists thereof (in which case any of the= search Damien> terms matches). Ah, I didn=CA=BCt go back to the docstring Damien> I think this is good enough. Yes Damien> "Success is the ability to go from one failure to another witho= ut Damien> losing enthusiasm." --Winston Churchill :-) Robert --=20