GNU bug report logs - #49203
[PATCH 0/2] Add ocaml-cohttp and dependencies

Previous Next

Package: guix-patches;

Reported by: Xinglu Chen <public <at> yoctocell.xyz>

Date: Thu, 24 Jun 2021 09:56:01 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Adu O'Hara <adu.ohara <at> posteo.net>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 49203 <at> debbugs.gnu.org
Subject: [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp.
Date: Fri, 25 Jun 2021 10:04:39 +0000
Xinglu Chen <public <at> yoctocell.xyz> writes:

>> True, what I was suggesting would add another patch to the 
>> series 
>> and mix up intentions of the series.
>
> Sorry, I don’t get what you are trying to say here.
>
>> Still, I'd suggest for ocaml-uri-sexp to inherit from
>> ocaml-uri. Otherwise we have them at two different versions.
>
> I think it makes more sense to do that in a separate series 
> since
> updating ‘ocaml-uri’ isn’t really related to adding 
> ‘ocaml-cohttp’.

Sorry for being unclear. Here's what I mean:

(define-public ocaml-uri-sexp
 (package
   (inherit ocaml-uri)
   (name "ocaml-uri-sexp")
   (arguments
    `(#:package "uri-sexp"
      #:test-target "."))
   (propagated-inputs
     `(("ocaml-uri" ,ocaml-uri)
       ("ocaml-ppx-sexp-conv" ,ocaml-ppx-sexp-conv)
       ("ocaml-sexplib0" ,ocaml-sexplib0)))
   (native-inputs `(("ocaml-ounit" ,ocaml-ounit)))))

Then when `ocaml-uri` eventually gets updated `ocaml-uri` and 
`ocaml-uri-sexp` will be at same version.




This bug report was last modified 3 years and 330 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.