GNU bug report logs - #49203
[PATCH 0/2] Add ocaml-cohttp and dependencies

Previous Next

Full log

Message #23 received at 49203 <at> debbugs.gnu.org (full text, mbox):

From: Adu O'Hara <adu.ohara <at> posteo.net>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 49203 <at> debbugs.gnu.org
Subject: Re: [bug#49203] [PATCH 1/2] gnu: Add ocaml-uri-sexp.
Date: Thu, 24 Jun 2021 19:32:30 +0000

Xinglu Chen <public <at> yoctocell.xyz> writes:

> On Thu, Jun 24 2021, Adu O'Hara wrote:
>
>> Thanks for the patches!
>>
>> There is already an `ocaml-uri`. How about updating that to 
>> 4.2.0 
>> (currently at 4.1.0) and let `ocaml-uri-sexp` inherit from 
>> ocaml-uri with #:package set to "uri-sexp"?
>
> That could probably be done in a separate patch series; this 
> series is
> about adding ‘ocaml-cohttp’.

True, what I was suggesting would add another patch to the series 
and mix up intentions of the series. Still, I'd suggest for 
ocaml-uri-sexp to inherit from ocaml-uri. Otherwise we have them 
at two different versions.

wdyt?

>
>> Another alternatively: remove the #:package argument from 
>> `ocaml-uri` so that all packages are built (`uri`, `uri-sexp` 
>> and 
>> `uri-re`).
>
> Those are three separate packages on Opam, so I don’t think it 
> makes
> sense for us to merge them into one.  Not everyone who installs
> ‘ocaml-uri’ is going to want ‘ocaml-uri-sexp’ and 
> ‘ocaml-uri-re’.
>
> WDYT?

Yeah, that make sense. Keeping them separate sounds good.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.