From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 23 18:46:57 2021 Received: (at submit) by debbugs.gnu.org; 23 Jun 2021 22:46:58 +0000 Received: from localhost ([127.0.0.1]:42010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwBe5-0008D8-LJ for submit@debbugs.gnu.org; Wed, 23 Jun 2021 18:46:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:34210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwBe3-0008D0-91 for submit@debbugs.gnu.org; Wed, 23 Jun 2021 18:46:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwBe3-0006pP-0V for guix-patches@gnu.org; Wed, 23 Jun 2021 18:46:55 -0400 Received: from out0.migadu.com ([94.23.1.103]:34636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwBdz-0004f6-Ju for guix-patches@gnu.org; Wed, 23 Jun 2021 18:46:54 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1624488408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=mwBA46sghhlYkPuqwq9Fgt98P6pnSNiC9a+mzQ5UTxo=; b=CPYZZWU+UgpDO35qotkgxweOfC37wto2G9yEjzNUIr8uWb+Sxkxz/YAk6UdGaApmeyJrBL iEWWPyUI5SFRQKt0Ve6vXwJUUHSl10NilhC24vFCm1uRxcaAJOsBzXXNhVevHr8T/fBn7i iCgFjwMos/0SHq9UZxsukVVHbFXWjvg= From: Sarah Morgensen To: guix-patches@gnu.org Subject: [PATCH] import: go: Fix match-error in 'go-package-description' Date: Wed, 23 Jun 2021 15:46:46 -0700 Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=94.23.1.103; envelope-from=iskarian@mgsn.dev; helo=out0.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/import/go.scm (go-package-description): Make sure description* is always a list, so the result is properly matched. --- Hello Guix, In the process of using `guix import go` I encountered a rare issue when the go.pkg.dev Documentation and UnitInfo sections for a package are both blank: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix import go github.com/neelance/sourcemap Backtrace: In ice-9/boot-9.scm: 1752:10 7 (with-exception-handler _ _ #:unwind? _ # _) In unknown file: 6 (apply-smob/0 #) In ice-9/boot-9.scm: 724:2 5 (call-with-prompt _ _ #) In ice-9/eval.scm: 619:8 4 (_ #(#(#))) In guix/ui.scm: 2147:12 3 (run-guix-command _ . _) In guix/scripts/import.scm: 120:11 2 (guix-import . _) In guix/scripts/import/go.scm: 118:27 1 (guix-import-go . _) In guix/import/go.scm: 191:4 0 (go-module->guix-package _ #:goproxy _ #:version _ # _) guix/import/go.scm:191:4: In procedure go-module->guix-package: Throw to key `match-error' with args `("match" "no matching pattern" #f)'. --8<---------------cut here---------------end--------------->8--- Looks like the error is due to using false where the empty list was expected. This tiny patch fixes that. Copyright for go.scm was added in . Sarah guix/import/go.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/guix/import/go.scm b/guix/import/go.scm index d110954664..cf8c62abe2 100644 --- a/guix/import/go.scm +++ b/guix/import/go.scm @@ -186,8 +186,9 @@ e.g. \"google.golang.org/protobuf/proto\"." (description (if (not (null? overview)) overview (select-content sxml))) - (description* (and (not (null? description)) - (first description)))) + (description* (if (not (null? description)) + (first description) + description))) (match description* (() #f) ;nothing selected ((p elements ...) base-commit: 1f3d7b45349d43e5cc02594083e0cd44ef730992 -- 2.31.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 28 02:55:08 2021 Received: (at submit) by debbugs.gnu.org; 28 Jun 2021 06:55:08 +0000 Received: from localhost ([127.0.0.1]:50782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxlAh-0001CP-OZ for submit@debbugs.gnu.org; Mon, 28 Jun 2021 02:55:08 -0400 Received: from lists.gnu.org ([209.51.188.17]:58722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxlAf-0001CE-2x for submit@debbugs.gnu.org; Mon, 28 Jun 2021 02:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxlAe-0006J2-Oy for guix-patches@gnu.org; Mon, 28 Jun 2021 02:55:04 -0400 Received: from m4s11.vlinux.de ([83.151.27.109]:50862 helo=bjoernhoefling.de) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxlAd-0008IK-1m for guix-patches@gnu.org; Mon, 28 Jun 2021 02:55:04 -0400 Received: from alma-ubu.fritz.box (p508acf09.dip0.t-ipconnect.de [80.138.207.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bjoernhoefling.de (Postfix) with ESMTPSA id E002E3F946; Mon, 28 Jun 2021 08:54:59 +0200 (CEST) Date: Mon, 28 Jun 2021 08:54:58 +0200 From: =?UTF-8?B?QmrDtnJuIEjDtmZsaW5n?= To: Sarah Morgensen via Guix-patches via Subject: Re: [bug#49200] [PATCH] import: go: Fix match-error in 'go-package-description' Message-ID: <20210628085458.754e926c@alma-ubu.fritz.box> In-Reply-To: References: X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/dLOu1vJVgOTFD4LZZGAc6N1"; protocol="application/pgp-signature"; micalg=pgp-sha512 Received-SPF: none client-ip=83.151.27.109; envelope-from=bjoern.hoefling@bjoernhoefling.de; helo=bjoernhoefling.de X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, KHOP_HELO_FCRDNS=0.399, SPF_HELO_NONE=0.001, SPF_NONE=0.001, TRACKER_ID=0.1 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: submit Cc: 49200-done@debbugs.gnu.org, Sarah Morgensen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) --Sig_/dLOu1vJVgOTFD4LZZGAc6N1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 23 Jun 2021 15:46:46 -0700 Sarah Morgensen via Guix-patches via wrote: > * guix/import/go.scm (go-package-description): Make sure description* > is always a list, so the result is properly matched. Pushed as 9d9152425e96c408357d0f4961767a5c08076c13 Thanks, Bj=C3=B6rn --Sig_/dLOu1vJVgOTFD4LZZGAc6N1 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iF0EAREKAB0WIQQiGUP0np8nb5SZM4K/KGy2WT5f/QUCYNlyQgAKCRC/KGy2WT5f /f0AAJ4gA33MoA/JQ4yF550L4+n/B9qSugCfVM25Zc5n79eTh9pPYdZbBKJVQPk= =l4Rf -----END PGP SIGNATURE----- --Sig_/dLOu1vJVgOTFD4LZZGAc6N1-- From unknown Sat Jun 21 10:46:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 26 Jul 2021 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator