GNU bug report logs - #49199
[PATCH core-updates] add package-db to runhaskell (haskell-build-system)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49199: closed ([PATCH core-updates] add package-db to
 runhaskell (haskell-build-system))
Date: Tue, 20 Jul 2021 22:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 21 Jul 2021 00:22:45 +0200
with message-id <87y2a04ocq.fsf <at> elephly.net>
and subject line [PATCH core-updates] add package-db to runhaskell (haskell-build-system)
has caused the debbugs.gnu.org bug report #49199,
regarding [PATCH core-updates] add package-db to runhaskell (haskell-build-system)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49199: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49199
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH core-updates] add package-db to runhaskell
 (haskell-build-system)
Date: Wed, 23 Jun 2021 22:09:05 +0000

[Message part 3 (text/plain, inline)]

Hello,

This is a patch to fix issue #48944 as well as more broadly an issue of Haskell packages that need modules at the configure step. Currently the package database is not passed to runhaskell directly, which means runhaskell Setup.hs configure does not have outside modules available. This blocks packages that need things like cabal-doctest or gtk2hs-buildtools like ghc-cairo (which has a custom build process in the package currently, for this reason). Comments in ghc-cairo and for other packages with this need, suggest the change made in this patch.

The simplest change I saw was to make the package database passed to runhaskell on any command; not sure if this would be better for just configure. It may be possible to do this just passing the actual needed packages with -package-id, as suggested in https://github.com/tweag/rules_haskell/issues/1314 However, I have not tried that and seemed more complicated than needed. Also, I did not modify the message printed as it already has the package-db in params, but perhaps better to be clear the exact command being run?

I have built many Haskell packages with this change and it works well for me, fixing the reported issue and packages I'm building not yet in guix. Given this changes the build command for all Haskell packages, would be happy for other tests to be run.

John

[runhaskell-add-pkgdb.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 49199-done <at> debbugs.gnu.org
Cc: John Kehayias <john.kehayias <at> protonmail.com>
Subject: [PATCH core-updates] add package-db to runhaskell
 (haskell-build-system)
Date: Wed, 21 Jul 2021 00:22:45 +0200

Hi,

I made a commit out of the diff and pushed it to wip-haskell, 
which is based on core-updates.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.