GNU bug report logs - #49181
Fix missing phases in Emacs builds

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Carlo Zancanaro <carlo <at> zancanaro.id.au>
Subject: bug#49181: closed (Re: bug#49181: [PATCH core-updates v2] guix:
 Make modify-phases error when adding before/after a missing phase)
Date: Tue, 10 Oct 2023 03:39:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#49181: Fix missing phases in Emacs builds

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 49181 <at> debbugs.gnu.org.

-- 
49181: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49181
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Carlo Zancanaro <carlo <at> zancanaro.id.au>
Cc: 49181-done <at> debbugs.gnu.org
Subject: Re: bug#49181: [PATCH core-updates v2] guix: Make modify-phases
 error when adding before/after a missing phase
Date: Mon, 09 Oct 2023 23:37:30 -0400

Hi,

Carlo Zancanaro <carlo <at> zancanaro.id.au> writes:

> * guix/build/utils.scm (alist-cons-before, alist-cons-after): Cause a match failure if the
> reference is not found, rather than appending to the alist.
> * tests/build-utils.scm: Update tests to match.

Installed to core-updates!

-- 
Thanks,
Maxim

[Message part 3 (message/rfc822, inline)]

From: Carlo Zancanaro <carlo <at> zancanaro.id.au>
To: guix-patches <at> gnu.org
Subject: Fix missing phases in Emacs builds
Date: Wed, 23 Jun 2021 16:45:28 +1000

[Message part 4 (text/plain, inline)]

Hi there!

I went to install emacs-protobuf-mode today and found that the 
build wasn't working. I investigated and it looks like someone 
renamed the add-source-to-load-path phase to expand-load-path, but 
they left a few references behind. The first of my patches fixes 
that.

The second of my patches is more controversial. It changes 
modify-phases to error out if the asked-for phase doesn't exist in 
add-before/add-after clauses. I think this is the right move, 
because it's hard to imagine when the default behaviour of "add to 
the end of the phases list" is helpful. In most cases the extra 
phases are setup/transformation phases that we need to run before 
the final "install" phase, so it's far more useful to fail early 
than to add these to the end of the phases list.

Carlo

[0001-gnu-Fix-references-to-emacs-build-system-s-expand-lo.patch (text/x-diff, attachment)]

[0002-guix-Make-modify-phases-error-when-adding-before-aft.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.