Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire

From: Maxime Devos <[email-masked]>
Date: Tue, 29 Jun 2021 10:06:04 +0200

دانیال بهزادی schreef op ma 28-06-2021 om 21:57 [+0000]:
> This is awesome. I think Guix really lacks a very detailed document on packaging.
> Every patch I wrote is vastly based on apriority assumptions and lots of try and fails.

Yes, not everything is in the manual.

FWIW, there should be a linter soonish verifying that #:tests? is respected:
<https://issues.guix.gnu.org/48320>. A sample of
'./pre-inst-env guix lint --no-network --exclude=derivation'
output ('derivation' is slow):

gnu/packages/astronomy.scm:898:5: [email-masked]: the 'check' phase should respect #:tests?
gnu/packages/astronomy.scm:690:5: [email-masked]: sentences in description should be followed by two spaces; possible infraction at 268
gnu/packages/attr.scm:43:5: [email-masked]: the 'check' phase should respect #:tests?
gnu/packages/audio.scm:5208:5: [email-masked]: the 'check' phase should respect #:tests?
gnu/packages/audio.scm:2484:2: [email-masked]: 'python-cython' should probably be a native input
gnu/packages/audio.scm:2488:6: [email-masked]: the source file name should contain the package name

Greetings,
Maxime.