Subject: Re: [bug#49170] [PATCH v2]: gnu: Add python-fire

From: Raghav Gururajan <[email-masked]>
Date: Mon, 28 Jun 2021 17:50:44 -0400

Hi Maxim!

> I'm a bit late, as this has already been merged,
> but this should have been something like:
> 
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (when tests?
>> +               (invoke "pytest")))))))

Ah my bad to miss it. Thanks for catching it.

> That way, tests can be disabled with "--without-tests".
> Try "./pre-inst-env guix build pytest --without-tests=pytests".
> Respecting #:tests? can also be important for cross-compilation.
> 
> Could you send a follow-up patch, or could someone directly
> commit such a change?

I pushed as e61874a598.

Regards,
RG.