GNU bug report logs - #49162
28.0.50; [PATCH] Use named face for apropos-face-button

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Mon, 21 Jun 2021 20:18:01 UTC

Severity: normal

Tags: patch

Found in version 28.0.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 49162 <at> debbugs.gnu.org, info <at> protesilaos.com
Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button
Date: Tue, 22 Jun 2021 17:44:25 +0200
On Jun 22 2021, Eli Zaretskii wrote:

>> From: Andreas Schwab <schwab <at> linux-m68k.org>
>> Cc: Protesilaos Stavrou <info <at> protesilaos.com>,  49162 <at> debbugs.gnu.org
>> Date: Tue, 22 Jun 2021 16:00:06 +0200
>> 
>> >>     Category apropos-face-button:
>> >
>> > That's the _button_, not its _face_.
>> 
>> But the new face is the face for the button.
>
> I don't have anything about naming the face apropos-button.  It's
> apropos-face-button that I don't like: it implies that it's a button
> of a face, or something that is apropos button-face; both are wrong.

But that happens to be the name of the button that the face is for, just
like the apropos-variable-button face is the face for the
apropos-variable-button button.  Since face names have no qualifiers,
such duplication is unavoidable.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."




This bug report was last modified 4 years and 53 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.