From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Jun 2021 20:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 49162@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162430666710952 (code B ref -1); Mon, 21 Jun 2021 20:18:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Jun 2021 20:17:47 +0000 Received: from localhost ([127.0.0.1]:36969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvQMd-0002qa-2x for submit@debbugs.gnu.org; Mon, 21 Jun 2021 16:17:47 -0400 Received: from lists.gnu.org ([209.51.188.17]:55312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvQMZ-0002qR-US for submit@debbugs.gnu.org; Mon, 21 Jun 2021 16:17:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvQMY-0000SY-5g for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2021 16:17:43 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:59617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvQMV-0008Bi-4m for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2021 16:17:41 -0400 Received: (Authenticated sender: public@protesilaos.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id E268CC0003 for ; Mon, 21 Jun 2021 20:17:33 +0000 (UTC) From: Protesilaos Stavrou User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Mon, 21 Jun 2021 23:17:32 +0300 Message-ID: <878s333rc3.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=217.70.183.198; envelope-from=info@protesilaos.com; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Dear maintainers, The attached patch defines a new face for the Apropos buffer which applies to buttons that indicate faces. Before the attributes were hardcoded and could thus not be edited by the user/theme. All the best, Protesilaos -- Protesilaos Stavrou https://protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-named-face-for-apropos-face-button.patch >From fed7e750cb8a6b0057c8c036c6113335f3ebeb44 Mon Sep 17 00:00:00 2001 Message-Id: From: Protesilaos Stavrou Date: Mon, 21 Jun 2021 23:11:35 +0300 Subject: [PATCH] Use named face for apropos-face-button * etc/NEWS: Document new face. * lisp/apropos.el (apropos-face): Define new face. (apropos-face-button): Specify face instead of hardcoding attributes. --- etc/NEWS | 3 +++ lisp/apropos.el | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 3c7d5ca10b..4cbd87b917 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1606,6 +1606,9 @@ These new navigation commands are bound to 'n' and 'p' in *** New command 'apropos-function'. This works like 'C-u M-x apropos-command' but is more discoverable. +*** New face 'apropos-face-button'. +Applies to buttons that indicate a face. + ** CC Mode *** Added support for Doxygen documentation style. diff --git a/lisp/apropos.el b/lisp/apropos.el index 17665a725a..f24448599f 100644 --- a/lisp/apropos.el +++ b/lisp/apropos.el @@ -96,6 +96,11 @@ (defface apropos-property "Face for property name in Apropos output, or nil for none." :version "24.3") +(defface apropos-face-button + '((t (:inherit (font-lock-variable-name-face button)))) + "Face for buttons that indicate a face in Apropos." + :version "28.1") + (defface apropos-function-button '((t (:inherit (font-lock-function-name-face button)))) "Button face indicating a function, macro, or command in Apropos." @@ -276,7 +281,7 @@ (define-button-type 'apropos-user-option (define-button-type 'apropos-face 'apropos-label "Face" 'apropos-short-label "F" - 'face '(font-lock-variable-name-face button) + 'face 'apropos-face-button 'help-echo "mouse-2, RET: Display more help on this face" 'follow-link t 'action (lambda (button) -- 2.32.0 --=-=-=-- From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 11:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou Cc: 49162@debbugs.gnu.org Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162436219021405 (code B ref 49162); Tue, 22 Jun 2021 11:44:02 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 11:43:10 +0000 Received: from localhost ([127.0.0.1]:37989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lveo9-0005ZA-UN for submit@debbugs.gnu.org; Tue, 22 Jun 2021 07:43:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lveo8-0005Yw-NF for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 07:43:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55898) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lveo3-00018J-0h; Tue, 22 Jun 2021 07:43:03 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4249 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lveo2-0006LH-KW; Tue, 22 Jun 2021 07:43:02 -0400 Date: Tue, 22 Jun 2021 14:42:47 +0300 Message-Id: <83eecuunuw.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <878s333rc3.fsf@protesilaos.com> (message from Protesilaos Stavrou on Mon, 21 Jun 2021 23:17:32 +0300) References: <878s333rc3.fsf@protesilaos.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Protesilaos Stavrou > Date: Mon, 21 Jun 2021 23:17:32 +0300 > > +*** New face 'apropos-face-button'. The name should be apropos-button-face, IMO. Thanks. From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Protesilaos Stavrou Cc: 49162@debbugs.gnu.org Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162436334523255 (code B ref 49162); Tue, 22 Jun 2021 12:03:02 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 12:02:25 +0000 Received: from localhost ([127.0.0.1]:38011 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvf6m-000631-Ox for submit@debbugs.gnu.org; Tue, 22 Jun 2021 08:02:24 -0400 Received: from mout.gmx.net ([212.227.17.22]:39971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvf6k-00062m-KW for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 08:02:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1624363335; bh=HDyesXm9tj53WRVbRrRuyZT+errtBkJhZC2K2DTeX0A=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=hq2O8v2DslvYSoGaSC8rtUZYBp72cOjLMiCAt9hSqVCOS5ggpRnXISZI5x9dCEWY/ aBWj+4rSbqPDGONhbqxwpAiMprcHfLczcgvKTKy5EQItHf8SklGegGWEnr99AykPhb XQEk8rJ915I8P/aqEghuFza+dNM8n6alqIKz+hQE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.101] ([212.95.5.67]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MO9z7-1lbVfC1Uan-00OYPc; Tue, 22 Jun 2021 14:02:15 +0200 References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> From: martin rudalics Message-ID: <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> Date: Tue, 22 Jun 2021 14:02:14 +0200 MIME-Version: 1.0 In-Reply-To: <83eecuunuw.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:/u8xTiPnfIwpw7iQV+xc1d3RSampiwVlguBGxqhCkEeiAxUi9l3 sDnNRe7QL4u1fhofH24xpKkj9nyJu+Bf+Real51kekzrOEuP/l3NNk4CBO23YpDikjNKvE1 ZBUBqEo/0+udxzIvm1M51zlTH0YhtViNKhE23FPVPB/JZWL6RnY4UDs0o6RSIi/+yZ7ucfL DKQw3z+SwXYhFzzm/xOag== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:f/xDH0Qlt/4=:BxgUEvvJ7JkIbrrGkSye1c fQsXF7Vc3LsEBxTfgMNn3qBoedUu+9/6LjOk7Gufb78oguY3F+9QUx7Dk/aRNk0eHRz8ibSy6 MGWJHyQdqfsdB45Zon27vUwTpw3xtP5yJb2nAg4eln8a8chDMAiqVWbO11ThF9GsGG7qnVNs2 6FXE65LUKPDXxRMqwyl48pmdDKYvB+gFumWGxR0L44NfsRVpWdvq5k3OoFUM1hTy7Lg1lRaq7 ekZORCj1/ay9/ZSd+T8KEuAueUeTFK30x9N49m1G5EIpdDxtl5qAKDEtYVALOGao+oo/0vnBF 7RIiP90pf6NCsBOfx9f+dbCnMDPs27BYFrUXBVCs2XLsazCJXVvnMCVtrgG+SpSVzMaBp+E6v mYXW2SUp2gXRzx0bipn1NVNRF1IJSohqOiuz1CWwXVfE4oc4MK+UOSPViulv3rRHCX0HnHXCW MqTDFmTaf86ODrOXirBS84yHsEPkDtRvwdvwOFk10GMfrh2XFywqzd4RotHULJIkgN6+suwxZ F9GtobFMbyb6HNmvmJhAg9E1wLwJ4XX2fMpiVviYhlq9IDGTBCuCZ16dGw7U7gWDWKl/4t/W8 3igpScmhN0PJz+pfWrUld3UjbMyzKr+gs5VYAHiskBDk94g6A9lyfzOGZTEQ1uLLCF8GKD5f+ chBDLo29DX4sXxASM0zz09hA2H4l08hnsW9LIfYXTmAMiJrmcERPNv3UQgPXXnxmazoHcs+Cm bQ+2aVsZ0u6Ehnp+6PFhMrzdHWKQYGUj2lUwWg6CtOpZ/HoMROu+wdNhhpGkrbG7uKBB+aA+V lcDbfns+94wvLrZikA16o6bowO3u+Dt/kQCt1F+8DQu/O1eS/7No1HB1wTwS2qx0J0QwVk6Tu FDmN8HytpEAbF2P8fS60DdIK4kHkNUNZgW4dMcXbiUHcrsLnFoWPIrxzl+DU9HNuuCp2HNfZP uFyHi+4p89JPOk6dMy4xqs3Q0bCYwVKp5OV6Q4GEezBckR96gjSKoZ91eRe2xL/WCnPEKDbRG lpE4NmpkyXie/bsWHx3ypR9DR0Y3MGmfWWT+/CRxIMaOtpGG98yFHgQIVe0HvuSBfsqnMnfru ApKWqeUcnCun0qHzldeYqCcm0WhZvUDZj4V X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> +*** New face 'apropos-face-button'. > > The name should be apropos-button-face, IMO. `apropos-button' IMO. martin From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: martin rudalics , Eli Zaretskii Cc: 49162@debbugs.gnu.org Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162436390424078 (code B ref 49162); Tue, 22 Jun 2021 12:12:01 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 12:11:44 +0000 Received: from localhost ([127.0.0.1]:38020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvfFn-0006GI-U9 for submit@debbugs.gnu.org; Tue, 22 Jun 2021 08:11:44 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:49861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvfFl-0006G5-QU for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 08:11:42 -0400 Received: (Authenticated sender: public@protesilaos.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 3EF35FF810; Tue, 22 Jun 2021 12:11:34 +0000 (UTC) From: Protesilaos Stavrou In-Reply-To: <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Tue, 22 Jun 2021 15:11:33 +0300 Message-ID: <87mtriaykq.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2021-06-22, 14:02 +0200, martin rudalics wrote: > >> +*** New face 'apropos-face-button'. > > > > The name should be apropos-button-face, IMO. > > `apropos-button' IMO. Thank you Martin and Eli! I picked that symbol because it was already given by the implicit face. You can try it with emacs -Q: - M-x apropos RET font-lock-variable RET - Place point over the underlined "Face" text and M-x describe-char - In the resulting Help buffer, you will find the reference to 'apropos-face-button', whose specification is defined thus: Category apropos-face-button: action [Show] apropos-label "Face" apropos-short-label "F" evaporate t face (font-lock-variable-name-face button) follow-link t help-echo "mouse-2, RET: Display more help on this face" keymap [Show] mouse-face highlight rear-nonsticky t supertype button type apropos-face What do you think? -- Protesilaos Stavrou https://protesilaos.com From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 12:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou Cc: martin rudalics , Eli Zaretskii , 49162@debbugs.gnu.org Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162436447025446 (code B ref 49162); Tue, 22 Jun 2021 12:22:02 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 12:21:10 +0000 Received: from localhost ([127.0.0.1]:38027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvfOv-0006cK-R5 for submit@debbugs.gnu.org; Tue, 22 Jun 2021 08:21:10 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:55914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvfOt-0006c6-TB for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 08:21:08 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4G8QVB3YXnz1s46p; Tue, 22 Jun 2021 14:21:06 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4G8QVB0zwQz1qr3L; Tue, 22 Jun 2021 14:21:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id QPMNC2QYzieT; Tue, 22 Jun 2021 14:21:05 +0200 (CEST) X-Auth-Info: S+4whpCNzynDLOJHE7ZhoWOH/ivkMjHaTJCiiXNT1NJvVyCYnhwfhfpTnsPj17cn Received: from igel.home (ppp-46-244-162-121.dynamic.mnet-online.de [46.244.162.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 22 Jun 2021 14:21:05 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id BA3452C3629; Tue, 22 Jun 2021 14:21:04 +0200 (CEST) From: Andreas Schwab References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> X-Yow: SHHHH!! I hear SIX TATTOOED TRUCK-DRIVERS tossing ENGINE BLOCKS into empty OIL DRUMS.. Date: Tue, 22 Jun 2021 14:21:04 +0200 In-Reply-To: <87mtriaykq.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Tue, 22 Jun 2021 15:11:33 +0300") Message-ID: <87mtrigken.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jun 22 2021, Protesilaos Stavrou wrote: > On 2021-06-22, 14:02 +0200, martin rudalics wrote: > >> >> +*** New face 'apropos-face-button'. >> > >> > The name should be apropos-button-face, IMO. >> >> `apropos-button' IMO. > > Thank you Martin and Eli! I picked that symbol because it was already > given by the implicit face. > > You can try it with emacs -Q: > > - M-x apropos RET font-lock-variable RET > - Place point over the underlined "Face" text and M-x describe-char > - In the resulting Help buffer, you will find the reference to > 'apropos-face-button', whose specification is defined thus: > > Category apropos-face-button: > > action [Show] > apropos-label "Face" > apropos-short-label "F" > evaporate t > face (font-lock-variable-name-face button) > follow-link t > help-echo "mouse-2, RET: Display more help on this face" > keymap [Show] > mouse-face highlight > rear-nonsticky t > supertype button > type apropos-face > > > What do you think? It's the face for the apropos-face-button, so the name looks right. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 12:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou Cc: rudalics@gmx.at, 49162@debbugs.gnu.org Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162436545027135 (code B ref 49162); Tue, 22 Jun 2021 12:38:01 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 12:37:30 +0000 Received: from localhost ([127.0.0.1]:38036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvfej-00073b-Ll for submit@debbugs.gnu.org; Tue, 22 Jun 2021 08:37:29 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37500) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvfei-00073O-4N for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 08:37:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58844) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvfec-0004wJ-Iv; Tue, 22 Jun 2021 08:37:22 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3636 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvfec-0002EX-2B; Tue, 22 Jun 2021 08:37:22 -0400 Date: Tue, 22 Jun 2021 15:37:04 +0300 Message-Id: <838s32ulcf.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87mtriaykq.fsf@protesilaos.com> (message from Protesilaos Stavrou on Tue, 22 Jun 2021 15:11:33 +0300) References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Protesilaos Stavrou > Cc: 49162@debbugs.gnu.org > Date: Tue, 22 Jun 2021 15:11:33 +0300 > > Thank you Martin and Eli! I picked that symbol because it was already > given by the implicit face. > > You can try it with emacs -Q: > > - M-x apropos RET font-lock-variable RET > - Place point over the underlined "Face" text and M-x describe-char > - In the resulting Help buffer, you will find the reference to > 'apropos-face-button', whose specification is defined thus: > > Category apropos-face-button: That's the _button_, not its _face_. It is cumbersome to call a face by a name that ends with "-button", IMO. From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 13:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 49162@debbugs.gnu.org Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.16243673966617 (code B ref 49162); Tue, 22 Jun 2021 13:10:01 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 13:09:56 +0000 Received: from localhost ([127.0.0.1]:38094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgA8-0001if-5D for submit@debbugs.gnu.org; Tue, 22 Jun 2021 09:09:56 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:53855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgA3-0001iL-LN for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 09:09:54 -0400 Received: (Authenticated sender: public@protesilaos.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 60AD7FF806; Tue, 22 Jun 2021 13:09:44 +0000 (UTC) From: Protesilaos Stavrou In-Reply-To: <838s32ulcf.fsf@gnu.org> References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> <838s32ulcf.fsf@gnu.org> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Emacs/28.0.50 (x86_64-pc-linux-gnu) Date: Tue, 22 Jun 2021 16:09:43 +0300 Message-ID: <87k0mmavvs.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain On 2021-06-22, 15:37 +0300, Eli Zaretskii wrote: >> From: Protesilaos Stavrou >> Cc: 49162@debbugs.gnu.org >> Date: Tue, 22 Jun 2021 15:11:33 +0300 >> >> Thank you Martin and Eli! I picked that symbol because it was already >> given by the implicit face. >> >> You can try it with emacs -Q: >> >> - M-x apropos RET font-lock-variable RET >> - Place point over the underlined "Face" text and M-x describe-char >> - In the resulting Help buffer, you will find the reference to >> 'apropos-face-button', whose specification is defined thus: >> >> Category apropos-face-button: > > That's the _button_, not its _face_. It is cumbersome to call a face > by a name that ends with "-button", IMO. I see. Thank you! Please find attached the revised patch for 'apropos-button-face' -- Protesilaos Stavrou https://protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-named-face-for-apropos-button-face.patch >From 8183d254688f2f37404c0669e0a7636dd4c18c7e Mon Sep 17 00:00:00 2001 Message-Id: <8183d254688f2f37404c0669e0a7636dd4c18c7e.1624367239.git.info@protesilaos.com> From: Protesilaos Stavrou Date: Mon, 21 Jun 2021 23:11:35 +0300 Subject: [PATCH] Use named face for apropos-button-face * etc/NEWS: Document new face. * lisp/apropos.el (apropos-face): Define new face. (apropos-button-face): Specify face instead of hardcoding attributes. --- etc/NEWS | 3 +++ lisp/apropos.el | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 3c7d5ca10b..1bf8801566 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1606,6 +1606,9 @@ These new navigation commands are bound to 'n' and 'p' in *** New command 'apropos-function'. This works like 'C-u M-x apropos-command' but is more discoverable. +*** New face 'apropos-button-face'. +Applies to buttons that indicate a face. + ** CC Mode *** Added support for Doxygen documentation style. diff --git a/lisp/apropos.el b/lisp/apropos.el index 17665a725a..c6c86f6db0 100644 --- a/lisp/apropos.el +++ b/lisp/apropos.el @@ -96,6 +96,11 @@ (defface apropos-property "Face for property name in Apropos output, or nil for none." :version "24.3") +(defface apropos-button-face + '((t (:inherit (font-lock-variable-name-face button)))) + "Face for buttons that indicate a face in Apropos." + :version "28.1") + (defface apropos-function-button '((t (:inherit (font-lock-function-name-face button)))) "Button face indicating a function, macro, or command in Apropos." @@ -276,7 +281,7 @@ (define-button-type 'apropos-user-option (define-button-type 'apropos-face 'apropos-label "Face" 'apropos-short-label "F" - 'face '(font-lock-variable-name-face button) + 'face 'apropos-button-face 'help-echo "mouse-2, RET: Display more help on this face" 'follow-link t 'action (lambda (button) -- 2.32.0 --=-=-=-- From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 13:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou Cc: 49162@debbugs.gnu.org, Eli Zaretskii Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162436888726297 (code B ref 49162); Tue, 22 Jun 2021 13:35:01 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 13:34:47 +0000 Received: from localhost ([127.0.0.1]:38167 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgYB-0006q4-5q for submit@debbugs.gnu.org; Tue, 22 Jun 2021 09:34:47 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgY9-0006pq-KP for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 09:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=BNffU9uYg84/Ay0NGNX0c/bknWrmN/fQhV9iya50y6w=; b=A/3phG2LQYOZzm1FPiff8Zprx6 +TCJA+1Hpo38i2EZt77DkYOvWl1B1RCLlrkfG2Gq+JO3CW2hd0Wky34FCUmAizi3rQOasoBentAt1 7YU+cJZAnlELGp+zJjMQ+VfZLF63AfZAS+z1r5Lyzei9fngGXrfe3lRb7fDGAo327j+I=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvgY0-0006tV-MD; Tue, 22 Jun 2021 15:34:38 +0200 From: Lars Ingebrigtsen References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> <838s32ulcf.fsf@gnu.org> <87k0mmavvs.fsf@protesilaos.com> X-Now-Playing: Genesis's _And Then There Were Three_: "Say It's Alright Joe" Date: Tue, 22 Jun 2021 15:34:31 +0200 In-Reply-To: <87k0mmavvs.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Tue, 22 Jun 2021 16:09:43 +0300") Message-ID: <87tulqowew.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Protesilaos Stavrou writes: > I see. Thank you! Please find attached the revised patch for > 'apropos-button-face' Thanks; applied to Emacs 28 (but I changed the name of the face to `apropos-button' -- we don't call new faces `-face' these days). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Protesilaos Stavrou writes: > I see. Thank you! Please find attached the revised patch for > 'apropos-button-face' Thanks; applied to Emacs 28 (but I changed the name of the face to `apropos-button' -- we don't call new faces `-face' these days). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 22 09:34:50 2021 Received: (at control) by debbugs.gnu.org; 22 Jun 2021 13:34:50 +0000 Received: from localhost ([127.0.0.1]:38170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgYE-0006qP-DJ for submit@debbugs.gnu.org; Tue, 22 Jun 2021 09:34:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgYC-0006pu-Sw for control@debbugs.gnu.org; Tue, 22 Jun 2021 09:34:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=F0nJs43ZLQyDJPNkWyXJpWD6qbQE5s0AxqCpWXtT9Rk=; b=uUnSoz81iAk61GIslbOHybClAJ FLMDpRTS2GD1dZmlJUAYwHkjPhSwk80AodPpNSU2JU3QneZrgTXJZYfiMDATTlIDr/bb5qRhO6TQm b9pVjX2rJ+D1xHRST8cvrCZ+jM24eFURmd5qydiPiAgFYlsmzWX/xiTeUmz4EVZ67Zw8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lvgY5-0006ti-ER for control@debbugs.gnu.org; Tue, 22 Jun 2021 15:34:43 +0200 Date: Tue, 22 Jun 2021 15:34:41 +0200 Message-Id: <87sg1aowem.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49162 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49162 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49162 28.1 quit From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 49162@debbugs.gnu.org, Protesilaos Stavrou Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.16243704186173 (code B ref 49162); Tue, 22 Jun 2021 14:01:02 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 14:00:18 +0000 Received: from localhost ([127.0.0.1]:39561 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgwl-0001bI-OJ for submit@debbugs.gnu.org; Tue, 22 Jun 2021 10:00:17 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:52937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvgwj-0001b9-Vd for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 10:00:10 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4G8ShS4Qgfz1s479; Tue, 22 Jun 2021 16:00:08 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4G8ShS21Ysz1qr3N; Tue, 22 Jun 2021 16:00:08 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id m7cMYp6jgp4b; Tue, 22 Jun 2021 16:00:07 +0200 (CEST) X-Auth-Info: a++jGSmPAFONaQ4x1SL8MTngp4a1U+yc42XbdsKJCr2QJKSNvsEpkSP5BlMShEBd Received: from igel.home (ppp-46-244-162-121.dynamic.mnet-online.de [46.244.162.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 22 Jun 2021 16:00:07 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 044562C3702; Tue, 22 Jun 2021 16:00:06 +0200 (CEST) From: Andreas Schwab References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> <838s32ulcf.fsf@gnu.org> X-Yow: I have accepted Provolone into my life! Date: Tue, 22 Jun 2021 16:00:06 +0200 In-Reply-To: <838s32ulcf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Jun 2021 15:37:04 +0300") Message-ID: <87im26gftl.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jun 22 2021, Eli Zaretskii wrote: >> From: Protesilaos Stavrou >> Cc: 49162@debbugs.gnu.org >> Date: Tue, 22 Jun 2021 15:11:33 +0300 >> >> Thank you Martin and Eli! I picked that symbol because it was already >> given by the implicit face. >> >> You can try it with emacs -Q: >> >> - M-x apropos RET font-lock-variable RET >> - Place point over the underlined "Face" text and M-x describe-char >> - In the resulting Help buffer, you will find the reference to >> 'apropos-face-button', whose specification is defined thus: >> >> Category apropos-face-button: > > That's the _button_, not its _face_. But the new face is the face for the button. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 15:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: 49162@debbugs.gnu.org, info@protesilaos.com Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162437602116946 (code B ref 49162); Tue, 22 Jun 2021 15:34:01 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 15:33:41 +0000 Received: from localhost ([127.0.0.1]:39692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lviPE-0004PG-W3 for submit@debbugs.gnu.org; Tue, 22 Jun 2021 11:33:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lviPD-0004P2-HM for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 11:33:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36150) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lviP7-0003ul-K9; Tue, 22 Jun 2021 11:33:33 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2653 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lviP7-0005Hu-8i; Tue, 22 Jun 2021 11:33:33 -0400 Date: Tue, 22 Jun 2021 18:33:13 +0300 Message-Id: <831r8tvrra.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87im26gftl.fsf@igel.home> (message from Andreas Schwab on Tue, 22 Jun 2021 16:00:06 +0200) References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> <838s32ulcf.fsf@gnu.org> <87im26gftl.fsf@igel.home> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andreas Schwab > Cc: Protesilaos Stavrou , 49162@debbugs.gnu.org > Date: Tue, 22 Jun 2021 16:00:06 +0200 > > >> Category apropos-face-button: > > > > That's the _button_, not its _face_. > > But the new face is the face for the button. I don't have anything about naming the face apropos-button. It's apropos-face-button that I don't like: it implies that it's a button of a face, or something that is apropos button-face; both are wrong. From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 49162@debbugs.gnu.org, info@protesilaos.com Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162437667317957 (code B ref 49162); Tue, 22 Jun 2021 15:45:02 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 15:44:33 +0000 Received: from localhost ([127.0.0.1]:39696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lviZl-0004fZ-29 for submit@debbugs.gnu.org; Tue, 22 Jun 2021 11:44:33 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:40872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lviZg-0004fN-Ch for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 11:44:32 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4G8W0p6jGZz1s2Br; Tue, 22 Jun 2021 17:44:26 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4G8W0p4NQYz1qr3T; Tue, 22 Jun 2021 17:44:26 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id KJSGto9yf0CS; Tue, 22 Jun 2021 17:44:25 +0200 (CEST) X-Auth-Info: DxuwhtzOsZ7FfPd24wQHYzHWhdIkacWS6k/guPOTHYEMsPA8qsaE9wElY915Fp7o Received: from igel.home (ppp-46-244-162-121.dynamic.mnet-online.de [46.244.162.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 22 Jun 2021 17:44:25 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 513552C3716; Tue, 22 Jun 2021 17:44:25 +0200 (CEST) From: Andreas Schwab References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> <838s32ulcf.fsf@gnu.org> <87im26gftl.fsf@igel.home> <831r8tvrra.fsf@gnu.org> X-Yow: Mr and Mrs PED, can I borrow 26.7% of the RAYON TEXTILE production of the INDONESIAN archipelago? Date: Tue, 22 Jun 2021 17:44:25 +0200 In-Reply-To: <831r8tvrra.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Jun 2021 18:33:13 +0300") Message-ID: <87lf71gazq.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Jun 22 2021, Eli Zaretskii wrote: >> From: Andreas Schwab >> Cc: Protesilaos Stavrou , 49162@debbugs.gnu.org >> Date: Tue, 22 Jun 2021 16:00:06 +0200 >> >> >> Category apropos-face-button: >> > >> > That's the _button_, not its _face_. >> >> But the new face is the face for the button. > > I don't have anything about naming the face apropos-button. It's > apropos-face-button that I don't like: it implies that it's a button > of a face, or something that is apropos button-face; both are wrong. But that happens to be the name of the button that the face is for, just like the apropos-variable-button face is the face for the apropos-variable-button button. Since face names have no qualifiers, such duplication is unavoidable. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From unknown Thu Sep 11 11:56:09 2025 X-Loop: help-debbugs@gnu.org Subject: bug#49162: 28.0.50; [PATCH] Use named face for apropos-face-button Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Jun 2021 15:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49162 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: 49162@debbugs.gnu.org, info@protesilaos.com Received: via spool by 49162-submit@debbugs.gnu.org id=B49162.162437729618926 (code B ref 49162); Tue, 22 Jun 2021 15:55:01 +0000 Received: (at 49162) by debbugs.gnu.org; 22 Jun 2021 15:54:56 +0000 Received: from localhost ([127.0.0.1]:39705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvijo-0004v6-Ii for submit@debbugs.gnu.org; Tue, 22 Jun 2021 11:54:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvijm-0004um-6I for 49162@debbugs.gnu.org; Tue, 22 Jun 2021 11:54:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36704) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvijf-0000Fg-Qg; Tue, 22 Jun 2021 11:54:47 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4092 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvijf-00076s-EJ; Tue, 22 Jun 2021 11:54:47 -0400 Date: Tue, 22 Jun 2021 18:54:29 +0300 Message-Id: <83zgvhuc7e.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87lf71gazq.fsf@igel.home> (message from Andreas Schwab on Tue, 22 Jun 2021 17:44:25 +0200) References: <878s333rc3.fsf@protesilaos.com> <83eecuunuw.fsf@gnu.org> <325c9dd4-2f6b-f8a8-bd87-02a8b6f28ba7@gmx.at> <87mtriaykq.fsf@protesilaos.com> <838s32ulcf.fsf@gnu.org> <87im26gftl.fsf@igel.home> <831r8tvrra.fsf@gnu.org> <87lf71gazq.fsf@igel.home> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andreas Schwab > Cc: info@protesilaos.com, 49162@debbugs.gnu.org > Date: Tue, 22 Jun 2021 17:44:25 +0200 > > > I don't have anything about naming the face apropos-button. It's > > apropos-face-button that I don't like: it implies that it's a button > > of a face, or something that is apropos button-face; both are wrong. > > But that happens to be the name of the button that the face is for, just > like the apropos-variable-button face is the face for the > apropos-variable-button button. And they are all unfortunate, IMO. We don't need to keep some kind of consistency here, I think.