From unknown Thu Sep 11 16:39:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49160 <49160@debbugs.gnu.org> To: bug#49160 <49160@debbugs.gnu.org> Subject: Status: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks Reply-To: bug#49160 <49160@debbugs.gnu.org> Date: Thu, 11 Sep 2025 23:39:27 +0000 retitle 49160 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks reassign 49160 emacs submitter 49160 dick severity 49160 normal tag 49160 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 21 15:39:40 2021 Received: (at submit) by debbugs.gnu.org; 21 Jun 2021 19:39:40 +0000 Received: from localhost ([127.0.0.1]:36933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvPli-0001qe-ME for submit@debbugs.gnu.org; Mon, 21 Jun 2021 15:39:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:40858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvPlf-0001qQ-ID for submit@debbugs.gnu.org; Mon, 21 Jun 2021 15:39:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvPle-0003Nn-FO for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2021 15:39:34 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:40727) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lvPla-0000qy-NZ for bug-gnu-emacs@gnu.org; Mon, 21 Jun 2021 15:39:34 -0400 Received: by mail-qv1-xf30.google.com with SMTP id f16so7225886qvs.7 for ; Mon, 21 Jun 2021 12:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=aNo43H+E7mP42SmvUih9B2Z8kA5PZp82+/UZ0ovEiWU=; b=vNTwMEfnmvlv6FusQ9UmtfKZXNFB/i1+pyymB10jESHVYm9Dprh0zjxzgYAwhh5BCC ZVuh5KRExhC/KG7TH/mB6zFiw9vkfBTvtZTAom/f0bm2BzuVQceraWtduEUfYurK99hD 6l8S0qao/92wDatvPNa5rtFKqJY5dSafwXAj7AHTrziCth/K0HF28EdRdXHNicnvTUak ztwFwg5uPQwfmtBi6QEwwUrvW3dShob9kziVzjDYAVXqg0U3POP5fg7vIhScBHq60+Q4 x7U7/iFgy/itQvQ6bfVwTL9lQFoKUVxN9bQxk+QNogJ0j9pPmftJr6elrh1bYcg5iucZ O+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=aNo43H+E7mP42SmvUih9B2Z8kA5PZp82+/UZ0ovEiWU=; b=PGf1JOB96QfR9n25yJFBvXqVkAbp4Rpk1wRzv+TbDvrx4izdINf3NXqNt9SdzvyMXj 0p/1kBR9YkvTvNGxvSsbHW9IZ9zbSq3mwujvE/JvT23RgdzwxE9d4eO4PGsIVOJ/ySay MjvISmHJYKjQedm360YmekJNMeE9kBPok2sO7/mptvk/WS8w7zN0LkEUl9pK3+2pkatT wfMy8RunRjr3XF28xWt1qZOA29b7JoT0u5K+yiI54ymge6W5oqLh7yc9Akl21CDw9S8S XoLPnro6tBnrl/A572JmDOwfQ08oyjzTvBZQT8xJcMH/gznBZSrxNvChV34VPQVeYY/O WCUQ== X-Gm-Message-State: AOAM533nPc8V2gbp91wgh/2BZd1mONT4NWpkkb1aNJUsRUQYsnuIxHFC mVD+LiFNIEhJ7OgL4fp/9PbYqryl+0o= X-Google-Smtp-Source: ABdhPJwuZV8tFQv9lJGfoTU0uzH01AuzxTEi11fc06i7ZT+HROVt3OZ87BmrUwtzM6ajty6lwoAaQg== X-Received: by 2002:a0c:e6c6:: with SMTP id l6mr18220319qvn.39.1624304368159; Mon, 21 Jun 2021 12:39:28 -0700 (PDT) Received: from localhost (pool-71-190-212-171.nycmny.fios.verizon.net. [71.190.212.171]) by smtp.gmail.com with ESMTPSA id q184sm10053507qkd.35.2021.06.21.12.39.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jun 2021 12:39:27 -0700 (PDT) From: dick To: bug-gnu-emacs@gnu.org Subject: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks Date: Mon, 21 Jun 2021 15:39:26 -0400 Message-ID: <874kdratxt.fsf@dick> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::f30; envelope-from=dick.r.chiang@gmail.com; helo=mail-qv1-xf30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain It's random whether buffers created outside `get-buffer-create`, i.e., indirect buffers, call kill-buffer hooks. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Uninitialized-inhibit-buffer-hooks.patch >From 84bee9ae521e702f0368d1cdf785252944a40574 Mon Sep 17 00:00:00 2001 From: dickmao Date: Mon, 21 Jun 2021 15:36:46 -0400 Subject: [PATCH] Uninitialized inhibit-buffer-hooks It's random whether buffers created outside `get-buffer-create`, i.e., indirect buffers, call kill-buffer hooks. * src/buffer.c (Fmake_indirect_buffer): Match base buffer's inhibit-buffer-hooks. * test/src/buffer-tests.el (buffer-tests-inhibit-buffer-hooks-indirect): Add a test. --- src/buffer.c | 1 + test/src/buffer-tests.el | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/src/buffer.c b/src/buffer.c index 565577e75a..5ba1682606 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -834,6 +834,7 @@ DEFUN ("make-indirect-buffer", Fmake_indirect_buffer, Smake_indirect_buffer, b->pt_byte = b->base_buffer->pt_byte; b->begv_byte = b->base_buffer->begv_byte; b->zv_byte = b->base_buffer->zv_byte; + b->inhibit_buffer_hooks = b->base_buffer->inhibit_buffer_hooks; b->newline_cache = 0; b->width_run_cache = 0; diff --git a/test/src/buffer-tests.el b/test/src/buffer-tests.el index 123f2e8eab..0161927419 100644 --- a/test/src/buffer-tests.el +++ b/test/src/buffer-tests.el @@ -1361,4 +1361,28 @@ buffer-tests-inhibit-buffer-hooks (should run-kbqf)) (remove-hook 'buffer-list-update-hook bluh)))) +(ert-deftest buffer-tests-inhibit-buffer-hooks-indirect () + "Indirect buffers do not call `get-buffer-create'." + (dolist (inhibit '(nil t)) + (let ((base (get-buffer-create "foo" inhibit))) + (unwind-protect + (dotimes (_i 11) + (let* (flag* + (flag (lambda () (prog1 t (setq flag* t)))) + (indirect (make-indirect-buffer base "foo[indirect]"))) + (unwind-protect + (progn + (with-current-buffer indirect + (add-hook 'kill-buffer-query-functions flag nil t)) + (kill-buffer indirect) + (if inhibit + (should-not flag*) + (should flag*))) + (let (kill-buffer-query-functions) + (when (buffer-live-p indirect) + (kill-buffer indirect)))))) + (let (kill-buffer-query-functions) + (when (buffer-live-p base) + (kill-buffer base))))))) + ;;; buffer-tests.el ends here -- 2.26.2 --=-=-= Content-Type: text/plain In GNU Emacs 28.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2021-06-16 built on dick Repository revision: 1aece73f02724f283bea73e374f6f7f2b4af3b50 Repository branch: gnus-dev-28 Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.4 LTS Configured using: 'configure --prefix=/home/dick/.local PKG_CONFIG_PATH=/home/dick/.local/lib/pkgconfig' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Magit Rev Minor modes in effect: goto-address-mode: t async-bytecomp-package-mode: t global-git-commit-mode: t magit-auto-revert-mode: t bug-reference-mode: t show-paren-mode: t projectile-mode: t flx-ido-mode: t override-global-mode: t shell-dirtrack-mode: t beacon-mode: t global-hl-line-mode: t winner-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/dick/ESS/lisp/obsolete/ess-swv hides /home/dick/ESS/lisp/ess-swv /home/dick/ESS/lisp/obsolete/ess-rutils hides /home/dick/ESS/lisp/ess-rutils /home/dick/ESS/lisp/obsolete/ess-noweb hides /home/dick/ESS/lisp/ess-noweb /home/dick/ESS/lisp/obsolete/mouseme hides /home/dick/ESS/lisp/mouseme /home/dick/ESS/lisp/obsolete/ess-mouse hides /home/dick/ESS/lisp/ess-mouse /home/dick/ESS/lisp/obsolete/ess-noweb-mode hides /home/dick/ESS/lisp/ess-noweb-mode /home/dick/ESS/lisp/obsolete/make-regexp hides /home/dick/ESS/lisp/make-regexp /home/dick/ESS/lisp/obsolete/ess-r-a hides /home/dick/ESS/lisp/ess-r-a /home/dick/ESS/lisp/obsolete/ess-noweb-font-lock-mode hides /home/dick/ESS/lisp/ess-noweb-font-lock-mode /home/dick/gomacro-mode/gomacro-mode hides /home/dick/.emacs.d/elpa/gomacro-mode-20200326.1103/gomacro-mode /home/dick/ESS/lisp/julia-mode hides /home/dick/.emacs.d/elpa/julia-mode-20200717.1915/julia-mode /home/dick/ESS/lisp/julia-mode-latexsubs hides /home/dick/.emacs.d/elpa/julia-mode-20200717.1915/julia-mode-latexsubs /home/dick/.emacs.d/elpa/hydra-20170924.2259/lv hides /home/dick/.emacs.d/elpa/lv-20191106.1238/lv /home/dick/org-gcal.el/org-gcal hides /home/dick/.emacs.d/elpa/org-gcal-0.3/org-gcal /home/dick/.emacs.d/elpa/async-20200113.1745/async-autoloads hides /home/dick/.local/share/emacs/site-lisp/emacs-async/async-autoloads /home/dick/.emacs.d/elpa/async-20200113.1745/async-bytecomp hides /home/dick/.local/share/emacs/site-lisp/emacs-async/async-bytecomp /home/dick/.emacs.d/elpa/async-20200113.1745/smtpmail-async hides /home/dick/.local/share/emacs/site-lisp/emacs-async/smtpmail-async /home/dick/.emacs.d/elpa/async-20200113.1745/dired-async hides /home/dick/.local/share/emacs/site-lisp/emacs-async/dired-async /home/dick/.emacs.d/elpa/async-20200113.1745/async hides /home/dick/.local/share/emacs/site-lisp/emacs-async/async /home/dick/.emacs.d/elpa/async-20200113.1745/async-pkg hides /home/dick/.local/share/emacs/site-lisp/emacs-async/async-pkg /home/dick/.emacs.d/lisp/json hides /home/dick/.local/share/emacs/28.0.50/lisp/json /home/dick/.emacs.d/elpa/transient-20210221.2251/transient hides /home/dick/.local/share/emacs/28.0.50/lisp/transient /home/dick/.emacs.d/elpa/org-9.4.5/ob-eval hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-eval /home/dick/.emacs.d/elpa/org-9.4.5/ob-perl hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-perl /home/dick/.emacs.d/elpa/org-9.4.5/ob-eshell hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-eshell /home/dick/.emacs.d/elpa/org-9.4.5/ob-abc hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-abc /home/dick/.emacs.d/elpa/org-9.4.5/ob-tangle hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-tangle /home/dick/.emacs.d/elpa/org-9.4.5/ob-vala hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-vala /home/dick/.emacs.d/elpa/org-9.4.5/org-attach-git hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-attach-git /home/dick/.emacs.d/elpa/org-9.4.5/org-ctags hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-ctags /home/dick/.emacs.d/elpa/org-9.4.5/ob-table hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-table /home/dick/.emacs.d/elpa/org-9.4.5/org-element hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-element /home/dick/.emacs.d/elpa/org-9.4.5/org-colview hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-colview /home/dick/.emacs.d/elpa/org-9.4.5/ol-mhe hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-mhe /home/dick/.emacs.d/elpa/org-9.4.5/ob-stan hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-stan /home/dick/.emacs.d/elpa/org-9.4.5/org-table hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-table /home/dick/.emacs.d/elpa/org-9.4.5/org-keys hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-keys /home/dick/.emacs.d/elpa/org-9.4.5/ol hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol /home/dick/.emacs.d/elpa/org-9.4.5/ob-dot hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-dot /home/dick/.emacs.d/elpa/org-9.4.5/ob-js hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-js /home/dick/.emacs.d/elpa/org-9.4.5/ob-clojure hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-clojure /home/dick/.emacs.d/elpa/org-9.4.5/ob-fortran hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-fortran /home/dick/.emacs.d/elpa/org-9.4.5/org-refile hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-refile /home/dick/.emacs.d/elpa/org-9.4.5/org-clock hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-clock /home/dick/.emacs.d/elpa/org-9.4.5/ob-sql hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-sql /home/dick/.emacs.d/elpa/org-9.4.5/ob-exp hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-exp /home/dick/.emacs.d/elpa/org-9.4.5/ob-asymptote hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-asymptote /home/dick/.emacs.d/elpa/org-9.4.5/ob-org hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-org /home/dick/.emacs.d/elpa/org-9.4.5/org-compat hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-compat /home/dick/.emacs.d/elpa/org-9.4.5/ob-python hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-python /home/dick/.emacs.d/elpa/org-9.4.5/ob-ref hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-ref /home/dick/.emacs.d/elpa/org-9.4.5/ox hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox /home/dick/.emacs.d/elpa/org-9.4.5/ob-C hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-C /home/dick/.emacs.d/elpa/org-9.4.5/ol-info hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-info /home/dick/.emacs.d/elpa/org-9.4.5/org-tempo hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-tempo /home/dick/.emacs.d/elpa/org-9.4.5/ox-md hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-md /home/dick/.emacs.d/elpa/org-9.4.5/ob-screen hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-screen /home/dick/.emacs.d/elpa/org-9.4.5/ob-lisp hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-lisp /home/dick/.emacs.d/elpa/org-9.4.5/ob-lua hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-lua /home/dick/.emacs.d/elpa/org-9.4.5/ob-matlab hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-matlab /home/dick/.emacs.d/elpa/org-9.4.5/org-list hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-list /home/dick/.emacs.d/elpa/org-9.4.5/ob-groovy hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-groovy /home/dick/.emacs.d/elpa/org-9.4.5/ol-docview hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-docview /home/dick/.emacs.d/elpa/org-9.4.5/ob-ebnf hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-ebnf /home/dick/.emacs.d/elpa/org-9.4.5/ob-forth hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-forth /home/dick/.emacs.d/elpa/org-9.4.5/ox-html hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-html /home/dick/.emacs.d/elpa/org-9.4.5/ob-io hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-io /home/dick/.emacs.d/elpa/org-9.4.5/org-faces hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-faces /home/dick/.emacs.d/elpa/org-9.4.5/ob-emacs-lisp hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-emacs-lisp /home/dick/.emacs.d/elpa/org-9.4.5/ob-ocaml hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-ocaml /home/dick/.emacs.d/elpa/org-9.4.5/ol-bbdb hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-bbdb /home/dick/.emacs.d/elpa/org-9.4.5/org-lint hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-lint /home/dick/.emacs.d/elpa/org-9.4.5/ob-shen hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-shen /home/dick/.emacs.d/elpa/org-9.4.5/org-loaddefs hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-loaddefs /home/dick/.emacs.d/elpa/org-9.4.5/ob-scheme hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-scheme /home/dick/.emacs.d/elpa/org-9.4.5/org-protocol hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-protocol /home/dick/.emacs.d/elpa/org-9.4.5/ob-maxima hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-maxima /home/dick/.emacs.d/elpa/org-9.4.5/ox-latex hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-latex /home/dick/.emacs.d/elpa/org-9.4.5/ob-mscgen hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-mscgen /home/dick/.emacs.d/elpa/org-9.4.5/ob-R hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-R /home/dick/.emacs.d/elpa/org-9.4.5/ob-sed hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-sed /home/dick/.emacs.d/elpa/org-9.4.5/org hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org /home/dick/.emacs.d/elpa/org-9.4.5/org-plot hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-plot /home/dick/.emacs.d/elpa/org-9.4.5/ox-beamer hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-beamer /home/dick/.emacs.d/elpa/org-9.4.5/org-pcomplete hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-pcomplete /home/dick/.emacs.d/elpa/org-9.4.5/ob-plantuml hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-plantuml /home/dick/.emacs.d/elpa/org-9.4.5/ox-publish hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-publish /home/dick/.emacs.d/elpa/org-9.4.5/ob-java hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-java /home/dick/.emacs.d/elpa/org-9.4.5/ol-eww hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-eww /home/dick/.emacs.d/elpa/org-9.4.5/org-macs hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-macs /home/dick/.emacs.d/elpa/org-9.4.5/ol-eshell hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-eshell /home/dick/.emacs.d/elpa/org-9.4.5/org-src hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-src /home/dick/.emacs.d/elpa/org-9.4.5/ol-rmail hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-rmail /home/dick/.emacs.d/elpa/org-9.4.5/org-datetree hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-datetree /home/dick/.emacs.d/elpa/org-9.4.5/ob-J hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-J /home/dick/.emacs.d/elpa/org-9.4.5/ob-shell hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-shell /home/dick/.emacs.d/elpa/org-9.4.5/org-archive hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-archive /home/dick/.emacs.d/elpa/org-9.4.5/org-habit hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-habit /home/dick/.emacs.d/elpa/org-9.4.5/ob-picolisp hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-picolisp /home/dick/.emacs.d/elpa/org-9.4.5/org-capture hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-capture /home/dick/.emacs.d/elpa/org-9.4.5/ob-core hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-core /home/dick/.emacs.d/elpa/org-9.4.5/ob-octave hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-octave /home/dick/.emacs.d/elpa/org-9.4.5/org-mobile hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-mobile /home/dick/.emacs.d/elpa/org-9.4.5/ol-bibtex hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-bibtex /home/dick/.emacs.d/elpa/org-9.4.5/org-goto hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-goto /home/dick/.emacs.d/elpa/org-9.4.5/ox-odt hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-odt /home/dick/.emacs.d/elpa/org-9.4.5/ob-calc hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-calc /home/dick/.emacs.d/elpa/org-9.4.5/ob-gnuplot hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-gnuplot /home/dick/.emacs.d/elpa/org-9.4.5/org-macro hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-macro /home/dick/.emacs.d/elpa/org-9.4.5/ob hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob /home/dick/.emacs.d/elpa/org-9.4.5/ob-comint hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-comint /home/dick/.emacs.d/elpa/org-9.4.5/ob-ditaa hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-ditaa /home/dick/.emacs.d/elpa/org-9.4.5/org-duration hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-duration /home/dick/.emacs.d/elpa/org-9.4.5/org-entities hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-entities /home/dick/.emacs.d/elpa/org-9.4.5/org-agenda hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-agenda /home/dick/.emacs.d/elpa/org-9.4.5/ox-ascii hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-ascii /home/dick/.emacs.d/elpa/org-9.4.5/org-num hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-num /home/dick/.emacs.d/elpa/org-9.4.5/ob-awk hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-awk /home/dick/.emacs.d/elpa/org-9.4.5/ob-ruby hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-ruby /home/dick/.emacs.d/elpa/org-9.4.5/ox-man hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-man /home/dick/.emacs.d/elpa/org-9.4.5/ob-sqlite hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-sqlite /home/dick/.emacs.d/elpa/org-9.4.5/ol-gnus hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-gnus /home/dick/.emacs.d/elpa/org-9.4.5/org-attach hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-attach /home/dick/.emacs.d/elpa/org-9.4.5/org-inlinetask hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-inlinetask /home/dick/.emacs.d/elpa/org-9.4.5/ob-coq hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-coq /home/dick/.emacs.d/elpa/org-9.4.5/org-feed hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-feed /home/dick/.emacs.d/elpa/org-9.4.5/ob-hledger hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-hledger /home/dick/.emacs.d/elpa/org-9.4.5/org-crypt hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-crypt /home/dick/.emacs.d/elpa/org-9.4.5/ol-irc hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-irc /home/dick/.emacs.d/elpa/org-9.4.5/ob-css hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-css /home/dick/.emacs.d/elpa/org-9.4.5/ob-haskell hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-haskell /home/dick/.emacs.d/elpa/org-9.4.5/org-footnote hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-footnote /home/dick/.emacs.d/elpa/org-9.4.5/org-indent hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-indent /home/dick/.emacs.d/elpa/org-9.4.5/ox-icalendar hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-icalendar /home/dick/.emacs.d/elpa/org-9.4.5/ob-processing hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-processing /home/dick/.emacs.d/elpa/org-9.4.5/ob-ledger hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-ledger /home/dick/.emacs.d/elpa/org-9.4.5/org-id hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-id /home/dick/.emacs.d/elpa/org-9.4.5/ox-org hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-org /home/dick/.emacs.d/elpa/org-9.4.5/ob-lob hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-lob /home/dick/.emacs.d/elpa/org-9.4.5/ob-latex hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-latex /home/dick/.emacs.d/elpa/org-9.4.5/ol-w3m hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ol-w3m /home/dick/.emacs.d/elpa/org-9.4.5/org-timer hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-timer /home/dick/.emacs.d/elpa/org-9.4.5/ob-makefile hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-makefile /home/dick/.emacs.d/elpa/org-9.4.5/ob-lilypond hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-lilypond /home/dick/.emacs.d/elpa/org-9.4.5/ox-texinfo hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ox-texinfo /home/dick/.emacs.d/elpa/org-9.4.5/ob-sass hides /home/dick/.local/share/emacs/28.0.50/lisp/org/ob-sass /home/dick/.emacs.d/elpa/org-9.4.5/org-mouse hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-mouse /home/dick/.emacs.d/elpa/org-9.4.5/org-version hides /home/dick/.local/share/emacs/28.0.50/lisp/org/org-version /home/dick/.emacs.d/elpa/hierarchy-20171221.1151/hierarchy hides /home/dick/.local/share/emacs/28.0.50/lisp/emacs-lisp/hierarchy Features: (shadow sort flyspell ispell footnote mail-extr gnus-msg emacsbug git-rebase rect eieio-compat package-x package-recipe make-mode ivy delsel colir ivy-overlay ffap dumb-jump f debug backtrace goto-addr completion magit-extras pulse vc-mtn vc-hg vc-bzr vc-src vc-sccs vc-cvs vc-rcs face-remap magit-patch-changelog magit-patch magit-submodule magit-obsolete magit-popup async-bytecomp async magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff git-commit log-edit pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor server magit-mode transient magit-git magit-section benchmark magit-utils crm ein-jupyter ein-dev ein-notebook python tramp-sh ein-python-send ein-traceback ein-shared-output ein-pytools ein-pager view ein-completer ein-notification ein-scratchsheet ein-worksheet poly-ein display-line-numbers quail polymode poly-lock polymode-base polymode-weave polymode-export polymode-compat polymode-methods polymode-core polymode-classes eieio-custom eieio-base ein-kill-ring ein-kernelinfo ein-file ein-notebooklist ein-contents-api eieio-opt speedbar ezimage dframe shortdoc autoload lisp-mnt vc bug-reference google-c-style tramp-archive tramp-gvfs tramp-cache zeroconf tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat ls-lisp cl-print help-fns radix-tree ag vc-svn s misearch multi-isearch vc-git diff-mode vc-dispatcher paredit-ext paredit mu4e mu4e-org mu4e-main mu4e-view mu4e-view-gnus gnus-art mm-uu mml2015 mm-view mml-smime smime dig mu4e-view-common mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions rfc2368 smtpmail sendmail mu4e-mark mu4e-proc mu4e-utils doc-view jka-compr image-mode exif mu4e-lists mu4e-message flow-fill org-tempo tempo org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-R ob-emacs-lisp ob-ein ein-cell ein-output-area ein-kernel ein-ipdb ein-query ein-events ein-websocket websocket bindat ein-node ewoc ein-log ein-classes ein-core request autorevert filenotify ein ein-utils deferred cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs ob ob-tangle org-src ob-ref ob-lob ob-table ob-exp ob-comint ob-core ob-eval org-table ol org-keys org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs gnus-sum shr kinsoku svg dom gnus-group mm-url gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time iso8601 gnus-spec gnus-int gnus-range gnus-win mule-util mu4e-vars message rmc puny rfc822 mml mml-sec epa epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader mu4e-meta subed subed-vtt subed-srt subed-common subed-mpv subed-debug subed-config dired-x inf-ruby ruby-mode smie ht dash anaphora a company haskell-interactive-mode haskell-presentation-mode haskell-process haskell-session haskell-compile haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme rx haskell-align-imports haskell-complete-module haskell-ghc-support etags fileloop generator dabbrev haskell-customize hydra lv use-package-ensure paren solarized-theme solarized-definitions projectile skeleton ibuf-macs find-dired dired dired-loaddefs ibuf-ext ibuffer ibuffer-loaddefs grep gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date flx-ido flx google-translate-default-ui google-translate-core-ui facemenu color ido google-translate-core google-translate-tk google-translate-backend use-package-bind-key bind-key auto-complete advice popup cus-edit pp cus-load wid-edit ess-r-mode ess-r-flymake flymake-proc flymake warnings thingatpt ess-r-xref xref ess-trns ess-r-package shell pcomplete ess-r-completion ess-roxy ess-r-syntax ess-rd noutline outline hideshow ess-s-lang ess-help ess-mode ess-inf project format-spec ess-tracebug ess ess-utils ess-custom compile text-property-search comint ansi-color emms-player-mplayer emms-player-simple emms emms-compat cl-extra help-mode use-package-core derived beacon easy-mmode pcase hl-line winner ring edmacro kmacro finder-inf json-reformat-autoloads json-snatcher-autoloads sml-mode-autoloads tornado-template-mode-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 1151579 186123) (symbols 48 51323 67) (strings 32 203238 28952) (string-bytes 1 6569076) (vectors 16 93439) (vector-slots 8 2236684 175533) (floats 8 731 3660) (intervals 56 51935 8732) (buffers 992 56)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 22 07:41:41 2021 Received: (at 49160) by debbugs.gnu.org; 22 Jun 2021 11:41:41 +0000 Received: from localhost ([127.0.0.1]:37985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvemj-0005Wm-KS for submit@debbugs.gnu.org; Tue, 22 Jun 2021 07:41:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lvemi-0005Wa-EZ for 49160@debbugs.gnu.org; Tue, 22 Jun 2021 07:41:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55874) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lvemd-0000bM-7C; Tue, 22 Jun 2021 07:41:35 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4158 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lvemc-0006Cl-Pw; Tue, 22 Jun 2021 07:41:35 -0400 Date: Tue, 22 Jun 2021 14:41:17 +0300 Message-Id: <83fsxaunxe.fsf@gnu.org> From: Eli Zaretskii To: dick In-Reply-To: <874kdratxt.fsf@dick> (message from dick on Mon, 21 Jun 2021 15:39:26 -0400) Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks References: <874kdratxt.fsf@dick> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: 49160@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: dick > Date: Mon, 21 Jun 2021 15:39:26 -0400 > > It's random whether buffers created outside `get-buffer-create`, i.e., > indirect buffers, call kill-buffer hooks. Please in the future try to be more explicit in describing the problem. "It is random" isn't explicit enough. More to the point: since this attribute of a buffer cannot be changed once the buffer is created, I think it might be okay to copy from the base buffer, but we should also allow the caller to control that by introducing an optional argument similar to that of get-buffer-create. And if we do that, we could also consider making the default value be nil, not necessarily a copy of that of the base buffer. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 19 12:23:48 2021 Received: (at 49160) by debbugs.gnu.org; 19 Jul 2021 16:23:48 +0000 Received: from localhost ([127.0.0.1]:60108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5W3Y-0004oq-6x for submit@debbugs.gnu.org; Mon, 19 Jul 2021 12:23:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5W3W-0004od-7h for 49160@debbugs.gnu.org; Mon, 19 Jul 2021 12:23:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AUgqvt3/f/suSG4nrbnEcx74ZY8Nc+iATncKtCotL4U=; b=PGqxRtng5eYYalfRJyuTdT48XI ao7ENhWriAcYAWihoxfoyAEs8Eio7Eu2w9d2HNGFJECaChSyN7W1Zvm1e6qGG+H0kl+1g2GTb5Gf7 NYz8pX1IPzOb6C5XfPlLKf0wdErwgcYqs+6jvsKNzxKzar412W0vFZ2gznWiQS2kI6Pc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5W3M-0000LE-Lp; Mon, 19 Jul 2021 18:23:39 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> X-Now-Playing: Aksak Maboul's _Before and After Bandits_: "Onze Dents-Son of l'Idiot (live)" Date: Mon, 19 Jul 2021 18:23:36 +0200 In-Reply-To: <83fsxaunxe.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 22 Jun 2021 14:41:17 +0300") Message-ID: <87a6mijmrb.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > More to the point: since this attribute of a buffer cannot be changed > once the buffer is created, I think it might be okay to copy from the > base buffer, but we should also allow the caller to co [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: 49160@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > More to the point: since this attribute of a buffer cannot be changed > once the buffer is created, I think it might be okay to copy from the > base buffer, but we should also allow the caller to control that by > introducing an optional argument similar to that of get-buffer-create. > And if we do that, we could also consider making the default value be > nil, not necessarily a copy of that of the base buffer. I've now applied Dick's patch, and then adjusted as you suggest. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 19 12:23:56 2021 Received: (at control) by debbugs.gnu.org; 19 Jul 2021 16:23:56 +0000 Received: from localhost ([127.0.0.1]:60111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5W3g-0004pB-GU for submit@debbugs.gnu.org; Mon, 19 Jul 2021 12:23:56 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5W3f-0004oz-3Z for control@debbugs.gnu.org; Mon, 19 Jul 2021 12:23:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=n3IyH25HvsMtVxQRB0voVSGZLB1b+3vxNp8WBi7mQfA=; b=ZyVc+FL/4ordxplwkT6RIAOzNd dPDeIXpvoxddz6Cjoipuuv00CoigusU9YzVv9S6uc3Xnx5acUi0KrtJZZ/KBV15Xj0kK/GlrQGrxk FMbYq/XnVCqI8INaDSmIEQn6SITbmfHwD/e1tj3MJqG/zNZUkhwzsD/4Qck3PiRbUGk8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5W3X-0000LN-5c for control@debbugs.gnu.org; Mon, 19 Jul 2021 18:23:49 +0200 Date: Mon, 19 Jul 2021 18:23:41 +0200 Message-Id: <878s22jmr6.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49160 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49160 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49160 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 19 12:47:42 2021 Received: (at 49160) by debbugs.gnu.org; 19 Jul 2021 16:47:42 +0000 Received: from localhost ([127.0.0.1]:60145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5WQg-0007ca-09 for submit@debbugs.gnu.org; Mon, 19 Jul 2021 12:47:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5WQd-0007cN-Mm for 49160@debbugs.gnu.org; Mon, 19 Jul 2021 12:47:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49494) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5WQY-0002F3-3g; Mon, 19 Jul 2021 12:47:34 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1728 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5WQX-0007zR-O8; Mon, 19 Jul 2021 12:47:34 -0400 Date: Mon, 19 Jul 2021 19:47:27 +0300 Message-Id: <83tukq5jz4.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87a6mijmrb.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 19 Jul 2021 18:23:36 +0200) Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: 49160@debbugs.gnu.org, dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: dick , 49160@debbugs.gnu.org > Date: Mon, 19 Jul 2021 18:23:36 +0200 > > Eli Zaretskii writes: > > > More to the point: since this attribute of a buffer cannot be changed > > once the buffer is created, I think it might be okay to copy from the > > base buffer, but we should also allow the caller to control that by > > introducing an optional argument similar to that of get-buffer-create. > > And if we do that, we could also consider making the default value be > > nil, not necessarily a copy of that of the base buffer. > > I've now applied Dick's patch, and then adjusted as you suggest. Thanks. From unknown Thu Sep 11 16:39:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 17 Aug 2021 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 14:31:04 2023 Received: (at control) by debbugs.gnu.org; 11 Jan 2023 19:31:04 +0000 Received: from localhost ([127.0.0.1]:43912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFgoS-00035s-FT for submit@debbugs.gnu.org; Wed, 11 Jan 2023 14:31:04 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:45013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFgoO-00035M-Ny for control@debbugs.gnu.org; Wed, 11 Jan 2023 14:31:03 -0500 Received: by mail-wr1-f43.google.com with SMTP id bk16so16067685wrb.11 for ; Wed, 11 Jan 2023 11:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Z4xSOcnpMvQs/IVsjD3ndZK683NXi5u2RMM1VrpMKKI=; b=JlKASYVAgYeA+0PvL2b01V2rd7nfvKsnyTJJqSyX7X8B/GccRRoS8DTygeT9JW24XR 5R1umlPMhfqKXv4dGUW1DUUQAMiHvZ6Gj9/JJVHdPZjW7ILYQtl/2AAXpHL8wbckFYGa Ncu2RsYxS4uK9cKDjxWRUVkUCwk5FIYv80n6fX3uyAI+S6mb7xbAkX6wONtFozfdtMWY gW4H2SdVTMpjAbjk6tHAN7brgrAuYZF9CW7boJPJuCI9T9GGnzMdoMeViVzUn5ViBtMF IHldhcdmfwVIhiTo8KL2W9cdAvR0ifgXHLHZYEueiG3ZuubKNe0sl9YupBb12Tdr8IC7 /V0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Z4xSOcnpMvQs/IVsjD3ndZK683NXi5u2RMM1VrpMKKI=; b=IiPkCx8fbUcqsSV6vOCRcks/F0/pjx6ITYaiRsDlWpc7AEKvQP/mHFyM0hMmfCaKC8 wMcg1fsTwMJAXKegGv6+Zs3UuZSsctQFlfVNPhJUJ2Idn1Y/XPXwI3cc4/CAo3jBrsIi tyipyhrSHCJqsmlc7wZuKaT9IduVvXOA9TCTxcpNZaI5TnAdz5Tqw2VVV4tDESk4AgyZ JlfmVvj5gRe7GYu2yMLF6FGjghGpZs9MuRPMJkZ63JlYxdBTP5CTQUmfdkPmD4i8vRrP Tz92uxN7dj19YGVBMEvkjuufndZiF5xwzmPGsXMZe5Xh6ngjQQ2PWRKD2Cgzs2KHReev brzw== X-Gm-Message-State: AFqh2kqdsY6xYKaNGaIMPaCObP9nVG7qZaA798hwkBbTvwlcLMan40q6 XYmteYmAaVr/4kKLtUs9XhpbG7/nST4d/I+9 X-Google-Smtp-Source: AMrXdXuMbuoo7pInmGyAEJNrGYx7hTFeXODturD0eCCacQtDSeRBL8oaK6R3qyxlq4ELHO8mnSFSig== X-Received: by 2002:a5d:4526:0:b0:2bb:3290:2541 with SMTP id j6-20020a5d4526000000b002bb32902541mr12278988wra.44.1673465454494; Wed, 11 Jan 2023 11:30:54 -0800 (PST) Received: from localhost ([109.78.59.75]) by smtp.gmail.com with ESMTPSA id t6-20020adfe446000000b002bb28209744sm14201599wrm.31.2023.01.11.11.30.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:30:54 -0800 (PST) From: "Basil L. Contovounesios" To: control@debbugs.gnu.org Subject: control message for bug #49160 Date: Wed, 11 Jan 2023 19:30:52 +0000 Message-ID: <87ilhcyikz.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) unarchive 49160 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 15:13:33 2023 Received: (at 49160) by debbugs.gnu.org; 11 Jan 2023 20:13:33 +0000 Received: from localhost ([127.0.0.1]:43954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFhTY-0006TQ-Vp for submit@debbugs.gnu.org; Wed, 11 Jan 2023 15:13:33 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:55153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFhTV-0006TB-Ra for 49160@debbugs.gnu.org; Wed, 11 Jan 2023 15:13:31 -0500 Received: by mail-wm1-f50.google.com with SMTP id o15so11853794wmr.4 for <49160@debbugs.gnu.org>; Wed, 11 Jan 2023 12:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EuslCVM6Xgyl9GP/at7HAFs1H1YanpuChXpRoh/Sx9U=; b=fI5h0hkNg7vZcmpM8/GX2ouOC+YknlQNNVRxZxwT84uzio28yyJIYpcozarwFKtwzA tcvDtJcNovtvZLfLsAOAC5myEIjn/Y7XqjGldTbP7EPZgozst0seYZdA9HFCR6apxTNl LDm8Kr6YUotg5T1OalTgLNMmN/K6/Ix5CxM2TjTgo3F8JttaTw+RPKAIyocISein8Nl8 F11j8eCO5NMVC1CrR1e4Uy7rqwEOKGharEvGvjcs+pPQsxxXG6Nh05Ks5piUKOEgg+ui VD48wJ0xwruuElO9Cv3zYSRpKO6KNKX5rN+31xgFS1Lu4aqTGxRQTGtMLK7ZweOY2R6r ePbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EuslCVM6Xgyl9GP/at7HAFs1H1YanpuChXpRoh/Sx9U=; b=BiP4LTQTUbF+ZEmgUdTdjb4N/Vrkq1p8gaW5yaW+ykf7F+IDGccPV8wXUsHy/fAzBA vGRlnQsKxDe095u4RoYZhCNeUGeqjutunCFLHINcd6ymSTLWVg0QpbBnvsrQPQWdSR2c gA/MDMV0eYvn9OYHlvPpA1uchUwNKTLJq8Oxsk/jRasCorTUCyiwpu40sg49hax6uDRl iwNUsXVcNswkomCurMxUvXnDuF4wRqC+ERM6XM3fX7X6srCD+5XRt1w6m8CRZRc4ELyT xX8de/fOQygvjTKdsdP6NTHBav9Uq4tZP1XbW1G93LUOyxOKRzzwVP4JgpeOPAgnkPpL 47FQ== X-Gm-Message-State: AFqh2kp+s9gjRkFu5jz3zn30cZ9ORGpCIINKTtVfuAfMA341mSMWGq2a Vo0FVLeDdGEniuG9FLA7BKEhQQ== X-Google-Smtp-Source: AMrXdXu3cKFpLhl9VKU50halaIfhgZTegrm3Gf0kjoWUF4v/ljP6sNHmVRt9jH+pbJApg2pCS34IGw== X-Received: by 2002:a05:600c:502a:b0:3da:9df:c4b9 with SMTP id n42-20020a05600c502a00b003da09dfc4b9mr3005998wmr.37.1673468003737; Wed, 11 Jan 2023 12:13:23 -0800 (PST) Received: from localhost ([109.78.59.75]) by smtp.gmail.com with ESMTPSA id y7-20020a7bcd87000000b003d997e5e679sm22019565wmj.14.2023.01.11.12.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 12:13:23 -0800 (PST) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks In-Reply-To: <87a6mijmrb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Jul 2021 18:23:36 +0200") References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> Date: Wed, 11 Jan 2023 20:13:21 +0000 Message-ID: <87sfggx21q.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49160 Cc: Eli Zaretskii , 49160@debbugs.gnu.org, dick X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen [2021-07-19 18:23 +0200] wrote: > Eli Zaretskii writes: > >> More to the point: since this attribute of a buffer cannot be changed >> once the buffer is created, I think it might be okay to copy from the >> base buffer, but we should also allow the caller to control that by >> introducing an optional argument similar to that of get-buffer-create. >> And if we do that, we could also consider making the default value be >> nil, not necessarily a copy of that of the base buffer. > > I've now applied Dick's patch, and then adjusted as you suggest. Fmake_indirect_buffer continues to run buffer-list-update-hook regardless of the new argument. Any objections to changing that? --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-buffer-list-update-hook-for-indirect-buffers.patch >From 0fdf0cb925088d0b5a019df2bbf803e550bebbd5 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 11 Jan 2023 16:34:07 +0000 Subject: [PATCH] Fix buffer-list-update-hook for indirect buffers Fmake_indirect_buffer can be told whether to run buffer hooks since bug#49160, but until now it ran buffer-list-update-hook irrespective of this. * src/buffer.c (Fmake_indirect_buffer): Don't run buffer-list-update-hook when called with a non-nil INHIBIT-BUFFER-HOOKS argument. (run_buffer_list_update_hook): Don't special-case NULL argument, as no such callers remain. * test/src/buffer-tests.el (buffer-tests-inhibit-buffer-hooks-indirect): Test whether indirect buffer hooks are run regardless of whether base buffer hooks are inhibited. Check that all three buffer hooks, not just kill-buffer-query-functions, are inhibited. --- src/buffer.c | 10 ++++----- test/src/buffer-tests.el | 46 +++++++++++++++++++++++----------------- 2 files changed, 31 insertions(+), 25 deletions(-) diff --git a/src/buffer.c b/src/buffer.c index 100e42fc1f9..88ca69b0dd8 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -525,14 +525,14 @@ get_truename_buffer (register Lisp_Object filename) return Qnil; } -/* Run buffer-list-update-hook if Vrun_hooks is non-nil, and BUF is NULL - or does not have buffer hooks inhibited. BUF is NULL when called by - make-indirect-buffer, since it does not inhibit buffer hooks. */ +/* Run buffer-list-update-hook if Vrun_hooks is non-nil and BUF does + not have buffer hooks inhibited. */ static void run_buffer_list_update_hook (struct buffer *buf) { - if (! (NILP (Vrun_hooks) || (buf && buf->inhibit_buffer_hooks))) + eassert (buf); + if (! (NILP (Vrun_hooks) || buf->inhibit_buffer_hooks)) call1 (Vrun_hooks, Qbuffer_list_update_hook); } @@ -907,7 +907,7 @@ DEFUN ("make-indirect-buffer", Fmake_indirect_buffer, Smake_indirect_buffer, set_buffer_internal_1 (old_b); } - run_buffer_list_update_hook (NULL); + run_buffer_list_update_hook (b); return buf; } diff --git a/test/src/buffer-tests.el b/test/src/buffer-tests.el index e5de8f3464a..9d4bbf3e040 100644 --- a/test/src/buffer-tests.el +++ b/test/src/buffer-tests.el @@ -8315,29 +8315,35 @@ buffer-tests-inhibit-buffer-hooks (remove-hook 'buffer-list-update-hook bluh)))) (ert-deftest buffer-tests-inhibit-buffer-hooks-indirect () - "Indirect buffers do not call `get-buffer-create'." - (dolist (inhibit '(nil t)) - (let ((base (get-buffer-create "foo" inhibit))) + "Test `make-indirect-buffer' argument INHIBIT-BUFFER-HOOKS." + (let* ( base run-bluh run-kbh run-kbqf + (bluh (lambda () (setq run-bluh t))) + (kbh (lambda () (setq run-kbh t))) + (kbqf (lambda () (setq run-kbqf t)))) + (dolist (inhibit-base '(nil t)) (unwind-protect - (dotimes (_i 11) - (let* (flag* - (flag (lambda () (prog1 t (setq flag* t)))) - (indirect (make-indirect-buffer base "foo[indirect]" nil - inhibit))) - (unwind-protect - (progn - (with-current-buffer indirect - (add-hook 'kill-buffer-query-functions flag nil t)) - (kill-buffer indirect) - (if inhibit - (should-not flag*) - (should flag*))) - (let (kill-buffer-query-functions) + (let (indirect) + (setq base (generate-new-buffer " base" inhibit-base)) + (dolist (inhibit-indirect '(nil t)) + (dotimes (_ 11) + (unwind-protect + (let ((name (generate-new-buffer-name " indirect"))) + (setq run-bluh nil run-kbh nil run-kbqf nil) + (add-hook 'buffer-list-update-hook bluh) + (with-current-buffer + (setq indirect (make-indirect-buffer + base name nil inhibit-indirect)) + (add-hook 'kill-buffer-hook kbh nil t) + (add-hook 'kill-buffer-query-functions kbqf nil t) + (kill-buffer)) + (should (xor inhibit-indirect run-bluh)) + (should (xor inhibit-indirect run-kbh)) + (should (xor inhibit-indirect run-kbqf))) + (remove-hook 'buffer-list-update-hook bluh) (when (buffer-live-p indirect) (kill-buffer indirect)))))) - (let (kill-buffer-query-functions) - (when (buffer-live-p base) - (kill-buffer base))))))) + (when (buffer-live-p base) + (kill-buffer base)))))) (ert-deftest zero-length-overlays-and-not () (with-temp-buffer -- 2.39.0 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 15:22:42 2023 Received: (at 49160) by debbugs.gnu.org; 11 Jan 2023 20:22:42 +0000 Received: from localhost ([127.0.0.1]:43968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFhcP-0006he-Pf for submit@debbugs.gnu.org; Wed, 11 Jan 2023 15:22:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFhcL-0006hN-FX for 49160@debbugs.gnu.org; Wed, 11 Jan 2023 15:22:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFhcE-0003bX-FP; Wed, 11 Jan 2023 15:22:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mltJyQM0Y3HzvQ51bFelVwBhr6m8rjIM467GCzpnJs0=; b=meEYuh9qP/xy m6edRCT6Hpm4+N1jDymb7DisONPl30w8KYIZP8RjUR0ZOuvJeXa1RSAsaCSz0CERLUaMwJ7mAGlhk xpd+65CtRK+Qx0oel6V5wq8Tn4s1x3LBeCgwwU8LaqBj6uDZ2sLDvTvAGqtjA2Wtu554HTMJx7iW4 ft/QvGQp8vRbPd0a5RpcgO4nzeR4SvkQgTbjGk6RSukjrqaKvMY1ojBIQGVtHB7Kyuv5467ukG9fK DioAzFU09Y+vOX5pxTZr1MdUro7ofIKG8JU4h46W6S5aWdniJu91DkTU1Nuy1EZbyXmc89eEKp9Px x4d4XmqoEDpcdR64SseQ7g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFhcD-0007K2-54; Wed, 11 Jan 2023 15:22:29 -0500 Date: Wed, 11 Jan 2023 22:23:01 +0200 Message-Id: <83wn5slt22.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" In-Reply-To: <87sfggx21q.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: larsi@gnus.org, 49160@debbugs.gnu.org, dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Cc: Eli Zaretskii , 49160@debbugs.gnu.org, dick > > Date: Wed, 11 Jan 2023 20:13:21 +0000 > > >> More to the point: since this attribute of a buffer cannot be changed > >> once the buffer is created, I think it might be okay to copy from the > >> base buffer, but we should also allow the caller to control that by > >> introducing an optional argument similar to that of get-buffer-create. > >> And if we do that, we could also consider making the default value be > >> nil, not necessarily a copy of that of the base buffer. > > > > I've now applied Dick's patch, and then adjusted as you suggest. > > Fmake_indirect_buffer continues to run buffer-list-update-hook > regardless of the new argument. Any objections to changing that? buffer-list-update-hook is not a buffer-hook, strictly speaking. So I'm not sure we want this. What is the real-life use case behind this request? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 11 16:16:29 2023 Received: (at 49160) by debbugs.gnu.org; 11 Jan 2023 21:16:29 +0000 Received: from localhost ([127.0.0.1]:44095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFiST-00028g-BG for submit@debbugs.gnu.org; Wed, 11 Jan 2023 16:16:29 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:36418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFiSR-00028T-JU for 49160@debbugs.gnu.org; Wed, 11 Jan 2023 16:16:28 -0500 Received: by mail-wr1-f41.google.com with SMTP id bs20so16313206wrb.3 for <49160@debbugs.gnu.org>; Wed, 11 Jan 2023 13:16:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/AN8dX9Z73N634upTE0/hcBqwQzS9cdRI+MBQawKDoQ=; b=U88dKmi+AGMDqW2woFp+DHF6QJhJce4pIbrLQaayy4AplWvVJK6y0XrO8UE+4vDOJD K5pJgl3KQW/mpFEJPyVMe8/ajmvVveTiW5tzBucEodg6TbwrmlDs/sy5Nhg3uK+2azAf 8k47LLpUJvltLS36K3OMCRn89vz4zAPf7bDXjAHFHJI97htivaWg4TopgDQTaqpeItsN g2LnibgtlVxICgnqA1pSaAvkkC+gR4GvsXTSNKbPwzmPvHnwmARIT9VfQwwTzh+HE26s CbvUDoKzA+oqEw/1T5kyEcOSUecX6gpMwOJ7MtgYtv2YSZm9irGNM9eP/ZrrLEZ9HclA Cx3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/AN8dX9Z73N634upTE0/hcBqwQzS9cdRI+MBQawKDoQ=; b=ecAPb2elIfXZxWESGzHQzcB9iQMga0KTTDTiYpEgKQHLa7p3gxagUfevUEjKiALNWH MN2tujWPBRTRUonURoJlN5o8ICHvfc7oKyjeP+IQKAwyZCJTW9mL7sqBFyO8rR+N2fOW tJVoDX49mBytPKe4h9xoHQNE7couv0MYZ1Q7PxLrZSMp/5WydlSVGUhZMlmeonBlgrIp AEqyVxa9ZgyiBPgC+Pm6JsMYa8aMAZKU0IKJDl3RL/BVJJFPEWpJUGKKe9QL8fjRzkrB JMZQ0k6L23eHU9PBBFdwABAgBQrkrVaKuwxgOJuzs5MEW+Ff4PYK9mlGCJXGt1UqLXKC LNzg== X-Gm-Message-State: AFqh2koZU/CwBW27hjGCjKUIRTEORRWAmAOe1RiVqHI5nJXqyiGpaguB zw9xK7OkAfbWTo2nsNJ5HfC5L5GACF5TIbza X-Google-Smtp-Source: AMrXdXv7Z6xhv/GSN0o1L4qm7DO+4ITtBwomJKqEc5td19lmpeY06OWp4j4Q+ToY6E0+3AFvU15STA== X-Received: by 2002:a05:6000:1c05:b0:261:d8be:3046 with SMTP id ba5-20020a0560001c0500b00261d8be3046mr50040866wrb.0.1673471782005; Wed, 11 Jan 2023 13:16:22 -0800 (PST) Received: from localhost ([109.78.59.75]) by smtp.gmail.com with ESMTPSA id bj27-20020a0560001e1b00b0023659925b2asm15174024wrb.51.2023.01.11.13.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 13:16:21 -0800 (PST) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks In-Reply-To: <83wn5slt22.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Jan 2023 15:22:32 -0500") References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> <83wn5slt22.fsf@gnu.org> Date: Wed, 11 Jan 2023 21:16:20 +0000 Message-ID: <871qo0vkkb.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49160 Cc: larsi@gnus.org, 49160@debbugs.gnu.org, dick.r.chiang@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2023-01-11 15:22 -0500] wrote: >> From: "Basil L. Contovounesios" >> Cc: Eli Zaretskii , 49160@debbugs.gnu.org, dick >> >> Date: Wed, 11 Jan 2023 20:13:21 +0000 >>=20 >> Fmake_indirect_buffer continues to run buffer-list-update-hook >> regardless of the new argument. Any objections to changing that? > > buffer-list-update-hook is not a buffer-hook, strictly speaking. Right, but it's inhibited together with 'strict' buffer-hooks (and documented as such) everywhere except for make-indirect-buffer: see get-buffer-create, generate-new-buffer, struct buffer, "(elisp) Buffer List", "(elisp) Creating Buffers", "(elisp) Buffer Internals", and etc/NEWS.28. In fact, "(elisp) Indirect Buffers" even says about make-indirect-buffer: *Note Creating Buffers, for the meaning of INHIBIT-BUFFER-HOOKS. Where "(elisp) Creating Buffers" elaborates: Both functions accept an optional argument INHIBIT-BUFFER-HOOKS. If it is non-=E2=80=98nil=E2=80=99, the buffer they create does not run the = hooks =E2=80=98kill-buffer-hook=E2=80=99, =E2=80=98kill-buffer-query-functions= =E2=80=99 (*note Killing Buffers), and =E2=80=98buffer-list-update-hook=E2=80=99 (*note Buffer Lis= t). This avoids slowing down internal or temporary buffers that are never presented to users or passed on to other applications. So while inhibit-buffer-hooks may be a slightly loose name, I think make-indirect-buffer should nevertheless heed it for buffer-list-update-hook as well, for the same reason this is done everywhere else. > So I'm not sure we want this. What is the real-life use case behind > this request? The real-life use case is satisfying this bug report+patch from me, fixing what seems like a simple oversight, and the ensuing peace of mind that I will be grateful for, of course ;). Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 02:39:28 2023 Received: (at 49160) by debbugs.gnu.org; 12 Jan 2023 07:39:28 +0000 Received: from localhost ([127.0.0.1]:44494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFsBM-0003w1-9s for submit@debbugs.gnu.org; Thu, 12 Jan 2023 02:39:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFsBJ-0003vn-Qf for 49160@debbugs.gnu.org; Thu, 12 Jan 2023 02:39:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFsBD-0002aB-Ei; Thu, 12 Jan 2023 02:39:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=47egSWYvGCCHgcgCU0o09DVk7haqXTtDT78QFPhG0T4=; b=NWpem2Flz5Y8Y+5I7Q1F VpVZSDbju76w2Q5VG313mF3BnlfImzKJjTutW6Jbgta6db2vTxike/ojeUt636eIxrphys/DdyDgc eCIyk/sTwKrROfGJGzYPkczZgwLH5vvVvKeNwIglxZ78hk3MCi+dHf/482JWsn4nKXJlBQeCBQC1h mylQ2MEmml+G83UtDwX4uh96APM5yCdRMlP4GaBK6alLwwG1u26TA6Co1q3tfJGLD9q7CHxtn0g43 AczT16ay1IpxIlC67K+2YBmi5zcFiOdabU6KoR4WFxKpIgLHufnUHHkQkIflRqHXM0og+LVrHuZbZ 8cRTcxqEMb9niA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFsB9-00056E-8r; Thu, 12 Jan 2023 02:39:19 -0500 Date: Thu, 12 Jan 2023 09:39:47 +0200 Message-Id: <83tu0wkxq4.fsf@gnu.org> From: Eli Zaretskii To: "Basil L. Contovounesios" , Stefan Monnier In-Reply-To: <871qo0vkkb.fsf@tcd.ie> (contovob@tcd.ie) Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> <83wn5slt22.fsf@gnu.org> <871qo0vkkb.fsf@tcd.ie> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: larsi@gnus.org, 49160@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: "Basil L. Contovounesios" > Cc: larsi@gnus.org, 49160@debbugs.gnu.org, dick.r.chiang@gmail.com > Date: Wed, 11 Jan 2023 21:16:20 +0000 > > Eli Zaretskii [2023-01-11 15:22 -0500] wrote: > > >> From: "Basil L. Contovounesios" > >> Cc: Eli Zaretskii , 49160@debbugs.gnu.org, dick > >> > >> Date: Wed, 11 Jan 2023 20:13:21 +0000 > >> > >> Fmake_indirect_buffer continues to run buffer-list-update-hook > >> regardless of the new argument. Any objections to changing that? > > > > buffer-list-update-hook is not a buffer-hook, strictly speaking. > > Right, but it's inhibited together with 'strict' buffer-hooks (and > documented as such) everywhere except for make-indirect-buffer: see > get-buffer-create, generate-new-buffer, struct buffer, "(elisp) Buffer > List", "(elisp) Creating Buffers", "(elisp) Buffer Internals", and > etc/NEWS.28. > > In fact, "(elisp) Indirect Buffers" even says about > make-indirect-buffer: > > *Note Creating Buffers, for the meaning of INHIBIT-BUFFER-HOOKS. > > Where "(elisp) Creating Buffers" elaborates: > > Both functions accept an optional argument INHIBIT-BUFFER-HOOKS. If > it is non-‘nil’, the buffer they create does not run the hooks > ‘kill-buffer-hook’, ‘kill-buffer-query-functions’ (*note Killing > Buffers), and ‘buffer-list-update-hook’ (*note Buffer List). This > avoids slowing down internal or temporary buffers that are never > presented to users or passed on to other applications. > > So while inhibit-buffer-hooks may be a slightly loose name, I think > make-indirect-buffer should nevertheless heed it for > buffer-list-update-hook as well, for the same reason this is done > everywhere else. > > > So I'm not sure we want this. What is the real-life use case behind > > this request? > > The real-life use case is satisfying this bug report+patch from me, > fixing what seems like a simple oversight, and the ensuing peace of mind > that I will be grateful for, of course ;). Stefan, WDYT? From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 12 11:25:50 2023 Received: (at 49160) by debbugs.gnu.org; 12 Jan 2023 16:25:50 +0000 Received: from localhost ([127.0.0.1]:48437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG0Ok-0000h8-2T for submit@debbugs.gnu.org; Thu, 12 Jan 2023 11:25:50 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:21210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pG0Oi-0000gu-Ek for 49160@debbugs.gnu.org; Thu, 12 Jan 2023 11:25:48 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1CA4A1000D8; Thu, 12 Jan 2023 11:25:43 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 661B7100054; Thu, 12 Jan 2023 11:25:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1673540741; bh=7tJD0yUOwkWnWRa7OcQHQZ/3yTODVv6Ra7lQAJ1k2XI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QbU9W8ywvWfbuirEuWk8kmDk68bHzIjbhS/+Uo79wPNNudUqjGriM17Ah88FFZIKg umR20ru+V/bAuB5QogJA0BEkT5c5S0HeHuKGcvVPFpEDIod/YBJXVMBwMyIEseW5H6 hx+yaceHdqMq+YalQYSQxMBu7GNGJ9wKCsrUKcKwJ7gXUCAemuSYpJ86NOdE9MdGZr srKGLph80zW4rDTX4yu7yh75tIev+HChAnnskDKpfyE9jMxIp9PiQWjFqx+QOFy1mq 2wDbt8BhuFYXaCXKFB38QXPysMBc6Ml2M17VuMVIi+GTycnBeGqUY0zQsv4Zo/MZcI YTcXz8NaVHGww== Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4B7CF120228; Thu, 12 Jan 2023 11:25:41 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks In-Reply-To: <83tu0wkxq4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 12 Jan 2023 09:39:47 +0200") Message-ID: References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> <83wn5slt22.fsf@gnu.org> <871qo0vkkb.fsf@tcd.ie> <83tu0wkxq4.fsf@gnu.org> Date: Thu, 12 Jan 2023 11:25:40 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: "Basil L. Contovounesios" , larsi@gnus.org, 49160@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > So I'm not sure we want this. What is the real-life use case behind >> > this request? >> >> The real-life use case is satisfying this bug report+patch from me, >> fixing what seems like a simple oversight, and the ensuing peace of mind >> that I will be grateful for, of course ;). > > Stefan, WDYT? It makes the code simpler and fixes a bug, I'm all for it. I don't think it's urgent, so it's not super important whether it goes into `emacs-29`, OTOH. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 08:20:20 2023 Received: (at 49160) by debbugs.gnu.org; 14 Jan 2023 13:20:20 +0000 Received: from localhost ([127.0.0.1]:53638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGgSK-0005dv-C1 for submit@debbugs.gnu.org; Sat, 14 Jan 2023 08:20:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGgSI-0005dc-0d for 49160@debbugs.gnu.org; Sat, 14 Jan 2023 08:20:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGgSB-0002f6-RZ; Sat, 14 Jan 2023 08:20:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wsExVSzXWc+uIO7Ynp3xGvZ3mHwOtMPtc9bfmG4wU8Q=; b=H4PUlqd+blVU rTSlTokWQHE2ERn65SReG5zXT/GJlOiisWU7uVOXxghvYDomR7Xm3S1dDDbLkad5juwRf24aODBd9 /0XLKNhCewKlKXHtIJ9xAJWt1evvC7BhohxA5jxuXiTAaYMPWBzuUlM7j2qqRP9Af0LHwB6ALYUw2 Mn+xb/O9doG5d4stRb+IzlXhvNrhh1RlGdSizSkFgZaYwm+ZF8w0Ud5c+GcbbDuSHITk5FtNzeWAy 1RhtL5RhaJh4dwNW5uO5O1NdTOSuSSLAMUXpEhLdCC9gNBuaL7CSHv352U+sd5rxRJPiyly5Vjb9j WSzHT61vhotMp3pN1h48tw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGgSB-0003cQ-BF; Sat, 14 Jan 2023 08:20:11 -0500 Date: Sat, 14 Jan 2023 15:20:14 +0200 Message-Id: <83pmbh6ynl.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier , contovob@tcd.ie In-Reply-To: (message from Stefan Monnier on Thu, 12 Jan 2023 11:25:40 -0500) Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> <83wn5slt22.fsf@gnu.org> <871qo0vkkb.fsf@tcd.ie> <83tu0wkxq4.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: larsi@gnus.org, 49160@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: "Basil L. Contovounesios" , larsi@gnus.org, > 49160@debbugs.gnu.org > Date: Thu, 12 Jan 2023 11:25:40 -0500 > > >> > So I'm not sure we want this. What is the real-life use case behind > >> > this request? > >> > >> The real-life use case is satisfying this bug report+patch from me, > >> fixing what seems like a simple oversight, and the ensuing peace of mind > >> that I will be grateful for, of course ;). > > > > Stefan, WDYT? > > It makes the code simpler and fixes a bug, I'm all for it. > I don't think it's urgent, so it's not super important whether it goes > into `emacs-29`, OTOH. Installing it means the buffer-list-update-hook will not run when we generate an indirect buffer with this option. Is that reasonable? If you-two aren't averted by this effect, then let's install this on the emacs-29 branch. From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 14 09:02:02 2023 Received: (at 49160) by debbugs.gnu.org; 14 Jan 2023 14:02:02 +0000 Received: from localhost ([127.0.0.1]:53684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGh6g-0006rC-E8 for submit@debbugs.gnu.org; Sat, 14 Jan 2023 09:02:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGh6d-0006qX-Au for 49160@debbugs.gnu.org; Sat, 14 Jan 2023 09:02:00 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9154880DCA; Sat, 14 Jan 2023 09:01:53 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EE9958043D; Sat, 14 Jan 2023 09:01:51 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1673704912; bh=O3itUTdrbJADmouuLfU04rMbjYs0k0iw9OWw89rZUKo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=N9c8G8Hu9MojHE+W6X9cjMmojIzlbZl/M49yCNlyphGuVl5w9RPtuOrtEl2eoNTzI ZPC2ff1InafK7tWveMAZmp9NjEGjWACzzk/vgUMsyYAPlXPzYPBBXaX2D3FUtDjN5R qu26wKlW4XieuUiYhAL5ujfm0UQ9uhmn6xDuuMrwSVJFT4ECdCpJ4mNcFDGw+m1RjR 6Mlu9LaIMvT7Dq0/70rcHexRGCecNtWMc+C5H9nwgNPtcvF8x3u21W09xrU4CQ8/eg ypGjRQhLJf6USV7fJyxjILEDnPRpSTE06jfgyNX8ZUvRfR9HohS2pgMyjemmG+9vWM x3+dNhUjGoqbQ== Received: from pastel (unknown [45.72.200.228]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AB84012017B; Sat, 14 Jan 2023 09:01:51 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks In-Reply-To: <83pmbh6ynl.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Jan 2023 15:20:14 +0200") Message-ID: References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> <83wn5slt22.fsf@gnu.org> <871qo0vkkb.fsf@tcd.ie> <83tu0wkxq4.fsf@gnu.org> <83pmbh6ynl.fsf@gnu.org> Date: Sat, 14 Jan 2023 09:01:50 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.232 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49160 Cc: contovob@tcd.ie, larsi@gnus.org, 49160@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> It makes the code simpler and fixes a bug, I'm all for it. >> I don't think it's urgent, so it's not super important whether it goes >> into `emacs-29`, OTOH. > > Installing it means the buffer-list-update-hook will not run when we > generate an indirect buffer with this option. Is that reasonable? I think it's not just reasonable but is what I'd expect to happen. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 06:08:15 2023 Received: (at 49160) by debbugs.gnu.org; 17 Jan 2023 11:08:15 +0000 Received: from localhost ([127.0.0.1]:35923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHjp9-0005Ql-Hm for submit@debbugs.gnu.org; Tue, 17 Jan 2023 06:08:15 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:36368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHjp6-0005QY-SQ for 49160@debbugs.gnu.org; Tue, 17 Jan 2023 06:08:14 -0500 Received: by mail-wm1-f45.google.com with SMTP id c4-20020a1c3504000000b003d9e2f72093so20695578wma.1 for <49160@debbugs.gnu.org>; Tue, 17 Jan 2023 03:08:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NYeKDDWHTJN7MWLxXURUSvBmQGsrrdij1sjBNnNMevE=; b=I9JVXo2e3exVSpkZOfhv8MMBxLLWo6jMVJ5yP20XyYotkrQM+L0VhJU3/2fKQe0X03 GQuGftxTDdyH+CYH8SVmme3yLYZmsq5OqYk5D4PVq9W0euwY+vbUa5uVJAgTz79TXfWh ePwOG7rgB1jo8Xx/hW0RCSLRLNLONRMv3nn02yY6+eWo3cMq9V+FX+wN9W8Uy1cbuwvU vY9oxjQr3e+eAdZGyoa4u8SPrQPwyrFyFm3LdpwavzGeBQKVX5F2l2hP2kUIkEI78lTf /ei2IkLLSG+/ba1s7A1OaOUFIte5elwriycwy6XSMjNtnBpRO4wkS6q3HbMIN4rwpsH+ Fn6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NYeKDDWHTJN7MWLxXURUSvBmQGsrrdij1sjBNnNMevE=; b=Cp4JRyT5521TbODVvGm3+i2nMkJjohOxfgRQGTxdayJ3sCxo8NTbvApkrxKKQcR6BF clcutyJ8U0fjm/a0Tv0rrguml1DrlEl+GgCZgxRNSxv3nHVXYskXDlhO5BBtB8Cgzwj0 MJti4T/nY1Th95swIQ9cYlKFLXI5lClgKKuIbYdqYMtJgGGMESVzswKtvTzqXRG99Zcj BX90JNAJNEhtmiYL82arozzrRB1cCdq0Dv4TPJYOs2hJSr6VA8JR1i6cf557+sK0A9Ad ac52TPsRAwK9Ej+i1wvsv+Hx1f5U4Gfpsw4VxBa7I0TBUAGQrxYM6NMTZ3VZlXwl0dr0 AQ2Q== X-Gm-Message-State: AFqh2kojeagM8jymCPzNwV8D62w3PyeKGu+goLsnDeMFlqILIT0gc5vl P8yi+2EttwCZD3k9tLW/oB7XNQ== X-Google-Smtp-Source: AMrXdXt26xEQaodiXAxOJsidZ8dKR4OIEubSLYEYxlVH6uLJMFY1QeTtOmDTG2ivMilNFwJQ9X1auQ== X-Received: by 2002:a05:600c:35d0:b0:3db:c4c:9224 with SMTP id r16-20020a05600c35d000b003db0c4c9224mr798036wmq.3.1673953686950; Tue, 17 Jan 2023 03:08:06 -0800 (PST) Received: from localhost ([93.107.210.14]) by smtp.gmail.com with ESMTPSA id bh13-20020a05600c3d0d00b003d358beab9dsm36322777wmb.47.2023.01.17.03.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 03:08:06 -0800 (PST) From: "Basil L. Contovounesios" To: Eli Zaretskii Subject: Re: bug#49160: 28.0.50; [PATCH] Uninitialized inhibit_buffer_hooks In-Reply-To: <83pmbh6ynl.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 14 Jan 2023 15:20:14 +0200") References: <874kdratxt.fsf@dick> <83fsxaunxe.fsf@gnu.org> <87a6mijmrb.fsf@gnus.org> <87sfggx21q.fsf@tcd.ie> <83wn5slt22.fsf@gnu.org> <871qo0vkkb.fsf@tcd.ie> <83tu0wkxq4.fsf@gnu.org> <83pmbh6ynl.fsf@gnu.org> Date: Tue, 17 Jan 2023 11:08:04 +0000 Message-ID: <87y1q1l8q3.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49160 Cc: larsi@gnus.org, 49160@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2023-01-14 15:20 +0200] wrote: > Installing it means the buffer-list-update-hook will not run when we > generate an indirect buffer with this option. Is that reasonable? > > If you-two aren't averted by this effect, then let's install this on > the emacs-29 branch. Done, thanks. Fix buffer-list-update-hook for indirect buffers bd094207c76 2023-01-17 10:38:22 +0000 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=bd094207c76 -- Basil From unknown Thu Sep 11 16:39:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 Feb 2023 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator