GNU bug report logs - #49149
[PATCH 0/7] Add deb format for guix pack.

Previous Next

Full log

Message #100 received at 49149 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 49149 <at> debbugs.gnu.org
Subject: Re: bug#49149: [PATCH 0/7] Add deb format for guix pack.
Date: Wed, 30 Jun 2021 12:13:05 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Instead of just naming them by their pack type, add information from the
> package(s) they contain to make it easier to differentiate them.
>
> * guix/scripts/pack.scm (define-with-source): New macro.
> (manifest->friendly-name): Extract procedure from ...
> (docker-image): ... here, now defined via the above macro.  Adjust REPOSITORY
> argument value accordingly.
> (guix-pack): Derive NAME using MANIFEST->FRIENDLY-NAME.

[...]

> -            (define tag
> -              ;; Compute a meaningful "repository" name, which will show up in
> -              ;; the output of "docker images".
> -              (let ((manifest (profile-manifest #$profile)))
> -                (let loop ((names (map manifest-entry-name
> -                                       (manifest-entries manifest))))
> -                  (define str (string-join names "-"))
> -                  (if (< (string-length str) 40)
> -                      str
> -                      (match names
> -                        ((_) str)
> -                        ((names ... _) (loop names))))))) ;drop one entry

I think this should not be factorized because the requirements are very
Docker-dependent.  Once factorized, it becomes easy to overlook this.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.