From unknown Fri Aug 15 21:26:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49128] [PATCH] services: Add file system utilities to profile. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Jun 2021 10:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49128 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49128@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162418379520625 (code B ref -1); Sun, 20 Jun 2021 10:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 20 Jun 2021 10:09:55 +0000 Received: from localhost ([127.0.0.1]:33108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luuOp-0005Mb-BI for submit@debbugs.gnu.org; Sun, 20 Jun 2021 06:09:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:47824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luuOo-0005MT-3j for submit@debbugs.gnu.org; Sun, 20 Jun 2021 06:09:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luuOn-0004cU-UL for guix-patches@gnu.org; Sun, 20 Jun 2021 06:09:53 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luuOk-0003JV-Vu for guix-patches@gnu.org; Sun, 20 Jun 2021 06:09:53 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B58DD20002 for ; Sun, 20 Jun 2021 10:09:47 +0000 (UTC) From: Brice Waegeneire Date: Sun, 20 Jun 2021 12:09:45 +0200 Message-Id: <20210620100945.15345-1-brice@waegenei.re> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.183.200; envelope-from=brice@waegenei.re; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Fixes . * gnu/services/base.scm (file-system-type->utilities, file-system-utilities): New procedures. (file-system-service-type): Extend 'profile-service-type' with 'file-system-utilities'. * gnu/system.scm (boot-file-system-service): New procedure… (operating-system-default-essential-services): …use it. (%base-packages): Remove 'e2fsprogs'. * gnu/system/file-systems.scm (file-system): Add 'utilities?' field. * doc/guix.texi (File Systems): Document 'file-system-utilities?'. --- doc/guix.texi | 6 ++++++ gnu/services/base.scm | 40 +++++++++++++++++++++++++++++++++++-- gnu/system.scm | 28 ++++++++++++++++---------- gnu/system/file-systems.scm | 6 +++++- 4 files changed, 67 insertions(+), 13 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index efeb176e3d..3115dbed38 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -14031,6 +14031,12 @@ a dependency of @file{/sys/fs/cgroup/cpu} and Another example is a file system that depends on a mapped device, for example for an encrypted partition (@pxref{Mapped Devices}). + +@item @code{utilities?} (default: @code{#t}) +When true, the filesystem utility package is added to the system +profile. Such as @code{e2fsprogs} for ext4 or @code{btrfs-progs} for +Btrfs partitions. + @end table @end deftp diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 3be2e984c3..9a05dd3c02 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -46,13 +46,20 @@ #:select (file-system-packages)) #:use-module (gnu packages admin) #:use-module ((gnu packages linux) - #:select (alsa-utils crda eudev e2fsprogs fuse gpm kbd lvm2 rng-tools)) + #:select (alsa-utils btrfs-progs crda eudev + e2fsprogs f2fs-tools fuse gpm kbd lvm2 rng-tools + util-linux xfsprogs)) #:use-module (gnu packages bash) #:use-module ((gnu packages base) #:select (coreutils glibc glibc-utf8-locales)) #:use-module (gnu packages package-management) #:use-module ((gnu packages gnupg) #:select (guile-gcrypt)) - #:use-module (gnu packages linux) + #:use-module ((gnu packages disk) + #:select (dosfstools)) + #:use-module ((gnu packages file-systems) + #:select (bcachefs-tools jfsutils zfs)) + #:use-module ((gnu packages mtools) + #:select (exfat-utils)) #:use-module (gnu packages terminals) #:use-module ((gnu build file-systems) #:select (mount-flags->bit-mask)) @@ -69,6 +76,7 @@ #:export (fstab-service-type root-file-system-service file-system-service-type + file-system-utilities swap-service host-name-service %default-console-font @@ -422,6 +430,32 @@ FILE-SYSTEM." (memq 'bind-mount (file-system-flags file-system)))) file-systems)) +(define (file-system-type->utilities type) + "Return a package providing the utilities for file system TYPE, #f +otherwise." + (assoc-ref + `(("bcachefs" . ,bcachefs-tools) + ("btrfs" . ,btrfs-progs) + ("exfat" . ,exfat-utils) + ("ext2" . ,e2fsprogs) + ("ext3" . ,e2fsprogs) + ("ext4" . ,e2fsprogs) + ("fat" . ,dosfstools) + ("f2fs" . ,f2fs-tools) + ("jfs" . ,jfsutils) + ("vfat" . ,dosfstools) + ("xfs" . ,xfsprogs) + ("zfs" . ,zfs)) + type)) + +(define (file-system-utilities file-systems) + "Return a list of packages containing file system utilities for +FILE-SYSTEMS." + (filter-map (lambda (file-system) + (when (file-system-utilities? file-system) + (file-system-type->utilities (file-system-type file-system)))) + file-systems)) + (define file-system-service-type (service-type (name 'file-systems) (extensions @@ -429,6 +463,8 @@ FILE-SYSTEM." file-system-shepherd-services) (service-extension fstab-service-type file-system-fstab-entries) + (service-extension profile-service-type + file-system-utilities) ;; Have 'user-processes' depend on 'file-systems'. (service-extension user-processes-service-type diff --git a/gnu/system.scm b/gnu/system.scm index 8a3ae27d04..23b4b23c28 100644 --- a/gnu/system.scm +++ b/gnu/system.scm @@ -526,6 +526,14 @@ marked as 'needed-for-boot'." (service file-system-service-type (map add-dependencies file-systems))) +(define (boot-file-system-service os) + "Return a service which adds, to the system profile, packages providing the +utilites for the file systems marked as 'needed-for-boot' in OS." + (let ((file-systems (filter file-system-needed-for-boot? + (operating-system-file-systems os)))) + (simple-service 'boot-file-system-utilities profile-service-type + (file-system-utilities file-systems)))) + (define (mapped-device-users device file-systems) "Return the subset of FILE-SYSTEMS that use DEVICE." (let ((targets (map (cut string-append "/dev/mapper/" <>) @@ -637,13 +645,14 @@ bookkeeping." (define known-fs (map file-system-mount-point (operating-system-file-systems os))) - (let* ((mappings (device-mapping-services os)) - (root-fs (root-file-system-service)) - (other-fs (non-boot-file-system-service os)) - (swaps (swap-services os)) - (procs (service user-processes-service-type)) - (host-name (host-name-service (operating-system-host-name os))) - (entries (operating-system-directory-base-entries os))) + (let* ((mappings (device-mapping-services os)) + (root-fs (root-file-system-service)) + (boot-fs (boot-file-system-service os)) + (non-boot-fs (non-boot-file-system-service os)) + (swaps (swap-services os)) + (procs (service user-processes-service-type)) + (host-name (host-name-service (operating-system-host-name os))) + (entries (operating-system-directory-base-entries os))) (cons* (service system-service-type entries) (service linux-builder-service-type (linux-builder-configuration @@ -674,7 +683,7 @@ bookkeeping." (operating-system-setuid-programs os)) (service profile-service-type (operating-system-packages os)) - other-fs + boot-fs non-boot-fs (append mappings swaps ;; Add the firmware service. @@ -812,8 +821,7 @@ of PROVENANCE-SERVICE-TYPE to its services." (define %base-packages ;; Default set of packages globally visible. It should include anything ;; required for basic administrator tasks. - (append (list e2fsprogs) - %base-packages-interactive + (append %base-packages-interactive %base-packages-linux %base-packages-networking %base-packages-utils)) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index 464e87cb18..35803d39e9 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -3,6 +3,7 @@ ;;; Copyright © 2020 Google LLC ;;; Copyright © 2020 Jakub Kądziołka ;;; Copyright © 2020 Maxim Cournoyer +;;; Copyright © 2020 Brice Waegeneire ;;; ;;; This file is part of GNU Guix. ;;; @@ -54,6 +55,7 @@ file-system-create-mount-point? file-system-dependencies file-system-location + file-system-utilities? file-system-type-predicate btrfs-subvolume? @@ -129,7 +131,9 @@ (default '())) ; or (location file-system-location (default (current-source-location)) - (innate))) + (innate)) + (utilities? file-system-utilities? ; Boolean + (default #t))) ;; A file system label for use in the 'device' field. (define-record-type -- 2.31.1 From unknown Fri Aug 15 21:26:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49128] [PATCH] services: Add file system utilities to profile. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Jun 2021 21:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49128 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 49128@debbugs.gnu.org Received: via spool by 49128-submit@debbugs.gnu.org id=B49128.162456919520480 (code B ref 49128); Thu, 24 Jun 2021 21:14:01 +0000 Received: (at 49128) by debbugs.gnu.org; 24 Jun 2021 21:13:15 +0000 Received: from localhost ([127.0.0.1]:44233 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwWex-0005KF-3E for submit@debbugs.gnu.org; Thu, 24 Jun 2021 17:13:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37560) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwWev-0005Jz-IQ for 49128@debbugs.gnu.org; Thu, 24 Jun 2021 17:13:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57286) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwWep-00057E-Va; Thu, 24 Jun 2021 17:13:07 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39960 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwWep-00058c-O9; Thu, 24 Jun 2021 17:13:07 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210620100945.15345-1-brice@waegenei.re> Date: Thu, 24 Jun 2021 23:13:06 +0200 In-Reply-To: <20210620100945.15345-1-brice@waegenei.re> (Brice Waegeneire's message of "Sun, 20 Jun 2021 12:09:45 +0200") Message-ID: <87lf6zrmot.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Brice Waegeneire skribis: > Fixes . Thanks for looking into it! > * gnu/services/base.scm (file-system-type->utilities, > file-system-utilities): New procedures. > (file-system-service-type): Extend 'profile-service-type' with > 'file-system-utilities'. > * gnu/system.scm (boot-file-system-service): New procedure=E2=80=A6 > (operating-system-default-essential-services): =E2=80=A6use it. > (%base-packages): Remove 'e2fsprogs'. > * gnu/system/file-systems.scm (file-system): Add 'utilities?' field. I think is not a good place to specify whether one would like utilities to be installed; records represent mountable file systems, and utilities installed in the profile are conceptually unrelated. Perhaps =E2=80=98file-system-service-type=E2=80=99 could extend =E2=80=98pr= ofile-service-type=E2=80=99 unconditionally, after all? WDYT? Ludo=E2=80=99. From unknown Fri Aug 15 21:26:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49128] [PATCH] services: Add file system utilities to profile. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Jul 2021 20:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49128 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49128@debbugs.gnu.org Received: via spool by 49128-submit@debbugs.gnu.org id=B49128.162560271231062 (code B ref 49128); Tue, 06 Jul 2021 20:19:02 +0000 Received: (at 49128) by debbugs.gnu.org; 6 Jul 2021 20:18:32 +0000 Received: from localhost ([127.0.0.1]:50309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rWa-00084w-9x for submit@debbugs.gnu.org; Tue, 06 Jul 2021 16:18:32 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:44589) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rWY-00084k-NI for 49128@debbugs.gnu.org; Tue, 06 Jul 2021 16:18:31 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay10.mail.gandi.net (Postfix) with ESMTPSA id B7DDF240004; Tue, 6 Jul 2021 20:18:24 +0000 (UTC) From: Brice Waegeneire References: <20210620100945.15345-1-brice@waegenei.re> <87lf6zrmot.fsf@gnu.org> Date: Tue, 06 Jul 2021 22:18:21 +0200 In-Reply-To: <87lf6zrmot.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 24 Jun 2021 23:13:06 +0200") Message-ID: <87y2aj2o36.fsf_-_@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Ludo=E2=80=99, Ludovic Court=C3=A8s writes: > Brice Waegeneire skribis: > >> * gnu/services/base.scm (file-system-type->utilities, >> file-system-utilities): New procedures. >> (file-system-service-type): Extend 'profile-service-type' with >> 'file-system-utilities'. >> * gnu/system.scm (boot-file-system-service): New procedure=E2=80=A6 >> (operating-system-default-essential-services): =E2=80=A6use it. >> (%base-packages): Remove 'e2fsprogs'. >> * gnu/system/file-systems.scm (file-system): Add 'utilities?' field. > > I think is not a good place to specify whether one would > like utilities to be installed; records represent > mountable file systems, and utilities installed in the profile are > conceptually unrelated. > > Perhaps =E2=80=98file-system-service-type=E2=80=99 could extend =E2=80=98= profile-service-type=E2=80=99 > unconditionally, after all? I can't think of a use case where you wouldn't wan't such utilites; not to say there isn't one. Having a way to specify an other version of a utility package could be usefull tho. I don't really care about that part. Cheers, - Brice From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 28 19:52:29 2022 Received: (at control) by debbugs.gnu.org; 28 Sep 2022 23:52:29 +0000 Received: from localhost ([127.0.0.1]:35188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odgqq-0006oV-Vi for submit@debbugs.gnu.org; Wed, 28 Sep 2022 19:52:29 -0400 Received: from mail-qk1-f173.google.com ([209.85.222.173]:41858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odgqo-0006oH-6S for control@debbugs.gnu.org; Wed, 28 Sep 2022 19:52:27 -0400 Received: by mail-qk1-f173.google.com with SMTP id k12so8876533qkj.8 for ; Wed, 28 Sep 2022 16:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:message-id:date:from:to:cc:subject:date; bh=F7KLkiccYRxZ4nTHzRAYkuEIxrZAP7GFIiSeFeeDPfQ=; b=nAcSkz1Ze+UHwZXiIZoHKEIs5RSXhw/oQRw6gMr6m0eiXZeberChaFL4oi8NQOJdU2 rSUuoOkyfaROXlgaTFiyA2HoMgiDTrYJ/uI8v+5heqv58l/ubrv+RzGksFbRK2vvezCq X1+uO8UeFk72/BeC/6mck6wliGWMGdIguPlB+oeBX0eiWAKjrldw/LHqn4OVQ1cNCHp0 q8ykffaRcdGtyW2vAoTqMQhQ4FUi8F9rCQhzYTYDX5jG5PRVEizXW6Pws0mpfFdKRkYB RUlfC/vgdhElS3VYFVG0QUKs5nxT6Jv/y4smjHqqhiLONyxhvjS1mal8eiERBHLrcAmM rpnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc :subject:date; bh=F7KLkiccYRxZ4nTHzRAYkuEIxrZAP7GFIiSeFeeDPfQ=; b=LfULp0y111hOb0J/fS4NAfwoKId9pjTiqdbwQIw6bwKxmZX7WwyU6vaSRfe2NSsb+2 Io9BVJCfPvmypBGLPUsNSYuvSWYCp3lrRe6IrWr5qWbzeWjMxVgd1vIGn5hIOTfQ90/h 7CQUikd7DMk0+frjhAt0Q2iR2k3nm+FkfteSGsyZ2Ij3BDtSaDczusNTx4Xd8P3ZA4qY zKuXjrtJGAb3jcn2DoH0MOcn2JYNPBhFJUlze1RsHjpRzasiZqQ3P3KS+BFqLqQWPubX aU/7smCGV1HLSio+Rl+KkORGcdBQPjIQsrVffV4up/EOyqYalv9MUaUzkyovMx/hMVs3 7mXA== X-Gm-Message-State: ACrzQf2BIMc+UVuW0gZ6mO/0GgkgjJ28E354owoNBfAct50fnslslYCj mUSNB6RVTjfL4Pd/HWgO+aYwJ9x8XA6ZNg== X-Google-Smtp-Source: AMsMyM7eYNKDvBaTpQzS4b7bMjXH96+3ILMSgQHdzYjfesBQsvvpsn+XeW8MrpkWXbOBYSbtrrwSYA== X-Received: by 2002:a37:aa51:0:b0:6cb:cdcd:5953 with SMTP id t78-20020a37aa51000000b006cbcdcd5953mr397059qke.613.1664409140603; Wed, 28 Sep 2022 16:52:20 -0700 (PDT) Received: from hurd (dsl-148-95.b2b2c.ca. [66.158.148.95]) by smtp.gmail.com with ESMTPSA id v6-20020a05620a0f0600b006bc0980db76sm4628476qkl.126.2022.09.28.16.52.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 16:52:20 -0700 (PDT) Date: Wed, 28 Sep 2022 19:52:19 -0400 Message-Id: <87wn9nqcp8.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #49128 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 49128 quit From unknown Fri Aug 15 21:26:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49128] [PATCH] services: Add file system utilities to profile. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 28 Sep 2022 23:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49128 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 49128-done@debbugs.gnu.org, Brice Waegeneire Received: via spool by 49128-done@debbugs.gnu.org id=D49128.166440914126178 (code D ref 49128); Wed, 28 Sep 2022 23:53:02 +0000 Received: (at 49128-done) by debbugs.gnu.org; 28 Sep 2022 23:52:21 +0000 Received: from localhost ([127.0.0.1]:35185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odgqi-0006o9-KP for submit@debbugs.gnu.org; Wed, 28 Sep 2022 19:52:20 -0400 Received: from mail-qk1-f182.google.com ([209.85.222.182]:35609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odgqg-0006nu-UN for 49128-done@debbugs.gnu.org; Wed, 28 Sep 2022 19:52:19 -0400 Received: by mail-qk1-f182.google.com with SMTP id u28so8901939qku.2 for <49128-done@debbugs.gnu.org>; Wed, 28 Sep 2022 16:52:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date; bh=MCHEdM5zen1hC1ZaKmrBiL/we2UUGm/UsIOrrfC7QWE=; b=Br+YM9nfBSpV0UgosAGLnuq8NeBvFk7XHjx8i+s8z6GWku6OB/0r/0ZjMYspBeR6vg RKkQW3fINuWxfC+W55dTlHXuQ6cfcOn32y8i1OGaxlCDM4VLngzG2ow+wJmNXY71rrAi WyIfvasZtbenAh3kxgwrDZrMcKjwEjTdqw8/gEkIm5NbiCP0fYTUzX3U2teEFdI42z3O Pwf9QPG+ffoxvifrZiPSwvacS8lZruBrnahyK8qhnC9DWye2RyuCb4ZYiCcOLP3fzP/9 8nOI/z8T9vXgqyU5TXo2tHSdyVwr8+UxBSqXuM8bu8l4S+YIucfdx7If9N8uo75MYb24 NCjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date; bh=MCHEdM5zen1hC1ZaKmrBiL/we2UUGm/UsIOrrfC7QWE=; b=kyQlDZ5/NOA7iQmODpmI43z1FfEMSJu5sZqN/brSt36vQEzhy1uY2q6QOCPAjurbLt gCyGYRGLVrTzRngLHvWLYF/BagSinzDvK7KXTjm4UrXMI4Zb0SiLkFLHVv3EZLbMccEa Q1mQ0KfgqEI9B6WHrZWKQAM/Pf/xW/JUBOr2eiUgGGt+7Hx0MZ278sC/DoNlaAl15wpl tmcdYfk0PjU0x2ONRBuz4e2l90d8F4UQ1AoZr2LoUvmQTaYyZ+7KlG79YhN1LluSQO5s ayLCtx/bKvfbkZblomO7M4jmLlY1PAM2ljItEFOJA41SxelexuCSOLjscqgcYGqgawub QKYw== X-Gm-Message-State: ACrzQf34t9H/zHZAoY6PAYDMMEIxuIeRyHrhLUf7hP33yrXDK3VkiqQF AHExEwOV4OlTuId/VGXq/5JAzH5qN4gEaA== X-Google-Smtp-Source: AMsMyM68c+9hjK0Wwi2Oeuk0oan8V5a8VmTAP/Y1GkgICldEvLGfJlkjrFkgBkveg4h1lWFXjsHapg== X-Received: by 2002:a05:620a:19a5:b0:6cf:4a24:cccb with SMTP id bm37-20020a05620a19a500b006cf4a24cccbmr446365qkb.376.1664409133177; Wed, 28 Sep 2022 16:52:13 -0700 (PDT) Received: from hurd (dsl-148-95.b2b2c.ca. [66.158.148.95]) by smtp.gmail.com with ESMTPSA id fv10-20020a05622a4a0a00b003445bb107basm4007405qtb.75.2022.09.28.16.52.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 16:52:12 -0700 (PDT) From: Maxim Cournoyer References: <20210620100945.15345-1-brice@waegenei.re> <87lf6zrmot.fsf@gnu.org> Date: Wed, 28 Sep 2022 19:52:11 -0400 In-Reply-To: <87lf6zrmot.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 24 Jun 2021 23:13:06 +0200") Message-ID: <87y1u3qcpg.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: > Hi, > > Brice Waegeneire skribis: > >> Fixes . > > Thanks for looking into it! > >> * gnu/services/base.scm (file-system-type->utilities, >> file-system-utilities): New procedures. >> (file-system-service-type): Extend 'profile-service-type' with >> 'file-system-utilities'. >> * gnu/system.scm (boot-file-system-service): New procedure=E2=80=A6 >> (operating-system-default-essential-services): =E2=80=A6use it. >> (%base-packages): Remove 'e2fsprogs'. >> * gnu/system/file-systems.scm (file-system): Add 'utilities?' field. > > I think is not a good place to specify whether one would > like utilities to be installed; records represent > mountable file systems, and utilities installed in the profile are > conceptually unrelated. > > Perhaps =E2=80=98file-system-service-type=E2=80=99 could extend =E2=80=98= profile-service-type=E2=80=99 > unconditionally, after all? I took out the utilities? field on (made it unconditional as suggested above), and pushed! Closing. Thanks for the addition! Maxim