From unknown Thu Jun 19 14:25:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49127 <49127@debbugs.gnu.org> To: bug#49127 <49127@debbugs.gnu.org> Subject: Status: Performance degradation in encode_coding_object Reply-To: bug#49127 <49127@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:25:01 +0000 retitle 49127 Performance degradation in encode_coding_object reassign 49127 emacs submitter 49127 Victor Nawothnig severity 49127 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 20 04:18:54 2021 Received: (at submit) by debbugs.gnu.org; 20 Jun 2021 08:18:54 +0000 Received: from localhost ([127.0.0.1]:32994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lusfN-0000CJ-L8 for submit@debbugs.gnu.org; Sun, 20 Jun 2021 04:18:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:38224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luqyZ-0003xI-EK for submit@debbugs.gnu.org; Sun, 20 Jun 2021 02:30:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51338) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luqyZ-0001qi-5E for bug-gnu-emacs@gnu.org; Sun, 20 Jun 2021 02:30:35 -0400 Received: from mr85p00im-zteg06023901.me.com ([17.58.23.192]:45945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luqyW-0002c1-0A for bug-gnu-emacs@gnu.org; Sun, 20 Jun 2021 02:30:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1624170627; bh=On+gBYlSFol7/uYoWXY0dGO7ecWymoDIKqDDornfQDY=; h=Content-Type:From:Mime-Version:Subject:Message-Id:Date:To; b=xVclvyqhEW67enSt+g6bi7KGHfRX7bF8i0v8kxlhtT+gsRX9rH75zk93JFrxwRas1 mJbn6VAUhjYEi79jcaXio4ASKF6gwSw+R6E/F5PKWXvPIT+wAOOels5o/5d8o5DuQp JwacKkP5BDQ9PlbEbgvZNuqGX71VE1uzAJjN/JEjGR7r9vog/8qWwqmzbhSlVgtKug 21XGHkp3swu0cwQZOM72lTpaqGs95GomXPYDpQM6KNb4mwj7WDrPpmZXmWeP2kU8yQ fFsep5Fu8GAT5RxPVFSDMUzMsM4vK63onrelGT4kAXItTT0b+D8XAxzlxPGr6dbE02 1MgOLZTfsIZuA== Received: from smtpclient.apple (p508bae06.dip0.t-ipconnect.de [80.139.174.6]) by mr85p00im-zteg06023901.me.com (Postfix) with ESMTPSA id 69BF768023F for ; Sun, 20 Jun 2021 06:30:27 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Victor Nawothnig Mime-Version: 1.0 (1.0) Subject: Performance degradation in encode_coding_object Message-Id: Date: Sun, 20 Jun 2021 08:30:24 +0200 To: bug-gnu-emacs@gnu.org X-Mailer: iPad Mail (18F72) X-Proofpoint-Virus-Version: =?UTF-8?Q?vendor=3Dfsecure_engine=3D1.1.170-22c6f66c430a71ce266a39bfe25bc?= =?UTF-8?Q?2903e8d5c8f:6.0.391,18.0.790,17.0.607.475.0000000_definitions?= =?UTF-8?Q?=3D2021-06-19=5F15:2021-06-18=5F01,2021-06-19=5F15,2020-04-07?= =?UTF-8?Q?=5F01_signatures=3D0?= X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 bulkscore=0 clxscore=1011 adultscore=0 mlxscore=0 spamscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2106200043 Received-SPF: pass client-ip=17.58.23.192; envelope-from=victor.nawothnig@icloud.com; helo=mr85p00im-zteg06023901.me.com X-Spam_score_int: -8 X-Spam_score: -0.9 X-Spam_bar: / X-Spam_report: (-0.9 / 5.0 requ) BAYES_40=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 20 Jun 2021 04:18:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, All of the following applies to Emacs 27.1 and 28.0.50. Im currently debugging a performance degradation in haskell-mode. When editi= ng code in a terminal frame, over time as I make modifications to source cod= e, redrawing lines during scrolling becomes continuously slower to the point= that it sometimes takes up 200ms for a single line to draw. This problem di= sappears once the GC runs. With gprof/prof_events I have nailed the problem to be encode_coding_object l= ooping over all markers. In degenerate cases this list can contain millions o= f markers. Traversing this list is particularly slow because of the indirect= ion being a singly linked list. Based on the fact that a GC remedies this, I= =E2=80=99m assuming this list contains mostly unreachable markers. When ste= pping through encode_coding_object with GDB after a GC this list of markers s= hrinks to small double digit numbers from millions. The source of these markers appears to be looking-at in the font locking cod= e of haskell-mode, this assumption is based on the fact that commenting out t= he uses of looking-at in haskell-mode prevents the accumulation of markers a= nd thus the slowdown. One contributing factor to all of this, is that for lsp-mode to perform adeq= uately, one needs a relatively high gc-cons-threshold, which means GCs that w= ould clean up the markers run more rarely, leading to higher accumulation of= markers over time. This problem only triggers in terminal frames, but not in GUI frames. Settin= g GDB breakpoints suggests that the GUI frame never even calls into encode_c= oding_object. So far I=E2=80=99m torn on whether this is a bug in the haskell-mode font lo= cking code or in Emacs. What do you think? Kind regards, Victor= From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 20 05:04:57 2021 Received: (at 49127) by debbugs.gnu.org; 20 Jun 2021 09:04:57 +0000 Received: from localhost ([127.0.0.1]:33013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lutNw-0003lB-Q7 for submit@debbugs.gnu.org; Sun, 20 Jun 2021 05:04:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lutNu-0003kt-KS for 49127@debbugs.gnu.org; Sun, 20 Jun 2021 05:04:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34928) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lutNp-0000Za-AK; Sun, 20 Jun 2021 05:04:49 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2437 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lutNo-0000tD-Ti; Sun, 20 Jun 2021 05:04:49 -0400 Date: Sun, 20 Jun 2021 12:04:59 +0300 Message-Id: <83eecwvrd0.fsf@gnu.org> From: Eli Zaretskii To: Victor Nawothnig In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 20 Jun 2021 08:30:24 +0200 > From: Victor Nawothnig via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > With gprof/prof_events I have nailed the problem to be encode_coding_object looping over all markers. In degenerate cases this list can contain millions of markers. Traversing this list is particularly slow because of the indirection being a singly linked list. Based on the fact that a GC remedies this, I’m assuming this list contains mostly unreachable markers. When stepping through encode_coding_object with GDB after a GC this list of markers shrinks to small double digit numbers from millions. > > The source of these markers appears to be looking-at in the font locking code of haskell-mode, this assumption is based on the fact that commenting out the uses of looking-at in haskell-mode prevents the accumulation of markers and thus the slowdown. Do you understand why using looking-at causes creation of markers? If so, can you show the details of why this happens? > One contributing factor to all of this, is that for lsp-mode to perform adequately, one needs a relatively high gc-cons-threshold, which means GCs that would clean up the markers run more rarely, leading to higher accumulation of markers over time. Yes, playing with GC threshold is usually a bad idea, but it is hard to explain to people why, and they keep doing that, to their cost. > This problem only triggers in terminal frames, but not in GUI frames. Setting GDB breakpoints suggests that the GUI frame never even calls into encode_coding_object. Can you should a backtrace from the call to encode_coding_object, including the Lisp backtrace (via the "xbacktrace" command)? > So far I’m torn on whether this is a bug in the haskell-mode font locking code or in Emacs. What do you think? Let's revisit this question after we have all the data I requested above, okay? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 12:50:01 2021 Received: (at 49127) by debbugs.gnu.org; 24 Jun 2021 16:50:02 +0000 Received: from localhost ([127.0.0.1]:44008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwSYD-0007tX-CK for submit@debbugs.gnu.org; Thu, 24 Jun 2021 12:50:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lwSYB-0007tI-NH for 49127@debbugs.gnu.org; Thu, 24 Jun 2021 12:50:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49550) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lwSY6-0004iw-Cj; Thu, 24 Jun 2021 12:49:54 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2224 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lwSY5-0006d4-ED; Thu, 24 Jun 2021 12:49:54 -0400 Date: Thu, 24 Jun 2021 19:49:41 +0300 Message-Id: <83y2azryvu.fsf@gnu.org> From: Eli Zaretskii To: victor.nawothnig@icloud.com In-Reply-To: <83eecwvrd0.fsf@gnu.org> (message from Eli Zaretskii on Sun, 20 Jun 2021 12:04:59 +0300) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83eecwvrd0.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Could you please respond to my requests below? I'd like to make some progress with this bug report. > Date: Sun, 20 Jun 2021 12:04:59 +0300 > From: Eli Zaretskii > Cc: 49127@debbugs.gnu.org > > > Date: Sun, 20 Jun 2021 08:30:24 +0200 > > From: Victor Nawothnig via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > With gprof/prof_events I have nailed the problem to be encode_coding_object looping over all markers. In degenerate cases this list can contain millions of markers. Traversing this list is particularly slow because of the indirection being a singly linked list. Based on the fact that a GC remedies this, I’m assuming this list contains mostly unreachable markers. When stepping through encode_coding_object with GDB after a GC this list of markers shrinks to small double digit numbers from millions. > > > > The source of these markers appears to be looking-at in the font locking code of haskell-mode, this assumption is based on the fact that commenting out the uses of looking-at in haskell-mode prevents the accumulation of markers and thus the slowdown. > > Do you understand why using looking-at causes creation of markers? If > so, can you show the details of why this happens? > > > One contributing factor to all of this, is that for lsp-mode to perform adequately, one needs a relatively high gc-cons-threshold, which means GCs that would clean up the markers run more rarely, leading to higher accumulation of markers over time. > > Yes, playing with GC threshold is usually a bad idea, but it is hard > to explain to people why, and they keep doing that, to their cost. > > > This problem only triggers in terminal frames, but not in GUI frames. Setting GDB breakpoints suggests that the GUI frame never even calls into encode_coding_object. > > Can you should a backtrace from the call to encode_coding_object, > including the Lisp backtrace (via the "xbacktrace" command)? > > > So far I’m torn on whether this is a bug in the haskell-mode font locking code or in Emacs. What do you think? > > Let's revisit this question after we have all the data I requested > above, okay? > > Thanks. > > > > From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 25 03:10:59 2021 Received: (at 49127) by debbugs.gnu.org; 25 Jul 2021 07:10:59 +0000 Received: from localhost ([127.0.0.1]:47441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7YHq-0002iB-Vh for submit@debbugs.gnu.org; Sun, 25 Jul 2021 03:10:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7YHo-0002hv-I8 for 49127@debbugs.gnu.org; Sun, 25 Jul 2021 03:10:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60728) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7YHj-0002ue-8E; Sun, 25 Jul 2021 03:10:51 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2617 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7YHi-0003Yl-Sb; Sun, 25 Jul 2021 03:10:51 -0400 Date: Sun, 25 Jul 2021 10:10:40 +0300 Message-Id: <835ywyyikv.fsf@gnu.org> From: Eli Zaretskii To: victor.nawothnig@icloud.com In-Reply-To: <83y2azryvu.fsf@gnu.org> (message from Eli Zaretskii on Thu, 24 Jun 2021 19:49:41 +0300) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83eecwvrd0.fsf@gnu.org> <83y2azryvu.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Ping! Please respond, so we could take care of this issue. To recap: I would like to have a backtrace from the call to encode_coding_object, including the Lisp backtrace (via the "xbacktrace" command), so that we could see how this performance issue happens. TIA > Date: Thu, 24 Jun 2021 19:49:41 +0300 > From: Eli Zaretskii > Cc: 49127@debbugs.gnu.org > > Ping! Could you please respond to my requests below? I'd like to > make some progress with this bug report. > > > Date: Sun, 20 Jun 2021 12:04:59 +0300 > > From: Eli Zaretskii > > Cc: 49127@debbugs.gnu.org > > > > > Date: Sun, 20 Jun 2021 08:30:24 +0200 > > > From: Victor Nawothnig via "Bug reports for GNU Emacs, > > > the Swiss army knife of text editors" > > > > > > With gprof/prof_events I have nailed the problem to be encode_coding_object looping over all markers. In degenerate cases this list can contain millions of markers. Traversing this list is particularly slow because of the indirection being a singly linked list. Based on the fact that a GC remedies this, I’m assuming this list contains mostly unreachable markers. When stepping through encode_coding_object with GDB after a GC this list of markers shrinks to small double digit numbers from millions. > > > > > > The source of these markers appears to be looking-at in the font locking code of haskell-mode, this assumption is based on the fact that commenting out the uses of looking-at in haskell-mode prevents the accumulation of markers and thus the slowdown. > > > > Do you understand why using looking-at causes creation of markers? If > > so, can you show the details of why this happens? > > > > > One contributing factor to all of this, is that for lsp-mode to perform adequately, one needs a relatively high gc-cons-threshold, which means GCs that would clean up the markers run more rarely, leading to higher accumulation of markers over time. > > > > Yes, playing with GC threshold is usually a bad idea, but it is hard > > to explain to people why, and they keep doing that, to their cost. > > > > > This problem only triggers in terminal frames, but not in GUI frames. Setting GDB breakpoints suggests that the GUI frame never even calls into encode_coding_object. > > > > Can you should a backtrace from the call to encode_coding_object, > > including the Lisp backtrace (via the "xbacktrace" command)? > > > > > So far I’m torn on whether this is a bug in the haskell-mode font locking code or in Emacs. What do you think? > > > > Let's revisit this question after we have all the data I requested > > above, okay? > > > > Thanks. > > > > > > > > > > > > > From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 15 11:07:39 2021 Received: (at 49127) by debbugs.gnu.org; 15 Aug 2021 15:07:40 +0000 Received: from localhost ([127.0.0.1]:47592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFHjf-0001pu-LR for submit@debbugs.gnu.org; Sun, 15 Aug 2021 11:07:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFHje-0001pj-Of for 49127@debbugs.gnu.org; Sun, 15 Aug 2021 11:07:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48864) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFHjZ-0008Au-Hj; Sun, 15 Aug 2021 11:07:33 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1603 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFHjZ-0000jF-20; Sun, 15 Aug 2021 11:07:33 -0400 Date: Sun, 15 Aug 2021 18:07:23 +0300 Message-Id: <83a6liagr8.fsf@gnu.org> From: Eli Zaretskii To: victor.nawothnig@icloud.com In-Reply-To: <835ywyyikv.fsf@gnu.org> (message from Eli Zaretskii on Sun, 25 Jul 2021 10:10:40 +0300) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83eecwvrd0.fsf@gnu.org> <83y2azryvu.fsf@gnu.org> <835ywyyikv.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping! Ping! Ping! Please respond! > Date: Sun, 25 Jul 2021 10:10:40 +0300 > From: Eli Zaretskii > Cc: 49127@debbugs.gnu.org > > Ping! Ping! Please respond, so we could take care of this issue. > > To recap: I would like to have a backtrace from the call to > encode_coding_object, including the Lisp backtrace (via the > "xbacktrace" command), so that we could see how this performance issue > happens. > > TIA > > > Date: Thu, 24 Jun 2021 19:49:41 +0300 > > From: Eli Zaretskii > > Cc: 49127@debbugs.gnu.org > > > > Ping! Could you please respond to my requests below? I'd like to > > make some progress with this bug report. > > > > > Date: Sun, 20 Jun 2021 12:04:59 +0300 > > > From: Eli Zaretskii > > > Cc: 49127@debbugs.gnu.org > > > > > > > Date: Sun, 20 Jun 2021 08:30:24 +0200 > > > > From: Victor Nawothnig via "Bug reports for GNU Emacs, > > > > the Swiss army knife of text editors" > > > > > > > > With gprof/prof_events I have nailed the problem to be encode_coding_object looping over all markers. In degenerate cases this list can contain millions of markers. Traversing this list is particularly slow because of the indirection being a singly linked list. Based on the fact that a GC remedies this, I’m assuming this list contains mostly unreachable markers. When stepping through encode_coding_object with GDB after a GC this list of markers shrinks to small double digit numbers from millions. > > > > > > > > The source of these markers appears to be looking-at in the font locking code of haskell-mode, this assumption is based on the fact that commenting out the uses of looking-at in haskell-mode prevents the accumulation of markers and thus the slowdown. > > > > > > Do you understand why using looking-at causes creation of markers? If > > > so, can you show the details of why this happens? > > > > > > > One contributing factor to all of this, is that for lsp-mode to perform adequately, one needs a relatively high gc-cons-threshold, which means GCs that would clean up the markers run more rarely, leading to higher accumulation of markers over time. > > > > > > Yes, playing with GC threshold is usually a bad idea, but it is hard > > > to explain to people why, and they keep doing that, to their cost. > > > > > > > This problem only triggers in terminal frames, but not in GUI frames. Setting GDB breakpoints suggests that the GUI frame never even calls into encode_coding_object. > > > > > > Can you should a backtrace from the call to encode_coding_object, > > > including the Lisp backtrace (via the "xbacktrace" command)? > > > > > > > So far I’m torn on whether this is a bug in the haskell-mode font locking code or in Emacs. What do you think? > > > > > > Let's revisit this question after we have all the data I requested > > > above, okay? > > > > > > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 13:43:34 2021 Received: (at 49127) by debbugs.gnu.org; 16 Aug 2021 17:43:34 +0000 Received: from localhost ([127.0.0.1]:50905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFge5-0001xm-Sj for submit@debbugs.gnu.org; Mon, 16 Aug 2021 13:43:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFge3-0001xZ-BT for 49127@debbugs.gnu.org; Mon, 16 Aug 2021 13:43:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55958) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFgdx-0007dQ-Q8; Mon, 16 Aug 2021 13:43:25 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4378 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFgdx-0001R4-C0; Mon, 16 Aug 2021 13:43:25 -0400 Date: Mon, 16 Aug 2021 20:43:20 +0300 Message-Id: <83sfz970av.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 16 Aug 2021 19:32:46 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Mon, 16 Aug 2021 19:32:46 +0200 > Cc: Eli Zaretskii , 49127@debbugs.gnu.org > > It looks very much like haskell-mode is producing way too many markers, and that should be easily fixed (I wrote a tentative pull request). However, the code in encode_coding_object appears broken. Look at the first loop in that function: > > if (EQ (src_object, dst_object)) > { > struct Lisp_Marker *tail; > > for (tail = BUF_MARKERS (current_buffer); tail; tail = tail->next) > { > tail->need_adjustment > = tail->charpos == (tail->insertion_type ? from : to); > need_marker_adjustment |= tail->need_adjustment; > } > } > > I don't know how this could ever work. We loop through the markers in the current buffer? Yes. Why do you think this loop is broken? > It is called from term.c with src_object and dst_object both being Qnil; no buffer is involved at all. At the very least the outer condition should have an "&& BUFFERP (dst_object)" added, and the loop should run through the markers of XBUFFER (dst_object) instead of current_buffer, no? > > `decode_coding_object` seem to get these things right but I only took a superficial look. It's probably copy-paste errors. It isn't a copy/paste, I think it's a simple omission. But if you look up-thread, you will see that I asked for xbacktrace results from the OP, to make sure I completely understand the reasons for the performance problem. I never got any responses for that. So if you can produce the Lisp backtraces in that case, and later test a fix, I'm quite sure I know how to fix this problem. TIA. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 14:07:29 2021 Received: (at 49127) by debbugs.gnu.org; 16 Aug 2021 18:07:29 +0000 Received: from localhost ([127.0.0.1]:50930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFh1B-0002fx-J5 for submit@debbugs.gnu.org; Mon, 16 Aug 2021 14:07:29 -0400 Received: from mail211c50.megamailservers.eu ([91.136.10.221]:48428 helo=mail194c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFh15-0002ff-G1 for 49127@debbugs.gnu.org; Mon, 16 Aug 2021 14:07:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629137237; bh=pZTKL2r/eIF4WofFOJaKCHIgqIiMqXgdmvNRtMQQ2Mg=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=GkwRjqs+ypbl6IKmr5XH7R7VdGkr164kSL6UweZT0Rj4FOVYeUq4gVjKZ8qquRiPx miNXWz+UdUaWN/r+17lIAITVVA5WBYZCvLe00Gl5i1pYvc4v8HJoZn0wf5BGw2nWf2 tiuX841q1RESAlr4otQX4qO4VP00WqicwvRIyQbk= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail194c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17GI7E9N029123; Mon, 16 Aug 2021 18:07:16 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> Content-Type: multipart/mixed; boundary="Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object Date: Mon, 16 Aug 2021 20:06:32 +0200 In-Reply-To: <83sfz970av.fsf@gnu.org> To: Eli Zaretskii References: <83sfz970av.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1A.611AA954.008D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=QJQWuTDL c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=3a_NVP5hYyDUylAqKpgA:9 a=CjuIK1q_8ugA:10 a=mxo5oClUaWORlOBPrwYA:9 a=1OfwrDeanrQA:10 a=nZGyFEsNMesJOn5ZQaYA:9 a=B2y7HmGcmWMA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 16 aug. 2021 kl. 19.43 skrev Eli Zaretskii : >> I don't know how this could ever work. We loop through the markers in the current buffer? > > Yes. Why do you think this loop is broken? Because unless I misunderstood the code entirely, the current buffer has nothing to do with the operation at hand. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 16 aug. 2021 kl. 19.43 skrev Eli Zaretskii : >> I don't know how this could ever work. We loop through the markers in = the current buffer? >=20 > Yes. Why do you think this loop is broken? Because unless I misunderstood the code entirely, the current buffer has = nothing to do with the operation at hand. It's easy to reproduce the original problem: run Emacs in a terminal and = make a buffer with many markers. See how the text displays slower with = more markers. I've attached a short example; try (make-test-buffer = 1000). The attached patch fixes this problem. --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0 Content-Disposition: attachment; filename=lus.el Content-Type: application/octet-stream; x-unix-mode=0644; name="lus.el" Content-Transfer-Encoding: 7bit ;;; -*- lexical-binding -*- (defvar my-markers nil) (defun make-test-buffer (n) (setq my-markers nil) (with-current-buffer (get-buffer-create "test-buffer") (erase-buffer) (dotimes (i 1000) (insert (format "%8d " i)) (dotimes (_ n) (push (point-marker) my-markers)) (insert "abcdefghijklmnopqrstuvwxyz\n")))) --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0 Content-Disposition: attachment; filename=0001-Fix-marker-traversion-in-encode_coding_object.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Fix-marker-traversion-in-encode_coding_object.patch" Content-Transfer-Encoding: quoted-printable =46rom=20d38eace17a24ed2d15a3bf069e1aaf05a495e077=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=2016=20Aug=202021=2019:57:34=20+0200=0A= Subject:=20[PATCH]=20Fix=20marker=20traversion=20in=20= encode_coding_object=0A=0A*=20src/coding.c=20(encode_coding_object):=20= Only=20traverse=20markers=20if=20we=20are=0Aencoding=20to=20and=20from=20= buffers,=20and=20use=20the=20right=20buffer=20when=20doing=20so.=0A=0A= This=20also=20fixes=20a=20performance=20problem=20when=20running=20in=20= a=20terminal=20and=0Athe=20displayed=20buffer=20has=20many=20markers=20= (bug#49127).=0AReported=20by=20Victor=20Nawothnig.=0A---=0A=20= src/coding.c=20|=204=20++--=0A=201=20file=20changed,=202=20= insertions(+),=202=20deletions(-)=0A=0Adiff=20--git=20a/src/coding.c=20= b/src/coding.c=0Aindex=2087b55aecc0..599ed48b2e=20100644=0A---=20= a/src/coding.c=0A+++=20b/src/coding.c=0A@@=20-8275,11=20+8275,11=20@@=20= encode_coding_object=20(struct=20coding_system=20*coding,=0A=20=0A=20=20=20= attrs=20=3D=20CODING_ID_ATTRS=20(coding->id);=0A=20=0A-=20=20if=20(EQ=20= (src_object,=20dst_object))=0A+=20=20if=20(EQ=20(src_object,=20= dst_object)=20&&=20BUFFERP=20(dst_object))=0A=20=20=20=20=20{=0A=20=20=20= =20=20=20=20struct=20Lisp_Marker=20*tail;=0A=20=0A-=20=20=20=20=20=20for=20= (tail=20=3D=20BUF_MARKERS=20(current_buffer);=20tail;=20tail=20=3D=20= tail->next)=0A+=20=20=20=20=20=20for=20(tail=20=3D=20BUF_MARKERS=20= (XBUFFER=20(dst_object));=20tail;=20tail=20=3D=20tail->next)=0A=20=09{=0A= =20=09=20=20tail->need_adjustment=0A=20=09=20=20=20=20=3D=20= tail->charpos=20=3D=3D=20(tail->insertion_type=20?=20from=20:=20to);=0A= --=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_2F59ED86-55C6-4DDB-83EB-6BDE5D11FBB0-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 14:50:23 2021 Received: (at 49127) by debbugs.gnu.org; 16 Aug 2021 18:50:23 +0000 Received: from localhost ([127.0.0.1]:50980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFhgk-0003o7-WF for submit@debbugs.gnu.org; Mon, 16 Aug 2021 14:50:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53530) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFhgg-0003no-2w for 49127@debbugs.gnu.org; Mon, 16 Aug 2021 14:50:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58324) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFhga-0003Go-DE; Mon, 16 Aug 2021 14:50:12 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4476 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFhgY-00022V-6D; Mon, 16 Aug 2021 14:50:12 -0400 Date: Mon, 16 Aug 2021 21:50:03 +0300 Message-Id: <83lf516x7o.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 16 Aug 2021 20:06:32 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Mon, 16 Aug 2021 20:06:32 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > > Yes. Why do you think this loop is broken? > > Because unless I misunderstood the code entirely, the current buffer has nothing to do with the operation at hand. It does, if both src_object and dst_object are the same (current) buffer. > It's easy to reproduce the original problem: run Emacs in a terminal and make a buffer with many markers. See how the text displays slower with more markers. I've attached a short example; try (make-test-buffer 1000). How can we be sure this reproduces the original issue? The original issue was reported from a real-life use case, not from a toy program. > The attached patch fixes this problem. Thanks, but this is not the whole story with that problem in encode_coding_object. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 16 16:04:52 2021 Received: (at 49127) by debbugs.gnu.org; 16 Aug 2021 20:04:52 +0000 Received: from localhost ([127.0.0.1]:51083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFiqp-0005jM-Pt for submit@debbugs.gnu.org; Mon, 16 Aug 2021 16:04:52 -0400 Received: from mail1461c50.megamailservers.eu ([91.136.14.61]:60026 helo=mail267c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFiqk-0005j2-HX for 49127@debbugs.gnu.org; Mon, 16 Aug 2021 16:04:50 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629144279; bh=2GjTgEGWe7CHrJwpq72JZd0k2d9/t3y4facIsHNJypM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ZGTLjVROQUML00WbjM/0586dtUzFp8MXtR4Yzny+uc5/mqXmZ6uab9w0x1Nq7tH19 J9ttwC1rt1DgZhKcOuGLzG+bCAiiZjqfmwe8GN83M3edWf7zhXvEC0UqX8TdqAp6KY aIKDJyJPjAiNXIocbut+xgn3+1fKmUDxCxNdv58E= Feedback-ID: mattiase@acm.or Received: from stanniol.lan (c-b952e353.032-75-73746f71.bbcust.telenor.se [83.227.82.185]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17GK4aCb012639; Mon, 16 Aug 2021 20:04:38 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83lf516x7o.fsf@gnu.org> Date: Mon, 16 Aug 2021 22:04:36 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F18.611AC4D7.004B, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=S9SnP7kP c=1 sm=1 tr=0 a=von4qPfY+hyqc0zmWf0tYQ==:117 a=von4qPfY+hyqc0zmWf0tYQ==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=QEEfLx4z3-02V98Qa4IA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 16 aug. 2021 kl. 20.50 skrev Eli Zaretskii : > It does, if both src_object and dst_object are the same (current) > buffer. There is nothing in that function or in the comment describing it which says that the current buffer must be either. It costs us nothing to use the correct value so that's what we should do. Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 16 aug. 2021 kl. 20.50 skrev Eli Zaretskii : > It does, if both src_object and dst_object are the same (current) > buffer. There is nothing in that function or in the comment describing it which = says that the current buffer must be either. It costs us nothing to use = the correct value so that's what we should do. > How can we be sure this reproduces the original issue? The original > issue was reported from a real-life use case, not from a toy program. Because I have read and tested the original code as well, which is how = that toy program that reproduces the problem in a simpler but = qualitatively equivalent way came to be. The patch fixes the symptoms of = both the toy program and the real-life use case. > Thanks, but this is not the whole story with that problem in > encode_coding_object. What is the whole story then? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 08:34:33 2021 Received: (at 49127) by debbugs.gnu.org; 17 Aug 2021 12:34:33 +0000 Received: from localhost ([127.0.0.1]:52034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFyIb-0005cG-3R for submit@debbugs.gnu.org; Tue, 17 Aug 2021 08:34:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFyIX-0005c2-VH for 49127@debbugs.gnu.org; Tue, 17 Aug 2021 08:34:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54950) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFyIS-0002D7-DX; Tue, 17 Aug 2021 08:34:24 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1713 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFyIR-0005fc-Vv; Tue, 17 Aug 2021 08:34:24 -0400 Date: Tue, 17 Aug 2021 15:34:19 +0300 Message-Id: <837dgk6yic.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 16 Aug 2021 22:04:36 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Mon, 16 Aug 2021 22:04:36 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > > Thanks, but this is not the whole story with that problem in > > encode_coding_object. > > What is the whole story then? See the change I installed a few minutes ago. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 08:35:20 2021 Received: (at 49127-done) by debbugs.gnu.org; 17 Aug 2021 12:35:20 +0000 Received: from localhost ([127.0.0.1]:52038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFyJM-0005dp-Cb for submit@debbugs.gnu.org; Tue, 17 Aug 2021 08:35:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFyJK-0005da-Q9 for 49127-done@debbugs.gnu.org; Tue, 17 Aug 2021 08:35:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54962) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFyJF-0002aX-KE; Tue, 17 Aug 2021 08:35:13 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1762 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFyJD-0007oT-0l; Tue, 17 Aug 2021 08:35:13 -0400 Date: Tue, 17 Aug 2021 15:35:08 +0300 Message-Id: <835yw46ygz.fsf@gnu.org> From: Eli Zaretskii To: victor.nawothnig@icloud.com In-Reply-To: <83a6liagr8.fsf@gnu.org> (message from Eli Zaretskii on Sun, 15 Aug 2021 18:07:23 +0300) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83eecwvrd0.fsf@gnu.org> <83y2azryvu.fsf@gnu.org> <835ywyyikv.fsf@gnu.org> <83a6liagr8.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127-done Cc: 49127-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 15 Aug 2021 18:07:23 +0300 > From: Eli Zaretskii > Cc: 49127@debbugs.gnu.org > > Ping! Ping! Ping! Please respond! This should now be fixed on the master branch. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 09:07:09 2021 Received: (at 49127) by debbugs.gnu.org; 17 Aug 2021 13:07:09 +0000 Received: from localhost ([127.0.0.1]:52067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFyo9-0006Q4-CR for submit@debbugs.gnu.org; Tue, 17 Aug 2021 09:07:09 -0400 Received: from mail18c50.megamailservers.eu ([91.136.10.28]:46516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFyo4-0006Pn-7s for 49127@debbugs.gnu.org; Tue, 17 Aug 2021 09:07:08 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629205621; bh=zHl1iEfjxYGCLMG7REsz9JPX1cmEu4b1naIkLqNm9Uk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=opecvubl5GU6e5/qr7d9hYgHn03dZzXpOmEqkEUpl4SzDYBM9KvkKdK+W3gSWiuJ6 Lb+P74ozD9/oj3C9Mh2KQ4yf6c0NuhV4LnGs8NMF4pWVfmnVJnzzHPRJ+QtPcttIuh 3Yimq0ab0Stm6aWO4IFAIF1xqO5JJCEgLyTOATCA= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail18c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17HD6xIN008220; Tue, 17 Aug 2021 13:07:00 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <837dgk6yic.fsf@gnu.org> Date: Tue, 17 Aug 2021 15:06:58 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F17.611BB475.0081, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Vt9d/N+n c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=Vyac5wvmHVeh98YBy2MA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 17 aug. 2021 kl. 14.34 skrev Eli Zaretskii > See the change I installed a few minutes ago. Let's see, you took my patch and fixed one more condition that I missed = (line 8301) -- thank you! Anyway, I'm happy that it got done at last, and it's good that you took = the time to write the documenting comment. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 10:06:03 2021 Received: (at 49127) by debbugs.gnu.org; 17 Aug 2021 14:06:03 +0000 Received: from localhost ([127.0.0.1]:53714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFzj9-0008Gt-Fw for submit@debbugs.gnu.org; Tue, 17 Aug 2021 10:06:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mFzj6-0008G5-5w for 49127@debbugs.gnu.org; Tue, 17 Aug 2021 10:06:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57522) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFzj0-0007U0-PZ; Tue, 17 Aug 2021 10:05:54 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3352 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFziz-0001gI-DJ; Tue, 17 Aug 2021 10:05:54 -0400 Date: Tue, 17 Aug 2021 17:05:49 +0300 Message-Id: <831r6s6u9u.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 17 Aug 2021 15:06:58 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Feedback-ID:mattiase@acm.or > From: Mattias EngdegÃ¥rd > Date: Tue, 17 Aug 2021 15:06:58 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > 17 aug. 2021 kl. 14.34 skrev Eli Zaretskii > > > See the change I installed a few minutes ago. > > Let's see, you took my patch and fixed one more condition that I missed (line 8301) -- thank you! No, it's you who took _my_ patch, removed one of its parts, and deleted the commentary. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 12:07:25 2021 Received: (at 49127) by debbugs.gnu.org; 17 Aug 2021 16:07:25 +0000 Received: from localhost ([127.0.0.1]:53894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG1cb-0002v0-Ic for submit@debbugs.gnu.org; Tue, 17 Aug 2021 12:07:25 -0400 Received: from mail1447c50.megamailservers.eu ([91.136.14.47]:59774 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG1cW-0002uh-8Q for 49127@debbugs.gnu.org; Tue, 17 Aug 2021 12:07:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629216433; bh=3en5VRqqgLHsW0b5qfiV+AMDTBKTj/Y6VhiVk2gkzzY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=l7DBTSNSqE6DM0xllUWOu39zwa4uS1ROSQyDQ8OX+uBhSFGCoLCRncA/oTqU/NSLZ au8jaDIpHy9xAUA2MiDReca+9uyUInRmgC9q0gg1hZz9Nxf6Dma9AB5QQofv8p9Lze 82Wuaxnuq3sUT6JCNdYjsDRD+MOIzSF1+SV52O7U= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17HG7AUu001481; Tue, 17 Aug 2021 16:07:12 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <831r6s6u9u.fsf@gnu.org> Date: Tue, 17 Aug 2021 18:07:10 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F25.611BDEB1.0034, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=K5pc4BeI c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=4ueYecUru9OLVE4c_RIA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 17 aug. 2021 kl. 16.05 skrev Eli Zaretskii : > No, it's you who took _my_ patch, removed one of its parts, and deleted > the commentary. Yes, I wanted to have all the credit to my name! All mine! Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 17 aug. 2021 kl. 16.05 skrev Eli Zaretskii : > No, it's you who took _my_ patch, removed one of its parts, and = deleted > the commentary. Yes, I wanted to have all the credit to my name! All mine! Seriously, I didn't mean to imply that you did anything improper, and = I'm genuinely pleased that we ended up with a good solution. This business makes me wonder if there are more cases where the linear = marker list causes bad performance. Probably not very often but it's not = unreasonable for a mode to have many data structures with many (live) = markers into the text, and that would lead to text changes going from = O(1) to O(text size). In any case, not anything to worry about right = now. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 17 13:16:39 2021 Received: (at 49127) by debbugs.gnu.org; 17 Aug 2021 17:16:39 +0000 Received: from localhost ([127.0.0.1]:53994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG2hb-0004nb-7Z for submit@debbugs.gnu.org; Tue, 17 Aug 2021 13:16:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mG2hZ-0004nM-0h for 49127@debbugs.gnu.org; Tue, 17 Aug 2021 13:16:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38528) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mG2hT-00087C-Q1; Tue, 17 Aug 2021 13:16:31 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3194 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mG2hT-0002Ti-Cz; Tue, 17 Aug 2021 13:16:31 -0400 Date: Tue, 17 Aug 2021 20:16:29 +0300 Message-Id: <83wnok56vm.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Tue, 17 Aug 2021 18:07:10 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Tue, 17 Aug 2021 18:07:10 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > This business makes me wonder if there are more cases where the linear marker list causes bad performance. Probably not very often but it's not unreasonable for a mode to have many data structures with many (live) markers into the text, and that would lead to text changes going from O(1) to O(text size). In any case, not anything to worry about right now. It's a problem to have many markers in a buffer. Not only for code that searches them linearly, but also for stuff like converting between character and byte positions, something that we do a lot in the most inner loops of our code. Lisp programs that produce gobs of markers should be ideally redesigned not to do so. Unless we change the way we store markers to make that a non-issue. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 07:04:25 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 11:04:25 +0000 Received: from localhost ([127.0.0.1]:54982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGJMu-0000mU-UM for submit@debbugs.gnu.org; Wed, 18 Aug 2021 07:04:25 -0400 Received: from mail1443c50.megamailservers.eu ([91.136.14.43]:56732 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGJMs-0000mE-A4 for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 07:04:23 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629284655; bh=uutEZV0PwmZRJLumTG+br0HrPotMi2GBbH/cFnRnGkw=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ld4y6S94Hfwwo0qCtE6s2fiKfCwb4Q/n/59fpLP0BUcuDeAggdceEpZ3Lfkcve7AC N3qDKgcUoeSsC7A1BWZUhCiltOgDcBOx7X3fyCqEn+V+twbUjopEsOp7kBc/W7Zvly iJatVWm76l6v3tyNxtp7RoeGMrsSGsvk+pxEX4Yg= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17IB4DmP014027; Wed, 18 Aug 2021 11:04:15 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83wnok56vm.fsf@gnu.org> Date: Wed, 18 Aug 2021 13:04:12 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F19.611CE92F.0029, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Xdb3M7x5 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=U0Xgpp0EEs0JW2xwPXoA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 17 aug. 2021 kl. 19.16 skrev Eli Zaretskii : > It's a problem to have many markers in a buffer. Not only for code > that searches them linearly, but also for stuff like converting > between character and byte positions, something that we do a lo [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 17 aug. 2021 kl. 19.16 skrev Eli Zaretskii : > It's a problem to have many markers in a buffer. Not only for code > that searches them linearly, but also for stuff like converting > between character and byte positions, something that we do a lot in > the most inner loops of our code. Lisp programs that produce gobs of > markers should be ideally redesigned not to do so. I agree; the haskell-mode usage was misguided in this respect. = Marker-intensive modes could still be justified occasionally: consider = an index of all definitions and uses of each variable, function and type = in a program, produced by an expensive compilation that cannot be re-run = for each little change. This could easily amount to thousands of markers = in a big file. > Unless we change > the way we store markers to make that a non-issue. We probably should but I agree that marker reduction should be the first = remedy to try. Improving the GC so that it's cheaper to run frequent collections would = also help in the common case where most markers are dead (as in this = case). From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 07:43:46 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 11:43:46 +0000 Received: from localhost ([127.0.0.1]:55027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGJyz-0003qW-M7 for submit@debbugs.gnu.org; Wed, 18 Aug 2021 07:43:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGJyx-0003qH-Lk for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 07:43:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43596) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGJyr-0004vf-V2; Wed, 18 Aug 2021 07:43:37 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3052 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGJyq-0003XV-Va; Wed, 18 Aug 2021 07:43:37 -0400 Date: Wed, 18 Aug 2021 14:43:38 +0300 Message-Id: <83bl5v566t.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 18 Aug 2021 13:04:12 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Wed, 18 Aug 2021 13:04:12 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > consider an index of all definitions and uses of each variable, function and type in a program, produced by an expensive compilation that cannot be re-run for each little change. This could easily amount to thousands of markers in a big file. They could have used text properties instead, no? From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 08:21:35 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 12:21:35 +0000 Received: from localhost ([127.0.0.1]:55067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGKZb-0004lZ-FB for submit@debbugs.gnu.org; Wed, 18 Aug 2021 08:21:35 -0400 Received: from mail1474c50.megamailservers.eu ([91.136.14.74]:57416 helo=mail102c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGKZY-0004lH-7A for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 08:21:33 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629289285; bh=UW6L0xIn++Q5bdTXx0+EPIBdTSiLxV8l/XFbBNi32kM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=QH9T3yR9UfaynmlRPJfB5hyWQm3/3s6E/n9TdKv7Tc2XVZztljNCec0BKaZwu1pK+ ZNxZkBPzhSK9yp9mPCHX1fjk3vcycuHAM31xMvQmDHln7qP54pMaRHcGcTF4Z0totM jFyzHqPxcXVQCeqiJnTywK1uHXGI4oWAlzRqeoU0= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail102c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17ICLMNR007489; Wed, 18 Aug 2021 12:21:24 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83bl5v566t.fsf@gnu.org> Date: Wed, 18 Aug 2021 14:21:22 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F24.611CFB45.0002, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Z/WS40ZA c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=_BKiplsOE5Of6e2QHgYA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 18 aug. 2021 kl. 13.43 skrev Eli Zaretskii : >> consider an index of all definitions and uses of each variable, function and type in a program, produced by an expensive compilation that cannot be re-run for each little change. This could easily [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 18 aug. 2021 kl. 13.43 skrev Eli Zaretskii : >> consider an index of all definitions and uses of each variable, = function and type in a program, produced by an expensive compilation = that cannot be re-run for each little change. This could easily amount = to thousands of markers in a big file. >=20 > They could have used text properties instead, no? Yes and no. That works for the direction from a point in the buffer but = not the other way: go to a specific place in the buffer, such as a = definition or all references of something. It could be something = selected from a tree in the sidebar etc or be implicit (as in "go to the = superclass of the class at point"). The alternative is to use plain offsets instead, and update them inside = buffer-change callback functions -- but then we are essentially doing = exactly what the Emacs marker implementation would be doing, only in = Elisp instead of C so probably slower, unless we use more clever data = structures. Emacs isn't badly designed -- the marker implementation is fine if we = assume there are only a few of them per buffer, which is mostly the = case. But it isn't scalable, and also adversely affected by large = amounts of garbage markers. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 09:23:18 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 13:23:18 +0000 Received: from localhost ([127.0.0.1]:55252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGLXK-0006Ns-8c for submit@debbugs.gnu.org; Wed, 18 Aug 2021 09:23:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGLXI-0006Ne-GC for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 09:23:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46792) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGLXD-0004dg-0K; Wed, 18 Aug 2021 09:23:11 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1186 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGLXB-0002tW-Qj; Wed, 18 Aug 2021 09:23:10 -0400 Date: Wed, 18 Aug 2021 16:23:11 +0300 Message-Id: <83v94251kw.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 18 Aug 2021 14:21:22 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Wed, 18 Aug 2021 14:21:22 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > > They could have used text properties instead, no? > > Yes and no. That works for the direction from a point in the buffer but not the other way: go to a specific place in the buffer, such as a definition or all references of something. It could be something selected from a tree in the sidebar etc or be implicit (as in "go to the superclass of the class at point"). Text property search doesn't fit the bill? > Emacs isn't badly designed -- the marker implementation is fine if we assume there are only a few of them per buffer, which is mostly the case. But it isn't scalable, and also adversely affected by large amounts of garbage markers. These situations usually mean we lack some infrastructure, and the Lisp program uses what's available, with bad results. A better solution is to design and implement the missing infrastructure instead. The problem with Emacs is not the design, it's that in many cases, instead of extending the design where something is missing, Lisp programmers tend to use the existing features outside of their intended purpose. IOW, our design is not evolving enough according to the needs, not in a small measure because those needs are not always communicated to us. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 09:32:27 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 13:32:27 +0000 Received: from localhost ([127.0.0.1]:55267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGLgA-0006c1-Qd for submit@debbugs.gnu.org; Wed, 18 Aug 2021 09:32:27 -0400 Received: from mail1453c50.megamailservers.eu ([91.136.14.53]:40348 helo=mail266c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGLg7-0006bi-UO for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 09:32:25 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629293536; bh=oHnhVX5td3SA+NLNXOg55P6PEiEDrwH7RC8A5PW8eUU=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Kq8CARUcOTv8eXVqzoHdTF3udR7eVsFedPn2I32ywb4vC6Xvq2Pvyt69nLa793kDX 26U0Y9ntRW2Drd0exY4qeawUBmFW+HOJAQRlX8XeUGzXsojkePLIhPzpIcpbCb2wRv aMZuMJC/4bads5vrQcEQcNeWZ2gjJLSbp8XO8y/o= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17IDWBFO023455; Wed, 18 Aug 2021 13:32:15 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83v94251kw.fsf@gnu.org> Date: Wed, 18 Aug 2021 15:32:11 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F1D.611D0BE0.006C, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=UeYvt5aN c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=d8pMPmXRhJ2yX37tGvQA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 18 aug. 2021 kl. 15.23 skrev Eli Zaretskii : > Text property search doesn't fit the bill? Oh it does, except that it's linear in the size of the buffer, and that doesn't really scale either. For a single interactive lookup this might not be too bad but there might be programmatic uses that [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 18 aug. 2021 kl. 15.23 skrev Eli Zaretskii : > Text property search doesn't fit the bill? Oh it does, except that it's linear in the size of the buffer, and that = doesn't really scale either. For a single interactive lookup this might = not be too bad but there might be programmatic uses that iterate. > These situations usually mean we lack some infrastructure, and the > Lisp program uses what's available, with bad results. A better > solution is to design and implement the missing infrastructure > instead. Could be, but markers is one type of infrastructure, and implementing = something else for the same purpose is a bit of a waste compared to just = making markers faster. > The problem with Emacs is not the design, it's that in many cases, > instead of extending the design where something is missing, Lisp > programmers tend to use the existing features outside of their > intended purpose. Very true. We have probably done our job for the time being, but let's = keep our eyes open for uses (legitimate or not) that stress the marker = system to the point of disappointment, and consider what to do then. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 09:39:35 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 13:39:35 +0000 Received: from localhost ([127.0.0.1]:55286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGLn1-0006pq-7J for submit@debbugs.gnu.org; Wed, 18 Aug 2021 09:39:35 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGLmw-0006pW-8i for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 09:39:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47512) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGLmq-0004cR-K8; Wed, 18 Aug 2021 09:39:20 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2173 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGLmo-0005yI-Tn; Wed, 18 Aug 2021 09:39:20 -0400 Date: Wed, 18 Aug 2021 16:39:19 +0300 Message-Id: <83r1eq50u0.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 18 Aug 2021 15:32:11 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Wed, 18 Aug 2021 15:32:11 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > 18 aug. 2021 kl. 15.23 skrev Eli Zaretskii : > > > Text property search doesn't fit the bill? > > Oh it does, except that it's linear in the size of the buffer It is? Don't we use the fact that properties are stored in an interval tree? From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 09:54:41 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 13:54:41 +0000 Received: from localhost ([127.0.0.1]:55302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGM1d-0000yH-AB for submit@debbugs.gnu.org; Wed, 18 Aug 2021 09:54:41 -0400 Received: from mail1459c50.megamailservers.eu ([91.136.14.59]:45014 helo=mail267c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGM1X-0000xx-Eo for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 09:54:36 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629294864; bh=CaoDTJGMd/HdySdk4ZT9Xllirhgu6OnpGFKA4UqgAKE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=V5YjoGBKC3oJyp7B2ZEB3Tn/oKw0+tEirYSB5d8aA1/SqS9p8d1TqfjbFmd1NxdDu gz/TId54XoZ20sSL9al/Aj4pdTo7NgrkLyEpWGie69CKDjLnNEzxk2uBYPTXwGeSSY Pdx2QJTgtr2f7kfOaMOxjxNv5dkUh4Itx4eidVnM= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17IDsLRk001814; Wed, 18 Aug 2021 13:54:23 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83r1eq50u0.fsf@gnu.org> Date: Wed, 18 Aug 2021 15:54:21 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <9675B719-53D4-4B3E-8659-04A91633C2E3@acm.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> <83r1eq50u0.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F19.611D1110.001D, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=S9SnP7kP c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=3heBtsAr2Q2XjlHuVHEA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 18 aug. 2021 kl. 15.39 skrev Eli Zaretskii : > It is? Don't we use the fact that properties are stored in an > interval tree? I could very well be wrong about this, but I believe that the interval tree is indexed by location, so that we can quickly find a property given an offset. Searching for a particular property or prope [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 18 aug. 2021 kl. 15.39 skrev Eli Zaretskii : > It is? Don't we use the fact that properties are stored in an > interval tree? I could very well be wrong about this, but I believe that the interval = tree is indexed by location, so that we can quickly find a property = given an offset. Searching for a particular property or property value = requires going through all properties. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 09:59:23 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 13:59:23 +0000 Received: from localhost ([127.0.0.1]:57144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGM6E-0001ZW-QW for submit@debbugs.gnu.org; Wed, 18 Aug 2021 09:59:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGM6D-0001ZE-H4 for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 09:59:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48598) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGM68-00078g-7x; Wed, 18 Aug 2021 09:59:16 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3390 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGM67-0003Uo-Qw; Wed, 18 Aug 2021 09:59:16 -0400 Date: Wed, 18 Aug 2021 16:59:13 +0300 Message-Id: <83mtpe4zwu.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <9675B719-53D4-4B3E-8659-04A91633C2E3@acm.org> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 18 Aug 2021 15:54:21 +0200) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> <83r1eq50u0.fsf@gnu.org> <9675B719-53D4-4B3E-8659-04A91633C2E3@acm.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias EngdegÃ¥rd > Date: Wed, 18 Aug 2021 15:54:21 +0200 > Cc: victor.nawothnig@icloud.com, 49127@debbugs.gnu.org > > 18 aug. 2021 kl. 15.39 skrev Eli Zaretskii : > > > It is? Don't we use the fact that properties are stored in an > > interval tree? > > I could very well be wrong about this, but I believe that the interval tree is indexed by location, so that we can quickly find a property given an offset. Searching for a particular property or property value requires going through all properties. next_interval doesn't look like linear search to me. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 10:34:33 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 14:34:33 +0000 Received: from localhost ([127.0.0.1]:57186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGMeG-0002YA-Vj for submit@debbugs.gnu.org; Wed, 18 Aug 2021 10:34:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGMeE-0002Xw-Vk for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 10:34:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8rCoFRmOFPfLVUjVTiyldEOt5k244E0PTdx1FEpu/II=; b=p3x3Oz80NQix2gSWe1c2bTRPGm 6h+U6409WuY6P/N5EMwvbPIbJfrmdg14QXqpRZu1RfdDC2rn2SDq0IGpo3XsmUecdSu7yvALkUfcl 4TIKXEY36afEdfAYBlxaiCYebHH4BIPlSFcnJGaGVUL3rTcRrn4F3RFytej0m3R5Nw6I=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mGMe4-0000pB-7H; Wed, 18 Aug 2021 16:34:24 +0200 From: Lars Ingebrigtsen To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> Date: Wed, 18 Aug 2021 16:34:19 +0200 In-Reply-To: <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 18 Aug 2021 15:32:11 +0200") Message-ID: <87mtpebz4k.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mattias EngdegÃ¥rd writes: > Could be, but markers is one type of infrastructure, and implementing > something else for the same purpose is a bit of a waste compared to > just making markers faster. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, Eli Zaretskii , victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mattias Engdeg=C3=A5rd writes: > Could be, but markers is one type of infrastructure, and implementing > something else for the same purpose is a bit of a waste compared to > just making markers faster. I'm all for making markers faster -- users do stumble onto this problem, is my impression. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 18 11:24:45 2021 Received: (at 49127) by debbugs.gnu.org; 18 Aug 2021 15:24:45 +0000 Received: from localhost ([127.0.0.1]:57293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGNQr-0008Js-FK for submit@debbugs.gnu.org; Wed, 18 Aug 2021 11:24:45 -0400 Received: from mail1442c50.megamailservers.eu ([91.136.14.42]:36106 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGNQo-0008Ja-SI for 49127@debbugs.gnu.org; Wed, 18 Aug 2021 11:24:44 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629300275; bh=9mUoSfyVjfSC6w5R+CbkXfXQv2Hxvx87/q6ebOvU6Uc=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=mG1V8O+GA/91OV0hoF/RmjnwWc3jFCdv8ZHn3ZM4tOLzJafgiKqmPtEh2FluXYDof FexPOpQ8veCuxbrp+FECV4y0/jXCArfVCLqoYxhvwc1WMGhpKYDtUJp3AoCmXPMEQq RAovMW1KJ2oAdKNpPfyAZZQ3b8IiIw56wsj9jTdY= Feedback-ID: mattiase@acm.or Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17IFOXV4025208; Wed, 18 Aug 2021 15:24:34 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Subject: Re: bug#49127: Performance degradation in encode_coding_object From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83mtpe4zwu.fsf@gnu.org> Date: Wed, 18 Aug 2021 17:24:32 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8FB99A1C-44FB-46B5-8198-4AE85BED26EE@acm.org> References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> <83r1eq50u0.fsf@gnu.org> <9675B719-53D4-4B3E-8659-04A91633C2E3@acm.org> <83mtpe4zwu.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F21.611D2633.007A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Xdb3M7x5 c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=pbyt4hQ18jVRKIm0NmkA:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-Origin-Country: SE X-Spam-Score: 1.4 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 18 aug. 2021 kl. 15.59 skrev Eli Zaretskii : > next_interval doesn't look like linear search to me. That's right, but it doesn't search for a particular property or property value -- it is used by next-property-change which only wants the change of some property. To find the position of a particular [...] Content analysis details: (1.4 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.4 KHOP_HELO_FCRDNS Relay HELO differs from its IP's reverse DNS X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 18 aug. 2021 kl. 15.59 skrev Eli Zaretskii : > next_interval doesn't look like linear search to me. That's right, but it doesn't search for a particular property or = property value -- it is used by next-property-change which only wants = the change of some property. To find the position of a particular = property, we would at least need to call something like = next-single-property-change, which calls next_interval in a loop. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 20 19:24:13 2021 Received: (at 49127) by debbugs.gnu.org; 20 Aug 2021 23:24:13 +0000 Received: from localhost ([127.0.0.1]:35673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHDrw-00048l-Rf for submit@debbugs.gnu.org; Fri, 20 Aug 2021 19:24:13 -0400 Received: from md5i.com ([75.151.244.229]:41092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHDrv-00048Y-4p for 49127@debbugs.gnu.org; Fri, 20 Aug 2021 19:24:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+jZksJyb0hwpiV3uMq3Ppl2te/RxhxaMYlYJvr8E4bs=; b=mTBxilJWXC3Y7TNOcvhLncOoIL iWcGfGT5+DSj7ulTjq8zJzZo+3wLJue0npjlIa2ZpovIrgUqfODXSbrA4pnbQnhYqXEW3JeVpMpNO dQBtSxjw2X0kTMV3xDQCdwsk8; Received: from abode ([192.168.177.1] helo=miko) by md5i.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mHDrp-002EGS-9I; Fri, 20 Aug 2021 19:24:05 -0400 From: Michael Welsh Duggan To: Lars Ingebrigtsen Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> <87mtpebz4k.fsf@gnus.org> Date: Fri, 20 Aug 2021 19:24:05 -0400 In-Reply-To: <87mtpebz4k.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 18 Aug 2021 16:34:19 +0200") Message-ID: <87pmu77l9m.fsf@md5i.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, Mattias =?iso-8859-1?Q?Engdeg=E5rd?= , victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Mattias Engdeg=E5rd writes: > >> Could be, but markers is one type of infrastructure, and implementing >> something else for the same purpose is a bit of a waste compared to >> just making markers faster. > > I'm all for making markers faster -- users do stumble onto this problem, > is my impression. Could this be added to etc/TODO? I have some ideas regarding this, but I don't know if I will be able to get to it (or get release permission from my place of work). --=20 Michael Welsh Duggan (md5i@md5i.com) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 21 02:35:22 2021 Received: (at 49127) by debbugs.gnu.org; 21 Aug 2021 06:35:22 +0000 Received: from localhost ([127.0.0.1]:35776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHKbB-0005v8-ST for submit@debbugs.gnu.org; Sat, 21 Aug 2021 02:35:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHKb9-0005uv-Uz for 49127@debbugs.gnu.org; Sat, 21 Aug 2021 02:35:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37362) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHKb4-0006B4-5w; Sat, 21 Aug 2021 02:35:14 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2251 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHKb1-0006V5-UZ; Sat, 21 Aug 2021 02:35:13 -0400 Date: Sat, 21 Aug 2021 09:34:56 +0300 Message-Id: <83tujjz4of.fsf@gnu.org> From: Eli Zaretskii To: Michael Welsh Duggan In-Reply-To: <87pmu77l9m.fsf@md5i.com> (message from Michael Welsh Duggan on Fri, 20 Aug 2021 19:24:05 -0400) Subject: Re: bug#49127: Performance degradation in encode_coding_object References: <83sfz970av.fsf@gnu.org> <4001E59F-63FF-4EF6-87B5-8A627871C4B8@acm.org> <83lf516x7o.fsf@gnu.org> <0FD46BCF-068E-4437-885A-D79F7ACD581F@acm.org> <837dgk6yic.fsf@gnu.org> <831r6s6u9u.fsf@gnu.org> <8CDC6E7F-73BF-4810-8218-04CD58316195@acm.org> <83wnok56vm.fsf@gnu.org> <83bl5v566t.fsf@gnu.org> <198FD972-CEBA-42FB-8FBB-4CAFA2BA1611@acm.org> <83v94251kw.fsf@gnu.org> <4114BE88-EFCA-4A6A-9423-09DAA37F5E8B@acm.org> <87mtpebz4k.fsf@gnus.org> <87pmu77l9m.fsf@md5i.com> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49127 Cc: 49127@debbugs.gnu.org, mattiase@acm.org, larsi@gnus.org, victor.nawothnig@icloud.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Welsh Duggan > Date: Fri, 20 Aug 2021 19:24:05 -0400 > Cc: 49127@debbugs.gnu.org, > Mattias Engdegård , > victor.nawothnig@icloud.com > > > I'm all for making markers faster -- users do stumble onto this problem, > > is my impression. > > Could this be added to etc/TODO? Thanks, done. From unknown Thu Jun 19 14:25:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 18 Sep 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator