GNU bug report logs - #49123
[PATCH 0/24] Add mirage

Previous Next

Package: guix-patches;

Reported by: slg <0x2d <at> disroot.org>

Date: Sun, 20 Jun 2021 00:25:02 UTC

Severity: normal

Tags: patch

Full log


View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: slg <0x2d <at> disroot.org>, 49123 <at> debbugs.gnu.org
Subject: [bug#49123] [PATCH 02/24] gnu: libolm: Add python bindings output.
Date: Mon, 21 Jun 2021 17:44:20 +0200
[Message part 1 (text/plain, inline)]
Hi,

>           (replace 'check
>             (lambda _
>               (with-directory-excursion "tests"
> -               (invoke "ctest" ".")))))))
> +               (invoke "ctest" "."))))

I would make this

>           (replace 'check
>             (lambda* (#:key tests? #:allow-other-keys)
>               (with-directory-excursion "tests"
>                 (when tests?
> -                 (invoke "ctest" ".")
> +                 (invoke "ctest" ".")))))

That way, "guix build libolm --without-tests=libolm" should work.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 3 years and 324 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.