GNU bug report logs - #49123
[PATCH 0/24] Add mirage

Previous Next

Full log

Message #125 received at 49123 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Vinicius Monego <monego <at> posteo.net>, slg <0x2d <at> disroot.org>, 
 49123 <at> debbugs.gnu.org, 48263 <at> debbugs.gnu.org
Subject: Re: [bug#49123] [PATCH 09/24] gnu: python-hyperframe: Update to 6.0.1.
Date: Sat, 24 Jul 2021 20:42:44 +0200

[Message part 1 (text/plain, inline)]

Vinicius Monego schreef op za 24-07-2021 om 18:30 [+0000]:
> Em sáb, 2021-07-24 às 17:22 +0200, Maxime Devos escreveu:
> 
> > The
> > dependency 'python-hypercorn' now fails to compile (*).  Aside from
> > that, this
> > patch LGTM.  This build failure seems to be caused by the update of
> > python-h11
> > (and not python-hyperframe), however.
> 
> That is true (see [1]). python-hypercorn will build again if updated to
> the latest version.

Ok, we'll have to apply the '48263' patch before the '49123' patch series
then.  FWIW, the '48263' patch looks good to me, but I only looked at
the patch itself and didn't do any other checks.

A comment about the commit message though:
> * gnu/packages/python-web.scm (hypercorn): Update to 0.11.2.
> (python-h11): Update to 0.12.0.
> [arguments]: Add 'test-target' keyword. Do not replace check phase.
> [native-inputs]: Add python-pytest-runner.
> ---
> Both packages have to updated at the same time
> or the hypercorn tests will fail (if either is updated first). I
> rebuilt the h11 dependents succesfully.

Why not include this rationale in the commit message itself?

> [1] http://issues.guix.gnu.org/48263

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.