GNU bug report logs - #49123
[PATCH 0/24] Add mirage

Previous Next

Full log

Message #116 received at 49123 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: slg <0x2d <at> disroot.org>, 49123 <at> debbugs.gnu.org
Subject: Re: [bug#49123] [PATCH 15/24] gnu: Add python-aioresponses.
Date: Wed, 21 Jul 2021 15:44:47 +0200

[Message part 1 (text/plain, inline)]

slg via Guix-patches via schreef op za 19-06-2021 om 22:07 [-0300]:
> * gnu/packages/python-web.scm (python-aioresponses): New variable.
> ---
>  gnu/packages/python-web.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index d4a959aacf..3a01a8c33c 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -6054,3 +6054,31 @@ your code non-blocking and speedy.")
>       "Socks is a library providing core proxy (SOCKS4, SOCKS5, HTTP tunneling)
>   functionality.")
>      (license license:asl2.0)))
> +
> +(define-public python-aioresponses
> +  (package
> +    (name "python-aioresponses")
> +    (version "0.7.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "aioresponses" version))
> +       (sha256
> +        (base32
> +         "16p8mdyfirddrsay62ji7rwcrqmmzxzf2isdbfm9cj5p338rbr42"))))

It build successfully and the source code doesn't appear to contain
malware (*) or anything pre-built.

(*) includes propietary software

> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f)) ;; Tests make http requests
> +    (propagated-inputs
> +     `(("python-aiohttp" ,python-aiohttp)))
> +    (native-inputs
> +     `(("python-pbr" ,python-pbr)))
> +    (home-page "https://github.com/pnuckowski/aioresponses")
> +    (synopsis "Mock out requests made by ClientSession from aiohttp package")

Either drop the 'package", or make this "... from the aiohttp package".

> +    (description "Aioresponses is a helper to mock/fake web requests in python
> +aiohttp package.  For requests module there are a lot of packages that help us

‘in python aiohttp package’ --> maybe ‘with aiohttp’.  You can drop the "us" in
"that help is"

> +with testing (eg. httpretty, responses, requests-mock).  When it comes to

it's e.g., not eg.

> +testing asynchronous HTTP requests it is a bit harder (at least at the beginning).

‘(at least in the beginning)’ doesn't really inform people searching for which
package they can use.  I'd suggest dropping it.

> +The purpose of this package is to provide an easy way to test asynchronous HTTP
> +requests.")

This sentence seems rather informative, clear and to the point. I'd move it to
the beginning of the description.

> +    (license license:x11)))

It's the expat license not the x11 license.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.