GNU bug report logs - #49123
[PATCH 0/24] Add mirage

Previous Next

Full log

Message #104 received at 49123 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: slg <0x2d <at> disroot.org>, 49123 <at> debbugs.gnu.org
Subject: Re: [bug#49123] [PATCH 10/24] gnu: python-h2: Update to 4.0.0.
Date: Sun, 18 Jul 2021 18:15:29 +0200

[Message part 1 (text/plain, inline)]

slg via Guix-patches via schreef op za 19-06-2021 om 22:07 [-0300]:
> * gnu/packages/python-web.scm (python-h2): Update to 4.0.0.
> * gnu/packages/python-web.scm (python-h2): Update home-page
> ---
>  gnu/packages/python-web.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 1a391a5060..4ef8d71f45 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -919,13 +919,13 @@ and that could be anything you want.")
>  (define-public python-h2
>    (package
>      (name "python-h2")
> -    (version "3.2.0")
> +    (version "4.0.0")
>      (source
>       (origin
>         (method url-fetch)
>         (uri (pypi-uri "h2" version))
>         (sha256
> -        (base32 "051gg30aca26rdxsmr9svwqm06pdz9bv21ch4n0lgi7jsvml2pw7"))))
> +        (base32 "0gar809k91d04ky3fqjidfxgbcdnj9hmm09csmz8aynnkl4wfymv"))))
>      (build-system python-build-system)
>      (arguments
>       `(#:phases
> @@ -939,7 +939,7 @@ and that could be anything you want.")
>      (propagated-inputs
>       `(("python-hpack" ,python-hpack)
>         ("python-hyperframe" ,python-hyperframe)))
> -    (home-page "https://github.com/python-hyper/hyper-h2")
> +    (home-page "https://github.com/python-hyper/h2")
>      (synopsis "HTTP/2 State-Machine based protocol implementation")
>      (description
>       "This module contains a pure-Python implementation of a HTTP/2 protocol

I verified the dependencies still build and reproducibility (using --check).
I also opened the tarball and there doesn't appear to be malware inside.
The diff between 3.2.0 and 4.0.0 doesn't seem suspicious, but I am not familiar
with how the HTTP/2 protocol works.

The new home page appears correct: the old home page redirects to the new.

This patch LGTM.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.