Subject: Re: [bug#49123] [PATCH 23/24] gnu: Add python-hsluv.

From: Maxime Devos <[email-masked]>
Date: Thu, 15 Jul 2021 15:31:15 +0200

slg via Guix-patches via schreef op za 19-06-2021 om 22:07 [-0300]:
> +(define-public python-hsluv
> +  (package
> +    (name "python-hsluv")
> +    (version "5.0.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "hsluv" version))
> +       (sha256
> +        (base32
> +         "1yi76w24rr7d8vva01jq6s4zv28w945l1vbf56j2azbakjr9ispz"))))
> +    (build-system python-build-system)
> +    (home-page "https://www.hsluv.org/")
> +    (synopsis "Human-friendly HSL")

HSLuv isn't HSL, so HSLuv isn't human-friendly HSL?

I think (synopsis "Convert between HSLuv and RGB colour coordinates")
would be more descriptive and more correct, in particular for people
who haven't ever heard of "HSL" or humans, and ‘human-friendly’ is
rather subjective.

> +    (description "HSLuv is a human-friendly alternative to HSL.")

‘16.4.4 Synopses and Descriptions’ in the manual has some guidelines
on synopses and descriptions.

> +    (license license:x11)))

LICENSE.txt is not the X11 license, as the following is missing:

  Except as contained in this notice, the name of the X Consortium shall
  not be used in advertising or otherwise to promote the sale, use or
  other dealings in this Software without prior written authorization
  from the X Consortium.

  X Window System is a trademark of X Consortium, Inc. 

Instead, it appears to be the expat license.

Greetings,
Maxime.