From unknown Sun Jun 15 08:49:25 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49112] [PATCH] import: launchpad: Use repository to retrieve releases. Resent-From: Matthew James Kraai Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Jun 2021 10:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49112 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49112@debbugs.gnu.org Cc: Matthew James Kraai X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16240972713168 (code B ref -1); Sat, 19 Jun 2021 10:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jun 2021 10:07:51 +0000 Received: from localhost ([127.0.0.1]:58594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luXtG-0000p2-Td for submit@debbugs.gnu.org; Sat, 19 Jun 2021 06:07:51 -0400 Received: from lists.gnu.org ([209.51.188.17]:34084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luXtF-0000ou-3z for submit@debbugs.gnu.org; Sat, 19 Jun 2021 06:07:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luXtE-0005zE-VC for guix-patches@gnu.org; Sat, 19 Jun 2021 06:07:48 -0400 Received: from mail.ftbfs.org ([52.8.68.13]:19668 helo=aws.ftbfs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luXtD-0000sJ-B2 for guix-patches@gnu.org; Sat, 19 Jun 2021 06:07:48 -0400 Received: from ip68-228-72-85.oc.oc.cox.net ([68.228.72.85] helo=localhost.localdomain) by aws.ftbfs.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1luXtB-00033y-CD; Sat, 19 Jun 2021 10:07:45 +0000 From: Matthew James Kraai Date: Sat, 19 Jun 2021 03:07:39 -0700 Message-Id: <20210619100739.11713-1-kraai@ftbfs.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No (score -1.0): ALL_TRUSTED=-1 Received-SPF: pass client-ip=52.8.68.13; envelope-from=kraai@ftbfs.org; helo=aws.ftbfs.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * guix/import/launchpad.scm (latest-released-version): Use repository instead of package name. (latest-release): Pass repository to latest-released-version. --- guix/import/launchpad.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/guix/import/launchpad.scm b/guix/import/launchpad.scm index a52b39a085..23ac6a3c7b 100644 --- a/guix/import/launchpad.scm +++ b/guix/import/launchpad.scm @@ -100,8 +100,8 @@ URL of the form (match (string-split (uri-path (string->uri url)) #\/) ((_ repo . rest) repo))) -(define (latest-released-version package-name) - "Return a string of the newest released version name given the PACKAGE-NAME, +(define (latest-released-version repository) + "Return a string of the newest released version name given the REPOSITORY, for example, 'linuxdcpp'. Return #f if there is no releases." (define (pre-release? x) ;; Versions containing anything other than digit characters and "." (for @@ -112,7 +112,7 @@ for example, 'linuxdcpp'. Return #f if there is no releases." (match (json-fetch (string-append "https://api.launchpad.net/1.0/" - package-name "/releases")) + repository "/releases")) (#f #f) ;404 or similar (json (assoc-ref @@ -129,7 +129,8 @@ for example, 'linuxdcpp'. Return #f if there is no releases." (let* ((source-uri (origin-github-uri (package-source pkg))) (name (package-name pkg)) - (newest-version (latest-released-version name))) + (repository (launchpad-repository source-uri)) + (newest-version (latest-released-version repository))) (if newest-version (upstream-source (package name) -- 2.32.0 From unknown Sun Jun 15 08:49:25 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49112] [PATCH] import: launchpad: Use repository to retrieve releases. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 19 Jun 2021 20:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49112 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Matthew James Kraai Cc: 49112@debbugs.gnu.org Received: via spool by 49112-submit@debbugs.gnu.org id=B49112.16241351455608 (code B ref 49112); Sat, 19 Jun 2021 20:40:01 +0000 Received: (at 49112) by debbugs.gnu.org; 19 Jun 2021 20:39:05 +0000 Received: from localhost ([127.0.0.1]:60876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luhk8-0001SO-P2 for submit@debbugs.gnu.org; Sat, 19 Jun 2021 16:39:04 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:5853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luhk6-0001Rn-M3 for 49112@debbugs.gnu.org; Sat, 19 Jun 2021 16:39:03 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 6B657240009; Sat, 19 Jun 2021 20:38:55 +0000 (UTC) From: Brice Waegeneire References: <20210619100739.11713-1-kraai@ftbfs.org> Date: Sat, 19 Jun 2021 22:38:53 +0200 In-Reply-To: <20210619100739.11713-1-kraai@ftbfs.org> (Matthew James Kraai's message of "Sat, 19 Jun 2021 03:07:39 -0700") Message-ID: <87k0mpy4gy.fsf@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Matthew, Thank you for the patch! Matthew James Kraai writes: > * guix/import/launchpad.scm (latest-released-version): Use repository instead > of package name. > (latest-release): Pass repository to latest-released-version. I had a patch for this, but yours is cleaner, using 'launchpad-directory'. I have added a copyright line and pushed as 9171079e515289120405c70c143445df2a35db1c. Cheers, - Brice From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 16:39:24 2021 Received: (at control) by debbugs.gnu.org; 19 Jun 2021 20:39:24 +0000 Received: from localhost ([127.0.0.1]:60879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luhkS-0001Sx-0D for submit@debbugs.gnu.org; Sat, 19 Jun 2021 16:39:24 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:46861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luhkQ-0001Si-8X for control@debbugs.gnu.org; Sat, 19 Jun 2021 16:39:22 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B1FA3C0003 for ; Sat, 19 Jun 2021 20:39:15 +0000 (UTC) Date: Sat, 19 Jun 2021 22:39:15 +0200 To: control@debbugs.gnu.org From: Brice Waegeneire Subject: control message for bug #49112 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" Message-Id: X-Spam-Score: -1.7 (-) close 49112 quit