GNU bug report logs - #49104
[PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode'

Previous Next

Full log

Message #23 received at 49104 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 49104 <at> debbugs.gnu.org
Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB
 in `flyspell-prog-mode'
Date: Sun, 27 Jun 2021 15:07:19 -0400

I pushed a slightly cleaner version of my patch,


        Stefan


Jim Porter [2021-06-19 10:31:38] wrote:

> On Sat, Jun 19, 2021 at 10:24 AM Stefan Monnier
> <monnier <at> iro.umontreal.ca> wrote:
>> In that case, `key-binding` might be a good replacement.
>> I see that using `key-binding` could find flyspell's own binding, tho, so we
>> should probably use the (first) patch below instead.
>>
>> Tho I also wonder why we do the lookup when flyspell is enabled instead
>> of doing directly in flyspell-auto-correct-word as in the second
>> patch below.
>
> Indeed, while I was looking into this some more, I saw that
> `flyspell-auto-correct-word' is bound to both `M-TAB' and `C-.' in
> `flyspell-mode-map'. Your second patch should properly delegate to the
> right command for either binding, which would be very nice. The
> original code (and my patch) always act as though you typed `M-TAB'
> when delegating, which isn't quite right.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.