From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 18 19:10:11 2021 Received: (at submit) by debbugs.gnu.org; 18 Jun 2021 23:10:11 +0000 Received: from localhost ([127.0.0.1]:58340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luNco-0007rZ-Uf for submit@debbugs.gnu.org; Fri, 18 Jun 2021 19:10:11 -0400 Received: from lists.gnu.org ([209.51.188.17]:57136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luNcn-0007rP-M6 for submit@debbugs.gnu.org; Fri, 18 Jun 2021 19:10:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luNcn-00017k-CO for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 19:10:09 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]:36783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luNcl-0000V8-LG for bug-gnu-emacs@gnu.org; Fri, 18 Jun 2021 19:10:09 -0400 Received: by mail-pl1-x630.google.com with SMTP id x10so5479410plg.3 for ; Fri, 18 Jun 2021 16:10:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Gq3+NThGUVMz0liIG4Q2qMdL3bjCi9wUZuNr6blefYc=; b=eQLVuO2qfgW9FVQGqivyH/URBgs9fjvMybcUOP8i75Vz1pdKYXJ83I6hxWn9hYGlAI smyC32U0iUYs3z1VHazd2aEV5pyRRhsjU0wcSOsVHuNbUSxmY49det6LzN5o8/KqT3la vH8v+FDw/5QvYkv8TtjeFBFUTZaV7Qs886dukFGnYVn/rs1Gbws1YIBUoFQso2iL/L/S v2843LacGaqxQV2ikZuB1AlSl8D3lwLqZ3zufSSMnVfS4dGzC9BpMG64ej/SreVnEXax 8G6gxh+5nLC6WUsONVrIUuseJz8H0pHr2FLZ+yz8IpaKM12wrVDOncaFuU3GfHtaqzWK xebA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Gq3+NThGUVMz0liIG4Q2qMdL3bjCi9wUZuNr6blefYc=; b=elDOuERr6LOH7/08ZLaw4jlyWMuBz+jIP/jRbUKXodVG0PkQSjFEYDbhpI+l5hHif2 FIBD6WWBwzig0Q/6+lyHELXnHyLwi947YbmRXy/bKO9WJOhBeSH16lNt2IEPr4c0fN2O L/DiPQOaoOqYatd7GEAyeBrIgrwnhJdXvwz8rSVLbTqu6DYTXxSFRAUVXn0Xo5TxE+jN J/Q3F80MW3bgUeTpHfGPbn9AGPOUVHdA0enO2fP1Hlq9z3XgAJe01U3RoghjLFPklZq2 wV/a5qyX2ogBO7bYLgRY0UlKiLeseQISYoih+RlY+huptlEanPiTT3zTtDhqmQULBmj9 SUXQ== X-Gm-Message-State: AOAM530reljHbov8sWbhis7BTSKpz2AwWmObtCyP23CxSRprzKTAiHZ3 Cv+9BbP1ug/mxfJLdM5q1dAUi8/3nPdA+aXE+ohH/Mrs6CM= X-Google-Smtp-Source: ABdhPJw+XihNQFvSdR6NABtFZLRP0Ee3dtS0p8bNQsRjoVzz7QhEke472JUSIaoLyKjE+clQMcxfuinPC0tp3l013O4= X-Received: by 2002:a17:90a:5998:: with SMTP id l24mr13164098pji.169.1624057805979; Fri, 18 Jun 2021 16:10:05 -0700 (PDT) MIME-Version: 1.0 From: Jim Porter Date: Fri, 18 Jun 2021 16:09:55 -0700 Message-ID: Subject: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="0000000000009edb0405c5126c31" Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_20=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000009edb0405c5126c31 Content-Type: text/plain; charset="UTF-8" `flyspell-prog-mode' uses the original M-TAB binding outside of comments, which is nice (see bug#18533). However, it doesn't account for remapped commands. For example, I remap `completion-at-point' to `company-complete' when `company-mode' is active. If I hit M-TAB while `company-mode' and `flyspell-prog-mode' are active, I get `completion-at-point', which isn't what I want. To reproduce this issue, you can do the following: emacs -Q (global-set-key [remap completion-at-point] (lambda () (interactive) (message "remapped"))) M-x flyspell-prog-mode M-TAB ;; Or C-M-i I've attached a patch that fixes the issue (hopefully it works in all cases; it works for me). --0000000000009edb0405c5126c31 Content-Type: application/octet-stream; name="0001-Handle-remapped-commands-for-original-M-TAB-binding-.patch" Content-Disposition: attachment; filename="0001-Handle-remapped-commands-for-original-M-TAB-binding-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kq2xx4da0 RnJvbSA3MzQ4OTBhZGZmODRjZjhmYmVjOWNmZjBhNWJiNmFkNjIwODc3MjE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5jb20+CkRh dGU6IEZyaSwgMTggSnVuIDIwMjEgMTY6MDI6MDcgLTA3MDAKU3ViamVjdDogW1BBVENIXSBIYW5k bGUgcmVtYXBwZWQgY29tbWFuZHMgZm9yIG9yaWdpbmFsIE0tVEFCIGJpbmRpbmcgaW4KICdmbHlz cGVsbC1wcm9nLW1vZGUnCgoqIGxpc3AvdGV4dG1vZGVzL2ZseXNwZWxsLmVsIChmbHlzcGVsbC1w cm9nLW1vZGUpOiBHZXQgdGhlIHJlbWFwcGVkCmNvbW1hbmQgZm9yIHRoZSBvcmlnaW5hbCBNLVRB QiBiaW5kaW5nIGlmIG5lY2Vzc2FyeS4KLS0tCiBsaXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5lbCB8 IDggKysrKystLS0KIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90ZXh0bW9kZXMvZmx5c3BlbGwuZWwgYi9saXNwL3RleHRt b2Rlcy9mbHlzcGVsbC5lbAppbmRleCBiYTQ4ZTVkZTIxLi5lYjRjNWNkZTI4IDEwMDY0NAotLS0g YS9saXNwL3RleHRtb2Rlcy9mbHlzcGVsbC5lbAorKysgYi9saXNwL3RleHRtb2Rlcy9mbHlzcGVs bC5lbApAQCAtNDEwLDkgKzQxMCwxMSBAQCBmbHlzcGVsbC1wcm9nLW1vZGUKICAgKGludGVyYWN0 aXZlKQogICAoc2V0cSBmbHlzcGVsbC1nZW5lcmljLWNoZWNrLXdvcmQtcHJlZGljYXRlCiAgICAg ICAgICMnZmx5c3BlbGwtZ2VuZXJpYy1wcm9nbW9kZS12ZXJpZnkpCi0gIChzZXRxLWxvY2FsIGZs eXNwZWxsLS1wcmV2LW1ldGEtdGFiLWJpbmRpbmcKLSAgICAgICAgICAgICAgKG9yIChsb2NhbC1r ZXktYmluZGluZyAiXE0tXHQiIHQpCi0gICAgICAgICAgICAgICAgICAoZ2xvYmFsLWtleS1iaW5k aW5nICJcTS1cdCIgdCkpKQorICAobGV0ICgocHJldi1tZXRhLXRhYi1iaW5kaW5nIChvciAobG9j YWwta2V5LWJpbmRpbmcgIlxNLVx0IiB0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoZ2xvYmFsLWtleS1iaW5kaW5nICJcTS1cdCIgdCkpKSkKKyAgICAoc2V0cS1sb2NhbCBm bHlzcGVsbC0tcHJldi1tZXRhLXRhYi1iaW5kaW5nCisgICAgICAgICAgICAgICAgKG9yIChjb21t YW5kLXJlbWFwcGluZyBwcmV2LW1ldGEtdGFiLWJpbmRpbmcpCisgICAgICAgICAgICAgICAgICAg IHByZXYtbWV0YS10YWItYmluZGluZykpKQogICAoZmx5c3BlbGwtbW9kZSAxKQogICAocnVuLWhv b2tzICdmbHlzcGVsbC1wcm9nLW1vZGUtaG9vaykpCiAKLS0gCjIuMjUuMQoK --0000000000009edb0405c5126c31-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 02:07:16 2021 Received: (at 49104) by debbugs.gnu.org; 19 Jun 2021 06:07:16 +0000 Received: from localhost ([127.0.0.1]:58454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luU8S-0001D4-7u for submit@debbugs.gnu.org; Sat, 19 Jun 2021 02:07:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luU8Q-0001Cr-JG for 49104@debbugs.gnu.org; Sat, 19 Jun 2021 02:07:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58544) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luU8L-0006Cp-9u; Sat, 19 Jun 2021 02:07:09 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2086 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luU8K-0007No-T3; Sat, 19 Jun 2021 02:07:09 -0400 Date: Sat, 19 Jun 2021 09:07:18 +0300 Message-Id: <83a6nmxu95.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter , Stefan Monnier In-Reply-To: (message from Jim Porter on Fri, 18 Jun 2021 16:09:55 -0700) Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49104 Cc: 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Date: Fri, 18 Jun 2021 16:09:55 -0700 > > `flyspell-prog-mode' uses the original M-TAB binding outside of > comments, which is nice (see bug#18533). However, it doesn't account > for remapped commands. For example, I remap `completion-at-point' to > `company-complete' when `company-mode' is active. If I hit M-TAB while > `company-mode' and `flyspell-prog-mode' are active, I get > `completion-at-point', which isn't what I want. > > To reproduce this issue, you can do the following: > > emacs -Q > (global-set-key [remap completion-at-point] > (lambda () (interactive) (message "remapped"))) > M-x flyspell-prog-mode > M-TAB ;; Or C-M-i Isn't it a bug that global/local-key-binding don't return such remapped bindings, at least optionally? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 07:51:39 2021 Received: (at 49104) by debbugs.gnu.org; 19 Jun 2021 11:51:39 +0000 Received: from localhost ([127.0.0.1]:58664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luZVj-0005zb-Bl for submit@debbugs.gnu.org; Sat, 19 Jun 2021 07:51:39 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:27702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luZVh-0005zE-Ho for 49104@debbugs.gnu.org; Sat, 19 Jun 2021 07:51:37 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 90419440766; Sat, 19 Jun 2021 07:51:31 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 45CAA4402F0; Sat, 19 Jun 2021 07:51:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1624103490; bh=o5jHxcCISbHLcolIgigIH1SEcSoLhlx1GxiKYsWvoQ8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kmrdx9aBN8N7K0lmih010/hQc6voSUIpUztu4iZkmW84vhP7FHi8cNyP0XYtsTrcG vDdHCxTDVEn2GMSHSx5wW6Kp8cahJ7Du7UtIrCTnRUklzBijIRpii2+Xeiu59Pe9pP oOWWp7v9kWldP+Rn4lKttOpMCx5q7tU/V90JX40sFr1JBT5XFMFL06kvn8wl0SvEIg VVfZ8Gg1Alcz3XZMydcUdGdxYDG1h1rBjl5Imh9Yeb//qfXN/ORyBO1ojj525+XBgl xzfwHHfDlPoz/7MRzTj/GrFZ7OtlN3i1xoVeXr70OdGhmnx7gQ0gQ1EI9IP0yxsn8V Dxmo69p7frulg== Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 094FA120156; Sat, 19 Jun 2021 07:51:29 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' Message-ID: References: <83a6nmxu95.fsf@gnu.org> Date: Sat, 19 Jun 2021 07:51:29 -0400 In-Reply-To: <83a6nmxu95.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Jun 2021 09:07:18 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49104 Cc: Jim Porter , 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> To reproduce this issue, you can do the following: >> >> emacs -Q >> (global-set-key [remap completion-at-point] >> (lambda () (interactive) (message "remapped"))) >> M-x flyspell-prog-mode >> M-TAB ;; Or C-M-i > > Isn't it a bug that global/local-key-binding don't return such > remapped bindings, at least optionally? I don't, but I wonder why flyspell-prog-mode uses those functions instead of using just `key-binding` (which seems simpler and does pay attention to remapping). IOW, what would be the problem with the patch below? Stefan diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index fb9361e45d..30b44daf54 100644 --- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el @@ -415,8 +415,7 @@ flyspell-prog-mode (setq flyspell-generic-check-word-predicate #'flyspell-generic-progmode-verify) (setq-local flyspell--prev-meta-tab-binding - (or (local-key-binding "\M-\t" t) - (global-key-binding "\M-\t" t))) + (key-binding "\M-\t")) (flyspell-mode 1) (run-hooks 'flyspell-prog-mode-hook)) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 08:20:13 2021 Received: (at 49104) by debbugs.gnu.org; 19 Jun 2021 12:20:13 +0000 Received: from localhost ([127.0.0.1]:58705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luZxN-0000i3-Jo for submit@debbugs.gnu.org; Sat, 19 Jun 2021 08:20:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luZxM-0000hm-3G for 49104@debbugs.gnu.org; Sat, 19 Jun 2021 08:20:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35130) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luZxF-0001ka-Sw; Sat, 19 Jun 2021 08:20:05 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1372 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luZxD-0001FU-QH; Sat, 19 Jun 2021 08:20:05 -0400 Date: Sat, 19 Jun 2021 15:20:12 +0300 Message-Id: <83pmwivyf7.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 19 Jun 2021 07:51:29 -0400) Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' References: <83a6nmxu95.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49104 Cc: jporterbugs@gmail.com, 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Jim Porter , 49104@debbugs.gnu.org > Date: Sat, 19 Jun 2021 07:51:29 -0400 > > >> To reproduce this issue, you can do the following: > >> > >> emacs -Q > >> (global-set-key [remap completion-at-point] > >> (lambda () (interactive) (message "remapped"))) > >> M-x flyspell-prog-mode > >> M-TAB ;; Or C-M-i > > > > Isn't it a bug that global/local-key-binding don't return such > > remapped bindings, at least optionally? > > I don't Why not? > but I wonder why flyspell-prog-mode uses those functions > instead of using just `key-binding` Because the latter is not described in the ELisp manual where global/local-key-binding are, and isn't referenced from there? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 13:24:48 2021 Received: (at 49104) by debbugs.gnu.org; 19 Jun 2021 17:24:48 +0000 Received: from localhost ([127.0.0.1]:60678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luei8-0002w6-1x for submit@debbugs.gnu.org; Sat, 19 Jun 2021 13:24:48 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:12445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luei3-0002vr-OT for 49104@debbugs.gnu.org; Sat, 19 Jun 2021 13:24:47 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BE9A08065C; Sat, 19 Jun 2021 13:24:37 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7A66B804DE; Sat, 19 Jun 2021 13:24:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1624123476; bh=aXRrrI99I0Ez0nlmrWrHjAOM9nUydYgKxa8DqzBoe0o=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=C/RgIoSNwWeYGf3EiSDZ3+huFcdclrxCd7N8ve+e1AWG4+HVZ13phrOI7cIAwPBtu Xk4ZOy17XjLmKgHIrOcDmuveU6BO5ocCRgDIWDoDWXoUP5kxK/ivrvapBPbUeH2Dj+ RfBO0ta0pb2YzjDLXYZsUG5hNBPJg38m9Ggns4SyYkfu0m84p7oKExH6OfK8eCJkaO xfwCxWqHUtPVv5e/GdgIHTz+z0BmaecH4MlU0LazLq5tQgXdgNald0njAwb/oFeKZc DbPRzQoZmtBv7zq1jOBRE+8yxMMX7YsfQkcMeH0oR9Md58W6V1MCJyqphS6YI/k9cW HVSt9HLmK0Ddw== Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 28540120273; Sat, 19 Jun 2021 13:24:36 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' Message-ID: References: <83a6nmxu95.fsf@gnu.org> <83pmwivyf7.fsf@gnu.org> Date: Sat, 19 Jun 2021 13:24:35 -0400 In-Reply-To: <83pmwivyf7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Jun 2021 15:20:12 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49104 Cc: jporterbugs@gmail.com, 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > Isn't it a bug that global/local-key-binding don't return such >> > remapped bindings, at least optionally? >> I don't > Why not? Good question. I think I meant to write "I don't know" instead of just "I don't". >> but I wonder why flyspell-prog-mode uses those functions >> instead of using just `key-binding` > Because the latter is not described in the ELisp manual where > global/local-key-binding are, and isn't referenced from there? In that case, `key-binding` might be a good replacement. I see that using `key-binding` could find flyspell's own binding, tho, so we should probably use the (first) patch below instead. Tho I also wonder why we do the lookup when flyspell is enabled instead of doing directly in flyspell-auto-correct-word as in the second patch below. Stefan diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index ba48e5de21..11ff0f426f 100644 --- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el @@ -411,8 +411,8 @@ flyspell-prog-mode (setq flyspell-generic-check-word-predicate #'flyspell-generic-progmode-verify) (setq-local flyspell--prev-meta-tab-binding - (or (local-key-binding "\M-\t" t) - (global-key-binding "\M-\t" t))) + (let ((flyspell-mode nil)) + (key-binding "\M-\t"))) (flyspell-mode 1) (run-hooks 'flyspell-prog-mode-hook)) diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el index ba48e5de21..649057270e 100644 --- a/lisp/textmodes/flyspell.el +++ b/lisp/textmodes/flyspell.el @@ -401,18 +401,12 @@ flyspell-generic-progmode-verify (let ((f (get-text-property (1- (point)) 'face))) (memq f flyspell-prog-text-faces)))) -(defvar flyspell--prev-meta-tab-binding nil - "Records the binding of M-TAB in effect before flyspell was activated.") - ;;;###autoload (defun flyspell-prog-mode () "Turn on `flyspell-mode' for comments and strings." (interactive) (setq flyspell-generic-check-word-predicate #'flyspell-generic-progmode-verify) - (setq-local flyspell--prev-meta-tab-binding - (or (local-key-binding "\M-\t" t) - (global-key-binding "\M-\t" t))) (flyspell-mode 1) (run-hooks 'flyspell-prog-mode-hook)) @@ -1990,13 +1984,10 @@ flyspell-auto-correct-word (interactive) ;; If we are not in the construct where flyspell should be active, ;; invoke the original binding of M-TAB, if that was recorded. - (if (and (local-variable-p 'flyspell--prev-meta-tab-binding) - (commandp flyspell--prev-meta-tab-binding t) - (functionp flyspell-generic-check-word-predicate) - (not (funcall flyspell-generic-check-word-predicate)) - (equal (where-is-internal 'flyspell-auto-correct-word nil t) - [?\M-\t])) - (call-interactively flyspell--prev-meta-tab-binding) + (if (and (functionp flyspell-generic-check-word-predicate) + (not (funcall flyspell-generic-check-word-predicate))) + (let ((flyspell-mode nil)) + (execut-command (key-binding (this-command-keys)))) (let ((pos (point)) (old-max (point-max))) ;; Flush a possibly stale cache from previous invocations of From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 13:31:54 2021 Received: (at 49104) by debbugs.gnu.org; 19 Jun 2021 17:31:54 +0000 Received: from localhost ([127.0.0.1]:60688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luep0-00037x-3d for submit@debbugs.gnu.org; Sat, 19 Jun 2021 13:31:54 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:43622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lueoy-00037k-Tp for 49104@debbugs.gnu.org; Sat, 19 Jun 2021 13:31:53 -0400 Received: by mail-pf1-f179.google.com with SMTP id a127so10273971pfa.10 for <49104@debbugs.gnu.org>; Sat, 19 Jun 2021 10:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PaHVZGKWkgPyFWZVLZ30IL4qTsvzfUog7s6zozmAECk=; b=h2/3ttGGmf2Lduwo1hp7oCohGUoznaPv/EjZi/oIXY3Xlgd15WTv59lIKvwsnqwXkx ryKTISpIGSSWt8LR8MZDUbr6xINduLi6+VxXprvQH68n/FIRH8/RyKyvK0FU91poNHOV yYm3kcK4Y+z/DYnBaFW3XNUpyd0SjCr3C7Ylkqci67dU2OSxyvJqDLlcJegIicRUaFqX 42AI5subn7kK0uX33Coa7Ue4yEH2lzmmFAADfBfMEpx7rr7YZsWf06nHvqEazvi+ufCU iSEVPec8Aevf1DFU/pHwEMqIfuflThZXOuMC8TgdJ2Nz29U1BT6GUlzsA2BMd+PCzx2D 02iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PaHVZGKWkgPyFWZVLZ30IL4qTsvzfUog7s6zozmAECk=; b=ivgEEhwCStp/Ryhg3ziJvdUgSfizhXZF3VnJl3iEmo/OxU58NWkPkYGCyeoDdlNohC Ezyhv6VVdS0uSJIC4pIeTcOWg0gEb55MiyK0C79BJCdH5IaDNROD8HeQbPYlM7Sf+tuN SU2MvIVDJGApeqgF4pIWpOqraxxk8rm3a/Sc0DqKgypOx/bDJ/t5I+bHaT2uGyqcxLIZ gXHgdSCKtXiNgHFmGJO8tM6D1dj0KocxLIGM3N+EcuLCtU56eNzmW97xVwajrVJOVgqL HYvhK16aUq7mWCc3xcG/1FhK37c1nGhUsld2IwwFGUAKbWvOUpOsk4fUNqpGwLod2Dtr C9FQ== X-Gm-Message-State: AOAM5303gWZqfj9iJvGs5A7E0+fXQBKN9alAoA7P9LjoJBYt5Qz4dGDA pnlIiwe8dH01RQuLT5/R9IMd2nD45iiZo/PGHHA= X-Google-Smtp-Source: ABdhPJx4OD/+1LXbkpSuL4Bvb7fIVgvJcjbTiFGR8YFgJ9QhKltTXdRVawLf2METvN+cmWUn7cTm/dRF5lqoE7rIn0A= X-Received: by 2002:a62:b415:0:b029:2f4:829f:e483 with SMTP id h21-20020a62b4150000b02902f4829fe483mr11418521pfn.4.1624123907041; Sat, 19 Jun 2021 10:31:47 -0700 (PDT) MIME-Version: 1.0 References: <83a6nmxu95.fsf@gnu.org> <83pmwivyf7.fsf@gnu.org> In-Reply-To: From: Jim Porter Date: Sat, 19 Jun 2021 10:31:38 -0700 Message-ID: Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49104 Cc: Eli Zaretskii , 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Jun 19, 2021 at 10:24 AM Stefan Monnier wrote: > In that case, `key-binding` might be a good replacement. > I see that using `key-binding` could find flyspell's own binding, tho, so we > should probably use the (first) patch below instead. > > Tho I also wonder why we do the lookup when flyspell is enabled instead > of doing directly in flyspell-auto-correct-word as in the second > patch below. Indeed, while I was looking into this some more, I saw that `flyspell-auto-correct-word' is bound to both `M-TAB' and `C-.' in `flyspell-mode-map'. Your second patch should properly delegate to the right command for either binding, which would be very nice. The original code (and my patch) always act as though you typed `M-TAB' when delegating, which isn't quite right. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 27 15:07:31 2021 Received: (at 49104) by debbugs.gnu.org; 27 Jun 2021 19:07:31 +0000 Received: from localhost ([127.0.0.1]:50403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxa7v-0000Mt-Cx for submit@debbugs.gnu.org; Sun, 27 Jun 2021 15:07:31 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:62219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxa7r-0000Me-LY for 49104@debbugs.gnu.org; Sun, 27 Jun 2021 15:07:30 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3D6F8440B73; Sun, 27 Jun 2021 15:07:22 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2681D440030; Sun, 27 Jun 2021 15:07:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1624820841; bh=wq00/55Y7uURs7nZnAfX21KmPu24cr2QMK8HW2vge5Q=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=XZJNZxsOcaEnoM//Mvr2yTg1CFQ/2MKundIV1NgagUcA/Rt8cH22BEoV7j/6084Vj L9sCTp61f/RWwc4UCbJaRDc0hRtVqD1kF4vqJNS7pXxM1jIzjfhIedQ7e3Tscnv7qe /mEBsbOW4E2wXR1+XAzL1VB2ulZ5bqr0btMQ3Qw/iOZ2+0FDCVRh54mBh3XJXS/Un1 RSuPzDVERgfp5OKjeE/ABN2FWRQ53UUj4pWhoNHXu/2MxIGpH1j2vPAOkDfN8CeD7w j+7kDoWUPdIJ3gqHHpVaUuiHSldGZNf1+8/WGkQ64zI62f+Fpvr8Hxpz0+Q7+QTBAq OAwQP3jVgL0sQ== Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A0FF5120B51; Sun, 27 Jun 2021 15:07:20 -0400 (EDT) From: Stefan Monnier To: Jim Porter Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' Message-ID: References: <83a6nmxu95.fsf@gnu.org> <83pmwivyf7.fsf@gnu.org> Date: Sun, 27 Jun 2021 15:07:19 -0400 In-Reply-To: (Jim Porter's message of "Sat, 19 Jun 2021 10:31:38 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49104 Cc: Eli Zaretskii , 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) I pushed a slightly cleaner version of my patch, Stefan Jim Porter [2021-06-19 10:31:38] wrote: > On Sat, Jun 19, 2021 at 10:24 AM Stefan Monnier > wrote: >> In that case, `key-binding` might be a good replacement. >> I see that using `key-binding` could find flyspell's own binding, tho, so we >> should probably use the (first) patch below instead. >> >> Tho I also wonder why we do the lookup when flyspell is enabled instead >> of doing directly in flyspell-auto-correct-word as in the second >> patch below. > > Indeed, while I was looking into this some more, I saw that > `flyspell-auto-correct-word' is bound to both `M-TAB' and `C-.' in > `flyspell-mode-map'. Your second patch should properly delegate to the > right command for either binding, which would be very nice. The > original code (and my patch) always act as though you typed `M-TAB' > when delegating, which isn't quite right. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 28 00:44:46 2021 Received: (at 49104) by debbugs.gnu.org; 28 Jun 2021 04:44:46 +0000 Received: from localhost ([127.0.0.1]:50621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxj8Y-0006Gl-GP for submit@debbugs.gnu.org; Mon, 28 Jun 2021 00:44:46 -0400 Received: from mail-pf1-f180.google.com ([209.85.210.180]:41595) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxj8V-0006GW-1M for 49104@debbugs.gnu.org; Mon, 28 Jun 2021 00:44:44 -0400 Received: by mail-pf1-f180.google.com with SMTP id c5so13096088pfv.8 for <49104@debbugs.gnu.org>; Sun, 27 Jun 2021 21:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MryuaQ+pYcgU2JCbD271Q4vT2XWdScqKgugWaSwjadg=; b=Lk1xILN+4+EbiQd1RaJuca//6z65PZCUUNUn2+GsGcXaYkU57NnjRK0MwGTUMaqHkc q7A2wb45vRirkcnVf8bRLfVF2pnXJetfsAJeduUp8qAt1KfichXimfY+Gn0Sn2SSKJLa vjxar+ettf57of0IixPXLThmf773ZayaA+2JIy9pP3zGzbb1H7yejSRy/b+pPJG85j7T AaKQvCz0dTDccNVR+qR+d/KaCWZTQVAR+WDk7wq843148Tsz1CmSlapRYUxHldCejb1n QQQl4HqjnC6m1a8jhGTgcBnWLJSTILU05KMhSImEOTMlt20nEseBEBYcPe+ZUdVv4k+B jsxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MryuaQ+pYcgU2JCbD271Q4vT2XWdScqKgugWaSwjadg=; b=CPhVbfBdl7w07qyGBZuco+5RV4Z2k0Sm3KW/LbNOZuCGmuAfjqweMeQraVr929/J48 pz47wk2/2nfDQqlPgoqEuRTmCDEdmhXAMHWtC/9v5qUNuWAXHcvCnJbFwDAkMW0oPJqe aOdbPQOfVzq0/qOPCox6yF5SEKAaZ93Gz3J+Y8MVdjSHLcAbTCrsIaHL/gSdGQul1M8m fOxl96ldM3h5NFloGDRo5F5wmSKQuNmTlAXa58Vkj2Y9wWHNtm4y2fO4hu2N3HZxUQ1e xdPBt771skAHS5ANw6uNRsT0rZOPTqLXMxIxZxUKhBk+kTsx3vIgbTao+TTQ15k0LPKh t+2Q== X-Gm-Message-State: AOAM531kb+8xHklvBbA9XdZ5+4/Z2JdB/SpmDXrA7FmTpJ08BEkVaUrN N2fwIcY455KtcJ1Qh1puMkYWkUJ6uif8z/14c7M= X-Google-Smtp-Source: ABdhPJxGT+Z2P97txYlS0S1yAj/3kU9SXmX5ZJVGOU4IfcF0wWcyQAwowef6WaR/iAafQ2UhLNfYZ5QQBICYQT0gKRk= X-Received: by 2002:a63:5d5c:: with SMTP id o28mr21553766pgm.22.1624855477266; Sun, 27 Jun 2021 21:44:37 -0700 (PDT) MIME-Version: 1.0 References: <83a6nmxu95.fsf@gnu.org> <83pmwivyf7.fsf@gnu.org> In-Reply-To: From: Jim Porter Date: Sun, 27 Jun 2021 21:44:27 -0700 Message-ID: Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 49104 Cc: Eli Zaretskii , 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jun 27, 2021 at 12:07 PM Stefan Monnier wrote: > > I pushed a slightly cleaner version of my patch, I tried it out locally and everything works perfectly with my config. Thanks for the fix. - Jim From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 20 08:13:30 2021 Received: (at 49104) by debbugs.gnu.org; 20 Jul 2021 12:13:30 +0000 Received: from localhost ([127.0.0.1]:33107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5ocs-00050F-ES for submit@debbugs.gnu.org; Tue, 20 Jul 2021 08:13:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5ocq-0004zz-1E for 49104@debbugs.gnu.org; Tue, 20 Jul 2021 08:13:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yF+AseTzWjuP2zA5x+wRZczA2GYDNXgsKMfa8i96ov8=; b=X7E5Dcx62krvJ/WWYurdImypi7 ZfrzuqeX+FKMQSgt8BNldgCMKSokq68aONvP/wRZXh3c+jAenwOOE6VI2yGWfo6HNGH7uzddWSVjA /4Ff7VRkDRasyJnPJd7qkmmwOcpgQOTXH/7y6I4K8tJC1N5Voap0lwdmifQJh2uUM7uc=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5ocg-0002xH-Lc; Tue, 20 Jul 2021 14:13:21 +0200 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#49104: [PATCH] 28.0.50; Handle remapped commands for M-TAB in `flyspell-prog-mode' References: <83a6nmxu95.fsf@gnu.org> <83pmwivyf7.fsf@gnu.org> X-Now-Playing: Squarepusher's _Be Up A Hello_: "Terminal Slam" Date: Tue, 20 Jul 2021 14:13:18 +0200 In-Reply-To: (Jim Porter's message of "Sun, 27 Jun 2021 21:44:27 -0700") Message-ID: <87o8axfajl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > On Sun, Jun 27, 2021 at 12:07 PM Stefan Monnier > wrote: >> >> I pushed a slightly cleaner version of my patch, > > I tried it out locally and everything works perfectly w [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 49104 Cc: Eli Zaretskii , Stefan Monnier , 49104@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > On Sun, Jun 27, 2021 at 12:07 PM Stefan Monnier > wrote: >> >> I pushed a slightly cleaner version of my patch, > > I tried it out locally and everything works perfectly with my config. > Thanks for the fix. This bug report was left open, so I'm closing it now. (I only skimmed it lightly, but if I understood correctly, Stefan's patched fixed the reported problem.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 20 08:13:33 2021 Received: (at control) by debbugs.gnu.org; 20 Jul 2021 12:13:33 +0000 Received: from localhost ([127.0.0.1]:33110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5ocv-00050T-Lk for submit@debbugs.gnu.org; Tue, 20 Jul 2021 08:13:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5ocu-000506-Br for control@debbugs.gnu.org; Tue, 20 Jul 2021 08:13:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bubP0XrEpeYlA0Pfns+KwSFnRp7htkcgjNW74YOGDTI=; b=QgJZyIW+etR4h627N96qoZZhV/ zFOXbKSkpZhngw9IzYQ/K9AlkLT/zS/hfNFtMoy2GNfSKaQP7XJ7LeoahV+p00CGhQXm+lVqFtAn2 IzZT33QGGsjtYaUKuMH1lrA4cqmpXeU4hc6uVll3qEJ6aaEO5dv33fq91fgHPaRV4Uhs=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5ocl-0002xO-UC for control@debbugs.gnu.org; Tue, 20 Jul 2021 14:13:26 +0200 Date: Tue, 20 Jul 2021 14:13:23 +0200 Message-Id: <87mtqhfajg.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #49104 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 49104 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 49104 28.1 quit From unknown Sat Aug 16 21:20:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Aug 2021 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator