GNU bug report logs - #49101
[PATCH 0/4] Add ocaml-mparser & friends

Previous Next

Full log

View this message in rfc822 format

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 49101 <at> debbugs.gnu.org
Subject: [bug#49101] [PATCH v2 2/5] gnu: ocaml4.07-expect: Switch to default OCaml compiler.
Date: Sat, 19 Jun 2021 15:57:19 +0200

[Message part 1 (text/plain, inline)]

On Sat, Jun 19 2021, Julien Lepiller wrote:

> This patch looks good, but I think it needs to be merged with the
> previous one, because after the first patch and before this one,
> ocaml4.07-pcre doesn't exist. Remember that we want to make sure we can
> build guix at every point in time.

Do you mean that I, if possible, should do bump the version of
‘ocaml4.07-pcre’ in one commit, and then switch ‘ocaml4.07-pcre’ and
‘ocaml4.07-expect’ to using the default compiler in the next commit,
like this?

  gnu: ocaml4.07-pcre: Update to 7.46.
  gnu: ocaml4.07-{pcre,expect}: Switch to default OCaml compiler.
  ...
  
> The rest of the series is good. I'm looking forward to v3 :)

Cool, thanks for the review!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.