GNU bug report logs - #49100
make check fails: %derivation-cache

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chris Marusich <cmmarusich <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49100: closed (make check fails: %derivation-cache )
Date: Wed, 23 Jun 2021 01:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 22 Jun 2021 18:34:19 -0700
with message-id <877dilbbz8.fsf <at> gmail.com>
and subject line Re: bug#49100: make check fails: %derivation-cache
has caused the debbugs.gnu.org bug report #49100,
regarding make check fails: %derivation-cache 
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49100: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49100
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chris Marusich <cmmarusich <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: make check fails: %derivation-cache 
Date: Fri, 18 Jun 2021 10:55:30 -0700

[Message part 3 (text/plain, inline)]

Hi,

On core-updates (a6c292a6f123acc86429722619ccb51ca54f844f), "make check"
errors out in tests/builders.scm:

--8<---------------cut here---------------start------------->8---
Backtrace:
           1 (primitive-load-path "tests/builders.scm")
In guix/tests.scm:
    146:8  0 (call-with-external-store #<procedure 7f92ff4f7d60 at i…>)

guix/tests.scm:146:8: In procedure call-with-external-store:
error: %derivation-cache: unbound variable
--8<---------------cut here---------------end--------------->8---

The problem appears to have been caused by
7d873f194ca69d6096d28d7a224ab78e83e34fe1 ("build-system: Rewrite using
gexps.").

The attached patch fixes the issue for me.  However, since I'm not sure
how %derivation-cache is or was supposed to be used, I would appreciate
a second opinion.

Note that %derivation-cache has been used to refer to two different
things in the past (see: 3182539875a67f5989c73c3c654fe3138bbc275c).
Note also that even after applying this fix, some tests relying on
call-with-external-store still fail when run (see: bug 47018).

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Chris Marusich <cmmarusich <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 49100-close <at> debbugs.gnu.org
Subject: Re: bug#49100: make check fails: %derivation-cache
Date: Tue, 22 Jun 2021 18:34:19 -0700

[Message part 6 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

>> The attached patch fixes the issue for me.  However, since I'm not sure
>> how %derivation-cache is or was supposed to be used, I would appreciate
>> a second opinion.
>
> You forgot to attach the patch, but I think it’s enough to remove the
> ‘hash-clear!’ call from ‘call-with-external-store’.

Sorry - but yes, that's all it did.  I removed the hash-clear! call.
I've gone ahead and committed this as
7f0af119a1e3ea9d0ae53811b619437b3e942702 on core-updates.

-- 
Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.