Subject: [bug#49090] [PATCH] gnu: Add blastem.

From: Xinglu Chen <[email-masked]>
Date: Sat, 19 Jun 2021 10:30:03 +0200

On Fri, Jun 18 2021, Leo Prikler wrote:

> Am Freitag, den 18.06.2021, 20:39 +0200 schrieb Xinglu Chen:
>> On Fri, Jun 18 2021, Leo Prikler wrote:
>> 
>> > +(define-public blastem
>> > +  (package
>> > +    (name "blastem")
>> > +    (version "0.6.2")
>> > +    (source (origin
>> > +              (method hg-fetch)
>> > +              (uri (hg-reference
>> > +                    (url "https://www.retrodev.com/repos/blastem")
>> > +                    (changeset (string-append "v" version))))
>> > +              (file-name (string-append name "-" version "-
>> > checkout"))
>> 
>> Nit: (guix hg-download) provides a ‘hg-file-name’ procedure, so you
>> can just use (hg-file-name name version).
> Good to know, I simply used the hg-reference... expansion from
> etc/snippets, so that should probably be updated.

Ah, I guess it time to update etc/snippets then :)

>> > +              (sha256
>> > +               (base32
>> > +                "08ycfisivh9rb9vmijlrpdryaw8spd81ck48960p15cnf8h25
>> > 35q"))
>> > +              (modules '((guix build utils)))
>> > +              (snippet
>> > +               '(begin
>> > +                  ;; TODO: Separately package and unbundle nuklear
>> > +                  (delete-file-recursively "zlib")))))
>> 
>> Why is the zlib directory removed?  Or perhaps, why do they bundle
>> their own Zlib?
> The have their own PNG implementation, which appears different from
> libpng.  So zlib exists as a dependency of that, but it's also
> #included elsewhere.

OK, thanks for the explanation.