From unknown Sat Jun 14 03:52:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#49086 <49086@debbugs.gnu.org> To: bug#49086 <49086@debbugs.gnu.org> Subject: Status: [PATCH] gnu: linkchecker: Update to 10.0.1. Reply-To: bug#49086 <49086@debbugs.gnu.org> Date: Sat, 14 Jun 2025 10:52:16 +0000 retitle 49086 [PATCH] gnu: linkchecker: Update to 10.0.1. reassign 49086 guix-patches submitter 49086 Arun Isaac severity 49086 normal tag 49086 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 18 08:00:59 2021 Received: (at submit) by debbugs.gnu.org; 18 Jun 2021 12:00:59 +0000 Received: from localhost ([127.0.0.1]:55960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luDB1-0002C2-Cv for submit@debbugs.gnu.org; Fri, 18 Jun 2021 08:00:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:52580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luDAz-0002Bu-Fa for submit@debbugs.gnu.org; Fri, 18 Jun 2021 08:00:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luDAv-0006yP-U8 for guix-patches@gnu.org; Fri, 18 Jun 2021 08:00:43 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:33346) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luDAr-00050l-E8 for guix-patches@gnu.org; Fri, 18 Jun 2021 08:00:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rwVRgWo1Y/eSgfP+psTzukdcybNkCHy9BPu0K9A6HcQ=; b=J1dc5CQDy62j5QrQvACYPl9dSk JKcJXgOcXHnmen6K++Y7zm6PEh5lcj+2nNTnBZyoTeXLgxcCRuhN4708bxI1FMTEea+p9gIi8/oiA j/7PQcBHSkalAq5TD0MIDS7yM2dHJbBE9gkQ4xcLag1Nyen9HTei1jNYE3RKsF8gxvvzDCCXgVSXD XUmQGQBQzZrKGbLePR9gp+vZdXxtSwYTidBFoJfgmrqiHU0+bSBCajzsJGL/Uv1WDh52/7i7GPyc3 ++Ro+sB8ifmVi4P7R0gFcU6KB4+pJTblwE9LG9bBJtM2j4BLxfDmi/7tXbEyMiFW3T6AmWp1nRZLP D59HcKmg==; Received: from [192.168.2.1] (helo=localhost.localdomain) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1luDAj-0005Bz-CK; Fri, 18 Jun 2021 17:30:29 +0530 From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] gnu: linkchecker: Update to 10.0.1. Date: Fri, 18 Jun 2021 17:30:22 +0530 Message-Id: <20210618120023.14607-1-arunisaac@systemreboot.net> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.59.75.54; envelope-from=arunisaac@systemreboot.net; helo=mugam.systemreboot.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/web.scm (linkchecker): Update to 10.0.1. [source]: Remove patches. [inputs]: Add python-beautifulsoup4. Replace python2-dnspython-1.16, python2-pyxdg and python2-requests with python-dnspython, python-pyxdg and python-requests respectively. [native-inputs]: Replace python2-pytest, python2-miniboa and python2-parameterized with python-pytest, python-miniboa and python-parameterized respectively. [arguments]: Use python 3. Replace check phase instead of deleting the standard phase and adding a custom one. Use add-installed-pythonpath instead of setting PYTHONPATH directly. [home-page]: Update URI. * gnu/packages/patches/linkchecker-tests-require-network.patch: Delete file. * gnu/local.mk (dist_patch_DATA): Unregister it. --- gnu/local.mk | 1 - .../linkchecker-tests-require-network.patch | 182 ------------------ gnu/packages/web.scm | 47 ++--- 3 files changed, 16 insertions(+), 214 deletions(-) delete mode 100644 gnu/packages/patches/linkchecker-tests-require-network.patch diff --git a/gnu/local.mk b/gnu/local.mk index 918c8515ac..b2b36d860a 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1383,7 +1383,6 @@ dist_patch_DATA = \ %D%/packages/patches/lierolibre-remove-arch-warning.patch \ %D%/packages/patches/lierolibre-try-building-other-arch.patch \ %D%/packages/patches/linbox-fix-pkgconfig.patch \ - %D%/packages/patches/linkchecker-tests-require-network.patch \ %D%/packages/patches/linphone-desktop-without-sdk.patch \ %D%/packages/patches/linux-libre-support-for-Pinebook-Pro.patch \ %D%/packages/patches/linux-libre-arm64-generic-pinebook-lcd.patch \ diff --git a/gnu/packages/patches/linkchecker-tests-require-network.patch b/gnu/packages/patches/linkchecker-tests-require-network.patch deleted file mode 100644 index f3e488cec2..0000000000 --- a/gnu/packages/patches/linkchecker-tests-require-network.patch +++ /dev/null @@ -1,182 +0,0 @@ -From f24c88a0732024028fffe0372039a847e91722ea Mon Sep 17 00:00:00 2001 -From: Christopher Baines -Date: Tue, 1 Jan 2019 22:36:29 +0000 -Subject: [PATCH] Mark more tests that require the network - -I believe all these tests require the network, at least they seem to -fail if it's I run them without connecting my computer to the web. - -I'm looking at this as part of packaging linkchecker for GNU Guix, -where the package is build and the tests are run in a isolated -environment, intentionally without network access, to avoid issues -with non-reproducible package builds. ---- - tests/checker/test_http.py | 2 ++ - tests/checker/test_http_misc.py | 2 ++ - tests/checker/test_http_redirect.py | 2 ++ - tests/checker/test_httpbin.py | 5 +++++ - tests/checker/test_misc.py | 4 ++++ - tests/checker/test_whitespace.py | 3 +++ - 6 files changed, 18 insertions(+) - -diff --git a/tests/checker/test_http.py b/tests/checker/test_http.py -index e4c1e097..8a8af567 100644 ---- a/tests/checker/test_http.py -+++ b/tests/checker/test_http.py -@@ -20,6 +20,7 @@ - - import pytest - -+from tests import need_network - from .httpserver import HttpServerTest, CookieRedirectHttpRequestHandler - - class TestHttp (HttpServerTest): -@@ -29,6 +30,7 @@ def __init__(self, methodName='runTest'): - super(TestHttp, self).__init__(methodName=methodName) - self.handler = CookieRedirectHttpRequestHandler - -+ @need_network - def test_html (self): - confargs = dict(recursionlevel=1) - self.file_test("http.html", confargs=confargs) -diff --git a/tests/checker/test_http_misc.py b/tests/checker/test_http_misc.py -index 9922d85f..c6b6afdb 100644 ---- a/tests/checker/test_http_misc.py -+++ b/tests/checker/test_http_misc.py -@@ -20,11 +20,13 @@ - import os - import sys - from .httpserver import HttpServerTest -+from tests import need_network - from linkcheck.network import iputil - - class TestHttpMisc (HttpServerTest): - """Test http:// misc link checking.""" - -+ @need_network - def test_html (self): - self.swf_test() - self.obfuscate_test() -diff --git a/tests/checker/test_http_redirect.py b/tests/checker/test_http_redirect.py -index f212d98e..2253a70d 100644 ---- a/tests/checker/test_http_redirect.py -+++ b/tests/checker/test_http_redirect.py -@@ -17,6 +17,7 @@ - """ - Test http checking. - """ -+from tests import need_network - from .httpserver import HttpServerTest, CookieRedirectHttpRequestHandler - - class TestHttpRedirect (HttpServerTest): -@@ -26,6 +27,7 @@ def __init__(self, methodName='runTest'): - super(TestHttpRedirect, self).__init__(methodName=methodName) - self.handler = CookieRedirectHttpRequestHandler - -+ @need_network - def test_redirect (self): - self.redirect1() - self.redirect2() -diff --git a/tests/checker/test_httpbin.py b/tests/checker/test_httpbin.py -index 0319c2f6..4c8fa846 100644 ---- a/tests/checker/test_httpbin.py -+++ b/tests/checker/test_httpbin.py -@@ -18,6 +18,7 @@ - Test http stuff with httpbin.org. - """ - import re -+from tests import need_network - from . import LinkCheckTest - - -@@ -30,6 +31,7 @@ def get_httpbin_url(path): - class TestHttpbin(LinkCheckTest): - """Test http:// link redirection checking.""" - -+ @need_network - def test_http_link(self): - linkurl = u"http://www.example.com" - nlinkurl = self.norm(linkurl) -@@ -48,6 +50,7 @@ def test_http_link(self): - ] - self.direct(url, resultlines, recursionlevel=1) - -+ @need_network - def test_basic_auth(self): - user = u"testuser" - password = u"testpassword" -@@ -67,6 +70,7 @@ def test_basic_auth(self): - ] - self.direct(url, resultlines, confargs=confargs) - -+ @need_network - def test_http_refresh_header(self): - linkurl = u"http://www.example.com" - nlinkurl = self.norm(linkurl) -@@ -85,6 +89,7 @@ def test_http_refresh_header(self): - ] - self.direct(url, resultlines, recursionlevel=1) - -+ @need_network - def test_http_content_location_header(self): - linkurl = u"http://www.example.com" - nlinkurl = self.norm(linkurl) -diff --git a/tests/checker/test_misc.py b/tests/checker/test_misc.py -index 2e4cfd07..f9591f9d 100644 ---- a/tests/checker/test_misc.py -+++ b/tests/checker/test_misc.py -@@ -17,6 +17,7 @@ - """ - Test miscellaneous html tag parsing and URL types - """ -+from tests import need_network - from . import LinkCheckTest - - -@@ -25,15 +26,18 @@ class TestMisc (LinkCheckTest): - Test misc link types. - """ - -+ @need_network - def test_misc (self): - self.file_test("misc.html") - - def test_html5 (self): - self.file_test("html5.html") - -+ @need_network - def test_archive (self): - self.file_test("archive.html") - -+ @need_network - def test_itms_services(self): - url = u"itms-services:?action=download-manifest&url=http://www.example.com/" - resultlines = [ -diff --git a/tests/checker/test_whitespace.py b/tests/checker/test_whitespace.py -index 609c108a..fc2727d6 100644 ---- a/tests/checker/test_whitespace.py -+++ b/tests/checker/test_whitespace.py -@@ -17,6 +17,7 @@ - """ - Test whitespace handling. - """ -+from tests import need_network - from . import LinkCheckTest - - -@@ -25,6 +26,7 @@ class TestWhitespace (LinkCheckTest): - Test whitespace in URLs. - """ - -+ @need_network - def test_leading_whitespace (self): - # Leading whitespace - url = u" http://www.example.org/" -@@ -50,6 +52,7 @@ def test_leading_whitespace (self): - ] - self.direct(url, resultlines) - -+ @need_network - def test_trailing_whitespace (self): - # Trailing whitespace - url = u"http://www.example.org/ " diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index d1f1d0f755..0fc2d7e441 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -15,7 +15,7 @@ ;;; Copyright © 2016 Ben Woodcroft ;;; Copyright © 2016 Clément Lassieur ;;; Copyright © 2016, 2017 Nikita -;;; Copyright © 2016, 2017, 2018, 2019 Arun Isaac +;;; Copyright © 2016, 2017, 2018, 2019, 2021 Arun Isaac ;;; Copyright © 2016–2021 Tobias Geerinckx-Rice ;;; Copyright © 2016 Bake Timmons ;;; Copyright © 2017 Thomas Danckaert @@ -6578,51 +6578,36 @@ Instagram and YouTube.") (define-public linkchecker (package (name "linkchecker") - (version "9.4.0") + (version "10.0.1") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/linkchecker/linkchecker") (commit (string-append "v" version)))) - (patches - (search-patches "linkchecker-tests-require-network.patch")) (file-name (git-file-name name version)) (sha256 (base32 - "03ihjmc4bqxxqv71bb43r2f23sx0xnbq1k2fsg9fw05qa5s9x187")))) + "1j97dc9a4yhpscwadhv5dxp7036pnrxiaky18l8ddr3pvxdjvkxs")))) (build-system python-build-system) (inputs - `(("python2-dnspython" ,python2-dnspython-1.16) - ("python2-pyxdg" ,python2-pyxdg) - ("python2-requests" ,python2-requests))) + `(("python-beautifulsoup4" ,python-beautifulsoup4) + ("python-dnspython" ,python-dnspython) + ("python-pyxdg" ,python-pyxdg) + ("python-requests" ,python-requests))) (native-inputs `(("gettext" ,gettext-minimal) - ("python2-pytest" ,python2-pytest) - ("python2-miniboa" ,python2-miniboa) - ("python2-parameterized" ,python2-parameterized))) + ("python-pytest" ,python-pytest) + ("python-miniboa" ,python-miniboa) + ("python-parameterized" ,python-parameterized))) (arguments - `(#:python ,python-2 - #:phases + `(#:phases (modify-phases %standard-phases - ;; Move the 'check phase to after 'install, so that the installed - ;; library can be used - (delete 'check) - (add-after 'install 'check - (lambda* (#:key outputs #:allow-other-keys) - (let ((out (assoc-ref outputs "out"))) - ;; Set PYTHONPATH so that the installed linkchecker is used - (setenv "PYTHONPATH" - (string-append out "/lib/python2.7/site-packages" - ":" - (getenv "PYTHONPATH"))) - ;; Remove this directory to avoid it being used when running - ;; the tests - (delete-file-recursively "linkcheck") - - (invoke "py.test" "tests")) - #t))))) - (home-page "https://linkcheck.github.io/linkchecker") + (replace 'check + (lambda* (#:key inputs outputs #:allow-other-keys) + (add-installed-pythonpath inputs outputs) + (invoke "py.test" "tests")))))) + (home-page "https://linkchecker.github.io/linkchecker/") (synopsis "Check websites for broken links") (description "LinkChecker is a website validator. It checks for broken links in websites. It is recursive and multithreaded providing output in -- 2.32.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 18 10:18:26 2021 Received: (at 49086) by debbugs.gnu.org; 18 Jun 2021 14:18:26 +0000 Received: from localhost ([127.0.0.1]:57526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luFKD-0008Pt-Mt for submit@debbugs.gnu.org; Fri, 18 Jun 2021 10:18:26 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:45470 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luFKB-0008Pe-U8 for 49086@debbugs.gnu.org; Fri, 18 Jun 2021 10:18:25 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1624025896; bh=qkT+HNSuUYsjcovk2tB3N7Jt2gUr2P4rqy743V21EJY=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=VSH+qg1dB3GCdovIAI94HR15c4O//33cPtT2/NCov2IZ21mCxESdpNGPyagsuIX15 l3Wkpd0Iv8bkyCxY3LIy3zAXdakUdKVvfdREd5Or6RsbdxOrxdfYUZ4r5UXr0QJtiT 5q6GAjvF2OwrRd7Tdv8ujyxg3B5dNFnn5AlFnaAw= To: Arun Isaac , 49086@debbugs.gnu.org Subject: Re: [bug#49086] [PATCH] gnu: linkchecker: Update to 10.0.1. In-Reply-To: <20210618120023.14607-1-arunisaac@systemreboot.net> References: <20210618120023.14607-1-arunisaac@systemreboot.net> Date: Fri, 18 Jun 2021 16:18:15 +0200 Message-ID: <87eecz6yu0.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, Jun 18 2021, Arun Isaac wrote: > * gnu/packages/web.scm (linkchecker): Update to 10.0.1. > [source]: Remove patches. > [inputs]: Add python-beautifulsoup4. Replace python2-dnspython-1.16, > python2-pyxdg and python2-requests with p [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS X-Debbugs-Envelope-To: 49086 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Fri, Jun 18 2021, Arun Isaac wrote: > * gnu/packages/web.scm (linkchecker): Update to 10.0.1. > [source]: Remove patches. > [inputs]: Add python-beautifulsoup4. Replace python2-dnspython-1.16, > python2-pyxdg and python2-requests with p [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Jun 18 2021, Arun Isaac wrote: > * gnu/packages/web.scm (linkchecker): Update to 10.0.1. > [source]: Remove patches. > [inputs]: Add python-beautifulsoup4. Replace python2-dnspython-1.16, > python2-pyxdg and python2-requests with python-dnspython, python-pyxdg and > python-requests respectively. > [native-inputs]: Replace python2-pytest, python2-miniboa and > python2-parameterized with python-pytest, python-miniboa and > python-parameterized respectively. > [arguments]: Use python 3. Replace check phase instead of deleting the > standard phase and adding a custom one. Use add-installed-pythonpath inst= ead > of setting PYTHONPATH directly. > [home-page]: Update URI. > * gnu/packages/patches/linkchecker-tests-require-network.patch: Delete fi= le. > * gnu/local.mk (dist_patch_DATA): Unregister it. > --- > gnu/local.mk | 1 - > .../linkchecker-tests-require-network.patch | 182 ------------------ > gnu/packages/web.scm | 47 ++--- > 3 files changed, 16 insertions(+), 214 deletions(-) > delete mode 100644 gnu/packages/patches/linkchecker-tests-require-networ= k.patch > > (define-public linkchecker > (package > (name "linkchecker") > - (version "9.4.0") > + (version "10.0.1") > (source > (origin > (method git-fetch) > (uri (git-reference > (url "https://github.com/linkchecker/linkchecker") > (commit (string-append "v" version)))) > - (patches > - (search-patches "linkchecker-tests-require-network.patch")) > (file-name (git-file-name name version)) > (sha256 > (base32 > - "03ihjmc4bqxxqv71bb43r2f23sx0xnbq1k2fsg9fw05qa5s9x187")))) > + "1j97dc9a4yhpscwadhv5dxp7036pnrxiaky18l8ddr3pvxdjvkxs")))) > (build-system python-build-system) > (inputs > - `(("python2-dnspython" ,python2-dnspython-1.16) > - ("python2-pyxdg" ,python2-pyxdg) > - ("python2-requests" ,python2-requests))) > + `(("python-beautifulsoup4" ,python-beautifulsoup4) > + ("python-dnspython" ,python-dnspython) > + ("python-pyxdg" ,python-pyxdg) > + ("python-requests" ,python-requests))) > (native-inputs > `(("gettext" ,gettext-minimal) > - ("python2-pytest" ,python2-pytest) > - ("python2-miniboa" ,python2-miniboa) > - ("python2-parameterized" ,python2-parameterized))) > + ("python-pytest" ,python-pytest) > + ("python-miniboa" ,python-miniboa) > + ("python-parameterized" ,python-parameterized))) > (arguments > - `(#:python ,python-2 > - #:phases > + `(#:phases > (modify-phases %standard-phases > - ;; Move the 'check phase to after 'install, so that the install= ed > - ;; library can be used > - (delete 'check) > - (add-after 'install 'check > - (lambda* (#:key outputs #:allow-other-keys) > - (let ((out (assoc-ref outputs "out"))) > - ;; Set PYTHONPATH so that the installed linkchecker is us= ed > - (setenv "PYTHONPATH" > - (string-append out "/lib/python2.7/site-packages" > - ":" > - (getenv "PYTHONPATH"))) > - ;; Remove this directory to avoid it being used when runn= ing > - ;; the tests > - (delete-file-recursively "linkcheck") > - > - (invoke "py.test" "tests")) > - #t))))) > - (home-page "https://linkcheck.github.io/linkchecker") > + (replace 'check > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (add-installed-pythonpath inputs outputs) > + (invoke "py.test" "tests")))))) This 'check phase doesn=E2=80=99t respect the =E2=80=98--with-tests=E2=80= =99 transformation. Something like the following would be better: (replace 'check (lambda* (#:key inputs outputs tests? #:allow-other-keys) (when tests? (with-directory-excursion "tests" (add-installed-pythonpath inputs outputs) (invoke "py.test" "tests"))))) Otherwise, LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmDMqycVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x514sP/iuNgHRD2QOjKwWvhmuj3rb0mWvS cU7x8TOpCUx7mFh3O4+SqOdGIk8Tdxo2Y0e/4nj7KoHutHK8oOGXCuheY8JvFQ3Z IWob7ww1v9Kz1/ocQBmACmnpp8GDGdZJ78npjucXCzuEZ7Ttw3yopSswFz9JtFTX r/J1Ijx5QXsxaTwY3Y6fyueF8YzaXfu0MjN6hl7Yt8PiZ+a0yThoLWMOU8kgkx/n L/4HF0dcFVWeWqNEwm1QFPjnwQTq1CiZRbU+px+1Ln/qluyvOyM0TtbRPkPIV5+U AJmYby8roI2Gn3c5tz8p7Ej2hPhf5zCSvESKDJ6DpqzLRbBMqR62S6Mh2uip32o5 rK+kh/IjANgC8VKX+9G/x/a98L0y50geEpGcSU9vJwGqOmiIN8pWCJ+Zw8ywpES2 6RsEUvowq1tycMXgSh9ip/Ll61JQ6FD2hTMdSECs1dYPY8u+v8aoKtwKMK/T/9jH X6zpsT5msPW5C/y/1G/rzTxnSNxhPDabeheV1FGqs9qMD0PQTrchvHCUxDXUxvyP i1W/Z2/g4hBX9sly8vsEm44ii8/IjiBdTQ3gzxZqySJU7rXqqD1iCUOzRLbUxJwK ELh+xVkswCxbZ7wFyrh3fywUEqwg6wgR83zYN+7lXZ4AT/f+nWKVrDGEYLIPayq+ Ew460YRnxvlQtNwn =NRLy -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 04:25:26 2021 Received: (at 49086) by debbugs.gnu.org; 19 Jun 2021 08:25:26 +0000 Received: from localhost ([127.0.0.1]:58494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luWIA-0004Qw-0i for submit@debbugs.gnu.org; Sat, 19 Jun 2021 04:25:26 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:42048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luWI6-0004Qk-Qg for 49086@debbugs.gnu.org; Sat, 19 Jun 2021 04:25:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Zzt7iN30+uDhmz3Xr0T3ZXCprp5+Uo6lX97wjC01xb4=; b=QEaa0KHrBY4XkJNPv0dxm1+EHv kS8yhfHPGvGz2oNDU4rQ4k5oUGaS686LZcIvzxW0+QXVa7TpweQhaFm69vElWiybEVqLBg6KMe5v1 VhqF+uzHtIwru/cKFaFEOIn4tt8k/21N+CVu6vlD3GLNRagYd9yuGGbSMIN5AxFm2fviWDxtswv4Z Fwx/sfv8sUlyMCOYhlHbj8UWwkttM3jcnqcw76PYKW+sR9zO3KGCqJ7+fHOvxctg3Nid+drOFsrD8 w3na/wvSiTlkZLV9sjIt1gmrej2ZVdWJMl886dzmgHB4hSRyVtjocYqDeyCSEMCsY1j64rwkxqfgf 1g1ON/iw==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1luWI3-0008lt-NR; Sat, 19 Jun 2021 13:55:19 +0530 From: Arun Isaac To: Xinglu Chen , 49086@debbugs.gnu.org Subject: Re: [bug#49086] [PATCH] gnu: linkchecker: Update to 10.0.1. In-Reply-To: <87eecz6yu0.fsf@yoctocell.xyz> References: <20210618120023.14607-1-arunisaac@systemreboot.net> <87eecz6yu0.fsf@yoctocell.xyz> Date: Sat, 19 Jun 2021 13:55:13 +0530 Message-ID: <87v96antw6.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49086 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > This 'check phase doesn=E2=80=99t respect the =E2=80=98--with-tests=E2=80= =99 transformation. > Something like the following would be better: > > (replace 'check > (lambda* (#:key inputs outputs tests? #:allow-other-keys) > (when tests? > (with-directory-excursion "tests" > (add-installed-pythonpath inputs outputs) > (invoke "py.test" "tests"))))) Makes sense. I'll add the `when tests?', but what's the with-directory-excursion for? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmDNqekbHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzaNEIALsC/7aM0ydJBcU3M5Pn LSA633tnw4DPxJZ0zSu6mtpQnzW+NpbBBT9VSfKxE54aUqqrs+5EZ+gR1l61177i LfhWMsGgt0I1ASxyIlhhWRIC+4Q92TWd/N52214TgIutJJ9il/bu55CB4JHaz00R 4RhGeSF2eKB7Cf8mmchMQPjVCLnPuYGaK6YS4ugU/rozZy36DtsKqDU7E2PrMXZZ tcTrxiatLZg6lsLvWReWGLCRgEVFgOoXqJJkwSkpGcBBh4CZJL7xiWFfM/YNvGrc /QVtUdvQpcVf6vsOeQxXiOW1erBrVoHqLUmM8Q5p01YdYCDbwxBOxRuNr0+844IJ dMg= =4TxI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 05:06:42 2021 Received: (at 49086) by debbugs.gnu.org; 19 Jun 2021 09:06:42 +0000 Received: from localhost ([127.0.0.1]:58558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luWw6-0007pP-7b for submit@debbugs.gnu.org; Sat, 19 Jun 2021 05:06:42 -0400 Received: from h87-96-130-155.cust.a3fiber.se ([87.96.130.155]:40638 helo=mail.yoctocell.xyz) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1luWw4-0007pC-KK for 49086@debbugs.gnu.org; Sat, 19 Jun 2021 05:06:41 -0400 From: Xinglu Chen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yoctocell.xyz; s=mail; t=1624093595; bh=ZL0IdrPNV41lXMK0U3Oy+WTNPIgCjnmQj3ZaLOxHwRU=; h=From:To:Subject:In-Reply-To:References:Date; b=KCc12busMXJ/+PQAsxNRWJchFKpsUjuO/DTKXI2UzEClbJNgOT95Z5+AsEhZ9dfDy HUic68YyjkW/xR1WG01j1zziTWuM5RVFDaY0p+TFntQXRjxCf3+nGeyCphGu0xODu0 Ery7uBJfSsKffG4r7G3cpaOdwDpM7GKzsC9Xt7nE= To: Arun Isaac , 49086@debbugs.gnu.org Subject: Re: [bug#49086] [PATCH] gnu: linkchecker: Update to 10.0.1. In-Reply-To: <87v96antw6.fsf@systemreboot.net> References: <20210618120023.14607-1-arunisaac@systemreboot.net> <87eecz6yu0.fsf@yoctocell.xyz> <87v96antw6.fsf@systemreboot.net> Date: Sat, 19 Jun 2021 11:06:34 +0200 Message-ID: <878s362pgl.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, Jun 19 2021, Arun Isaac wrote: >> This 'check phase doesn’t respect the ‘--with-tests’ transformation. >> Something like the following would be better: >> >> (replace 'check >> (lambda* (#:key inputs outputs tests? #:allow-ot [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS X-Debbugs-Envelope-To: 49086 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sat, Jun 19 2021, Arun Isaac wrote: >> This 'check phase doesn’t respect the ‘--with-tests’ transformation. >> Something like the following would be better: >> >> (replace 'check >> (lambda* (#:key inputs outputs tests? #:allow-ot [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: yoctocell.xyz (xyz)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.5 FROM_SUSPICIOUS_NTLD From abused NTLD 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Jun 19 2021, Arun Isaac wrote: >> This 'check phase doesn=E2=80=99t respect the =E2=80=98--with-tests=E2= =80=99 transformation. >> Something like the following would be better: >> >> (replace 'check >> (lambda* (#:key inputs outputs tests? #:allow-other-keys) >> (when tests? >> (with-directory-excursion "tests" >> (add-installed-pythonpath inputs outputs) >> (invoke "py.test" "tests"))))) > > Makes sense. I'll add the `when tests?', but what's the > with-directory-excursion for? Oops, ignore the =E2=80=98with-directory-excursion=E2=80=99, sorry about th= at. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJJBAEBCAAzFiEEAVhh4yyK5+SEykIzrPUJmaL7XHkFAmDNs5oVHHB1YmxpY0B5 b2N0b2NlbGwueHl6AAoJEKz1CZmi+1x5tPYQAKuZjW9RN81IIBaZaw5dvtuTPAYV ue2z5uLQU2Mdq1ljwD6lMzj9R0SXzi6t2R1q25ERiWFSwKcepxdLp9ynsGP8Iefy 7MOfhqlZI7Q2dmRWBBSoAAj+A/GaUzLcZs733ztQyNFswMq4l6H1+n85bQzpShLD saQxq4YO9LMLQ2Q62PGKrr96jkOGSOjThUkfApQtnP+OOanAX1aG9T60ofjZbjTZ A4gkPe+Sup314qHRMG+FSd1uLxOZ0sclJq+sDK/Dlm7jGUzWJYTZRJcwz2hhuWTB UIAXWh0pFU5D1S5+VdNHwQjyvxPaA7PdCbdowrofNCoRXMdVJwbSBMkjlwRhIxZU FoWLi3rKI2J7lvT4JdphQGnX8I+A2DnHaHB2NmCtr5B0TAr8xHDlTtSgf9mmtdd5 8V0vn4J/3EdJxf1tptW9wNpazfXTynfnQQQwmZm3JMTpVqUnpbGZFq49JySOs/zt 1KKDOjV4jd1SzxbETT0/9Qg271mlOj/8UNZSwkqeqQoOYnfQl45oZnZTCTLF9F+W BJ0ZcObI7E6XVjTlcNvaXZ3q9Wmn2UQDWxAIU1La1CtNifR7Rpc/3yKTmSfwYSKi qElFRe5cV8ywMcf8T7x7h2FWhZK+5zwH5B7dQ5JgwOySWtKjWZdJNfxHH9tqiude v5XvoreiNvqQ4P4N =2vqG -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 15:08:25 2021 Received: (at 49086-done) by debbugs.gnu.org; 19 Jun 2021 19:08:25 +0000 Received: from localhost ([127.0.0.1]:60810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lugKP-0005Rb-7E for submit@debbugs.gnu.org; Sat, 19 Jun 2021 15:08:25 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:42050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lugKL-0005RR-Px for 49086-done@debbugs.gnu.org; Sat, 19 Jun 2021 15:08:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:To:From:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6lmWqr7PFJUgznKXCCIwDPuIzYfFh72c2+rvLZs6leI=; b=XKVqW998VjsyYb+ytv3xOWTPEM yXX+QwWQx/IJQr6Z9cdVdD/NhByou6Yjb/uaQlR6LDohcNT2vMhdOqNYwdLa+ppG/eJ4ML5v6zHro X0KEXGgqRzHBNegGPIMI7UktmKIe3cJ+ONrpn/+50chez8KUda2wkqs7NlinxaLAo84eoKKfXcGZF KFR0VlpwIY0ox4mLYA5kjBEd3/4cYCmRG8IYesVYiUUD9u5pChsjfA/bGCpLGhVpYt3aJzAi6elyk aL8lJ4hyKG3u3kRv9cH9d4JW37JKaRpamyxkcamcdDgeQzxBR9naaKZMLUKehOZ18mhdNxN8g9Gk9 Gu1hF8JQ==; Received: from [192.168.2.1] (helo=steel) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lugKJ-000BYJ-3P; Sun, 20 Jun 2021 00:38:19 +0530 From: Arun Isaac To: Xinglu Chen , 49086-done@debbugs.gnu.org Subject: Re: [bug#49086] [PATCH] gnu: linkchecker: Update to 10.0.1. In-Reply-To: <87v96antw6.fsf@systemreboot.net> References: <20210618120023.14607-1-arunisaac@systemreboot.net> <87eecz6yu0.fsf@yoctocell.xyz> <87v96antw6.fsf@systemreboot.net> Date: Sun, 20 Jun 2021 00:37:58 +0530 Message-ID: <87sg1doepd.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 49086-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Pushed to master. Thanks for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFPBAEBCAA5FiEEf3MDQ/Lwnzx3v3nTLiXui2GAK7MFAmDOQI4bHGFydW5pc2Fh Y0BzeXN0ZW1yZWJvb3QubmV0AAoJEC4l7othgCuzxF4H/2j+Vju+zhy7M3yLOkKL ViZvbsF86MltM8UsJXK1AzORlsvLdQ7Voj3rckgVIjlMGJUBxh/vz7rQibFusZ58 LcpvslQo8CZlQwI6wPVhEXUepq8bXWxTwISrD0zxjOT9wlVZOqV1oi++rr+eRsSX u66Ryo43qJ3+XmuHInBa0jfYbkyaNaRHqNpQV91p9h/yZEUlAr7ZKYY1DnLOOFId 4K63tJIXZ4/fPfBPMgw1pgvieIuk18zBTK5sWOvUe30xQZ3MLZOVrPe63HuL3cGn I1w92qM9CSnGekzs3GM58vNTafXqivs3nfp/J2MJ8vqAhuFRqymVne0wWQgCJVLX ac8= =w/Fw -----END PGP SIGNATURE----- --=-=-=-- From unknown Sat Jun 14 03:52:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 18 Jul 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator