From unknown Sun Jun 22 08:00:15 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49056] [PATCH] services: pcscd: Fix daemon signal handling. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Jun 2021 06:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49056 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49056@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162382551012772 (code B ref -1); Wed, 16 Jun 2021 06:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Jun 2021 06:38:30 +0000 Received: from localhost ([127.0.0.1]:51303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltPC2-0003Jw-9Q for submit@debbugs.gnu.org; Wed, 16 Jun 2021 02:38:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:52580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltPC1-0003Jp-Et for submit@debbugs.gnu.org; Wed, 16 Jun 2021 02:38:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltPC1-00045T-4g for guix-patches@gnu.org; Wed, 16 Jun 2021 02:38:29 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:40201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltPBy-00014K-Vb for guix-patches@gnu.org; Wed, 16 Jun 2021 02:38:28 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CE5C020003 for ; Wed, 16 Jun 2021 06:38:21 +0000 (UTC) From: Brice Waegeneire Date: Wed, 16 Jun 2021 08:38:18 +0200 Message-Id: <20210616063818.12656-1-brice@waegenei.re> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.183.200; envelope-from=brice@waegenei.re; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) "pcscd" wouldn't handle SIGTERM as it inherited ignoring this signal (and others) from its parent shepherd. The constructor make-forkexec, restore signal handling. Fixes . * gnu/services/security-token.scm (pcscd)[start]: Use make-fork-exec-constructor to start "pcscd". --- Depend on patch . gnu/services/security-token.scm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gnu/services/security-token.scm b/gnu/services/security-token.scm index 0cbb591e10..822984b70b 100644 --- a/gnu/services/security-token.scm +++ b/gnu/services/security-token.scm @@ -57,12 +57,15 @@ (provision '(pcscd)) (requirement '(syslogd)) (modules '((gnu build shepherd))) - (start #~(lambda _ + (start #~(lambda args (let ((socket "/run/pcscd/pcscd.comm")) (when (file-exists? socket) (delete-file socket))) - (invoke #$(file-append pcsc-lite "/sbin/pcscd")) - (call-with-input-file "/run/pcscd/pcscd.pid" read))) + (apply (make-forkexec-constructor + (list #$(file-append pcsc-lite "/sbin/pcscd") + "--foreground") + #:log-file "/var/log/pcscd.log") + args))) (stop #~(make-kill-destructor))))))) (define pcscd-activation -- 2.31.1 From unknown Sun Jun 22 08:00:15 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#49056] [PATCH] services: pcscd: Fix daemon signal handling. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Jun 2021 21:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49056 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brice Waegeneire Cc: 49056@debbugs.gnu.org Received: via spool by 49056-submit@debbugs.gnu.org id=B49056.162474120616295 (code B ref 49056); Sat, 26 Jun 2021 21:01:01 +0000 Received: (at 49056) by debbugs.gnu.org; 26 Jun 2021 21:00:06 +0000 Received: from localhost ([127.0.0.1]:48715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxFPK-0004Ek-AN for submit@debbugs.gnu.org; Sat, 26 Jun 2021 17:00:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lxFPH-0004Df-1t for 49056@debbugs.gnu.org; Sat, 26 Jun 2021 17:00:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40870) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxFPB-0000Mj-5C; Sat, 26 Jun 2021 16:59:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42488 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxFP9-0003c8-Md; Sat, 26 Jun 2021 16:59:56 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210616063818.12656-1-brice@waegenei.re> Date: Sat, 26 Jun 2021 22:59:53 +0200 In-Reply-To: <20210616063818.12656-1-brice@waegenei.re> (Brice Waegeneire's message of "Wed, 16 Jun 2021 08:38:18 +0200") Message-ID: <87tulk1gvq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Brice Waegeneire skribis: > "pcscd" wouldn't handle SIGTERM as it inherited ignoring this > signal (and others) from its parent shepherd. The constructor > make-forkexec, restore signal handling. Fixes > . > > * gnu/services/security-token.scm (pcscd)[start]: Use > make-fork-exec-constructor to start "pcscd". Well done! > + (start #~(lambda args > (let ((socket "/run/pcscd/pcscd.comm")) > (when (file-exists? socket) > (delete-file socket))) > - (invoke #$(file-append pcsc-lite "/sbin/pcscd")) > - (call-with-input-file "/run/pcscd/pcscd.pid" read))) > + (apply (make-forkexec-constructor > + (list #$(file-append pcsc-lite "/sbin/pcscd") > + "--foreground") > + #:log-file "/var/log/pcscd.log") > + args))) We can probably call =E2=80=98fork+exec-command=E2=80=99 directly instead o= f going through =E2=80=98make-forkexec-constructor=E2=80=99, no? Otherwise LGTM, thanks! Ludo=E2=80=99. From unknown Sun Jun 22 08:00:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Brice Waegeneire Subject: bug#49056: closed (Re: bug#49056: [PATCH] services: pcscd: Fix daemon signal handling.) Message-ID: References: <87y2anclcr.fsf_-_@waegenei.re> <20210616063818.12656-1-brice@waegenei.re> X-Gnu-PR-Message: they-closed 49056 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 49056@debbugs.gnu.org Date: Sat, 03 Jul 2021 18:19:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1625336341-1401-1" This is a multi-part message in MIME format... ------------=_1625336341-1401-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #49056: [PATCH] services: pcscd: Fix daemon signal handling. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 49056@debbugs.gnu.org. --=20 49056: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D49056 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1625336341-1401-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 49056-done) by debbugs.gnu.org; 3 Jul 2021 18:18:24 +0000 Received: from localhost ([127.0.0.1]:39827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzkDg-0000La-Jh for submit@debbugs.gnu.org; Sat, 03 Jul 2021 14:18:24 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzkDd-0000LK-UJ for 49056-done@debbugs.gnu.org; Sat, 03 Jul 2021 14:18:22 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id F0B4FFF805; Sat, 3 Jul 2021 18:18:15 +0000 (UTC) From: Brice Waegeneire To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#49056: [PATCH] services: pcscd: Fix daemon signal handling. References: <20210616063818.12656-1-brice@waegenei.re> <87tulk1gvq.fsf@gnu.org> Date: Sat, 03 Jul 2021 20:18:12 +0200 In-Reply-To: <87tulk1gvq.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 26 Jun 2021 22:59:53 +0200") Message-ID: <87y2anclcr.fsf_-_@waegenei.re> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 49056-done Cc: 49056-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ludovic Court=C3=A8s writes: > We can probably call =E2=80=98fork+exec-command=E2=80=99 directly instead= of going > through =E2=80=98make-forkexec-constructor=E2=80=99, no? > > Otherwise LGTM, thanks! Changed to use =E2=80=98fork+exec-command=E2=80=99 and pushed as e789ce538ed848bacb8f4eb5742f78b965ccf57c. ------------=_1625336341-1401-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 16 Jun 2021 06:38:30 +0000 Received: from localhost ([127.0.0.1]:51303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltPC2-0003Jw-9Q for submit@debbugs.gnu.org; Wed, 16 Jun 2021 02:38:30 -0400 Received: from lists.gnu.org ([209.51.188.17]:52580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltPC1-0003Jp-Et for submit@debbugs.gnu.org; Wed, 16 Jun 2021 02:38:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltPC1-00045T-4g for guix-patches@gnu.org; Wed, 16 Jun 2021 02:38:29 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:40201) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltPBy-00014K-Vb for guix-patches@gnu.org; Wed, 16 Jun 2021 02:38:28 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id CE5C020003 for ; Wed, 16 Jun 2021 06:38:21 +0000 (UTC) From: Brice Waegeneire To: guix-patches@gnu.org Subject: [PATCH] services: pcscd: Fix daemon signal handling. Date: Wed, 16 Jun 2021 08:38:18 +0200 Message-Id: <20210616063818.12656-1-brice@waegenei.re> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=217.70.183.200; envelope-from=brice@waegenei.re; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) "pcscd" wouldn't handle SIGTERM as it inherited ignoring this signal (and others) from its parent shepherd. The constructor make-forkexec, restore signal handling. Fixes . * gnu/services/security-token.scm (pcscd)[start]: Use make-fork-exec-constructor to start "pcscd". --- Depend on patch . gnu/services/security-token.scm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/gnu/services/security-token.scm b/gnu/services/security-token.scm index 0cbb591e10..822984b70b 100644 --- a/gnu/services/security-token.scm +++ b/gnu/services/security-token.scm @@ -57,12 +57,15 @@ (provision '(pcscd)) (requirement '(syslogd)) (modules '((gnu build shepherd))) - (start #~(lambda _ + (start #~(lambda args (let ((socket "/run/pcscd/pcscd.comm")) (when (file-exists? socket) (delete-file socket))) - (invoke #$(file-append pcsc-lite "/sbin/pcscd")) - (call-with-input-file "/run/pcscd/pcscd.pid" read))) + (apply (make-forkexec-constructor + (list #$(file-append pcsc-lite "/sbin/pcscd") + "--foreground") + #:log-file "/var/log/pcscd.log") + args))) (stop #~(make-kill-destructor))))))) (define pcscd-activation -- 2.31.1 ------------=_1625336341-1401-1--