GNU bug report logs - #49054
Add borg-sans-mono Font

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49054 in the body.
You can then email your comments to 49054 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Add borg-sans-mono Font
Date: Wed, 16 Jun 2021 00:53:14 +0000

[Message part 1 (text/plain, inline)]

This is my first contribution, so let me know if I did something wrong. The patch is attatched.

[Message part 2 (text/html, inline)]

[0001-gnu-Add-font-borg-sans-mono.patch (text/x-patch, attachment)]

Message #8 received at 49054 <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Charles <charles.b.jackson <at> protonmail.com>, 49054 <at> debbugs.gnu.org
Subject: Re: Add borg-sans-mono Font
Date: Wed, 16 Jun 2021 08:33:59 +0200

Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles:
> This is my first contribution, so let me know if I did something
> wrong. The patch is attatched.

> > Subject: [PATCH] gnu: Add font-borg-sans-mono
> > 
> > * gnu/packages/fonts.scm (font-borg-sans-mono): Add font
Nitpicky, but the dot in the headerline is missing and we usually
denote new packages by "new variable" since that's what they are on
Scheme level.

> +    (name "font-borg-sans-mono")
> +    (version "0.3.0")
> +    (home-page "https://github.com/charje/borg-sans-mono")
home-page usually comes after build-system+arguments.

> +       (uri (string-append
> +             home-page
> +             "/releases/download/v"
> +             version
> +             "/borg-sans-mono.zip"))
Please type out home-page.  It could very well be, that the devs start
some fancy Github Pages website, which would break this code.

> +    (description "Droid Sans Mono Slashed + Hasklig-style
> ligatures!")
This is not very descriptive at all, I'm afraid.  If Hasklig or Monoid
are a reasonable alternative to this font, it's probably easier to find
a description for them.

Regards,
Leo

Message #11 received at 49054 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: Leo Prikler <leo.prikler <at> student.tugraz.at>
Cc: 49054 <at> debbugs.gnu.org
Subject: Re: Add borg-sans-mono Font
Date: Sat, 19 Jun 2021 16:33:06 +0000

[Message part 1 (text/plain, inline)]

Thank you so much for reviewing my patch, and helping me correct it. Attatched is an fixed version.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, June 16th, 2021 at 1:33 AM, Leo Prikler <leo.prikler <at> student.tugraz.at> wrote:

> Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles:
>
> > This is my first contribution, so let me know if I did something
> >
> > wrong. The patch is attatched.
>
> > > Subject: [PATCH] gnu: Add font-borg-sans-mono
> > >
> > > -   gnu/packages/fonts.scm (font-borg-sans-mono): Add font
>
> Nitpicky, but the dot in the headerline is missing and we usually
>
> denote new packages by "new variable" since that's what they are on
>
> Scheme level.
>
> > -   (name "font-borg-sans-mono")
> > -   (version "0.3.0")
> > -   (home-page "https://github.com/charje/borg-sans-mono")
>
> home-page usually comes after build-system+arguments.
>
> > -         (uri (string-append
> >
> >
> > -               home-page
> >
> >
> > -               "/releases/download/v"
> >
> >
> > -               version
> >
> >
> > -               "/borg-sans-mono.zip"))
> >
> >
>
> Please type out home-page. It could very well be, that the devs start
>
> some fancy Github Pages website, which would break this code.
>
> > -   (description "Droid Sans Mono Slashed + Hasklig-style
> >
> >     ligatures!")
>
> This is not very descriptive at all, I'm afraid. If Hasklig or Monoid
>
> are a reasonable alternative to this font, it's probably easier to find
>
> a description for them.
>
> Regards,
>
> Leo

[0001-gnu-Add-new-variable-font-borg-sans-mono.patch (text/x-patch, attachment)]

Message #16 received at 49054-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Prikler <leo.prikler <at> student.tugraz.at>
To: Charles <charles.b.jackson <at> protonmail.com>
Cc: 49054-done <at> debbugs.gnu.org
Subject: Re: Add borg-sans-mono Font
Date: Sat, 19 Jun 2021 19:38:47 +0200

Am Samstag, den 19.06.2021, 16:33 +0000 schrieb Charles:
> Thank you so much for reviewing my patch, and helping me correct it.
> Attatched is an fixed version.
I've pushed your patch with some cosmetic adjustments as listed below:
- instead of appending the package to the end, I added it after
Google's Roboto fonts
- I changed the git-reference to be a two-liner
- I changed the hash to be a three-liner as otherwise there'd be
problems with smaller screens and you don't want those.
- I reworded the description a little as the old one included a typo
and to me personally didn't really get the actual idea behind the
package across.

I missed, that the commit message still didn't follow the format 100%.
I ought to have corrected it to:

gnu: Add font-borg-sans-mono.

* gnu/packages/fonts.scm (font-borg-sans-mono): New variable.

Anyway, you should now be able to pull and build the font :)

All the best,
Leo
> 
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> 
> On Wednesday, June 16th, 2021 at 1:33 AM, Leo Prikler <
> leo.prikler <at> student.tugraz.at> wrote:
> 
> > Am Mittwoch, den 16.06.2021, 00:53 +0000 schrieb Charles:
> > 
> > > This is my first contribution, so let me know if I did something
> > > 
> > > wrong. The patch is attatched.
> > > > Subject: [PATCH] gnu: Add font-borg-sans-mono
> > > > 
> > > > -   gnu/packages/fonts.scm (font-borg-sans-mono): Add font
> > 
> > Nitpicky, but the dot in the headerline is missing and we usually
> > 
> > denote new packages by "new variable" since that's what they are on
> > 
> > Scheme level.
> > 
> > > -   (name "font-borg-sans-mono")
> > > -   (version "0.3.0")
> > > -   (home-page "https://github.com/charje/borg-sans-mono")
> > 
> > home-page usually comes after build-system+arguments.
> > 
> > > -         (uri (string-append
> > > 
> > > 
> > > -               home-page
> > > 
> > > 
> > > -               "/releases/download/v"
> > > 
> > > 
> > > -               version
> > > 
> > > 
> > > -               "/borg-sans-mono.zip"))
> > > 
> > > 
> > 
> > Please type out home-page. It could very well be, that the devs
> > start
> > 
> > some fancy Github Pages website, which would break this code.
> > 
> > > -   (description "Droid Sans Mono Slashed + Hasklig-style
> > > 
> > >     ligatures!")
> > 
> > This is not very descriptive at all, I'm afraid. If Hasklig or
> > Monoid
> > 
> > are a reasonable alternative to this font, it's probably easier to
> > find
> > 
> > a description for them.
> > 
> > Regards,
> > 
> > Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.