GNU bug report logs - #49028
[PATCH] gnu: Add mda-lv2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49028 in the body.
You can then email your comments to 49028 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Wilms <t_w_ <at> freenet.de>
To: guix-patches <at> gnu.org
Cc: Thorsten Wilms <t_w_ <at> freenet.de>
Subject: [PATCH] gnu: Add mda-lv2
Date: Mon, 14 Jun 2021 21:32:24 +0200

* gnu/packages/audio.scm (mda-lv2): New variable.
---
 gnu/packages/audio.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3885a22e10..e352f797da 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5275,3 +5275,38 @@ Icecast server.")
 generator, generating audio signals out of Linux's /dev/dsp audio
 device.  There is support for mono and/or stereo and 8 or 16 bit samples.")
     (license license:gpl2)))
+
+(define-public mda-lv2
+  (package
+   (name "mda-lv2")
+   (version "1.2.6")
+   (source
+    (origin
+     (method url-fetch)
+     (uri
+      ;; Tarball from gitlab lacks waflib directory content, so take it from
+      ;; drobilla.net.
+      (string-append "http://download.drobilla.net/mda-lv2-"
+		     version ".tar.bz2"))
+     (sha256
+      (base32 "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f  ; There are no tests.
+      #:configure-flags
+      (list (string-append "--prefix="
+			   (assoc-ref %outputs "out")))))
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://drobilla.net/software/mda-lv2")
+   (synopsis "Audio plug-in pack for LV2")
+   (description
+    "A port of the MDA VST plugins to LV2. Includes effects and a few
+instruments.")
+   (license (list license:gpl3+ license:gpl3+))))
-- 
2.32.0

Message #8 received at 49028 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Thorsten Wilms <t_w_ <at> freenet.de>, 49028 <at> debbugs.gnu.org
Cc: Thorsten Wilms <t_w_ <at> freenet.de>
Subject: Re: [bug#49028] [PATCH] gnu: Add mda-lv2
Date: Fri, 18 Jun 2021 16:36:18 +0200

[Message part 1 (text/plain, inline)]

On Mon, Jun 14 2021, Thorsten Wilms wrote:

> +(define-public mda-lv2
> +  (package
> +   (name "mda-lv2")
> +   (version "1.2.6")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri
> +      ;; Tarball from gitlab lacks waflib directory content, so take it from
> +      ;; drobilla.net.
> +      (string-append "http://download.drobilla.net/mda-lv2-"
> +		     version ".tar.bz2"))

The waflib directory is a submodule in the Git repo, something like this
should work (untested):

  (git-reference
    (url "https://gitlab.com/drobilla/mda-lv2")
    (commit (string-append "v" version))
    (recursive? #t))
  
> +     (sha256
> +      (base32 "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
> +   (build-system waf-build-system)
> +   (arguments
> +    `(#:tests? #f  ; There are no tests.
> +      #:configure-flags
> +      (list (string-append "--prefix="
> +			   (assoc-ref %outputs "out")))))
> +   (inputs
> +    `(("lv2" ,lv2)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "LV2_PATH")
> +           (files '("lib/lv2")))))
> +   (home-page "https://drobilla.net/software/mda-lv2")
> +   (synopsis "Audio plug-in pack for LV2")
> +   (description
> +    "A port of the MDA VST plugins to LV2. Includes effects and a few
> +instruments.")

The description should consist of one or more full sentences, and use
double spaces between sentences.  Maybe something like this:

  MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and
  a few instrument plugins.
  
> +   (license (list license:gpl3+ license:gpl3+))))

The two licenses are the same, simply ‘license:gpl3+’ would do.

Could you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 49028 <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Wilms <t_w_ <at> freenet.de>
To: 49028 <at> debbugs.gnu.org
Cc: Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: [bug#49028] [PATCH] gnu: Add mda-lv2
Date: Sun, 20 Jun 2021 16:26:12 +0200

I fixed the description and license. I think there’s no need to change
away from the tarball, as it’s actually an official release on the code
author’s domain.

Thanks, Xinglu Chen!


* gnu/packages/audio.scm (mda-lv2): New variable.
---
 gnu/packages/audio.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3885a22e10..e352f797da 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5275,3 +5275,38 @@ Icecast server.")
 generator, generating audio signals out of Linux's /dev/dsp audio
 device.  There is support for mono and/or stereo and 8 or 16 bit
samples.") (license license:gpl2)))
+
+(define-public mda-lv2
+  (package
+   (name "mda-lv2")
+   (version "1.2.6")
+   (source
+    (origin
+     (method url-fetch)
+     (uri
+      ;; Tarball from gitlab lacks waflib directory content, so take
it from
+      ;; drobilla.net.
+      (string-append "http://download.drobilla.net/mda-lv2-"
+		     version ".tar.bz2"))
+     (sha256
+      (base32
"1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f  ; There are no tests.
+      #:configure-flags
+      (list (string-append "--prefix="
+			   (assoc-ref %outputs "out")))))
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://drobilla.net/software/mda-lv2")
+   (synopsis "Audio plug-in pack for LV2")
+   (description
+ MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and
+a few instrument plugins.
+   (license license:gpl3+)))
-- 
2.32.0

Message #14 received at 49028 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Thorsten Wilms <t_w_ <at> freenet.de>, 49028 <at> debbugs.gnu.org
Subject: Re: [bug#49028] [PATCH] gnu: Add mda-lv2
Date: Tue, 22 Jun 2021 09:44:06 +0200

[Message part 1 (text/plain, inline)]

On Sun, Jun 20 2021, Thorsten Wilms wrote:

> I fixed the description and license. I think there’s no need to change
> away from the tarball, as it’s actually an official release on the code
> author’s domain.

Fair enough.

> Thanks, Xinglu Chen!

You are welcome!

Note that things that shouldn’t be part of the commit message should be
put below the ‘---’ line.  The subject should also contain “[PATCH v2]”
to reflect that this is the second version of the patch, you can pass
the ‘--reroll-count=2’ to ‘git send-email’.

Also, I am not able to apply the patch, ‘git am’ reports:

  Applying: gnu: Add mda-lv2
  error: corrupt patch at line 12
  error: could not build fake ancestor
  hint: Use 'git am --show-current-patch=diff' to see the failed patch
  Patch failed at 0001 gnu: Add mda-lv2
  When you have resolved this problem, run "git am --continue".
  If you prefer to skip this patch, run "git am --skip" instead.
  To restore the original branch and stop patching, run "git am --abort".

Your previous patch did apply cleanly, did you do anything differently?

> +(define-public mda-lv2
> +  (package
> +   (name "mda-lv2")
> +   (version "1.2.6")
> +   (source
> +    (origin
> +     (method url-fetch)
> +     (uri
> +      ;; Tarball from gitlab lacks waflib directory content, so take
> it from
> +      ;; drobilla.net.

This comment isn’t accurate anymore, so there is probably no need for
it.

> +      (string-append "http://download.drobilla.net/mda-lv2-"
> +		     version ".tar.bz2"))
> +     (sha256
> +      (base32
> "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
> +   (build-system waf-build-system)
> +   (arguments
> +    `(#:tests? #f  ; There are no tests.
> +      #:configure-flags
> +      (list (string-append "--prefix="
> +			   (assoc-ref %outputs "out")))))
> +   (inputs
> +    `(("lv2" ,lv2)))
> +   (native-inputs
> +    `(("pkg-config" ,pkg-config)))
> +   (native-search-paths
> +    (list (search-path-specification
> +           (variable "LV2_PATH")
> +           (files '("lib/lv2")))))
> +   (home-page "https://drobilla.net/software/mda-lv2")
> +   (synopsis "Audio plug-in pack for LV2")
> +   (description
> + MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and
> +a few instrument plugins.

The description should be put inside double quotes :)

Could you send a v3?

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 49028 <at> debbugs.gnu.org (full text, mbox):

From: Thorsten Wilms <t_w_ <at> freenet.de>
To: 49028 <at> debbugs.gnu.org
Cc: Xinglu Chen <public <at> yoctocell.xyz>, Thorsten Wilms <t_w_ <at> freenet.de>
Subject: [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm (mda-lv2): New
 variable.
Date: Tue, 22 Jun 2021 13:00:54 +0200

---
 gnu/packages/audio.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 3885a22e10..22dc71fe50 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -5275,3 +5275,36 @@ Icecast server.")
 generator, generating audio signals out of Linux's /dev/dsp audio
 device.  There is support for mono and/or stereo and 8 or 16 bit samples.")
     (license license:gpl2)))
+
+(define-public mda-lv2
+  (package
+   (name "mda-lv2")
+   (version "1.2.6")
+   (source
+    (origin
+     (method url-fetch)
+     (uri
+      (string-append "http://download.drobilla.net/mda-lv2-"
+		     version ".tar.bz2"))
+     (sha256
+      (base32 "1nspk2j11l65m5r9z5isw8j749vh9a89wgx8mkrrq15f4iq12rnd"))))
+   (build-system waf-build-system)
+   (arguments
+    `(#:tests? #f  ; There are no tests.
+      #:configure-flags
+      (list (string-append "--prefix="
+			   (assoc-ref %outputs "out")))))
+   (inputs
+    `(("lv2" ,lv2)))
+   (native-inputs
+    `(("pkg-config" ,pkg-config)))
+   (native-search-paths
+    (list (search-path-specification
+           (variable "LV2_PATH")
+           (files '("lib/lv2")))))
+   (home-page "https://drobilla.net/software/mda-lv2")
+   (synopsis "Audio plug-in pack for LV2")
+   (description
+    "MDA-LV2 is an LV2 port of the MDA plugins.  It includes effects and a few
+instrument plugins.")
+   (license license:gpl3+)))
-- 
2.32.0

Message #20 received at 49028 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Thorsten Wilms <t_w_ <at> freenet.de>, 49028 <at> debbugs.gnu.org
Cc: Thorsten Wilms <t_w_ <at> freenet.de>
Subject: Re: [bug#49028] [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm
 (mda-lv2): New variable.
Date: Wed, 23 Jun 2021 10:46:42 +0200

[Message part 1 (text/plain, inline)]

On Tue, Jun 22 2021, Thorsten Wilms wrote:

> ---
>  gnu/packages/audio.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)

LGTM, apart from the commit summary being a little messed up. :)

I don’t have commit access though, so you will have to wait for someone
else to merge it.

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 49028-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Thorsten Wilms <t_w_ <at> freenet.de>
Cc: 49028-done <at> debbugs.gnu.org, Xinglu Chen <public <at> yoctocell.xyz>
Subject: Re: [bug#49028] [PATCH v3] Add mda-lv2. * gnu/packages/audio.scm
 (mda-lv2): New variable.
Date: Mon, 28 Jun 2021 17:49:30 +0300

[Message part 1 (text/plain, inline)]

Thanks. Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.