GNU bug report logs - #49005
28.0.50; Not possible to jump to first or last completions entry in fido-vertical-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49005 in the body.
You can then email your comments to 49005 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Lang <simon.lang <at> outlook.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Cc: João Távora <joaotavora <at> gmail.com>
Subject: 28.0.50; Not possible to jump to first or last completions entry in
 fido-vertical-mode
Date: Sun, 13 Jun 2021 15:27:36 +0000

[Message part 1 (text/plain, inline)]

In the brand new fido-vertical mode, completions are not cycled in contrast to icomplete-vertical-mode.
There is not yet a function to jump to the first or last completions entry, which sometimes can be helpful.
This patch would proposes two simple helper functions for doing that.

Thank you!





In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.5.0, NS appkit-2022.50 Version 11.4 (Build 20F71))
 of 2021-06-06 built on Zwei.local
Windowing system distributor 'Apple', version 10.3.2022
System Description:  macOS 11.4

Configured using:
 'configure --disable-dependency-tracking --disable-silent-rules
 --enable-locallisppath=/usr/local/share/emacs/site-lisp
 --infodir=/usr/local/Cellar/emacs-plus <at> 28/28.0.50/share/info/emacs
 --prefix=/usr/local/Cellar/emacs-plus <at> 28/28.0.50 --with-xml2
 --with-gnutls --with-native-compilation --without-dbus
 --with-imagemagick --with-modules --with-rsvg --with-ns
 --disable-ns-self-contained 'CFLAGS=-I/usr/local/opt/gcc/include
 -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include
 -I/usr/local/opt/jpeg/include' 'LDFLAGS=-L/usr/local/lib/gcc/11
 -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include
 -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include''

Configured features:
ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES
NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF
TOOLKIT_SCROLL_BARS XIM ZLIB

Important settings:
  value of $LANG: en_GB.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads kqueue cocoa ns lcms2
multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 67367 8465)
 (symbols 48 6527 0)
 (strings 32 18695 2230)
 (string-bytes 1 645512)
 (vectors 16 13390)
 (vector-slots 8 280721 11188)
 (floats 8 22 39)
 (intervals 56 226 0)
 (buffers 992 10))

[Message part 2 (text/html, inline)]

[0001-icomplete-vertical-functions-to-go-to-first-or-last-.patch (application/octet-stream, attachment)]

Message #8 received at 49005 <at> debbugs.gnu.org (full text, mbox):

From: Simon Lang <simon.lang <at> outlook.com>
To: 49005 <at> debbugs.gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: Re: 28.0.50; Not possible to jump to first or last completions entry
 in fido-vertical-mode
Date: Wed, 30 Jun 2021 20:27:22 +0100

doesn’t make sense?

> On 13 Jun 2021, at 16:27, Simon Lang <simon.lang <at> outlook.com> wrote:
> 
> 
> In the brand new fido-vertical mode, completions are not cycled in contrast to icomplete-vertical-mode. 
> There is not yet a function to jump to the first or last completions entry, which sometimes can be helpful.
> This patch would proposes two simple helper functions for doing that.
> 
> Thank you!
> 
> 
> 
> 
> 
> In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.5.0, NS appkit-2022.50 Version 11.4 (Build 20F71))
>  of 2021-06-06 built on Zwei.local
> Windowing system distributor 'Apple', version 10.3.2022
> System Description:  macOS 11.4
> 
> Configured using:
>  'configure --disable-dependency-tracking --disable-silent-rules
>  --enable-locallisppath=/usr/local/share/emacs/site-lisp
>  --infodir=/usr/local/Cellar/emacs-plus <at> 28/28.0.50/share/info/emacs
>  --prefix=/usr/local/Cellar/emacs-plus <at> 28/28.0.50 --with-xml2
>  --with-gnutls --with-native-compilation --without-dbus
>  --with-imagemagick --with-modules --with-rsvg --with-ns
>  --disable-ns-self-contained 'CFLAGS=-I/usr/local/opt/gcc/include
>  -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include
>  -I/usr/local/opt/jpeg/include' 'LDFLAGS=-L/usr/local/lib/gcc/11
>  -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include
>  -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include''
> 
> Configured features:
> ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES
> NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF
> TOOLKIT_SCROLL_BARS XIM ZLIB
> 
> Important settings:
>   value of $LANG: en_GB.UTF-8
>   locale-coding-system: utf-8-unix
> 
> Major mode: Lisp Interaction
> 
> Minor modes in effect:
>   tooltip-mode: t
>   global-eldoc-mode: t
>   eldoc-mode: t
>   electric-indent-mode: t
>   mouse-wheel-mode: t
>   tool-bar-mode: t
>   menu-bar-mode: t
>   file-name-shadow-mode: t
>   global-font-lock-mode: t
>   font-lock-mode: t
>   blink-cursor-mode: t
>   auto-composition-mode: t
>   auto-encryption-mode: t
>   auto-compression-mode: t
>   line-number-mode: t
>   transient-mark-mode: t
> 
> Load-path shadows:
> None found.
> 
> Features:
> (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
> rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
> rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
> eieio-loaddefs password-cache json map text-property-search time-date
> subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
> cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
> iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
> lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
> term/common-win tool-bar dnd fontset image regexp-opt fringe
> tabulated-list replace newcomment text-mode elisp-mode lisp-mode
> prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
> timer select scroll-bar mouse jit-lock font-lock syntax font-core
> term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
> misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
> cp51932 hebrew greek romanian slovak czech european ethiopic indian
> cyrillic chinese composite charscript charprop case-table epa-hook
> jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
> loaddefs faces cus-face macroexp files window text-properties overlay
> sha1 md5 base64 format env code-pages mule custom widget
> hashtable-print-readable backquote threads kqueue cocoa ns lcms2
> multi-tty make-network-process native-compile emacs)
> 
> Memory information:
> ((conses 16 67367 8465)
>  (symbols 48 6527 0)
>  (strings 32 18695 2230)
>  (string-bytes 1 645512)
>  (vectors 16 13390)
>  (vector-slots 8 280721 11188)
>  (floats 8 22 39)
>  (intervals 56 226 0)
>  (buffers 992 10))
> 
> <0001-icomplete-vertical-functions-to-go-to-first-or-last-.patch>

Message #11 received at 49005 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Simon Lang <simon.lang <at> outlook.com>
Cc: 49005 <at> debbugs.gnu.org
Subject: Re: 28.0.50; Not possible to jump to first or last completions entry
 in fido-vertical-mode
Date: Wed, 30 Jun 2021 21:08:55 +0100

No, no, makes a lot of sense.  I just haven't looked at your code
yet in depth.

Your implementation seems to repeat some logic, and I'd rather
reuse paging code, so maybe you can work on that: reducing code
duplication.  But as soon as I have time I'll look at this and offer some
suggestions.

Sorry for the delay, and keep bumping this if I forget.

João

On Wed, Jun 30, 2021 at 8:27 PM Simon Lang <simon.lang <at> outlook.com> wrote:
>
> doesn’t make sense?
>
> > On 13 Jun 2021, at 16:27, Simon Lang <simon.lang <at> outlook.com> wrote:
> >
> >
> > In the brand new fido-vertical mode, completions are not cycled in contrast to icomplete-vertical-mode.
> > There is not yet a function to jump to the first or last completions entry, which sometimes can be helpful.
> > This patch would proposes two simple helper functions for doing that.
> >
> > Thank you!
> >
> >
> >
> >
> >
> > In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.5.0, NS appkit-2022.50 Version 11.4 (Build 20F71))
> >  of 2021-06-06 built on Zwei.local
> > Windowing system distributor 'Apple', version 10.3.2022
> > System Description:  macOS 11.4
> >
> > Configured using:
> >  'configure --disable-dependency-tracking --disable-silent-rules
> >  --enable-locallisppath=/usr/local/share/emacs/site-lisp
> >  --infodir=/usr/local/Cellar/emacs-plus <at> 28/28.0.50/share/info/emacs
> >  --prefix=/usr/local/Cellar/emacs-plus <at> 28/28.0.50 --with-xml2
> >  --with-gnutls --with-native-compilation --without-dbus
> >  --with-imagemagick --with-modules --with-rsvg --with-ns
> >  --disable-ns-self-contained 'CFLAGS=-I/usr/local/opt/gcc/include
> >  -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include
> >  -I/usr/local/opt/jpeg/include' 'LDFLAGS=-L/usr/local/lib/gcc/11
> >  -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include
> >  -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include''
> >
> > Configured features:
> > ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES
> > NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF
> > TOOLKIT_SCROLL_BARS XIM ZLIB
> >
> > Important settings:
> >   value of $LANG: en_GB.UTF-8
> >   locale-coding-system: utf-8-unix
> >
> > Major mode: Lisp Interaction
> >
> > Minor modes in effect:
> >   tooltip-mode: t
> >   global-eldoc-mode: t
> >   eldoc-mode: t
> >   electric-indent-mode: t
> >   mouse-wheel-mode: t
> >   tool-bar-mode: t
> >   menu-bar-mode: t
> >   file-name-shadow-mode: t
> >   global-font-lock-mode: t
> >   font-lock-mode: t
> >   blink-cursor-mode: t
> >   auto-composition-mode: t
> >   auto-encryption-mode: t
> >   auto-compression-mode: t
> >   line-number-mode: t
> >   transient-mark-mode: t
> >
> > Load-path shadows:
> > None found.
> >
> > Features:
> > (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
> > rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
> > rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
> > eieio-loaddefs password-cache json map text-property-search time-date
> > subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
> > mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
> > cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
> > iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
> > lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
> > term/common-win tool-bar dnd fontset image regexp-opt fringe
> > tabulated-list replace newcomment text-mode elisp-mode lisp-mode
> > prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
> > timer select scroll-bar mouse jit-lock font-lock syntax font-core
> > term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
> > misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
> > cp51932 hebrew greek romanian slovak czech european ethiopic indian
> > cyrillic chinese composite charscript charprop case-table epa-hook
> > jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
> > loaddefs faces cus-face macroexp files window text-properties overlay
> > sha1 md5 base64 format env code-pages mule custom widget
> > hashtable-print-readable backquote threads kqueue cocoa ns lcms2
> > multi-tty make-network-process native-compile emacs)
> >
> > Memory information:
> > ((conses 16 67367 8465)
> >  (symbols 48 6527 0)
> >  (strings 32 18695 2230)
> >  (string-bytes 1 645512)
> >  (vectors 16 13390)
> >  (vector-slots 8 280721 11188)
> >  (floats 8 22 39)
> >  (intervals 56 226 0)
> >  (buffers 992 10))
> >
> > <0001-icomplete-vertical-functions-to-go-to-first-or-last-.patch>
>


-- 
João Távora

Message #14 received at 49005 <at> debbugs.gnu.org (full text, mbox):

From: Simon Lang <simon.lang <at> outlook.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: "49005 <at> debbugs.gnu.org" <49005 <at> debbugs.gnu.org>
Subject: Re: 28.0.50; Not possible to jump to first or last completions entry
 in fido-vertical-mode
Date: Thu, 1 Jul 2021 09:16:11 +0100

will do!

> On 30 Jun 2021, at 21:08, João Távora <joaotavora <at> gmail.com> wrote:
> 
> No, no, makes a lot of sense.  I just haven't looked at your code
> yet in depth.
> 
> Your implementation seems to repeat some logic, and I'd rather
> reuse paging code, so maybe you can work on that: reducing code
> duplication.  But as soon as I have time I'll look at this and offer some
> suggestions.
> 
> Sorry for the delay, and keep bumping this if I forget.
> 
> João
> 
> On Wed, Jun 30, 2021 at 8:27 PM Simon Lang <simon.lang <at> outlook.com> wrote:
>> 
>> doesn’t make sense?
>> 
>>> On 13 Jun 2021, at 16:27, Simon Lang <simon.lang <at> outlook.com> wrote:
>>> 
>>> 
>>> In the brand new fido-vertical mode, completions are not cycled in contrast to icomplete-vertical-mode.
>>> There is not yet a function to jump to the first or last completions entry, which sometimes can be helpful.
>>> This patch would proposes two simple helper functions for doing that.
>>> 
>>> Thank you!
>>> 
>>> 
>>> 
>>> 
>>> 
>>> In GNU Emacs 28.0.50 (build 1, x86_64-apple-darwin20.5.0, NS appkit-2022.50 Version 11.4 (Build 20F71))
>>> of 2021-06-06 built on Zwei.local
>>> Windowing system distributor 'Apple', version 10.3.2022
>>> System Description:  macOS 11.4
>>> 
>>> Configured using:
>>> 'configure --disable-dependency-tracking --disable-silent-rules
>>> --enable-locallisppath=/usr/local/share/emacs/site-lisp
>>> --infodir=/usr/local/Cellar/emacs-plus <at> 28/28.0.50/share/info/emacs
>>> --prefix=/usr/local/Cellar/emacs-plus <at> 28/28.0.50 --with-xml2
>>> --with-gnutls --with-native-compilation --without-dbus
>>> --with-imagemagick --with-modules --with-rsvg --with-ns
>>> --disable-ns-self-contained 'CFLAGS=-I/usr/local/opt/gcc/include
>>> -I/usr/local/opt/libgccjit/include -I/usr/local/opt/gmp/include
>>> -I/usr/local/opt/jpeg/include' 'LDFLAGS=-L/usr/local/lib/gcc/11
>>> -I/usr/local/opt/gcc/include -I/usr/local/opt/libgccjit/include
>>> -I/usr/local/opt/gmp/include -I/usr/local/opt/jpeg/include''
>>> 
>>> Configured features:
>>> ACL GIF GLIB GMP GNUTLS IMAGEMAGICK JPEG JSON LCMS2 LIBXML2 MODULES
>>> NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG THREADS TIFF
>>> TOOLKIT_SCROLL_BARS XIM ZLIB
>>> 
>>> Important settings:
>>>  value of $LANG: en_GB.UTF-8
>>>  locale-coding-system: utf-8-unix
>>> 
>>> Major mode: Lisp Interaction
>>> 
>>> Minor modes in effect:
>>>  tooltip-mode: t
>>>  global-eldoc-mode: t
>>>  eldoc-mode: t
>>>  electric-indent-mode: t
>>>  mouse-wheel-mode: t
>>>  tool-bar-mode: t
>>>  menu-bar-mode: t
>>>  file-name-shadow-mode: t
>>>  global-font-lock-mode: t
>>>  font-lock-mode: t
>>>  blink-cursor-mode: t
>>>  auto-composition-mode: t
>>>  auto-encryption-mode: t
>>>  auto-compression-mode: t
>>>  line-number-mode: t
>>>  transient-mark-mode: t
>>> 
>>> Load-path shadows:
>>> None found.
>>> 
>>> Features:
>>> (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
>>> rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
>>> rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
>>> eieio-loaddefs password-cache json map text-property-search time-date
>>> subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
>>> mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
>>> cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
>>> iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
>>> lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util
>>> term/common-win tool-bar dnd fontset image regexp-opt fringe
>>> tabulated-list replace newcomment text-mode elisp-mode lisp-mode
>>> prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
>>> timer select scroll-bar mouse jit-lock font-lock syntax font-core
>>> term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
>>> misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
>>> cp51932 hebrew greek romanian slovak czech european ethiopic indian
>>> cyrillic chinese composite charscript charprop case-table epa-hook
>>> jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
>>> loaddefs faces cus-face macroexp files window text-properties overlay
>>> sha1 md5 base64 format env code-pages mule custom widget
>>> hashtable-print-readable backquote threads kqueue cocoa ns lcms2
>>> multi-tty make-network-process native-compile emacs)
>>> 
>>> Memory information:
>>> ((conses 16 67367 8465)
>>> (symbols 48 6527 0)
>>> (strings 32 18695 2230)
>>> (string-bytes 1 645512)
>>> (vectors 16 13390)
>>> (vector-slots 8 280721 11188)
>>> (floats 8 22 39)
>>> (intervals 56 226 0)
>>> (buffers 992 10))
>>> 
>>> <0001-icomplete-vertical-functions-to-go-to-first-or-last-.patch>
>> 
> 
> 
> -- 
> João Távora

Message #19 received at 49005-done <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Simon Lang <simon.lang <at> outlook.com>
Cc: 49005-done <at> debbugs.gnu.org
Subject: Re: bug#49005: 28.0.50; Not possible to jump to first or last
 completions entry in fido-vertical-mode
Date: Tue, 17 Aug 2021 13:00:22 +0100

João Távora <joaotavora <at> gmail.com> writes:

> No, no, makes a lot of sense.  I just haven't looked at your code
> yet in depth.
>
> Your implementation seems to repeat some logic, and I'd rather
> reuse paging code, so maybe you can work on that: reducing code
> duplication.  But as soon as I have time I'll look at this and offer some
> suggestions.
>
> Sorry for the delay, and keep bumping this if I forget.

I've pushed a solution to this in:

    commit 96bbd6f0a7f20ae77bcd8a477b54b11ba5b42cc6 (HEAD -> master, origin/master, origin/HEAD)
    Author: João Távora <joaotavora <at> gmail.com>
    Date:   Tue Aug 17 12:48:37 2021 +0100
     
        Jump to first,last completion with M-<, M-> in icomplete-vertical-mode
     
        Fixes: bug#49005
     
        Co-authored-by: Simon Lang <simon.lang <at> outlook.com>

With the aforementioned de-duplications and binding it to M-< and M->
so that it also works easily for tty emacsen.  Let me know what you
think.

Thanks,
João

Message #22 received at 49005-done <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: 49005-done <at> debbugs.gnu.org
Subject: Re: bug#49005: 28.0.50; Not possible to jump to first or last
 completions entry in fido-vertical-mode
Date: Tue, 17 Aug 2021 13:09:51 +0100

Fixed in

commit 96bbd6f0a7f20ae77bcd8a477b54b11ba5b42cc6 (origin/master, origin/HEAD)
Author: João Távora <joaotavora <at> gmail.com>
Date:   Tue Aug 17 12:48:37 2021 +0100

    Jump to first,last completion with M-<, M-> in icomplete-vertical-mode

    Fixes: bug#49005

    Co-authored-by: Simon Lang <simon.lang <at> outlook.com>

    * lisp/icomplete.el (icomplete-backward-completions): Return
    non-nil iff something was stepped.  Ajust docstring.

Message #25 received at 49005-done <at> debbugs.gnu.org (full text, mbox):

From: Simon Lang <simon.lang <at> outlook.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: 49005-done <at> debbugs.gnu.org
Subject: Re: bug#49005: 28.0.50; Not possible to jump to first or last
 completions entry in fido-vertical-mode
Date: Mon, 6 Sep 2021 17:24:48 +0100

Fantastic!

sorry for the delayed reply …

> On 17 Aug 2021, at 13:00, João Távora <joaotavora <at> gmail.com> wrote:
> 
> João Távora <joaotavora <at> gmail.com> writes:
> 
>> No, no, makes a lot of sense.  I just haven't looked at your code
>> yet in depth.
>> 
>> Your implementation seems to repeat some logic, and I'd rather
>> reuse paging code, so maybe you can work on that: reducing code
>> duplication.  But as soon as I have time I'll look at this and offer some
>> suggestions.
>> 
>> Sorry for the delay, and keep bumping this if I forget.
> 
> I've pushed a solution to this in:
> 
>    commit 96bbd6f0a7f20ae77bcd8a477b54b11ba5b42cc6 (HEAD -> master, origin/master, origin/HEAD)
>    Author: João Távora <joaotavora <at> gmail.com>
>    Date:   Tue Aug 17 12:48:37 2021 +0100
> 
>        Jump to first,last completion with M-<, M-> in icomplete-vertical-mode
> 
>        Fixes: bug#49005
> 
>        Co-authored-by: Simon Lang <simon.lang <at> outlook.com>
> 
> With the aforementioned de-duplications and binding it to M-< and M->
> so that it also works easily for tty emacsen.  Let me know what you
> think.
> 
> Thanks,
> João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.