GNU bug report logs - #48953
Improve Dino

Previous Next

Full log

Message #29 received at 48953 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Raghav Gururajan <rg <at> raghavgururajan.name>
Cc: 48953 <at> debbugs.gnu.org
Subject: Re: [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features.
Date: Thu, 10 Jun 2021 23:35:25 -0400 (EDT)

[Message part 1 (text/plain, inline)]

On Thu, 10 Jun 2021, Raghav Gururajan via Guix-patches via wrote:

> * gnu/packages/messaging.scm (dino)[phases](wrap-env): New phase.
> [inputs]: Add gspell, gstreamer, gst-plugins-base, gst-plugins-good,
> icu4c, libsrtp and webrtc-audio-processing.
> ---
> gnu/packages/messaging.scm | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 5be733f3a2..41f26ba8e0 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -114,6 +114,7 @@
>   #:use-module (gnu packages sphinx)
>   #:use-module (gnu packages sqlite)
>   #:use-module (gnu packages tcl)
> +  #:use-module (gnu packages telephony)
>   #:use-module (gnu packages texinfo)
>   #:use-module (gnu packages textutils)
>   #:use-module (gnu packages tls)
> @@ -1241,6 +1242,17 @@ Encryption to Gajim.")
>                            (guix build glib-or-gtk-build-system))
>        #:phases
>        (modify-phases %standard-phases
> +         (add-after 'install 'wrap-env
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (for-each
> +                (lambda (name)
> +                  (let ((file (string-append out "/bin/" name))
> +                        (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
> +                    (wrap-program file
> +                      `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))
> +                '("dino")))
> +             #t))

Nitpick of a sort: Can we forgo the #t with the (hopefully soon) 
upcoming core-updates merge?

[…]

> +       ("gspell" ,gspell)               ; for spell-check support
> +       ("gstreamer" ,gstreamer)         ; for A/V support
> +       ("gst-plugins-base" ,gst-plugins-base)
> +       ("gst-plugins-good" ,gst-plugins-good)

[…]

> +       ("webrtc-audio-processing" ,webrtc-audio-processing))) ; for A/V support

Is there actual A/V support in this version of Dino, or is that only 
coming in 0.3.0?

Best,
Jack

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.