GNU bug report logs - #48943
[PATCH] import: hackage: Support "common" field and imports

Previous Next

Package: guix-patches;

Reported by: Philip Munksgaard <philip <at> munksgaard.me>

Date: Thu, 10 Jun 2021 08:41:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 48943 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Philip Munksgaard <philip <at> munksgaard.me>
Cc: 48943 <at> debbugs.gnu.org
Subject: Re: bug#48943: [PATCH] import: hackage: Support "common" field and
 imports
Date: Sun, 13 Jun 2021 22:34:46 +0200

Hi,

Philip Munksgaard <philip <at> munksgaard.me> skribis:

> Fixes <https://issues.guix.gnu.org/48701>.
>
> * guix/import/cabal.scm (make-cabal-parser): Modify.
> (is-common): New variable.
> (lex-common): New procedure.
> (is-id): Modify.
> (eval-cabal): Modify.

Could you add a test case in ‘tests/hackage.scm’ and send an updated
patch?

Apart from that it LGTM, thanks!

Ludo’.
This bug report was last modified 3 years and 327 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.