GNU bug report logs - #48920
[PATCH 1/2] gnu: python-toolz: Enable tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48920: closed ([PATCH 1/2] gnu: python-toolz: Enable tests.)
Date: Tue, 08 Jun 2021 17:19:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 8 Jun 2021 13:18:41 -0400
with message-id <YL+mcayZbgK94Uye <at> jasmine.lan>
and subject line Re: [bug#48920] [PATCH 1/2] gnu: python-toolz: Enable tests.
has caused the debbugs.gnu.org bug report #48920,
regarding [PATCH 1/2] gnu: python-toolz: Enable tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48920: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48920
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 1/2] gnu: python-toolz: Enable tests.
Date: Tue,  8 Jun 2021 13:33:03 +0000

* gnu/packages/python-xyz.scm (python-toolz)[arguments]: Remove #:tests?.
Override check phase.
[native-inputs]: Add python-pytest.
---
 gnu/packages/python-xyz.scm | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 0d6c9fc2c5..c724357c11 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -21341,9 +21341,17 @@ library's @code{threading} module.")
         (base32
          "1j9i7fdjnx9dz35fdj5gvgxx6585ja9sxgaiv65if77nlxz0m7wj"))))
     (build-system python-build-system)
-    ;; FIXME: tests cannot be computed: "Can't perform this operation for
-    ;; unregistered loader type"
-    (arguments '(#:tests? #f))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+             (when tests?
+               (add-installed-pythonpath inputs outputs)
+               (invoke "python" "-m" "pytest" "--doctest-modules"
+                       "--pyargs" "toolz")))))))
+    (native-inputs
+     `(("python-pytest" ,python-pytest)))
     (home-page "https://github.com/pytoolz/toolz/")
     (synopsis "List processing tools and functional utilities")
     (description
-- 
2.31.1

[Message part 3 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 48920-done <at> debbugs.gnu.org
Subject: Re: [bug#48920] [PATCH 1/2] gnu: python-toolz: Enable tests.
Date: Tue, 8 Jun 2021 13:18:41 -0400

On Tue, Jun 08, 2021 at 01:33:03PM +0000, Vinicius Monego wrote:
> * gnu/packages/python-xyz.scm (python-toolz)[arguments]: Remove #:tests?.
> Override check phase.
> [native-inputs]: Add python-pytest.

Thanks! Pushed as 74c70553394e32f7b6d5fa56da3bf3b18623c70f

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.