GNU bug report logs - #48918
[PATCH 1/2] gnu: python-pyzmq: Enable tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#48918: closed ([PATCH 1/2] gnu: python-pyzmq: Enable tests.)
Date: Tue, 08 Jun 2021 17:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 8 Jun 2021 13:46:53 -0400
with message-id <YL+tDWI1NpJ4sAn5 <at> jasmine.lan>
and subject line Re: [bug#48918] [PATCH 1/2] gnu: python-pyzmq: Enable tests.
has caused the debbugs.gnu.org bug report #48918,
regarding [PATCH 1/2] gnu: python-pyzmq: Enable tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
48918: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=48918
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH 1/2] gnu: python-pyzmq: Enable tests.
Date: Tue,  8 Jun 2021 13:20:29 +0000

* gnu/packages/python-xyz.scm (python-pyzmq)[arguments]: Remove #:tests?. Add
phase to build Cython extensions before tests.
[native-inputs]: Remove python-nose. Add python-cython, python-pytest.
---
 gnu/packages/python-xyz.scm | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 9f961756b1..367c75f0f7 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -9162,14 +9162,18 @@ applications.")
     (arguments
      `(#:configure-flags
        (list (string-append "--zmq=" (assoc-ref %build-inputs "zeromq")))
-       ;; FIXME: You must build pyzmq with 'python setup.py build_ext
-       ;; --inplace' for 'python setup.py test' to work.
-       #:tests? #f))
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'build-ext
+           (lambda _
+             ;; Cython extensions have to be built before running the tests.
+             (invoke "python" "setup.py" "build_ext" "--inplace"))))))
     (inputs
      `(("zeromq" ,zeromq)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
-       ("python-nose" ,python-nose)))
+       ("python-cython" ,python-cython)
+       ("python-pytest" ,python-pytest)))
     (home-page "https://github.com/zeromq/pyzmq")
     (synopsis "Python bindings for 0MQ")
     (description
-- 
2.31.1

[Message part 3 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 48918-done <at> debbugs.gnu.org
Subject: Re: [bug#48918] [PATCH 1/2] gnu: python-pyzmq: Enable tests.
Date: Tue, 8 Jun 2021 13:46:53 -0400

On Tue, Jun 08, 2021 at 01:20:29PM +0000, Vinicius Monego wrote:
> * gnu/packages/python-xyz.scm (python-pyzmq)[arguments]: Remove #:tests?. Add
> phase to build Cython extensions before tests.
> [native-inputs]: Remove python-nose. Add python-cython, python-pytest.

Thanks!

I renamed the new phase to 'build-extensions', because we typically try
to avoid abbreviations. They can be confusing to those who are not
fluent in English.

Pushed as 172a0794bb9fe3af77ea459145bf7364b82c5cf2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.