GNU bug report logs - #48916
28.0.50; allow windmove to select windows with the 'no-other-window parameter

Previous Next

Package: emacs;

Reported by: pillule <pillule <at> riseup.net>

Date: Tue, 8 Jun 2021 10:28:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #37 received at 48916 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: pillule <pillule <at> riseup.net>
Cc: Robert Pluim <rpluim <at> gmail.com>, 48916 <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#48916: 28.0.50; allow windmove to select windows with the
 'no-other-window parameter
Date: Wed, 09 Jun 2021 23:13:04 +0300
>> You could try using new option in all functions that call
>> window-in-direction:
>> in windmove-display-in-direction, in windmove-delete-in-direction,
>> in windmove-swap-states-in-direction.
>
> Done.
> I am in terra incognita for theses commands, The opportunity to add new
> keybindings in my configuration is always nice :p
>
> It was really simple and my tests seems to works fine with
> 'windmove-allow-all-windows' for all functions.
>
> See the patch attached.

Thanks, now it's much better.

> As a side note, while reading these commands,
>
> I think 'windmove-display-same-window', 'windmove-display-new-frame',
> 'windmove-display-new-tab' are not really at they own place in windmove.
>
> We have already "C-x 4 1" (same-window-prefix) and "C-x 5 5"
> (other-frame-prefix) and (other-tab-prefix) --that is not bound to any
> key on my system but would eventually have its place in the "C-x t" map.

It's very strange that your configuration has unbound other-tab-prefix.
By default, it's bound to 'C-x t t'.

> Should we --for these windmove-commands :
> 1. keep them as they are
> 2. make aliases and clean-up 'windmove-display-in-direction'
> 3. delete them and clean-up 'windmove-display-in-direction'
> ?

Please keep them as they are.  It's very convenient
to bind these commands to use the same prefix keys
that are configured by windmove customization
(that was greatly improved recently!)




This bug report was last modified 4 years and 35 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.