Subject: [bug#48909] [PATCH] gnu: Add goldendict.

From: Ludovic Courtès <[email-masked]>
Date: Sun, 13 Jun 2021 22:40:52 +0200

Hi Sergey,

Sergey Trofimov <[email-masked]> skribis:

> I've reused the patch from nixpkgs and added opencc dependency.
>
>>>From e5c96b58f23f56da605b4ccdf3cef7d04ef379c9 Mon Sep 17 00:00:00 2001
> From: Sergey Trofimov <[email-masked]>
> Date: Mon, 7 Jun 2021 21:50:30 +0200
> Subject: [PATCH] gnu: Add goldendict.
>
> ---
>  gnu/packages/dictionaries.scm                 | 65 +++++++++++++++++++
>  .../goldendict-remove-check-for-update.patch  | 49 ++++++++++++++
>  2 files changed, 114 insertions(+)
>  create mode 100644 gnu/packages/patches/goldendict-remove-check-for-update.patch

Overall it LGTM, and it’s great that you addressed the issue Brendan
mentioned.

Minor issues:

[...]

> +++ b/gnu/packages/patches/goldendict-remove-check-for-update.patch
> @@ -0,0 +1,49 @@
> +diff --git i/config.cc w/config.cc

Please add a line or two at the top explaining what the patch does.

Also add this file to ‘gnu/local.mk’.

Bonus points if you attempt a ChangeLog-style commit log.  :-)
(See <https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html>.)

Could you send an updated patch?

Thank you!

Ludo’.