GNU bug report logs - #48902
28.0.50; Directory names containing apostrophes and backticks cause problems

Previous Next

Package: emacs;

Reported by: Rudolf Adamkovič <salutis <at> me.com>

Date: Mon, 7 Jun 2021 14:05:02 UTC

Severity: normal

Found in version 28.0.50

Fixed in version 28.1

Done: Alan Third <alan <at> idiocy.org>

Bug is archived. No further changes may be made.

Full log

Message #83 received at 48902 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alan Third <alan <at> idiocy.org>
Cc: 48902 <at> debbugs.gnu.org, mattiase <at> acm.org, larsi <at> gnus.org, salutis <at> me.com,
 naofumi <at> yasufuku.dev
Subject: Re: bug#48902: 28.0.50;
 Directory names containing apostrophes and backticks cause problems
Date: Wed, 09 Jun 2021 14:56:14 +0300

> Date: Tue, 8 Jun 2021 21:33:01 +0100
> From: Alan Third <alan <at> idiocy.org>
> Cc: 48902 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
>  Rudolf Adamkovič <salutis <at> me.com>, naofumi <at> yasufuku.dev
> 
> It's not just allocInitFromFile, I'm looking at the other callers of
> image_find_image_file and they all call ENCODE_FILE after it too.

Encoding an already encoded file name is a no-op.  But I agree it's
unclean and we had better fixed that.

> Patch attached. I've tested it here but I only have a couple of images
> to try it with.

Thanks, it LGTM.  But please also adjust the comment of
image_find_image_fd.
This bug report was last modified 4 years and 59 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.